diff options
author | Konsta Holtta <kholtta@nvidia.com> | 2014-09-26 09:05:41 -0400 |
---|---|---|
committer | Dan Willemsen <dwillemsen@nvidia.com> | 2015-03-18 15:11:34 -0400 |
commit | 2d0bcfa3318c276dba5100510e59c5c2fa62957f (patch) | |
tree | 8651c32920cddc94cf046c76e7ea6676d6e688e8 /drivers/gpu/nvgpu/gk20a/as_gk20a.c | |
parent | 79ab01debd382b91aecb474fc3cb51de78e2f1a7 (diff) |
gpu: nvgpu: add __must_check to gk20a_busy
The return value of gk20a_busy must be checked since it may not succeed
in some cases. Add the __must_check attribute that generates a compiler
warning for code that does not read the return value and fix all uses of
the function to take error cases into account.
Bug 200040921
Change-Id: Ibc2b119985fa230324c88026fe94fc5f1894fe4f
Signed-off-by: Konsta Holtta <kholtta@nvidia.com>
Reviewed-on: http://git-master/r/542552
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Tested-by: Terje Bergstrom <tbergstrom@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/gk20a/as_gk20a.c')
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/as_gk20a.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/as_gk20a.c b/drivers/gpu/nvgpu/gk20a/as_gk20a.c index ed7602f0..5ca7c806 100644 --- a/drivers/gpu/nvgpu/gk20a/as_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/as_gk20a.c | |||
@@ -82,8 +82,12 @@ int gk20a_as_release_share(struct gk20a_as_share *as_share) | |||
82 | if (atomic_dec_return(&as_share->ref_cnt) > 0) | 82 | if (atomic_dec_return(&as_share->ref_cnt) > 0) |
83 | return 0; | 83 | return 0; |
84 | 84 | ||
85 | gk20a_busy(g->dev); | 85 | err = gk20a_busy(g->dev); |
86 | if (err) | ||
87 | return err; | ||
88 | |||
86 | err = gk20a_vm_release_share(as_share); | 89 | err = gk20a_vm_release_share(as_share); |
90 | |||
87 | gk20a_idle(g->dev); | 91 | gk20a_idle(g->dev); |
88 | 92 | ||
89 | release_as_share_id(as_share->as, as_share->id); | 93 | release_as_share_id(as_share->as, as_share->id); |