diff options
author | David Nieto <dmartineznie@nvidia.com> | 2017-09-18 23:31:28 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2017-09-22 18:44:25 -0400 |
commit | 7134e9e852116f86745cd23312bbfba34100bf6d (patch) | |
tree | 763a9db89290450a37ad19d7f57acfa66ce33526 /drivers/gpu/nvgpu/common/pramin.c | |
parent | f6fcecfc6f437a6d24aa113f75e43cb6dbbd5e0f (diff) |
gpu: nvgpu: prevent crash during unbind
This change solves crashes during bind that were introduced in the driver
during the OS unification refactoring due to lack of coverage of the remove()
function.
The fixes during remove are:
(1) Prevent NULL dereference on GPUs with secure boot
(2) Prevent NULL dereferences when fecs_trace is not enabled
(3) Added PRAMIN blocker during driver removal if HW is no longer accesible
(4) Prevent double free of debugfs nodes as they are handled on the
debugfs_remove_recursive() call
(5) quiesce() can now be called without checking is HW accesible flag is set
(6) added function to free irq so no IRQ association is left on the driver after
it is removed
(7) prevent NULL dereference on nvgpu_thread_stop() if the thread is already
stopped
JIRA: EVLR-1739
Change-Id: I787d38f202d5267a6b34815f23e1bc88110e8455
Signed-off-by: David Nieto <dmartineznie@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1563005
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common/pramin.c')
-rw-r--r-- | drivers/gpu/nvgpu/common/pramin.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/gpu/nvgpu/common/pramin.c b/drivers/gpu/nvgpu/common/pramin.c index ae9c9b1f..7955e6c2 100644 --- a/drivers/gpu/nvgpu/common/pramin.c +++ b/drivers/gpu/nvgpu/common/pramin.c | |||
@@ -16,6 +16,7 @@ | |||
16 | 16 | ||
17 | #include <nvgpu/pramin.h> | 17 | #include <nvgpu/pramin.h> |
18 | #include <nvgpu/page_allocator.h> | 18 | #include <nvgpu/page_allocator.h> |
19 | #include <nvgpu/enabled.h> | ||
19 | 20 | ||
20 | #include "gk20a/gk20a.h" | 21 | #include "gk20a/gk20a.h" |
21 | 22 | ||
@@ -88,6 +89,14 @@ void nvgpu_pramin_access_batched(struct gk20a *g, struct nvgpu_mem *mem, | |||
88 | void *sgl; | 89 | void *sgl; |
89 | u32 byteoff, start_reg, until_end, n; | 90 | u32 byteoff, start_reg, until_end, n; |
90 | 91 | ||
92 | /* | ||
93 | * TODO: Vidmem is not accesible through pramin on shutdown path. | ||
94 | * driver should be refactored to prevent this from happening, but for | ||
95 | * now it is ok just to ignore the writes | ||
96 | */ | ||
97 | if (!g->regs && nvgpu_is_enabled(g, NVGPU_DRIVER_IS_DYING)) | ||
98 | return; | ||
99 | |||
91 | alloc = get_vidmem_page_alloc(mem->priv.sgt->sgl); | 100 | alloc = get_vidmem_page_alloc(mem->priv.sgt->sgl); |
92 | sgt = &alloc->sgt; | 101 | sgt = &alloc->sgt; |
93 | for (sgl = sgt->sgl; sgl; sgl = nvgpu_sgt_get_next(sgt, sgl)) { | 102 | for (sgl = sgt->sgl; sgl; sgl = nvgpu_sgt_get_next(sgt, sgl)) { |