gpu: nvgpu: fix kernel memory leak in pmu remove support

When unbinding the driver, secure pmu firmware was not freed
in nvgpu_remove_pmu_support(). Free related firmware if
previously allocated.

JIRA EVLR-1959
Bug 200352099

Change-Id: If9e431964837b3233ec25931b2ab61da920e5540
Signed-off-by: Thomas Fleury <tfleury@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1582909
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>

1 files changed, 12 insertions, 0 deletions

diff --git a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
index 29b70b58..8c4e091d 100644
--- a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
+++ b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
@@ -2235,6 +2235,18 @@ static void nvgpu_remove_pmu_support(struct nvgpu_pmu *pmu)
         if (pmu->fw)
                 nvgpu_release_firmware(g, pmu->fw);
 
+        if (g->acr.pmu_fw)
+                nvgpu_release_firmware(g, g->acr.pmu_fw);
+
+        if (g->acr.pmu_desc)
+                nvgpu_release_firmware(g, g->acr.pmu_desc);
+
+        if (g->acr.acr_fw)
+                nvgpu_release_firmware(g, g->acr.acr_fw);
+
+        if (g->acr.hsbl_fw)
+                nvgpu_release_firmware(g, g->acr.hsbl_fw);
+
         nvgpu_mutex_destroy(&pmu->elpg_mutex);
         nvgpu_mutex_destroy(&pmu->pg_mutex);
         nvgpu_mutex_destroy(&pmu->isr_mutex);