summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
diff options
context:
space:
mode:
authorDavid Nieto <dmartineznie@nvidia.com>2017-09-18 23:31:28 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-09-22 18:44:25 -0400
commit7134e9e852116f86745cd23312bbfba34100bf6d (patch)
tree763a9db89290450a37ad19d7f57acfa66ce33526 /drivers/gpu/nvgpu/common/pmu/pmu_fw.c
parentf6fcecfc6f437a6d24aa113f75e43cb6dbbd5e0f (diff)
gpu: nvgpu: prevent crash during unbind
This change solves crashes during bind that were introduced in the driver during the OS unification refactoring due to lack of coverage of the remove() function. The fixes during remove are: (1) Prevent NULL dereference on GPUs with secure boot (2) Prevent NULL dereferences when fecs_trace is not enabled (3) Added PRAMIN blocker during driver removal if HW is no longer accesible (4) Prevent double free of debugfs nodes as they are handled on the debugfs_remove_recursive() call (5) quiesce() can now be called without checking is HW accesible flag is set (6) added function to free irq so no IRQ association is left on the driver after it is removed (7) prevent NULL dereference on nvgpu_thread_stop() if the thread is already stopped JIRA: EVLR-1739 Change-Id: I787d38f202d5267a6b34815f23e1bc88110e8455 Signed-off-by: David Nieto <dmartineznie@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1563005 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common/pmu/pmu_fw.c')
-rw-r--r--drivers/gpu/nvgpu/common/pmu/pmu_fw.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
index 077a1bf8..5fd8121d 100644
--- a/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
+++ b/drivers/gpu/nvgpu/common/pmu/pmu_fw.c
@@ -2223,7 +2223,8 @@ static void nvgpu_remove_pmu_support(struct nvgpu_pmu *pmu)
2223 if (nvgpu_alloc_initialized(&pmu->dmem)) 2223 if (nvgpu_alloc_initialized(&pmu->dmem))
2224 nvgpu_alloc_destroy(&pmu->dmem); 2224 nvgpu_alloc_destroy(&pmu->dmem);
2225 2225
2226 nvgpu_release_firmware(g, pmu->fw); 2226 if (pmu->fw)
2227 nvgpu_release_firmware(g, pmu->fw);
2227 2228
2228 nvgpu_mutex_destroy(&pmu->elpg_mutex); 2229 nvgpu_mutex_destroy(&pmu->elpg_mutex);
2229 nvgpu_mutex_destroy(&pmu->pg_mutex); 2230 nvgpu_mutex_destroy(&pmu->pg_mutex);