diff options
author | Alex Waterman <alexw@nvidia.com> | 2018-09-05 19:09:43 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-12 20:48:24 -0400 |
commit | 2c95becc9edf5e9ebfa392c4b6c3fbd0b9580f8d (patch) | |
tree | acacafd7aef3db7b98245f144817895eb8b0ff09 /drivers/gpu/nvgpu/common/mm/nvgpu_mem.c | |
parent | ba2a632f039af2d13db9a0e4df9e34206116aef0 (diff) |
gpu: nvgpu: Fix MISRA 21.2 violations (nvgpu_mem.c, mm.c)
MISRA 21.2 states that we may not use reserved identifiers; since
all identifiers beginning with '_' are reserved by libc, the usage
of '__' as a prefix is disallowed.
Handle the 21.2 fixes for nvgpu_mem.c and mm.c; this deletes the
'__' prefixes and slightly renames the __nvgpu_aperture_mask()
function since there's a coherent version and a general version.
Change-Id: Iee871ad90db3f2622f9099bd9992eb994e0fbf34
Signed-off-by: Alex Waterman <alexw@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1813623
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common/mm/nvgpu_mem.c')
-rw-r--r-- | drivers/gpu/nvgpu/common/mm/nvgpu_mem.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/drivers/gpu/nvgpu/common/mm/nvgpu_mem.c b/drivers/gpu/nvgpu/common/mm/nvgpu_mem.c index ab75b136..e251f3c4 100644 --- a/drivers/gpu/nvgpu/common/mm/nvgpu_mem.c +++ b/drivers/gpu/nvgpu/common/mm/nvgpu_mem.c | |||
@@ -33,8 +33,9 @@ | |||
33 | * will not add any checks. If you want to simply use the default coherency then | 33 | * will not add any checks. If you want to simply use the default coherency then |
34 | * use nvgpu_aperture_mask(). | 34 | * use nvgpu_aperture_mask(). |
35 | */ | 35 | */ |
36 | u32 __nvgpu_aperture_mask(struct gk20a *g, enum nvgpu_aperture aperture, | 36 | u32 nvgpu_aperture_mask_coh(struct gk20a *g, enum nvgpu_aperture aperture, |
37 | u32 sysmem_mask, u32 sysmem_coh_mask, u32 vidmem_mask) | 37 | u32 sysmem_mask, u32 sysmem_coh_mask, |
38 | u32 vidmem_mask) | ||
38 | { | 39 | { |
39 | /* | 40 | /* |
40 | * Some iGPUs treat sysmem (i.e SoC DRAM) as vidmem. In these cases the | 41 | * Some iGPUs treat sysmem (i.e SoC DRAM) as vidmem. In these cases the |
@@ -45,7 +46,7 @@ u32 __nvgpu_aperture_mask(struct gk20a *g, enum nvgpu_aperture aperture, | |||
45 | } | 46 | } |
46 | 47 | ||
47 | switch (aperture) { | 48 | switch (aperture) { |
48 | case __APERTURE_SYSMEM_COH: | 49 | case APERTURE_SYSMEM_COH: |
49 | return sysmem_coh_mask; | 50 | return sysmem_coh_mask; |
50 | case APERTURE_SYSMEM: | 51 | case APERTURE_SYSMEM: |
51 | return sysmem_mask; | 52 | return sysmem_mask; |
@@ -69,16 +70,18 @@ u32 nvgpu_aperture_mask(struct gk20a *g, struct nvgpu_mem *mem, | |||
69 | */ | 70 | */ |
70 | if (nvgpu_is_enabled(g, NVGPU_USE_COHERENT_SYSMEM) && | 71 | if (nvgpu_is_enabled(g, NVGPU_USE_COHERENT_SYSMEM) && |
71 | ap == APERTURE_SYSMEM) { | 72 | ap == APERTURE_SYSMEM) { |
72 | ap = __APERTURE_SYSMEM_COH; | 73 | ap = APERTURE_SYSMEM_COH; |
73 | } | 74 | } |
74 | 75 | ||
75 | return __nvgpu_aperture_mask(g, ap, | 76 | return nvgpu_aperture_mask_coh(g, ap, |
76 | sysmem_mask, sysmem_coh_mask, vidmem_mask); | 77 | sysmem_mask, |
78 | sysmem_coh_mask, | ||
79 | vidmem_mask); | ||
77 | } | 80 | } |
78 | 81 | ||
79 | bool nvgpu_aperture_is_sysmem(enum nvgpu_aperture ap) | 82 | bool nvgpu_aperture_is_sysmem(enum nvgpu_aperture ap) |
80 | { | 83 | { |
81 | return ap == __APERTURE_SYSMEM_COH || ap == APERTURE_SYSMEM; | 84 | return ap == APERTURE_SYSMEM_COH || ap == APERTURE_SYSMEM; |
82 | } | 85 | } |
83 | 86 | ||
84 | bool nvgpu_mem_is_sysmem(struct nvgpu_mem *mem) | 87 | bool nvgpu_mem_is_sysmem(struct nvgpu_mem *mem) |