diff options
author | Alex Waterman <alexw@nvidia.com> | 2018-09-05 18:28:05 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-12 20:48:11 -0400 |
commit | 338500c8e2ee342612d7bc4eb1cd87850228d4e2 (patch) | |
tree | 55f607de797b24577fb03158c33738322b54e100 /drivers/gpu/nvgpu/common/mm/buddy_allocator.c | |
parent | 19434a22454778a14cd918ad6a0ec061634a1fc2 (diff) |
gpu: nvgpu: Fix MISRA 21.2 violations (public allocator APIs)
MISRA 21.2 states that we may not use reserved identifiers; since
all identifiers beginning with '_' are reserved by libc, the usage
of '__' as a prefix is disallowed.
This fixes places in the public allocator APIs. This consists of
the various init routines which are used to create an allocator
and the debug macro used within the allocator code.
The buddy allocator was handled by collapsing the internal
'__' prepended version with the non-prefixed version. The only
required change was in the page_allocator code which now had to
pass in a NULL vm pointer (since the VM is not needed for managing
VIDMEM).
JIRA NVGPU-1029
Change-Id: I484a144e61789bf594c525c1ca307b96d120830f
Signed-off-by: Alex Waterman <alexw@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1813578
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common/mm/buddy_allocator.c')
-rw-r--r-- | drivers/gpu/nvgpu/common/mm/buddy_allocator.c | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/drivers/gpu/nvgpu/common/mm/buddy_allocator.c b/drivers/gpu/nvgpu/common/mm/buddy_allocator.c index b29045ba..3b8d9939 100644 --- a/drivers/gpu/nvgpu/common/mm/buddy_allocator.c +++ b/drivers/gpu/nvgpu/common/mm/buddy_allocator.c | |||
@@ -1281,10 +1281,10 @@ static const struct nvgpu_allocator_ops buddy_ops = { | |||
1281 | * will try and pick a reasonable max order. | 1281 | * will try and pick a reasonable max order. |
1282 | * @flags: Extra flags necessary. See GPU_BALLOC_*. | 1282 | * @flags: Extra flags necessary. See GPU_BALLOC_*. |
1283 | */ | 1283 | */ |
1284 | int __nvgpu_buddy_allocator_init(struct gk20a *g, struct nvgpu_allocator *na, | 1284 | int nvgpu_buddy_allocator_init(struct gk20a *g, struct nvgpu_allocator *na, |
1285 | struct vm_gk20a *vm, const char *name, | 1285 | struct vm_gk20a *vm, const char *name, |
1286 | u64 base, u64 size, u64 blk_size, | 1286 | u64 base, u64 size, u64 blk_size, |
1287 | u64 max_order, u64 flags) | 1287 | u64 max_order, u64 flags) |
1288 | { | 1288 | { |
1289 | int err; | 1289 | int err; |
1290 | u64 pde_size; | 1290 | u64 pde_size; |
@@ -1312,7 +1312,7 @@ int __nvgpu_buddy_allocator_init(struct gk20a *g, struct nvgpu_allocator *na, | |||
1312 | return -ENOMEM; | 1312 | return -ENOMEM; |
1313 | } | 1313 | } |
1314 | 1314 | ||
1315 | err = __nvgpu_alloc_common_init(na, g, name, a, false, &buddy_ops); | 1315 | err = nvgpu_alloc_common_init(na, g, name, a, false, &buddy_ops); |
1316 | if (err) { | 1316 | if (err) { |
1317 | goto fail; | 1317 | goto fail; |
1318 | } | 1318 | } |
@@ -1396,11 +1396,3 @@ fail: | |||
1396 | nvgpu_kfree(g, a); | 1396 | nvgpu_kfree(g, a); |
1397 | return err; | 1397 | return err; |
1398 | } | 1398 | } |
1399 | |||
1400 | int nvgpu_buddy_allocator_init(struct gk20a *g, struct nvgpu_allocator *na, | ||
1401 | const char *name, u64 base, u64 size, | ||
1402 | u64 blk_size, u64 flags) | ||
1403 | { | ||
1404 | return __nvgpu_buddy_allocator_init(g, na, NULL, name, | ||
1405 | base, size, blk_size, 0, 0); | ||
1406 | } | ||