summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/common/fifo/tsg.c
diff options
context:
space:
mode:
authorSagar Kamble <skamble@nvidia.com>2021-02-02 11:32:23 -0500
committermobile promotions <svcmobile_promotions@nvidia.com>2021-03-19 17:39:39 -0400
commit13fc430775eb0e39dc06e420d5c92dda7016f6ae (patch)
treea29ac9b259819124b8ffd0250feaab53fbb693c7 /drivers/gpu/nvgpu/common/fifo/tsg.c
parent9170f2b77cba9aedd957acdde7c758e81e073cc0 (diff)
gpu: nvgpu: retry tsg unbind if NEXT is set
The NEXT bit can remain set for the channel if timeslice expires before scheduler clears it. Due to this nvgpu fails TSG unbind and in turn nvrm_gpu fails channel close. In this case, checking the channel hw state after some time can help see NEXT bit cleared by scheduler. Reenable the tsg and return -EAGAIN to nvrm_gpu for it to retry again. Bug 3144960 Bug 200520811 Change-Id: I35f417f02270e371a4e632986b73a00f8a4f921a Signed-off-by: Sagar Kamble <skamble@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2468391 (cherry picked from commit cf287a4ef592e7329f813c076ec8bdad18dc5933) Reviewed-on: https://git-master.nvidia.com/r/c/linux-nvgpu/+/2479106 Tested-by: mobile promotions <svcmobile_promotions@nvidia.com> Reviewed-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> GVS: Gerrit_Virtual_Submit
Diffstat (limited to 'drivers/gpu/nvgpu/common/fifo/tsg.c')
-rw-r--r--drivers/gpu/nvgpu/common/fifo/tsg.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/gpu/nvgpu/common/fifo/tsg.c b/drivers/gpu/nvgpu/common/fifo/tsg.c
index 841dd465..ebcdd2be 100644
--- a/drivers/gpu/nvgpu/common/fifo/tsg.c
+++ b/drivers/gpu/nvgpu/common/fifo/tsg.c
@@ -1,5 +1,5 @@
1/* 1/*
2 * Copyright (c) 2014-2020, NVIDIA CORPORATION. All rights reserved. 2 * Copyright (c) 2014-2021, NVIDIA CORPORATION. All rights reserved.
3 * 3 *
4 * Permission is hereby granted, free of charge, to any person obtaining a 4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"), 5 * copy of this software and associated documentation files (the "Software"),
@@ -148,7 +148,7 @@ int gk20a_tsg_bind_channel(struct tsg_gk20a *tsg,
148} 148}
149 149
150/* The caller must ensure that channel belongs to a tsg */ 150/* The caller must ensure that channel belongs to a tsg */
151int gk20a_tsg_unbind_channel(struct channel_gk20a *ch) 151int gk20a_tsg_unbind_channel(struct channel_gk20a *ch, bool force)
152{ 152{
153 struct gk20a *g = ch->g; 153 struct gk20a *g = ch->g;
154 struct tsg_gk20a *tsg = tsg_gk20a_from_ch(ch); 154 struct tsg_gk20a *tsg = tsg_gk20a_from_ch(ch);
@@ -159,6 +159,11 @@ int gk20a_tsg_unbind_channel(struct channel_gk20a *ch)
159 } 159 }
160 160
161 err = gk20a_fifo_tsg_unbind_channel(ch); 161 err = gk20a_fifo_tsg_unbind_channel(ch);
162
163 if (!force && err == -EAGAIN) {
164 return err;
165 }
166
162 if (err) { 167 if (err) {
163 nvgpu_err(g, "Channel %d unbind failed, tearing down TSG %d", 168 nvgpu_err(g, "Channel %d unbind failed, tearing down TSG %d",
164 ch->chid, tsg->tsgid); 169 ch->chid, tsg->tsgid);