summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/nvgpu/common/falcon
diff options
context:
space:
mode:
authorMahantesh Kumbar <mkumbar@nvidia.com>2017-05-29 14:06:18 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-05-31 13:14:51 -0400
commitf97d62eb8fa773a1748adb0e523199e7bee9a348 (patch)
treeef37da96468556543a1d6e90cf5c6d3b3589b719 /drivers/gpu/nvgpu/common/falcon
parent8d6b5cc349643c5e96384a8dbc27afc705bc5bfc (diff)
gpu: nvgpu: Avoid NULL dereference of flcn
-issue: flcn pointer in nvgpu_flcn_sw_init() will be NULL in default case of switch, and that results in NULL pointer dereference on flcn->flcn_id. -Fix: Used flcn_id parameter to print falcon id in default case. Coverity ID: 2514311 Coverity ID: 2514313 Bug 200291879 Change-Id: I7008817c22cdf8d9d9027cc1b724e2424b4a3d8e Signed-off-by: Mahantesh Kumbar <mkumbar@nvidia.com> Reviewed-on: http://git-master/r/1491694 Reviewed-by: Automatic_Commit_Validation_User Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com> GVS: Gerrit_Virtual_Submit Reviewed-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-by: Sachin Nikam <snikam@nvidia.com> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/common/falcon')
-rw-r--r--drivers/gpu/nvgpu/common/falcon/falcon.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/nvgpu/common/falcon/falcon.c b/drivers/gpu/nvgpu/common/falcon/falcon.c
index ac1b390f..bcc24355 100644
--- a/drivers/gpu/nvgpu/common/falcon/falcon.c
+++ b/drivers/gpu/nvgpu/common/falcon/falcon.c
@@ -39,7 +39,7 @@ void nvgpu_flcn_sw_init(struct gk20a *g, u32 flcn_id)
39 flcn->flcn_id = flcn_id; 39 flcn->flcn_id = flcn_id;
40 break; 40 break;
41 default: 41 default:
42 nvgpu_err(g, "Invalid/Unsupported falcon ID %x", flcn->flcn_id); 42 nvgpu_err(g, "Invalid/Unsupported falcon ID %x", flcn_id);
43 break; 43 break;
44 }; 44 };
45 45