diff options
author | Srirangan <smadhavan@nvidia.com> | 2018-08-28 01:39:19 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-08-28 09:47:36 -0400 |
commit | 361eca66b58051d46daad1b600eef1f72b7f15c0 (patch) | |
tree | e101ab419710c0ceb3b641098210d4147c11919e /drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c | |
parent | 4032e8915a65aa94f8b556676c5606683ec28f52 (diff) |
gpu: nvgpu: boardobj: Fix MISRA 15.6 violations
MISRA Rule-15.6 requires that all if-else blocks be enclosed in braces,
including single statement blocks. Fix errors due to single statement
if blocks without braces, introducing the braces.
JIRA NVGPU-671
Change-Id: I604d85367cd4b99c39df2b9fa2d7a7219ef941d5
Signed-off-by: Srirangan <smadhavan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1807153
Reviewed-by: svc-misra-checker <svc-misra-checker@nvidia.com>
Reviewed-by: Konsta Holtta <kholtta@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Vijayakumar Subbu <vsubbu@nvidia.com>
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c')
-rw-r--r-- | drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c | 105 |
1 files changed, 70 insertions, 35 deletions
diff --git a/drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c b/drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c index 849abe16..c3f4f4a5 100644 --- a/drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c +++ b/drivers/gpu/nvgpu/boardobj/boardobjgrpmask.c | |||
@@ -32,11 +32,13 @@ | |||
32 | u32 boardobjgrpmask_init(struct boardobjgrpmask *mask, u8 bitsize, | 32 | u32 boardobjgrpmask_init(struct boardobjgrpmask *mask, u8 bitsize, |
33 | struct ctrl_boardobjgrp_mask *extmask) | 33 | struct ctrl_boardobjgrp_mask *extmask) |
34 | { | 34 | { |
35 | if (mask == NULL) | 35 | if (mask == NULL) { |
36 | return -EINVAL; | 36 | return -EINVAL; |
37 | } | ||
37 | if ((bitsize != CTRL_BOARDOBJGRP_E32_MAX_OBJECTS) && | 38 | if ((bitsize != CTRL_BOARDOBJGRP_E32_MAX_OBJECTS) && |
38 | (bitsize != CTRL_BOARDOBJGRP_E255_MAX_OBJECTS)) | 39 | (bitsize != CTRL_BOARDOBJGRP_E255_MAX_OBJECTS)) { |
39 | return -EINVAL; | 40 | return -EINVAL; |
41 | } | ||
40 | 42 | ||
41 | mask->bitcount = bitsize; | 43 | mask->bitcount = bitsize; |
42 | mask->maskdatacount = CTRL_BOARDOBJGRP_MASK_DATA_SIZE(bitsize); | 44 | mask->maskdatacount = CTRL_BOARDOBJGRP_MASK_DATA_SIZE(bitsize); |
@@ -56,12 +58,15 @@ u32 boardobjgrpmask_import(struct boardobjgrpmask *mask, u8 bitsize, | |||
56 | { | 58 | { |
57 | u8 index; | 59 | u8 index; |
58 | 60 | ||
59 | if (mask == NULL) | 61 | if (mask == NULL) { |
60 | return -EINVAL; | 62 | return -EINVAL; |
61 | if (extmask == NULL) | 63 | } |
64 | if (extmask == NULL) { | ||
62 | return -EINVAL; | 65 | return -EINVAL; |
63 | if (mask->bitcount != bitsize) | 66 | } |
67 | if (mask->bitcount != bitsize) { | ||
64 | return -EINVAL; | 68 | return -EINVAL; |
69 | } | ||
65 | 70 | ||
66 | for (index = 0; index < mask->maskdatacount; index++) { | 71 | for (index = 0; index < mask->maskdatacount; index++) { |
67 | mask->data[index] = extmask->data[index]; | 72 | mask->data[index] = extmask->data[index]; |
@@ -77,12 +82,15 @@ u32 boardobjgrpmask_export(struct boardobjgrpmask *mask, u8 bitsize, | |||
77 | { | 82 | { |
78 | u8 index; | 83 | u8 index; |
79 | 84 | ||
80 | if (mask == NULL) | 85 | if (mask == NULL) { |
81 | return -EINVAL; | 86 | return -EINVAL; |
82 | if (extmask == NULL) | 87 | } |
88 | if (extmask == NULL) { | ||
83 | return -EINVAL; | 89 | return -EINVAL; |
84 | if (mask->bitcount != bitsize) | 90 | } |
91 | if (mask->bitcount != bitsize) { | ||
85 | return -EINVAL; | 92 | return -EINVAL; |
93 | } | ||
86 | 94 | ||
87 | for (index = 0; index < mask->maskdatacount; index++) { | 95 | for (index = 0; index < mask->maskdatacount; index++) { |
88 | extmask->data[index] = mask->data[index]; | 96 | extmask->data[index] = mask->data[index]; |
@@ -95,8 +103,9 @@ u32 boardobjgrpmask_clr(struct boardobjgrpmask *mask) | |||
95 | { | 103 | { |
96 | u8 index; | 104 | u8 index; |
97 | 105 | ||
98 | if (mask == NULL) | 106 | if (mask == NULL) { |
99 | return -EINVAL; | 107 | return -EINVAL; |
108 | } | ||
100 | for (index = 0; index < mask->maskdatacount; index++) { | 109 | for (index = 0; index < mask->maskdatacount; index++) { |
101 | mask->data[index] = 0; | 110 | mask->data[index] = 0; |
102 | } | 111 | } |
@@ -108,8 +117,9 @@ u32 boardobjgrpmask_set(struct boardobjgrpmask *mask) | |||
108 | { | 117 | { |
109 | u8 index; | 118 | u8 index; |
110 | 119 | ||
111 | if (mask == NULL) | 120 | if (mask == NULL) { |
112 | return -EINVAL; | 121 | return -EINVAL; |
122 | } | ||
113 | for (index = 0; index < mask->maskdatacount; index++) { | 123 | for (index = 0; index < mask->maskdatacount; index++) { |
114 | mask->data[index] = 0xFFFFFFFF; | 124 | mask->data[index] = 0xFFFFFFFF; |
115 | } | 125 | } |
@@ -121,8 +131,9 @@ u32 boardobjgrpmask_inv(struct boardobjgrpmask *mask) | |||
121 | { | 131 | { |
122 | u8 index; | 132 | u8 index; |
123 | 133 | ||
124 | if (mask == NULL) | 134 | if (mask == NULL) { |
125 | return -EINVAL; | 135 | return -EINVAL; |
136 | } | ||
126 | for (index = 0; index < mask->maskdatacount; index++) { | 137 | for (index = 0; index < mask->maskdatacount; index++) { |
127 | mask->data[index] = ~mask->data[index]; | 138 | mask->data[index] = ~mask->data[index]; |
128 | } | 139 | } |
@@ -134,11 +145,13 @@ bool boardobjgrpmask_iszero(struct boardobjgrpmask *mask) | |||
134 | { | 145 | { |
135 | u8 index; | 146 | u8 index; |
136 | 147 | ||
137 | if (mask == NULL) | 148 | if (mask == NULL) { |
138 | return true; | 149 | return true; |
150 | } | ||
139 | for (index = 0; index < mask->maskdatacount; index++) { | 151 | for (index = 0; index < mask->maskdatacount; index++) { |
140 | if (mask->data[index] != 0) | 152 | if (mask->data[index] != 0) { |
141 | return false; | 153 | return false; |
154 | } | ||
142 | } | 155 | } |
143 | return true; | 156 | return true; |
144 | } | 157 | } |
@@ -148,8 +161,9 @@ u8 boardobjgrpmask_bitsetcount(struct boardobjgrpmask *mask) | |||
148 | u8 index; | 161 | u8 index; |
149 | u8 result = 0; | 162 | u8 result = 0; |
150 | 163 | ||
151 | if (mask == NULL) | 164 | if (mask == NULL) { |
152 | return result; | 165 | return result; |
166 | } | ||
153 | 167 | ||
154 | for (index = 0; index < mask->maskdatacount; index++) { | 168 | for (index = 0; index < mask->maskdatacount; index++) { |
155 | u32 m = mask->data[index]; | 169 | u32 m = mask->data[index]; |
@@ -166,8 +180,9 @@ u8 boardobjgrpmask_bitidxlowest(struct boardobjgrpmask *mask) | |||
166 | u8 index; | 180 | u8 index; |
167 | u8 result = CTRL_BOARDOBJ_IDX_INVALID; | 181 | u8 result = CTRL_BOARDOBJ_IDX_INVALID; |
168 | 182 | ||
169 | if (mask == NULL) | 183 | if (mask == NULL) { |
170 | return result; | 184 | return result; |
185 | } | ||
171 | 186 | ||
172 | for (index = 0; index < mask->maskdatacount; index++) { | 187 | for (index = 0; index < mask->maskdatacount; index++) { |
173 | u32 m = mask->data[index]; | 188 | u32 m = mask->data[index]; |
@@ -188,8 +203,9 @@ u8 boardobjgrpmask_bitidxhighest(struct boardobjgrpmask *mask) | |||
188 | u8 index; | 203 | u8 index; |
189 | u8 result = CTRL_BOARDOBJ_IDX_INVALID; | 204 | u8 result = CTRL_BOARDOBJ_IDX_INVALID; |
190 | 205 | ||
191 | if (mask == NULL) | 206 | if (mask == NULL) { |
192 | return result; | 207 | return result; |
208 | } | ||
193 | 209 | ||
194 | for (index = 0; index < mask->maskdatacount; index++) { | 210 | for (index = 0; index < mask->maskdatacount; index++) { |
195 | u32 m = mask->data[index]; | 211 | u32 m = mask->data[index]; |
@@ -210,10 +226,12 @@ u32 boardobjgrpmask_bitclr(struct boardobjgrpmask *mask, u8 bitidx) | |||
210 | u8 index; | 226 | u8 index; |
211 | u8 offset; | 227 | u8 offset; |
212 | 228 | ||
213 | if (mask == NULL) | 229 | if (mask == NULL) { |
214 | return -EINVAL; | 230 | return -EINVAL; |
215 | if (bitidx >= mask->bitcount) | 231 | } |
232 | if (bitidx >= mask->bitcount) { | ||
216 | return -EINVAL; | 233 | return -EINVAL; |
234 | } | ||
217 | 235 | ||
218 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); | 236 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); |
219 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); | 237 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); |
@@ -228,10 +246,12 @@ u32 boardobjgrpmask_bitset(struct boardobjgrpmask *mask, u8 bitidx) | |||
228 | u8 index; | 246 | u8 index; |
229 | u8 offset; | 247 | u8 offset; |
230 | 248 | ||
231 | if (mask == NULL) | 249 | if (mask == NULL) { |
232 | return -EINVAL; | 250 | return -EINVAL; |
233 | if (bitidx >= mask->bitcount) | 251 | } |
252 | if (bitidx >= mask->bitcount) { | ||
234 | return -EINVAL; | 253 | return -EINVAL; |
254 | } | ||
235 | 255 | ||
236 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); | 256 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); |
237 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); | 257 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); |
@@ -246,10 +266,12 @@ u32 boardobjgrpmask_bitinv(struct boardobjgrpmask *mask, u8 bitidx) | |||
246 | u8 index; | 266 | u8 index; |
247 | u8 offset; | 267 | u8 offset; |
248 | 268 | ||
249 | if (mask == NULL) | 269 | if (mask == NULL) { |
250 | return -EINVAL; | 270 | return -EINVAL; |
251 | if (bitidx >= mask->bitcount) | 271 | } |
272 | if (bitidx >= mask->bitcount) { | ||
252 | return -EINVAL; | 273 | return -EINVAL; |
274 | } | ||
253 | 275 | ||
254 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); | 276 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); |
255 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); | 277 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); |
@@ -264,10 +286,12 @@ bool boardobjgrpmask_bitget(struct boardobjgrpmask *mask, u8 bitidx) | |||
264 | u8 index; | 286 | u8 index; |
265 | u8 offset; | 287 | u8 offset; |
266 | 288 | ||
267 | if (mask == NULL) | 289 | if (mask == NULL) { |
268 | return false; | 290 | return false; |
269 | if (bitidx >= mask->bitcount) | 291 | } |
292 | if (bitidx >= mask->bitcount) { | ||
270 | return false; | 293 | return false; |
294 | } | ||
271 | 295 | ||
272 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); | 296 | index = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_INDEX(bitidx); |
273 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); | 297 | offset = CTRL_BOARDOBJGRP_MASK_MASK_ELEMENT_OFFSET(bitidx); |
@@ -281,10 +305,12 @@ u32 boardobjgrpmask_and(struct boardobjgrpmask *dst, | |||
281 | { | 305 | { |
282 | u8 index; | 306 | u8 index; |
283 | 307 | ||
284 | if (!boardobjgrpmask_sizeeq(dst, op1)) | 308 | if (!boardobjgrpmask_sizeeq(dst, op1)) { |
285 | return -EINVAL; | 309 | return -EINVAL; |
286 | if (!boardobjgrpmask_sizeeq(dst, op2)) | 310 | } |
311 | if (!boardobjgrpmask_sizeeq(dst, op2)) { | ||
287 | return -EINVAL; | 312 | return -EINVAL; |
313 | } | ||
288 | 314 | ||
289 | for (index = 0; index < dst->maskdatacount; index++) { | 315 | for (index = 0; index < dst->maskdatacount; index++) { |
290 | dst->data[index] = op1->data[index] & op2->data[index]; | 316 | dst->data[index] = op1->data[index] & op2->data[index]; |
@@ -299,10 +325,12 @@ u32 boardobjgrpmask_or(struct boardobjgrpmask *dst, | |||
299 | { | 325 | { |
300 | u8 index; | 326 | u8 index; |
301 | 327 | ||
302 | if (!boardobjgrpmask_sizeeq(dst, op1)) | 328 | if (!boardobjgrpmask_sizeeq(dst, op1)) { |
303 | return -EINVAL; | 329 | return -EINVAL; |
304 | if (!boardobjgrpmask_sizeeq(dst, op2)) | 330 | } |
331 | if (!boardobjgrpmask_sizeeq(dst, op2)) { | ||
305 | return -EINVAL; | 332 | return -EINVAL; |
333 | } | ||
306 | 334 | ||
307 | for (index = 0; index < dst->maskdatacount; index++) { | 335 | for (index = 0; index < dst->maskdatacount; index++) { |
308 | dst->data[index] = op1->data[index] | op2->data[index]; | 336 | dst->data[index] = op1->data[index] | op2->data[index]; |
@@ -317,10 +345,12 @@ u32 boardobjgrpmask_xor(struct boardobjgrpmask *dst, | |||
317 | { | 345 | { |
318 | u8 index; | 346 | u8 index; |
319 | 347 | ||
320 | if (!boardobjgrpmask_sizeeq(dst, op1)) | 348 | if (!boardobjgrpmask_sizeeq(dst, op1)) { |
321 | return -EINVAL; | 349 | return -EINVAL; |
322 | if (!boardobjgrpmask_sizeeq(dst, op2)) | 350 | } |
351 | if (!boardobjgrpmask_sizeeq(dst, op2)) { | ||
323 | return -EINVAL; | 352 | return -EINVAL; |
353 | } | ||
324 | 354 | ||
325 | for (index = 0; index < dst->maskdatacount; index++) { | 355 | for (index = 0; index < dst->maskdatacount; index++) { |
326 | dst->data[index] = op1->data[index] ^ op2->data[index]; | 356 | dst->data[index] = op1->data[index] ^ op2->data[index]; |
@@ -334,8 +364,9 @@ u32 boardobjgrpmask_copy(struct boardobjgrpmask *dst, | |||
334 | { | 364 | { |
335 | u8 index; | 365 | u8 index; |
336 | 366 | ||
337 | if (!boardobjgrpmask_sizeeq(dst, src)) | 367 | if (!boardobjgrpmask_sizeeq(dst, src)) { |
338 | return -EINVAL; | 368 | return -EINVAL; |
369 | } | ||
339 | 370 | ||
340 | for (index = 0; index < dst->maskdatacount; index++) { | 371 | for (index = 0; index < dst->maskdatacount; index++) { |
341 | dst->data[index] = src->data[index]; | 372 | dst->data[index] = src->data[index]; |
@@ -347,10 +378,12 @@ u32 boardobjgrpmask_copy(struct boardobjgrpmask *dst, | |||
347 | bool boardobjgrpmask_sizeeq(struct boardobjgrpmask *op1, | 378 | bool boardobjgrpmask_sizeeq(struct boardobjgrpmask *op1, |
348 | struct boardobjgrpmask *op2) | 379 | struct boardobjgrpmask *op2) |
349 | { | 380 | { |
350 | if (op1 == NULL) | 381 | if (op1 == NULL) { |
351 | return false; | 382 | return false; |
352 | if (op2 == NULL) | 383 | } |
384 | if (op2 == NULL) { | ||
353 | return false; | 385 | return false; |
386 | } | ||
354 | 387 | ||
355 | return op1->bitcount == op2->bitcount; | 388 | return op1->bitcount == op2->bitcount; |
356 | } | 389 | } |
@@ -360,15 +393,17 @@ bool boardobjgrpmask_issubset(struct boardobjgrpmask *op1, | |||
360 | { | 393 | { |
361 | u8 index; | 394 | u8 index; |
362 | 395 | ||
363 | if (!boardobjgrpmask_sizeeq(op2, op1)) | 396 | if (!boardobjgrpmask_sizeeq(op2, op1)) { |
364 | return false; | 397 | return false; |
398 | } | ||
365 | 399 | ||
366 | for (index = 0; index < op1->maskdatacount; index++) { | 400 | for (index = 0; index < op1->maskdatacount; index++) { |
367 | u32 op_1 = op1->data[index]; | 401 | u32 op_1 = op1->data[index]; |
368 | u32 op_2 = op2->data[index]; | 402 | u32 op_2 = op2->data[index]; |
369 | 403 | ||
370 | if ((op_1 & op_2) != op_1) | 404 | if ((op_1 & op_2) != op_1) { |
371 | return false; | 405 | return false; |
406 | } | ||
372 | } | 407 | } |
373 | 408 | ||
374 | return true; | 409 | return true; |