diff options
author | Philip Elcan <pelcan@nvidia.com> | 2018-08-29 15:46:12 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2018-09-07 00:33:50 -0400 |
commit | 7f8226887c28267d3c2351692d4429ead1e17695 (patch) | |
tree | aa09c45e496b058044c9d9a94c94d9922c572285 /drivers/gpu/nvgpu/boardobj/boardobj.h | |
parent | 0e58ebaae13dd59b6aba5297f898e7c89fcd2742 (diff) |
gpu: nvgpu: cleanup return types for MISRA 10.3
This is a big cleanup of return types across a number of modules in the
nvgpu driver. Many functions were returning u32 but using negative
return codes. This is a MISRA 10.3 violation by assigning signed values
to a u32.
JIRA NVGPU-647
Change-Id: I59ee66706321f5b5b1a07ed8c24b81583e9ba28c
Signed-off-by: Philip Elcan <pelcan@nvidia.com>
Reviewed-on: https://git-master.nvidia.com/r/1810743
Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com>
Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
Diffstat (limited to 'drivers/gpu/nvgpu/boardobj/boardobj.h')
-rw-r--r-- | drivers/gpu/nvgpu/boardobj/boardobj.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/nvgpu/boardobj/boardobj.h b/drivers/gpu/nvgpu/boardobj/boardobj.h index 8fc8d1cc..4df14aaa 100644 --- a/drivers/gpu/nvgpu/boardobj/boardobj.h +++ b/drivers/gpu/nvgpu/boardobj/boardobj.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (c) 2016-2017, NVIDIA CORPORATION. All rights reserved. | 2 | * Copyright (c) 2016-2018, NVIDIA CORPORATION. All rights reserved. |
3 | * | 3 | * |
4 | * Permission is hereby granted, free of charge, to any person obtaining a | 4 | * Permission is hereby granted, free of charge, to any person obtaining a |
5 | * copy of this software and associated documentation files (the "Software"), | 5 | * copy of this software and associated documentation files (the "Software"), |
@@ -42,14 +42,14 @@ typedef bool boardobj_implements(struct gk20a *g, struct boardobj *pboardobj, | |||
42 | * description structure, describing this BOARDOBJ board device to the PMU. | 42 | * description structure, describing this BOARDOBJ board device to the PMU. |
43 | * | 43 | * |
44 | */ | 44 | */ |
45 | typedef u32 boardobj_pmudatainit(struct gk20a *g, struct boardobj *pboardobj, | 45 | typedef int boardobj_pmudatainit(struct gk20a *g, struct boardobj *pboardobj, |
46 | struct nv_pmu_boardobj *pmudata); | 46 | struct nv_pmu_boardobj *pmudata); |
47 | 47 | ||
48 | /* | 48 | /* |
49 | * Constructor for the base Board Object. Called by each device-specific | 49 | * Constructor for the base Board Object. Called by each device-specific |
50 | * implementation of the BOARDOBJ interface to initialize the board object. | 50 | * implementation of the BOARDOBJ interface to initialize the board object. |
51 | */ | 51 | */ |
52 | typedef u32 boardobj_construct(struct gk20a *g, struct boardobj **pboardobj, | 52 | typedef int boardobj_construct(struct gk20a *g, struct boardobj **pboardobj, |
53 | u16 size, void *args); | 53 | u16 size, void *args); |
54 | 54 | ||
55 | /* | 55 | /* |
@@ -58,7 +58,7 @@ typedef u32 boardobj_construct(struct gk20a *g, struct boardobj **pboardobj, | |||
58 | * This has to be explicitly set by each device that extends from the | 58 | * This has to be explicitly set by each device that extends from the |
59 | * board object. | 59 | * board object. |
60 | */ | 60 | */ |
61 | typedef u32 boardobj_destruct(struct boardobj *pboardobj); | 61 | typedef int boardobj_destruct(struct boardobj *pboardobj); |
62 | 62 | ||
63 | /* | 63 | /* |
64 | * Base Class for all physical or logical device on the PCB. | 64 | * Base Class for all physical or logical device on the PCB. |