summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDeepak Nibade <dnibade@nvidia.com>2017-10-26 04:50:08 -0400
committermobile promotions <svcmobile_promotions@nvidia.com>2017-11-02 12:25:29 -0400
commite1120727e7c854d093a21752c426c8597b16825d (patch)
tree1624015ac09eeec506560de93f27e01adc27aadd
parentd256b2aa5246af46ae6e3a938ba0f974254a5910 (diff)
Revert "gpu: nvgpu: WAR: unbind_channel_verify_status ret val"
This reverts commit a8643b3a99af5011f4e933967f8a09f227ce4949. Proper resolution is implemented in user space (nvrm_gpu) to idle all channels of TSG before unbinding a channel from it And with that we should not see NEXT bit set on channel while unbinding Hence revert the WAR and again return error if we find NEXT bit set on channel Also restore the error print Bug 200327095 Change-Id: Id58e00c4602a4a5c9f65e5ee1329b606f45993d7 Signed-off-by: Deepak Nibade <dnibade@nvidia.com> Reviewed-on: https://git-master.nvidia.com/r/1585991 Reviewed-by: mobile promotions <svcmobile_promotions@nvidia.com> Tested-by: mobile promotions <svcmobile_promotions@nvidia.com>
-rw-r--r--drivers/gpu/nvgpu/gk20a/fifo_gk20a.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c b/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c
index 58a4180f..76995406 100644
--- a/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c
+++ b/drivers/gpu/nvgpu/gk20a/fifo_gk20a.c
@@ -1947,10 +1947,9 @@ int gk20a_fifo_tsg_unbind_channel_verify_status(struct channel_gk20a *ch)
1947 struct gk20a *g = ch->g; 1947 struct gk20a *g = ch->g;
1948 1948
1949 if (gk20a_fifo_channel_status_is_next(g, ch->chid)) { 1949 if (gk20a_fifo_channel_status_is_next(g, ch->chid)) {
1950 nvgpu_log(g, gpu_dbg_info, 1950 nvgpu_err(g, "Channel %d to be removed from TSG %d has NEXT set!",
1951 "Channel %d to be removed from TSG %d has NEXT set!",
1952 ch->chid, ch->tsgid); 1951 ch->chid, ch->tsgid);
1953 return 0; 1952 return -EINVAL;
1954 } 1953 }
1955 1954
1956 if (g->ops.fifo.tsg_verify_status_ctx_reload) 1955 if (g->ops.fifo.tsg_verify_status_ctx_reload)