diff options
author | Vijayakumar <vsubbu@nvidia.com> | 2017-05-04 07:13:30 -0400 |
---|---|---|
committer | mobile promotions <svcmobile_promotions@nvidia.com> | 2017-05-05 12:04:15 -0400 |
commit | a1e80ec509ed650b21e6a58e2ec58b03779dbfb1 (patch) | |
tree | ca3b16e3543954aa8ded1a69a6688a4818870ef7 | |
parent | ee9733e587d977610975435a84e5af7cabba8870 (diff) |
gpu: nvgpu: fix error for static code analysis
mark functions local to the file as static
fixing errors in volt and flcn modules.
Bug 200299572
Change-Id: Ibacbd83649fee3066a90694a3df90bb909b24aa5
Signed-off-by: Vijayakumar <vsubbu@nvidia.com>
Reviewed-on: http://git-master/r/1475357
Reviewed-by: Automatic_Commit_Validation_User
Reviewed-by: svccoveritychecker <svccoveritychecker@nvidia.com>
GVS: Gerrit_Virtual_Submit
Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com>
Tested-by: Terje Bergstrom <tbergstrom@nvidia.com>
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/flcn_gk20a.c | 2 | ||||
-rw-r--r-- | drivers/gpu/nvgpu/gk20a/flcn_gk20a.h | 1 | ||||
-rw-r--r-- | drivers/gpu/nvgpu/volt/volt_dev.c | 15 | ||||
-rw-r--r-- | drivers/gpu/nvgpu/volt/volt_policy.c | 2 |
4 files changed, 11 insertions, 9 deletions
diff --git a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c index 404718d0..f36b9e32 100644 --- a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c +++ b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.c | |||
@@ -34,7 +34,7 @@ static void gk20a_falcon_ops(struct nvgpu_falcon *flcn) | |||
34 | flcn_vops->write_dmatrfbase = NULL; | 34 | flcn_vops->write_dmatrfbase = NULL; |
35 | } | 35 | } |
36 | 36 | ||
37 | void gk20a_falcon_hal_sw_init(struct nvgpu_falcon *flcn) | 37 | static void gk20a_falcon_hal_sw_init(struct nvgpu_falcon *flcn) |
38 | { | 38 | { |
39 | struct gk20a *g = flcn->g; | 39 | struct gk20a *g = flcn->g; |
40 | 40 | ||
diff --git a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.h b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.h index 388dba31..2af58104 100644 --- a/drivers/gpu/nvgpu/gk20a/flcn_gk20a.h +++ b/drivers/gpu/nvgpu/gk20a/flcn_gk20a.h | |||
@@ -13,7 +13,6 @@ | |||
13 | #ifndef __FLCN_GK20A_H__ | 13 | #ifndef __FLCN_GK20A_H__ |
14 | #define __FLCN_GK20A_H__ | 14 | #define __FLCN_GK20A_H__ |
15 | 15 | ||
16 | void gk20a_falcon_sw_init(struct nvgpu_falcon *flcn); | ||
17 | void gk20a_falcon_init_hal(struct gpu_ops *gops); | 16 | void gk20a_falcon_init_hal(struct gpu_ops *gops); |
18 | 17 | ||
19 | #endif /* __FLCN_GK20A_H__ */ | 18 | #endif /* __FLCN_GK20A_H__ */ |
diff --git a/drivers/gpu/nvgpu/volt/volt_dev.c b/drivers/gpu/nvgpu/volt/volt_dev.c index 9fd80144..4617b241 100644 --- a/drivers/gpu/nvgpu/volt/volt_dev.c +++ b/drivers/gpu/nvgpu/volt/volt_dev.c | |||
@@ -29,7 +29,7 @@ | |||
29 | #define VOLT_DEV_PWM_VOLTAGE_STEPS_INVALID 0 | 29 | #define VOLT_DEV_PWM_VOLTAGE_STEPS_INVALID 0 |
30 | #define VOLT_DEV_PWM_VOLTAGE_STEPS_DEFAULT 1 | 30 | #define VOLT_DEV_PWM_VOLTAGE_STEPS_DEFAULT 1 |
31 | 31 | ||
32 | u32 volt_device_pmu_data_init_super(struct gk20a *g, | 32 | static u32 volt_device_pmu_data_init_super(struct gk20a *g, |
33 | struct boardobj *pboard_obj, struct nv_pmu_boardobj *ppmudata) | 33 | struct boardobj *pboard_obj, struct nv_pmu_boardobj *ppmudata) |
34 | { | 34 | { |
35 | u32 status; | 35 | u32 status; |
@@ -73,7 +73,7 @@ static u32 volt_device_pmu_data_init_pwm(struct gk20a *g, | |||
73 | return status; | 73 | return status; |
74 | } | 74 | } |
75 | 75 | ||
76 | u32 construct_volt_device(struct gk20a *g, | 76 | static u32 construct_volt_device(struct gk20a *g, |
77 | struct boardobj **ppboardobj, u16 size, void *pargs) | 77 | struct boardobj **ppboardobj, u16 size, void *pargs) |
78 | { | 78 | { |
79 | struct voltage_device *ptmp_dev = (struct voltage_device *)pargs; | 79 | struct voltage_device *ptmp_dev = (struct voltage_device *)pargs; |
@@ -101,7 +101,8 @@ u32 construct_volt_device(struct gk20a *g, | |||
101 | return status; | 101 | return status; |
102 | } | 102 | } |
103 | 103 | ||
104 | u32 construct_pwm_volt_device(struct gk20a *g, struct boardobj **ppboardobj, | 104 | static u32 construct_pwm_volt_device(struct gk20a *g, |
105 | struct boardobj **ppboardobj, | ||
105 | u16 size, void *pargs) | 106 | u16 size, void *pargs) |
106 | { | 107 | { |
107 | struct boardobj *pboard_obj = NULL; | 108 | struct boardobj *pboard_obj = NULL; |
@@ -129,7 +130,8 @@ u32 construct_pwm_volt_device(struct gk20a *g, struct boardobj **ppboardobj, | |||
129 | } | 130 | } |
130 | 131 | ||
131 | 132 | ||
132 | struct voltage_device_entry *volt_dev_construct_dev_entry_pwm(struct gk20a *g, | 133 | static struct voltage_device_entry *volt_dev_construct_dev_entry_pwm( |
134 | struct gk20a *g, | ||
133 | u32 voltage_uv, void *pargs) | 135 | u32 voltage_uv, void *pargs) |
134 | { | 136 | { |
135 | struct voltage_device_pwm_entry *pentry = NULL; | 137 | struct voltage_device_pwm_entry *pentry = NULL; |
@@ -164,7 +166,7 @@ static u8 volt_dev_operation_type_convert(u8 vbios_type) | |||
164 | return CTRL_VOLT_DEVICE_OPERATION_TYPE_INVALID; | 166 | return CTRL_VOLT_DEVICE_OPERATION_TYPE_INVALID; |
165 | } | 167 | } |
166 | 168 | ||
167 | struct voltage_device *volt_volt_device_construct(struct gk20a *g, | 169 | static struct voltage_device *volt_volt_device_construct(struct gk20a *g, |
168 | void *pargs) | 170 | void *pargs) |
169 | { | 171 | { |
170 | struct boardobj *pboard_obj = NULL; | 172 | struct boardobj *pboard_obj = NULL; |
@@ -436,7 +438,8 @@ static int volt_device_volt_cmp(const void *a, const void *b) | |||
436 | return (int)a_entry->voltage_uv - (int)b_entry->voltage_uv; | 438 | return (int)a_entry->voltage_uv - (int)b_entry->voltage_uv; |
437 | } | 439 | } |
438 | 440 | ||
439 | u32 volt_device_state_init(struct gk20a *g, struct voltage_device *pvolt_dev) | 441 | static u32 volt_device_state_init(struct gk20a *g, |
442 | struct voltage_device *pvolt_dev) | ||
440 | { | 443 | { |
441 | u32 status = 0; | 444 | u32 status = 0; |
442 | struct voltage_rail *pRail = NULL; | 445 | struct voltage_rail *pRail = NULL; |
diff --git a/drivers/gpu/nvgpu/volt/volt_policy.c b/drivers/gpu/nvgpu/volt/volt_policy.c index d9d4d9da..288529e4 100644 --- a/drivers/gpu/nvgpu/volt/volt_policy.c +++ b/drivers/gpu/nvgpu/volt/volt_policy.c | |||
@@ -69,7 +69,7 @@ static u32 construct_volt_policy_split_rail(struct gk20a *g, | |||
69 | return status; | 69 | return status; |
70 | } | 70 | } |
71 | 71 | ||
72 | u32 volt_policy_pmu_data_init_split_rail(struct gk20a *g, | 72 | static u32 volt_policy_pmu_data_init_split_rail(struct gk20a *g, |
73 | struct boardobj *pboardobj, struct nv_pmu_boardobj *ppmudata) | 73 | struct boardobj *pboardobj, struct nv_pmu_boardobj *ppmudata) |
74 | { | 74 | { |
75 | u32 status = 0; | 75 | u32 status = 0; |