diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2007-02-12 03:55:37 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 12:48:46 -0500 |
commit | 9c2e08c592cd357a8330c34def1e8ecfdcf53275 (patch) | |
tree | 62e7449e43bb502f2e9630ab41832ceccd9a0f65 /sound/oss | |
parent | da7071d7e32d15149cc513f096a3638097b66387 (diff) |
[PATCH] mark struct file_operations const 9
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/oss')
-rw-r--r-- | sound/oss/ad1889.c | 4 | ||||
-rw-r--r-- | sound/oss/btaudio.c | 6 | ||||
-rw-r--r-- | sound/oss/dmasound/dmasound_core.c | 6 | ||||
-rw-r--r-- | sound/oss/emu10k1/audio.c | 2 | ||||
-rw-r--r-- | sound/oss/emu10k1/midi.c | 2 | ||||
-rw-r--r-- | sound/oss/emu10k1/mixer.c | 2 | ||||
-rw-r--r-- | sound/oss/hal2.c | 4 | ||||
-rw-r--r-- | sound/oss/msnd_pinnacle.c | 2 | ||||
-rw-r--r-- | sound/oss/os.h | 2 | ||||
-rw-r--r-- | sound/oss/sh_dac_audio.c | 2 | ||||
-rw-r--r-- | sound/oss/soundcard.c | 2 | ||||
-rw-r--r-- | sound/oss/via82cxxx_audio.c | 4 | ||||
-rw-r--r-- | sound/oss/vwsnd.c | 4 |
13 files changed, 21 insertions, 21 deletions
diff --git a/sound/oss/ad1889.c b/sound/oss/ad1889.c index 09263d72a5..f072432749 100644 --- a/sound/oss/ad1889.c +++ b/sound/oss/ad1889.c | |||
@@ -778,7 +778,7 @@ static int ad1889_release(struct inode *inode, struct file *file) | |||
778 | return 0; | 778 | return 0; |
779 | } | 779 | } |
780 | 780 | ||
781 | static struct file_operations ad1889_fops = { | 781 | static const struct file_operations ad1889_fops = { |
782 | .owner = THIS_MODULE, | 782 | .owner = THIS_MODULE, |
783 | .llseek = no_llseek, | 783 | .llseek = no_llseek, |
784 | .read = ad1889_read, | 784 | .read = ad1889_read, |
@@ -812,7 +812,7 @@ static int ad1889_mixer_ioctl(struct inode *inode, struct file *file, | |||
812 | return codec->mixer_ioctl(codec, cmd, arg); | 812 | return codec->mixer_ioctl(codec, cmd, arg); |
813 | } | 813 | } |
814 | 814 | ||
815 | static struct file_operations ad1889_mixer_fops = { | 815 | static const struct file_operations ad1889_mixer_fops = { |
816 | .owner = THIS_MODULE, | 816 | .owner = THIS_MODULE, |
817 | .llseek = no_llseek, | 817 | .llseek = no_llseek, |
818 | .ioctl = ad1889_mixer_ioctl, | 818 | .ioctl = ad1889_mixer_ioctl, |
diff --git a/sound/oss/btaudio.c b/sound/oss/btaudio.c index ad7210a00d..f845528e1f 100644 --- a/sound/oss/btaudio.c +++ b/sound/oss/btaudio.c | |||
@@ -429,7 +429,7 @@ static int btaudio_mixer_ioctl(struct inode *inode, struct file *file, | |||
429 | return 0; | 429 | return 0; |
430 | } | 430 | } |
431 | 431 | ||
432 | static struct file_operations btaudio_mixer_fops = { | 432 | static const struct file_operations btaudio_mixer_fops = { |
433 | .owner = THIS_MODULE, | 433 | .owner = THIS_MODULE, |
434 | .llseek = no_llseek, | 434 | .llseek = no_llseek, |
435 | .open = btaudio_mixer_open, | 435 | .open = btaudio_mixer_open, |
@@ -796,7 +796,7 @@ static unsigned int btaudio_dsp_poll(struct file *file, struct poll_table_struct | |||
796 | return mask; | 796 | return mask; |
797 | } | 797 | } |
798 | 798 | ||
799 | static struct file_operations btaudio_digital_dsp_fops = { | 799 | static const struct file_operations btaudio_digital_dsp_fops = { |
800 | .owner = THIS_MODULE, | 800 | .owner = THIS_MODULE, |
801 | .llseek = no_llseek, | 801 | .llseek = no_llseek, |
802 | .open = btaudio_dsp_open_digital, | 802 | .open = btaudio_dsp_open_digital, |
@@ -807,7 +807,7 @@ static struct file_operations btaudio_digital_dsp_fops = { | |||
807 | .poll = btaudio_dsp_poll, | 807 | .poll = btaudio_dsp_poll, |
808 | }; | 808 | }; |
809 | 809 | ||
810 | static struct file_operations btaudio_analog_dsp_fops = { | 810 | static const struct file_operations btaudio_analog_dsp_fops = { |
811 | .owner = THIS_MODULE, | 811 | .owner = THIS_MODULE, |
812 | .llseek = no_llseek, | 812 | .llseek = no_llseek, |
813 | .open = btaudio_dsp_open_analog, | 813 | .open = btaudio_dsp_open_analog, |
diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c index 80b836e80d..a0ec886f2a 100644 --- a/sound/oss/dmasound/dmasound_core.c +++ b/sound/oss/dmasound/dmasound_core.c | |||
@@ -371,7 +371,7 @@ static int mixer_ioctl(struct inode *inode, struct file *file, u_int cmd, | |||
371 | return -EINVAL; | 371 | return -EINVAL; |
372 | } | 372 | } |
373 | 373 | ||
374 | static struct file_operations mixer_fops = | 374 | static const struct file_operations mixer_fops = |
375 | { | 375 | { |
376 | .owner = THIS_MODULE, | 376 | .owner = THIS_MODULE, |
377 | .llseek = no_llseek, | 377 | .llseek = no_llseek, |
@@ -1337,7 +1337,7 @@ static int sq_ioctl(struct inode *inode, struct file *file, u_int cmd, | |||
1337 | return -EINVAL; | 1337 | return -EINVAL; |
1338 | } | 1338 | } |
1339 | 1339 | ||
1340 | static struct file_operations sq_fops = | 1340 | static const struct file_operations sq_fops = |
1341 | { | 1341 | { |
1342 | .owner = THIS_MODULE, | 1342 | .owner = THIS_MODULE, |
1343 | .llseek = no_llseek, | 1343 | .llseek = no_llseek, |
@@ -1561,7 +1561,7 @@ static ssize_t state_read(struct file *file, char __user *buf, size_t count, | |||
1561 | return n; | 1561 | return n; |
1562 | } | 1562 | } |
1563 | 1563 | ||
1564 | static struct file_operations state_fops = { | 1564 | static const struct file_operations state_fops = { |
1565 | .owner = THIS_MODULE, | 1565 | .owner = THIS_MODULE, |
1566 | .llseek = no_llseek, | 1566 | .llseek = no_llseek, |
1567 | .read = state_read, | 1567 | .read = state_read, |
diff --git a/sound/oss/emu10k1/audio.c b/sound/oss/emu10k1/audio.c index efcf589d70..e75ea21eb8 100644 --- a/sound/oss/emu10k1/audio.c +++ b/sound/oss/emu10k1/audio.c | |||
@@ -1582,7 +1582,7 @@ static void emu10k1_waveout_bh(unsigned long refdata) | |||
1582 | return; | 1582 | return; |
1583 | } | 1583 | } |
1584 | 1584 | ||
1585 | struct file_operations emu10k1_audio_fops = { | 1585 | const struct file_operations emu10k1_audio_fops = { |
1586 | .owner = THIS_MODULE, | 1586 | .owner = THIS_MODULE, |
1587 | .llseek = no_llseek, | 1587 | .llseek = no_llseek, |
1588 | .read = emu10k1_audio_read, | 1588 | .read = emu10k1_audio_read, |
diff --git a/sound/oss/emu10k1/midi.c b/sound/oss/emu10k1/midi.c index cca3dad2bd..df1e990449 100644 --- a/sound/oss/emu10k1/midi.c +++ b/sound/oss/emu10k1/midi.c | |||
@@ -458,7 +458,7 @@ int emu10k1_midi_callback(unsigned long msg, unsigned long refdata, unsigned lon | |||
458 | } | 458 | } |
459 | 459 | ||
460 | /* MIDI file operations */ | 460 | /* MIDI file operations */ |
461 | struct file_operations emu10k1_midi_fops = { | 461 | const struct file_operations emu10k1_midi_fops = { |
462 | .owner = THIS_MODULE, | 462 | .owner = THIS_MODULE, |
463 | .read = emu10k1_midi_read, | 463 | .read = emu10k1_midi_read, |
464 | .write = emu10k1_midi_write, | 464 | .write = emu10k1_midi_write, |
diff --git a/sound/oss/emu10k1/mixer.c b/sound/oss/emu10k1/mixer.c index 6419796c2e..bc3805fb07 100644 --- a/sound/oss/emu10k1/mixer.c +++ b/sound/oss/emu10k1/mixer.c | |||
@@ -681,7 +681,7 @@ static int emu10k1_mixer_release(struct inode *inode, struct file *file) | |||
681 | return 0; | 681 | return 0; |
682 | } | 682 | } |
683 | 683 | ||
684 | struct file_operations emu10k1_mixer_fops = { | 684 | const struct file_operations emu10k1_mixer_fops = { |
685 | .owner = THIS_MODULE, | 685 | .owner = THIS_MODULE, |
686 | .llseek = no_llseek, | 686 | .llseek = no_llseek, |
687 | .ioctl = emu10k1_mixer_ioctl, | 687 | .ioctl = emu10k1_mixer_ioctl, |
diff --git a/sound/oss/hal2.c b/sound/oss/hal2.c index d18286ccc1..80a42773c6 100644 --- a/sound/oss/hal2.c +++ b/sound/oss/hal2.c | |||
@@ -1377,7 +1377,7 @@ static int hal2_release(struct inode *inode, struct file *file) | |||
1377 | return 0; | 1377 | return 0; |
1378 | } | 1378 | } |
1379 | 1379 | ||
1380 | static struct file_operations hal2_audio_fops = { | 1380 | static const struct file_operations hal2_audio_fops = { |
1381 | .owner = THIS_MODULE, | 1381 | .owner = THIS_MODULE, |
1382 | .llseek = no_llseek, | 1382 | .llseek = no_llseek, |
1383 | .read = hal2_read, | 1383 | .read = hal2_read, |
@@ -1388,7 +1388,7 @@ static struct file_operations hal2_audio_fops = { | |||
1388 | .release = hal2_release, | 1388 | .release = hal2_release, |
1389 | }; | 1389 | }; |
1390 | 1390 | ||
1391 | static struct file_operations hal2_mixer_fops = { | 1391 | static const struct file_operations hal2_mixer_fops = { |
1392 | .owner = THIS_MODULE, | 1392 | .owner = THIS_MODULE, |
1393 | .llseek = no_llseek, | 1393 | .llseek = no_llseek, |
1394 | .ioctl = hal2_ioctl_mixdev, | 1394 | .ioctl = hal2_ioctl_mixdev, |
diff --git a/sound/oss/msnd_pinnacle.c b/sound/oss/msnd_pinnacle.c index 24110d63b1..f1f49ebf75 100644 --- a/sound/oss/msnd_pinnacle.c +++ b/sound/oss/msnd_pinnacle.c | |||
@@ -1106,7 +1106,7 @@ static irqreturn_t intr(int irq, void *dev_id) | |||
1106 | return IRQ_HANDLED; | 1106 | return IRQ_HANDLED; |
1107 | } | 1107 | } |
1108 | 1108 | ||
1109 | static struct file_operations dev_fileops = { | 1109 | static const struct file_operations dev_fileops = { |
1110 | .owner = THIS_MODULE, | 1110 | .owner = THIS_MODULE, |
1111 | .read = dev_read, | 1111 | .read = dev_read, |
1112 | .write = dev_write, | 1112 | .write = dev_write, |
diff --git a/sound/oss/os.h b/sound/oss/os.h index 0490562c7f..a1a962d7f6 100644 --- a/sound/oss/os.h +++ b/sound/oss/os.h | |||
@@ -43,4 +43,4 @@ extern int sound_nblocks; | |||
43 | #undef PSEUDO_DMA_AUTOINIT | 43 | #undef PSEUDO_DMA_AUTOINIT |
44 | #define ALLOW_BUFFER_MAPPING | 44 | #define ALLOW_BUFFER_MAPPING |
45 | 45 | ||
46 | extern struct file_operations oss_sound_fops; | 46 | extern const struct file_operations oss_sound_fops; |
diff --git a/sound/oss/sh_dac_audio.c b/sound/oss/sh_dac_audio.c index 51f554154c..7ea9accc2b 100644 --- a/sound/oss/sh_dac_audio.c +++ b/sound/oss/sh_dac_audio.c | |||
@@ -255,7 +255,7 @@ static int dac_audio_release(struct inode *inode, struct file *file) | |||
255 | return 0; | 255 | return 0; |
256 | } | 256 | } |
257 | 257 | ||
258 | struct file_operations dac_audio_fops = { | 258 | const struct file_operations dac_audio_fops = { |
259 | .read = dac_audio_read, | 259 | .read = dac_audio_read, |
260 | .write = dac_audio_write, | 260 | .write = dac_audio_write, |
261 | .ioctl = dac_audio_ioctl, | 261 | .ioctl = dac_audio_ioctl, |
diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c index b92c8cd1ae..dcd8d6d2f5 100644 --- a/sound/oss/soundcard.c +++ b/sound/oss/soundcard.c | |||
@@ -483,7 +483,7 @@ static int sound_mmap(struct file *file, struct vm_area_struct *vma) | |||
483 | return 0; | 483 | return 0; |
484 | } | 484 | } |
485 | 485 | ||
486 | struct file_operations oss_sound_fops = { | 486 | const struct file_operations oss_sound_fops = { |
487 | .owner = THIS_MODULE, | 487 | .owner = THIS_MODULE, |
488 | .llseek = no_llseek, | 488 | .llseek = no_llseek, |
489 | .read = sound_read, | 489 | .read = sound_read, |
diff --git a/sound/oss/via82cxxx_audio.c b/sound/oss/via82cxxx_audio.c index c96cc8c68b..7ab3a732e1 100644 --- a/sound/oss/via82cxxx_audio.c +++ b/sound/oss/via82cxxx_audio.c | |||
@@ -1619,7 +1619,7 @@ out: | |||
1619 | } | 1619 | } |
1620 | 1620 | ||
1621 | 1621 | ||
1622 | static struct file_operations via_mixer_fops = { | 1622 | static const struct file_operations via_mixer_fops = { |
1623 | .owner = THIS_MODULE, | 1623 | .owner = THIS_MODULE, |
1624 | .open = via_mixer_open, | 1624 | .open = via_mixer_open, |
1625 | .llseek = no_llseek, | 1625 | .llseek = no_llseek, |
@@ -2042,7 +2042,7 @@ static int via_interrupt_init (struct via_info *card) | |||
2042 | * | 2042 | * |
2043 | */ | 2043 | */ |
2044 | 2044 | ||
2045 | static struct file_operations via_dsp_fops = { | 2045 | static const struct file_operations via_dsp_fops = { |
2046 | .owner = THIS_MODULE, | 2046 | .owner = THIS_MODULE, |
2047 | .open = via_dsp_open, | 2047 | .open = via_dsp_open, |
2048 | .release = via_dsp_release, | 2048 | .release = via_dsp_release, |
diff --git a/sound/oss/vwsnd.c b/sound/oss/vwsnd.c index 6dfb9f4b03..d25249a932 100644 --- a/sound/oss/vwsnd.c +++ b/sound/oss/vwsnd.c | |||
@@ -3035,7 +3035,7 @@ static int vwsnd_audio_release(struct inode *inode, struct file *file) | |||
3035 | return err; | 3035 | return err; |
3036 | } | 3036 | } |
3037 | 3037 | ||
3038 | static struct file_operations vwsnd_audio_fops = { | 3038 | static const struct file_operations vwsnd_audio_fops = { |
3039 | .owner = THIS_MODULE, | 3039 | .owner = THIS_MODULE, |
3040 | .llseek = no_llseek, | 3040 | .llseek = no_llseek, |
3041 | .read = vwsnd_audio_read, | 3041 | .read = vwsnd_audio_read, |
@@ -3225,7 +3225,7 @@ static int vwsnd_mixer_ioctl(struct inode *ioctl, | |||
3225 | return retval; | 3225 | return retval; |
3226 | } | 3226 | } |
3227 | 3227 | ||
3228 | static struct file_operations vwsnd_mixer_fops = { | 3228 | static const struct file_operations vwsnd_mixer_fops = { |
3229 | .owner = THIS_MODULE, | 3229 | .owner = THIS_MODULE, |
3230 | .llseek = no_llseek, | 3230 | .llseek = no_llseek, |
3231 | .ioctl = vwsnd_mixer_ioctl, | 3231 | .ioctl = vwsnd_mixer_ioctl, |