litmus2008.git/ipc, branch master

ipc: lost unlock and fput in mqueue.c on error path

2007-11-29T17:24:52+00:00

The error path in sys_mq_getsetattr() after the call to
audit_mq_getsetattr() is wrong - the info->lock is not unlocked and the
struct file *filp is not put.

Fix them both.

Signed-off-by: Pavel Emelyanov 
Cc: Pierre Peiffer 
Cc: Nadia Derbey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[NETLINK]: Fix unicast timeouts

2007-11-07T12:15:12+00:00

Commit ed6dcf4a in the history.git tree broke netlink_unicast timeouts
by moving the schedule_timeout() call to a new function that doesn't
propagate the remaining timeout back to the caller. This means on each
retry we start with the full timeout again.

ipc/mqueue.c seems to actually want to wait indefinitely so this
behaviour is retained.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[PATCH] pass dentry to audit_inode()/audit_inode_child()

2007-10-21T06:37:18+00:00

makes caller simpler *and* allows to scan ancestors

Signed-off-by: Al Viro

IPC: fix error case when idr-cache is empty in ipcget()

2007-10-19T18:53:49+00:00

With the use of idr to store the ipc, the case where the idr cache is
empty, when idr_get_new is called (this may happen even if we call
idr_pre_get() before), is not well handled: it lets
semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1.
does not reflect the facts and 2.  does not conform to the man(s).

This patch fixes this by retrying the whole process of allocation in this case.

Signed-off-by: Pierre Peiffer 
Cc: Nadia Derbey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

virtualization of sysv msg queues is incomplete

2007-10-19T18:53:48+00:00

Virtualization of sysv msg queues is incomplete: msg_hdrs and msg_bytes
variables visible from userspace are global.  Let's make them
per-namespace.

Signed-off-by: Alexey Kuznetsov 
Signed-off-by: Kirill Korotaev 
Cc: Pierre Peiffer 
Cc: Nadia Derbey 
Cc: Serge Hallyn 
Acked-by: "Eric W. Biederman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

IPC: cleanup some code and wrong comments about semundo list managment

2007-10-19T18:53:48+00:00

Some comments about sem_undo_list seem wrong.
About the comment above unlock_semundo:
"... If task2 now exits before task1 releases the lock (by calling
unlock_semundo()), then task1 will never call spin_unlock(). ..."

This is just wrong, I see no reason for which task1 will not call
spin_unlock... The rest of this comment is also wrong... Unless I
miss something (of course).

Finally, (un)lock_semundo functions are useless, so remove them
for simplification. (this avoids an useless if statement)

Signed-off-by: Pierre Peiffer 
Cc: Nadia Derbey 
Acked-by: Serge Hallyn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: remove unneeded parameters

2007-10-19T18:53:48+00:00

Remvoe the unneeded parameters from ipc_checkid() and ipc_buildid()
interfaces.

Signed-off-by: Nadia Derbey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fix idr_find() locking

2007-10-19T18:53:48+00:00

This is a patch that fixes the way idr_find() used to be called in ipc_lock():
in all the paths that don't imply an update of the ipcs idr, it was called
without the idr tree being locked.

The changes are:
  . in ipc_ids, the mutex has been changed into a reader/writer semaphore.
  . ipc_lock() now takes the mutex as a reader during the idr_find().
  . a new routine ipc_lock_down() has been defined: it doesn't take the
    mutex, assuming that it is being held by the caller. This is the routine
    that is now called in all the update paths.

Signed-off-by: Nadia Derbey 
Acked-by: Jarek Poplawski 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: fix wrong comments

2007-10-19T18:53:47+00:00

This patch fixes the wrong / obsolete comments in the ipc code.  Also adds
a missing lock around ipc_get_maxid() in shm_get_stat().

Signed-off-by: Nadia Derbey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ipc: inline ipc_buildid()

2007-10-19T18:53:47+00:00

This is a trivial patch that changes the ipc_buildid() routine into a static
inline.

Signed-off-by: Nadia Derbey 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds