litmus2008.git/include/scsi, branch master

Revert "scsi: revert "[SCSI] Get rid of scsi_cmnd->done""

2008-01-06T18:17:12+00:00

This reverts commit ac40532ef0b8649e6f7f83859ea0de1c4ed08a19, which gets
us back the original cleanup of 6f5391c283d7fdcf24bf40786ea79061919d1e1d.

It turns out that the bug that was triggered by that commit was
apparently not actually triggered by that commit at all, and just the
testing conditions had changed enough to make it appear to be due to it.

The real problem seems to have been found by Peter Osterlund:

  "pktcdvd sets it [block device size] when opening the /dev/pktcdvd
   device, but when the drive is later opened as /dev/scd0, there is
   nothing that sets it back.  (Btw, 40944 is possible if the disk is a
   CDRW that was formatted with "cdrwtool -m 10236".)

   The problem is that pktcdvd opens the cd device in non-blocking mode
   when pktsetup is run, and doesn't close it again until pktsetup -d is
   run.  The effect is that if you meanwhile open the cd device,
   blkdev.c:do_open() doesn't call bd_set_size() because
   bdev->bd_openers is non-zero."

In particular, to repeat the bug (regardless of whether commit
6f5391c283d7fdcf24bf40786ea79061919d1e1d is applied or not):

  " 1. Start with an empty drive.
    2. pktsetup 0 /dev/scd0
    3. Insert a CD containing an isofs filesystem.
    4. mount /dev/pktcdvd/0 /mnt/tmp
    5. umount /mnt/tmp
    6. Press the eject button.
    7. Insert a DVD containing a non-writable filesystem.
    8. mount /dev/scd0 /mnt/tmp
    9. find /mnt/tmp -type f -print0 | xargs -0 sha1sum >/dev/null
    10. If the DVD contains data beyond the physical size of a CD, you
        get I/O errors in the terminal, and dmesg reports lots of
        "attempt to access beyond end of device" errors."

which in turn is because the nested open after the media change won't
cause the size to be set properly (because the original open still holds
the block device, and we only do the bd_set_size() when we don't have
other people holding the device open).

The proper fix for that is probably to just do something like

	bdev->bd_inode->i_size = (loff_t)get_capacity(disk)<<9;

in fs/block_dev.c:do_open() even for the cases where we're not the
original opener (but *not* call bd_set_size(), since that will also
change the block size of the device).

Cc: Peter Osterlund 
Cc: James Bottomley 
Cc: Matthew Wilcox 
Cc: Ingo Molnar 
Cc: Andrew Morton 
Signed-off-by: Linus Torvalds

scsi: revert "[SCSI] Get rid of scsi_cmnd->done"

2008-01-02T21:11:06+00:00

This reverts commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d ("[SCSI]
Get rid of scsi_cmnd->done") that was supposed to be a cleanup commit,
but apparently it causes regressions:

  Bug 9370 - v2.6.24-rc2-409-g9418d5d: attempt to access beyond end of device
  http://bugzilla.kernel.org/show_bug.cgi?id=9370

this patch should be reintroduced in a more split-up form to make
testing of it easier.

Signed-off-by: Ingo Molnar 
Acked-by: Matthew Wilcox 
Cc: James Bottomley 
Signed-off-by: Linus Torvalds

esp_scsi: fix reset cleanup spinlock recursion

2007-12-11T03:43:55+00:00

The esp_reset_cleanup() function is called with the host lock held and
invokes starget_for_each_device() which wants to take it too.  Here is a
fix along the lines of shost_for_each_device()/__shost_for_each_device()
adding a __starget_for_each_device() counterpart which assumes the lock
has already been taken.

Eventually, I think the driver should get modified so that more work is
done as a softirq rather than in the interrupt context, but for now it
fixes a bug that causes the spinlock debugger to fire.

While at it, it fixes a small number of cosmetic problems with
starget_for_each_device() too.

Signed-off-by: Maciej W. Rozycki 
Acked-by: David S. Miller 
Cc: James Bottomley 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

SCSI: add asynchronous event notification API

2007-11-04T02:23:02+00:00

Originally based on a patch by Kristen Carlson Accardi @ Intel.
Copious input from James Bottomley.

Signed-off-by: Jeff Garzik

cleanup asm/scatterlist.h includes

2007-11-02T07:47:06+00:00

Not architecture specific code should not #include .

This patch therefore either replaces them with
#include  or simply removes them if they were
unused.

Signed-off-by: Adrian Bunk 
Signed-off-by: Jens Axboe

[SCSI] include linux/scatterlist.h in scsi_eh.h

2007-10-18T01:53:56+00:00

Spotted by Paul Jackson 

The error handler rework moved the scatterlist into a globally exposed
structure in scsi_eh.h; unfortunately, the scatterlist include needs
to move from scsi_error.c to scsi_eh.h to allow this to compile
universally.

Acked-by: Paul Jackson 
Signed-off-by: James Bottomley

do not export /usr/include/scsi in make headers_install

2007-10-17T15:42:52+00:00

/usr/include/scsi is provided by glibc.
Remove the scsi export from make headers_install target.

Signed-off-by: Olaf Hering 
Cc: David Woodhouse 
Cc: James Bottomley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

remove sglist_len

2007-10-16T09:24:44+00:00

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

[SCSI] add use_sg_chaining option to scsi_host_template

2007-10-16T09:24:32+00:00

This option is true if a low-level driver can support sg
chaining. This will be removed eventually when all the drivers are
converted to support sg chaining. q->max_phys_segments is set to
SCSI_MAX_SG_SEGMENTS if false.

Signed-off-by: FUJITA Tomonori 
Signed-off-by: Jens Axboe

SCSI: support for allocating large scatterlists

2007-10-16T09:12:53+00:00

This is what enables large commands. If we need to allocate an
sgtable that doesn't fit in a single page, allocate several
SCSI_MAX_SG_SEGMENTS sized tables and chain them together.

SCSI defaults to large chained sg tables, if the arch supports it.

Signed-off-by: Jens Axboe