litmus2008.git/drivers/usb/class, branch master

Add missing newlines to some uses of dev_ messages

2007-10-18T21:37:28+00:00

Found these while looking at printk uses.

Add missing newlines to dev_ uses
Add missing KERN_ prefixes to multiline dev_s
Fixed a wierd->weird spelling typo
Added a newline to a printk

Signed-off-by: Joe Perches 
Cc: "Luck, Tony" 
Cc: Jens Axboe 
Cc: Mark M. Hoffman 
Cc: Roland Dreier 
Cc: Tilman Schmidt 
Cc: David Woodhouse 
Cc: Jeff Garzik 
Cc: Stephen Hemminger 
Cc: Greg KH 
Cc: Jeremy Fitzhardinge 
Cc: Geert Uytterhoeven 
Cc: Alessandro Zummo 
Cc: David Brownell 
Cc: James Smart 
Cc: Andrew Vasquez 
Cc: "Antonino A. Daplas" 
Cc: Evgeniy Polyakov 
Cc: Russell King 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

usblp: Fix a double kfree

2007-10-12T21:55:15+00:00

If submit fails, slab hits a BUG() because of a double kfree.
The today's lesson is, you cannot just slap USB_FREE_BUFFER on code
without adjusting the error paths.

The patch is made bigger by opportunistic refactoring.

Signed-Off-By: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

usblp: Cosmetics

2007-10-12T21:55:14+00:00

This is a small bunch of cosmetic fixes:
 - Timeout is not a write timeout anymore, rename
 - Condition in poll was confusingly backwards, invert and simplify
 - The comment log gave a wrong impression of version 0.13, terminate it.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

usblp: mutex in usblp_check_status

2007-10-12T21:55:14+00:00

Add a mutex to protect the ->statusbuf. Not really an issue, because CUPS
is single-threaded when it talks to the printer, but I feel safer this way.
This should be deadlock-free, but I kept this as a separate patch in case
someone ends running a git bisect.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

usblp: Make use of URB_FREE_BUFFER

2007-10-12T21:54:58+00:00

Employ the new API URB_FREE_BUFFER that we've got. There was talk of a combined
constructor for this case, but apparently it's not happening, so just set the
flag explicitly for now.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

usblp: Implement the ENOSPC convention

2007-10-12T21:54:58+00:00

This patch implements a mode when a printer returns ENOSPC when it runs
out of paper. The default remains the same as before. An application which
wishes to use this function has to enable it explicitly with an ioctl
LPABORT.

This is done on a request by our (Fedora) CUPS guy, Tim Waugh. The API is
similar enough to the lp0's one that CUPS works with both (but see below),
but it's has some differences.

Most importantly, the abort mode is persistent in case of lp0: once tunelp
was run your cat fill blow up until you reboot or run tunelp again. For
usblp, I made it so the abort mode is only in effect as long as device
is open. This way you can mix and match CUPS and cat(1) freely and nothing
bad happens even if you run out of paper. It is also safer in the face
of any unexpected crashes.

It has to be noted that mixing LPABORT and O_NONBLOCK is not advised.
It probably does not do what you want: instead of returning -ENOSPC
it will always return -EAGAIN (because it would otherwise block while
waiting for the paper). Applications which use O_NONBLOCK should continue
to use LPGETSTATUS like before.

Finally, CUPS actually requires patching to take full advantage of this.
It has several components; those which invoke LPABORT work, but some of
them need the ioctl added. This is completely compatible, you can mix
old CUPS and new kernels or vice versa.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman

USB: cdc-acm: fix sysfs attribute registration bug

2007-08-22T21:27:43+00:00

This patch (as950) fixes a bug in the cdc-acm driver.  It doesn't keep
track of which interface (control or data) the sysfs attributes get
registered for, and as a result, during disconnect it will sometimes
attempt to remove the attributes from the wrong interface.  The
left-over attributes can cause a crash later on, particularly if the driver
module has been unloaded.

Signed-off-by: Alan Stern 
Acked-by: Oliver Neukum 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

USB: class: usblp: clean up urb->status usage

2007-07-20T00:46:06+00:00

This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: Greg Kroah-Hartman

USB: class: cdc-acm: clean up urb->status usage

2007-07-20T00:46:06+00:00

This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: Greg Kroah-Hartman

USB: usblp: "Big cleanup" breaks O_NONBLOCK

2007-07-20T00:46:03+00:00

I found the first regresson in the rewritten ("all dynamic" and "no races")
driver. If application uses O_NONBLOCK, I return -EAGAIN despite the URB
being submitted successfuly. This causes the application to resubmit the
same data erroneously.

The fix is to pretend that the transfer has succeeded even if URB was
merely queued. It is the same behaviour as with the old version.

Signed-off-by: Pete Zaitcev 
Signed-off-by: Greg Kroah-Hartman