aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
Commit message (Collapse)AuthorAge
* staging: lustre: lclient: lcommon_cl.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | fixed: WARNING: suspect code indent for conditional statements (32, 32) Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: lcommon_cl.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | | | fixed: WARNING: line over 80 characters, used a new variable 'size_index' to store the offset. Replaced "unsigned long" with "loff_t" type for 'cur_index'. Removed the parenthesis around the second part of the if statement following the '||' as its not required. Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: lcommon_cl.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | fixed: ERROR: inline keyword should sit between storage class and type Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: lcommon_cl.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | fixed: ERROR: do not initialise statics to 0 or NULL Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: lcommon_cl.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | fixed: WARNING: Missing a blank line after declarations Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: lcommon_misc.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | | | fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: glimpse.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | fixed "WARNING: labels should not be indented" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: lclient: glimpse.c fixing coding style issuesAnil Belur2014-06-18
| | | | | | | Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)" Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: Fix sparse warnings for undeclared symbolsScott Weir2014-06-18
| | | | | | | | This patch fixes the sparse warnings in drivers/staging/lustre/lustre/ptlrpc/sec_lproc.c: sec_lproc.c:58:6: warning: symbol 'sec_flags2str' was not declared. Should it be static? Signed-off-by: Scott Weir <sjw0410@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: remove memset(0) after LIBCFS_ALLOCVitaly Osipov2014-06-18
| | | | | | | | | | | | | | | | | | | Joe Perches mentioned on driverdev-devel that memset after LIBCFS_ALLOC is not necessary as it is already done during LIBCFS_ALLOC_POST. This commit removes these unnecessary memsets. Based on the results of running a cocci patch along the lines of: @@ expression E1, E2; @@ LIBCFS_ALLOC (E1,E2); ... - memset(E1,0,E2); Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: removed spaces at the start of a lineMarc Fite2014-06-18
| | | | | | | This is a patch in order to remove 2 lines with spaces at the start of the line. Signed-off-by: Marc Fite <marc@fite.cat> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: lustre: fix sparse warnings for undeclared symbolsJohn Church2014-06-18
| | | | | | | | | | This patch fixes the following sparse warnings for drivers/staging/lustre/lnet/lnet/router.c: router.c:139:1: warning: symbol 'lnet_ni_notify_locked' was not declared. Should it be static? router.c:277:1: warning: symbol 'lnet_add_route_to_rnet' was not declared. Should it be static? Signed-off-by: John Church <sleeveroller@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* lustre/osc/osc_dev.c add a blank line after declarationsHonggang Li2014-06-18
| | | | | Signed-off-by: Honggang Li <enjoymindful@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* lustre/osc/osc_dev.c remove space between sizeof and open parenthesisHonggang Li2014-06-18
| | | | | Signed-off-by: Honggang Li <enjoymindful@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: wlan-ng: cfg80211.c: Fix sparse warningsTair Rzayev2014-06-18
| | | | | | | Include necessary header files to avoid "should be static" sparse warning Signed-off-by: Tair Rzayev <tair.rzayev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: tidspbridge: Fix whitespace for pointers in function headersJeff Oczek2014-06-18
| | | | | | | Change style in function headers from 'type * ptr' to 'type *ptr' Signed-off-by: Jeff Oczek <jeffoczek@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: tidspbridge: Add parameter names to function ptrs in struct dbll_attrsJeff Oczek2014-06-18
| | | | | | | Add more descriptive names to function pointers in definition of struct dbll_attrs Signed-off-by: Jeff Oczek <jeffoczek@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/fwserial: (coding style) remove not needed return statementsRadek Dostal2014-06-18
| | | | | | | | Style-only modifications to make checkpatch.pl -f a bit happier. Fixes warning: "void function return statements are not generally useful" Signed-off-by: Radek Dostal <rd@radekdostal.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging/fwserial: (coding style) add blank line after every declarationRadek Dostal2014-06-18
| | | | | | | | Style-only modifications to make checkpatch.pl -f a bit happier. Fixes warning: "Missing a blank line after declarations" Signed-off-by: Radek Dostal <rd@radekdostal.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: keucr: usb.c: add blank lines after declarationsMathias Engan2014-06-18
| | | | | | | | Add blank line after declarations in eucr_suspend and eucr_resume as reported by checkpatch. Signed-off-by: Mathias Engan <mathias.engan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: tidspbridge: use safer test on the result of find_first_zero_bitJulia Lawall2014-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may return a larger number than the maximum position argument if that position is not a multiple of BITS_PER_LONG. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression e1,e2,e3; statement S1,S2; @@ e1 = find_first_zero_bit(e2,e3) ... if (e1 - == + >= e3) S1 else S2 // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: tidspbridge: pmgr: dspapi.c: Cleaning up uninitialized variableRickard Strandqvist2014-06-18
| | | | | | | | There is a risk that the variables will be used without being initialized. Has also improved error handling, after an email proposal from Dan Carpenter. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: style - use kmalloc_array(n, s, ...) instead of ↵Wolfgang Ocker2014-06-18
| | | | | | | | | | kmalloc(n*s, ...) Fix a style issue reported by checkpatch.pl for the Eudyptula challenge Signed-off-by: Wolfgang Ocker <weo@weo1.de> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: goldfish: fix coding style.Hoang Tran2014-06-18
| | | | | | | | | | | Using an else following a break or return can unnecessarily indent code blocks. This patch fixes coding style reported by checkpatch.pl, a part of eudyptula challenge. Signed-off-by: Hoang Tran <hoangtran.gwr@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_stc.h: add read/write callbacks to struct ni_privateH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | | | The {read,write}[bwl] macros used to access the registers in the ni_atmio, ni_mio_cs, and ni_pcimio drivers and the included ni_mio_common.c file all rely on a local variable having a specific name. They also require some of the ni_mio_common code to need a __maybe_unused tag on the devpriv local variable. Remove all the macros by converting them into private functions and storing the callbacks in the private data. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_stc.h: remove unused members from struct ni_privateH Hartley Sweeten2014-06-18
| | | | | | | | | | | Remove all the unsed members from the private data for the ni mio drivers. The ao0p and ao1p members are only used in the ni_ao_reset() function and the code is commented out. Remove them, and the commented out code, as well. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_stc.h: remove NI_PRIVATE_COMMON macroH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This macro is used to create the private data structure that is used by the ni_atmio, ni_mio_cs, and ni_pcimio drivers. These drivers all include the ni_mio_common.c source to provide most of the driver functionality. The only driver specific information needed to convert the macro into a proper struct definition is the MAX_N_CALDACS define. This define is used to size a couple array members in the struct. The ni_atmio and ni_mio_cs drivers both define MAX_N_CALDACS as 32. The ni_pcimio driver defines it as (16+16+2). The ni_mio_common file only uses this define to sanity check that the struct members are large enough for the number of channels in the calibration subdevice. Move the MAX_N_CALDACS define to ni_stc.h and set it to the largest number of caldacs (34). The ni_atmio and ni_mio_cs drivers also add one additional member to the private data struct before using the NI_PRIVATE_COMMON macro. For the ni_atmio driver, the struct pnp_dev pointer can be saved in the comedi_device as the 'hw_dev'. The (*detach) of this driver can then use to_pnp_dev() to get it back when detaching the pnp device. In the ni_mio_cs driver, the struct pcmia_device pointer is not used so it can simply be removed. The NI_PRIVATE_COMMON macro can then be converted into a proper struct definition. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ke_counter: add ability to select counter clock sourceH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | Add an (*insn_config) to the counter subdevice to allow the user to select the clock source for the counters using the INSN_CONFIG_SET_CLOCK_SRC instruction. The current selection can be queried with the instruction INSN_CONFIG_GET_CLOCK_SRC. Also, handle the INSN_CONFIG_RESET instruction to reset all the counters. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adl_pci9111: simplify A/D trigger selection codeH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | The functions pci9111_trigger_source_set(), pci9111_pretrigger_set(), and pci9111_autoscan_set() are all used to select the A/D trigger type. They all do a read/mask/set/write of the A/D Trigger Mode Control register. Simplify the code by removing these helper functions and combining all the trigger bits so that a single write can be used to set the register. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adl_pci9111: remove PCI9111_HR_DEVICE_ID defineH Hartley Sweeten2014-06-18
| | | | | | | | | | This define is only used in the pci_device_id table and doesn't add any additional clarity to the code. Remove the define and just open code the value. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adl_pci9111: remove PCI9111_DRIVER_NAME defineH Hartley Sweeten2014-06-18
| | | | | | | | | | | This define is only used in a comedi_error() message. The addition of the driver name to the message is not necessary. Remove the define. For aesthetics, convert the comedi_error() into a dev_dbg(). Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: pcl724: add support for Diamond Systems ONYX-MM-DIO moduleH Hartley Sweeten2014-06-18
| | | | | | | | | | | The Diamond Systems ONYX-MM-DIO board is a PC/104 module with two 8255 chips providing 48 digital I/O channels. This board can be supported by the pcl724 driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: pcl730: add support for Diamond Systems IR104-PBF moduleH Hartley Sweeten2014-06-18
| | | | | | | | | | | | The Diamond Systems IR104-PBF board is a PC/104 module with 20 optoisolated inputs and 20 relay outputs. This board can be supported by the pcl730 driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Cc: Greg Kroah-Hartman <gregk@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove ADDIDATA_* definesH Hartley Sweeten2014-06-18
| | | | | | | | | These defines don't add any additional clarity to the addi_data drivers. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove {LO, HI}WORD macrosH Hartley Sweeten2014-06-18
| | | | | | | | | These macros don't add any additional clarity to the addi_data drivers. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove ADDIDATA_{EN, DIS}ABLE definesH Hartley Sweeten2014-06-18
| | | | | | | | | These defines don't add any additional clarity to the addi_data drivers. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove ADDI_{EN, DIS}ABLE definesH Hartley Sweeten2014-06-18
| | | | | | | | | These defines don't add any additional clarity to the addi_data drivers. They are also only used in the addi_apci_3120 driver. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove APCI1710_SAVE_INTERRUPT defineH Hartley Sweeten2014-06-18
| | | | | | | | This define is not used. Remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: addi_common.h: remove 'b_SingleDiff' from private dataH Hartley Sweeten2014-06-18
| | | | | | | | This member is set but never used. Just remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_daq_700: update driver commentIan Abbott2014-06-18
| | | | | | | | | | | | | Reformat the comment describing this comedi driver to use the usual block comment format. Also remove reference to digital I/O emulating an 8255, because it doesn't, and remove "DIO only" from the "Description:" line as it also supports analog inputs. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: tidy up the register map definesH Hartley Sweeten2014-06-18
| | | | | | | | Cleanup the existing defines and add some missing bit defines. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: tidy up the subdevice initH Hartley Sweeten2014-06-18
| | | | | | | | For aesthetics, add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: remove 's->len_chanlist' init for analog inputsH Hartley Sweeten2014-06-18
| | | | | | | | | This driver does not support async commands so the len_chanlist init is unnecessary. Remove it and allow the core to default the value to '1'. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: remove ADQ12B_SIZE defineH Hartley Sweeten2014-06-18
| | | | | | | | | | This define is only used in the comedi_request_region() call to specify the I/O resource size. Remove it and just open code the value. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: remove 'differential' from private dataH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | This member of the private data is only used during the attach to determine if there are 8 differential or 16 single-ended analog inputs. Remove the member and use the comedi_devconfig option directly. Also, fix the subdev_flags when differential analog inputs are used. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: remove 'unipolar' from private dataH Hartley Sweeten2014-06-18
| | | | | | | | | | This member of the private data is only used during the attach to determine which range table to use for the analog inputs. Remove the member and use the comedi_devconfig option directly. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: tidy up adq12b_ai_rinsn()H Hartley Sweeten2014-06-18
| | | | | | | | | | | | | | | | For aesthetics, rename this function. Clean up the local variables by reusing 'val' instead of using separate variables for the: 'status' - use once to trigger the first A/D conversion 'hi' and 'lo' - used to read the A/D conversion result For aesthetics, change the final return to insn->n and remove the comment. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: adq12b: fix ctreg (ai channel/range) programmingH Hartley Sweeten2014-06-18
| | | | | | | | | | | | | | | | This driver only updates the ctreg (ai channel/range) register if the desired channel or range has changed since the last analog input read operation. It does this becuase the hardware requires an udelay to allow the multiplexor to settle. Unfortunatly the current code never updates the 'last_channel' and 'last_range' in the private data so the ctreg gets updated every time. Fix this and simplify it a bit by just storing the last ctreg value in the private data. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_mio_common: fix the (*insn_read) for the freq_out counterH Hartley Sweeten2014-06-18
| | | | | | | | | The (*insn_read) functions are supposed to "read" insn->n data values and return the number of values read. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
* staging: comedi: ni_mio_common: fix the (*insn_write) for the freq_out counterH Hartley Sweeten2014-06-18
| | | | | | | | | | The (*insn_write) functions are supposed to write insn->n data values and return the number of values written. For this subdevice it only makes sense to write the last data value. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>