aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/iwlegacy
Commit message (Collapse)AuthorAge
...
* Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/netDavid S. Miller2012-03-18
|\
| * iwl3945: fix possible il->txq NULL pointer dereference in delayed worksStanislaw Gruszka2012-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On il3945_down procedure we free tx queue data and nullify il->txq pointer. After that we drop mutex and then cancel delayed works. There is possibility, that after drooping mutex and before the cancel, some delayed work will start and crash while trying to send commands to the device. For example, here is reported crash in il3945_bg_reg_txpower_periodic(): https://bugzilla.kernel.org/show_bug.cgi?id=42766#c10 Patch fix problem by adding il->txq check on works that send commands, hence utilize tx queue. Reported-by: Clemens Eisserer <linuxhippy@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | mac80211: rename bss_conf timestamp to last_tsfJohannes Berg2012-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This value is not really very useful by itself, yet some drivers (including iwlwifi until I can figure out what it should do) use it. At least rename it to "last_tsf" to indicate the meaning and add a note that it may be really old. I suspect the value may become useful combined with the rx_status->mactime, but we don't (yet) store that value and pass it to the driver. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove unused enum il4965_calib_enabled_stateGreg Dietsche2012-02-29
| | | | | | | | | | | | | | Remove the enum il4965_calib_enabled_state because it is not used. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove enum iw_calib and related codeGreg Dietsche2012-02-29
| | | | | | | | | | | | | | | | | | | | | | Remove the enum il_calib. It defined one identifier: IL_CALIB_MAX. Remove the function il4965_calib_free_results. It was doing nothing because IL_CALIB_MAX is zero. Next, remove calib_results from the il_priv structure and also remove the associated return type/struct il_calib_result. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: Kconfig: Change Debug Option to be more clearGreg Dietsche2012-02-29
| | | | | | | | | | | | | | | | | | Since the menuconfig system doesn't indent the debug options for the 3945 /4965, add some text to make it clear which debug options are being configured. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: Kconfig: Move Debugging OptionsGreg Dietsche2012-02-29
| | | | | | | | | | | | | | Move the debug options so they appear below the 3945 / 4965 options. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | mac80211: handle non-bufferable MMPDUs correctlyJohannes Berg2012-02-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This renames the IEEE80211_TX_CTL_POLL_RESPONSE TX flag to IEEE80211_TX_CTL_NO_PS_BUFFER and also uses it for non-bufferable MMPDUs (all MMPDUs but deauth, disassoc and action frames.) Previously, mac80211 would let the MMPDU through but not set the flag so drivers supporting some hardware aids for avoiding the PS races would then reject the frame. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove il_is_rfkill_hwStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: s/il_txq_mem/il_free_txq_mem/gStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | Previous name was confusing. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: s/S_RF_KILL_HW/S_RFKILL/gStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: small queue initializations cleanupStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: enable only rfkill interrupt when rfkill switch is on during IFF_UPStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: small il4965_set_hw_ready cleanupStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: check correct il_poll_bit error valueStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: do not grab nic access if rfkillStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | | | If rfkill is on il_grab_nic_access() fail and we can not write to the various registers during stop procedure. Write to those registers unconditionally instead. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwleagcy: fix ident code damageStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | Using ident is not always good. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwleagcy: remove old commentsStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: improve mac operation debuggability a bitStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of tx/rx traffic logStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | The same data can be gathered using monitor mode. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: merge all ops structures into oneStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: merge il_lib_ops into il_opsStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove il_apm_opsStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: merge eeprom_ops into lib_opsStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove temp_opsStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | Remove unneeded structure and cleanup temperature calibration routines a bit. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move debugfs_ops to il_privStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: gather all 4965 handlers in one placeStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | Handers belongs logically into 4965-mac.c file. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: regulatory_bands is not an opsStanislaw Gruszka2012-02-22
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: use writeb,writel,readl directlyStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | That change will save us some CPU cycles at run time. Having port-based I/O seems to be not possible for PCIe devices. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: cleanup/fix memory barriersStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | wmb(), rmb() are not needed when writel(), readl() are used as accessors for MMIO. We use them indirectly via iowrite32(), ioread32(). What is needed mmiowb(), for synchronizing writes coming from different CPUs on PCIe bridge (see in patch comments). This fortunately is not needed on x86, where mmiowb() is just defined as compiler barrier. As iwlegacy devices are most likely not used on anything other than x86, this is not so important fix. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: always check if got h/w access before writeStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | | | | | | | Before we write to the device register always check if _il_grap_nic_access() was successful. Change type return type _il_grap_nic_access() to bool, and add likely()/unlikely() statements. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: dump stack when fail to gain access to the deviceStanislaw Gruszka2012-02-22
| | | | | | | | | | | | | | | | | | | | | | | | Print dump stack when the device is not responding. This should give some more clue about the reason of failure. Also change the message we print, since "MAC in deep sleep" is kinda confusing. On the way add unlikely(), as fail to gain NIC access is hmm ... unlikely. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove set_hw_params callbackStanislaw Gruszka2012-02-06
| | | | | | | | | | | | | | We do not need that callback, settings parameters can be done locally. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove struct il_tx_infoStanislaw Gruszka2012-02-06
| | | | | | | | | | | | | | It's just wrapper to sk_buff pointers ... Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: merge il_base_params into il_cfgStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move ops out of configStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctx structureStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove il_setup_interface()Stanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctx->is_activeStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctx->ac_to_queueStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctx->ac_to_fifoStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move ht out of ctx structureStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move qos_data out of ctx structureStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: remove ctx interface_modesStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctx->station_flagsStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move wep_keys out of contextStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of mcast_queueStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of ctxidStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: get rid of *_devtypeStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
* | iwlegacy: move bcast_sta_id to hw_paramsStanislaw Gruszka2012-02-06
| | | | | | | | | | Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>