aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/atm
Commit message (Collapse)AuthorAge
* net: Make setsockopt() optlen be unsigned.David S. Miller2009-09-30
| | | | | | | | | | | | This provides safety against negative optlen at the type level instead of depending upon (sometimes non-trivial) checks against this sprinkled all over the the place, in each and every implementation. Based upon work done by Arjan van de Ven and feedback from Linus Torvalds. Signed-off-by: David S. Miller <davem@davemloft.net>
* atm: dereference of he_dev->rbps_virt in he_init_group()Juha Leppanen2009-09-28
| | | | | | | | | The prefix decrement causes a very long loop if pci_pool_alloc() failed in the first iteration. Also I swapped rbps and rbpl arguments. Reported-by: Juha Leppanen <juha_motorsportcom@luukku.com> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* Merge branch 'master' of git://git.infradead.org/users/dwmw2/solos-2.6David S. Miller2009-09-22
|\
| * solos: Show Interleaving details for ADSL2 and 2+Simon Farnsworth2009-05-07
| | | | | | | | | | | | | | | | | | InterleaveRDn and InterleaveRUp only apply to G.dmt. The equivalents for ADSL2 and 2+ are BisRDn and BisRUp. In addition, the INPdown and INPup statuses are useful when trying to track down instability on a line. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Add some margin-related parametersDavid Woodhouse2009-04-30
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Check for rogue received packetsNathan Williams2009-03-25
| | | | | | | | | | | | | | | | | | Sometimes there can be received packets with the size field set to 0xFFFF. This seems to only occur after an FPGA or firmware upgrade. This patch discards packets with an invalid size. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: support new FPGA RAM layoutNathan Williams2009-03-25
| | | | | | | | | | | | | | | | | | Buffer sizes have been changed to 2048 bytes. Flash upgrades use a dedicated RAM block. Add support for daughterboard. Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
* | atm: dereference of he_dev->rbps_virt in he_init_group()roel kluin2009-09-22
| | | | | | | | | | | | | | | | he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail, s them. Make sure that he_init_group() cleans up after errors. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* | drivers/atm: Use DIV_ROUND_CLOSESTJulia Lawall2009-08-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d but is perhaps more readable. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @haskernel@ @@ #include <linux/kernel.h> @depends on haskernel@ expression x,__divisor; @@ - (((x) + ((__divisor) / 2)) / (__divisor)) + DIV_ROUND_CLOSEST(x,__divisor) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
* | drivers/atm: Correct redundant testJulia Lawall2009-07-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | str has already been tested. It seems that this test should be on the recently returned value snr. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; expression E; @@ if (x == NULL || ...) { ... when forall return ...; } ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) ( *x == NULL | *x != NULL ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
* | Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n)Yang Hongyang2009-04-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the second go through of the old DMA_nBIT_MASK macro,and there're not so many of them left,so I put them into one patch.I hope this is the last round. After this the definition of the old DMA_nBIT_MASK macro could be removed. Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Russell King <rmk@arm.linux.org.uk> Cc: Tony Lindgren <tony@atomide.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Greg KH <greg@kroah.com> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* | dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)Yang Hongyang2009-04-07
| | | | | | | | | | | | | | | | Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* | atm: fix non-const printk argumentStephen Hemminger2009-03-21
| | | | | | | | | | | | | | Change printk() argument to fix compiler warning. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* | Merge branch 'master' of git://git.infradead.org/~dwmw2/solos-2.6David S. Miller2009-03-21
|\|
| * solos: Disable DMA until we have an FPGA update with it actually implemented.David Woodhouse2009-03-17
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Automatically determine number of portsNathan Williams2009-03-17
| | | | | | | | | | Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Reset device on unload, free pending skbsDavid Woodhouse2009-03-17
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Swap upstream/downstream rates in status packet, clean up some moreDavid Woodhouse2009-01-29
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Set RX empty flag at startup only for !dma modeDavid Woodhouse2009-01-29
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Don't clear config registers at startupDavid Woodhouse2009-01-29
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Tidy up status interrupt handling, cope with 'ERROR' statusDavid Woodhouse2009-01-29
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Add 'reset' module parameter to reset the DSL chips on loadDavid Woodhouse2009-01-29
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Remove debugging, commented-out test codeDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Clean up handling of card->tx_mask a littleDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Fix various bugs in status packet handlingDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Remove superfluous wait_queue_head_t from struct solos_paramDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Remove IRQF_DISABLED, don't frob IRQ enable on the FPGA in solos_irq()David Woodhouse2009-01-28
| | | | | | | | | | | | Neither of these are necessary. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Remove unused loopback debug stuffDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Tidy up tx_mask handling for ports which need TXDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Tidy up DMA handling a little. Still untestedDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: First attempt at DMA supportDavid Woodhouse2009-01-28
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Remove parameter group from sysfs on ATM dev deregisterDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Fix under-allocation of skb size for get/set parametersDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Add SNR and Attn to status packet, fix oops on loadDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Reject non-AAL5 connections.... for nowDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Kill existing connections on link down eventDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Handle new line status change packets, hook up to ATM layer infoDavid Woodhouse2009-01-27
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Add initial list of parametersDavid Woodhouse2009-01-27
| | | | | | | | | | | | | | I don't much like the trick with multiple inclusions of solos-attrlist.c but don't really see a saner way to do it without repeating the list. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Handle attribute show/store in kernel more sanelyDavid Woodhouse2009-01-27
| | | | | | | | | | | | | | | | There are still a _lot_ of attributes, but for at least the basic ones we want to be able to get/set them from the kernel. Especially the ones we want to inform the ATM core about (link state, speed). Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Kill global 'opens' count.David Woodhouse2009-01-26
| | | | | | | | Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Clean up firmware loading codeDavid Woodhouse2009-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We no longer try to load firmware while the ATM is up and running. However, this means that we _do_ make init_module() wait for it, and it takes a long time for now (since we're using ultra-conservative code in the FPGA for that too). The inner loop which uses swahb32p() was by Simon Farnsworth. Simon has patches which migrate us to request_firmware_nowait(), for which we'll actually need to take down the ATM devices, do the upgrade, then reregister them. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: FPGA and firmware update support.Simon Farnsworth2009-01-26
| | | | | | | | | | | | | | | | | | This is just a straight pull in of changes, syncing us up to 0.07 from openadsl.sf.net Signed-off-by: Nathan Williams <nathan@traverse.com.au> Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Slight debugging improvementsSimon Farnsworth2009-01-26
| | | | | | | | | | | | | | | | | | | | | | Print a message if pskb_expand_head fails. Make atmdebug writable by root, so that you can turn printing of data sent to and received from the card on and off at runtime - useful for tracking corruption. Signed-off-by: Simon Farnsworth <simon@farnz.org.uk> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
| * solos: Fix length header in FPGA transfersDavid Woodhouse2009-01-26
| | | | | | | | | | | | | | | | The length field shouldn't ever include the size of the header itself. This fixes the problem that some people were seeing with 1500-byte packets. Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
* | Merge branch 'master' of /home/davem/src/GIT/linux-2.6/David S. Miller2009-02-24
|\ \
| * | ATM: misplaced parentheses?Roel Kluin2009-02-18
| | | | | | | | | | | | | | | | | | | | | Add missing parentheses Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* | | atm: Add missing parenthesesRoel Kluin2009-02-18
|/ / | | | | | | | | Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
* | fore200: fix oops on failed firmware loadMeelis Roos2009-02-10
| | | | | | | | | | | | | | | | | | Fore 200 ATM driver fails to handle request_firmware failures and oopses when no firmware file was found. Fix it by checking for the right return values and propaganting the return value up. Signed-off-by: Meelis Roos <mroos@linux.ee> Signed-off-by: David S. Miller <davem@davemloft.net>
* | drivers/atm: introduce missing kfreeJulia Lawall2009-02-08
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S | x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S ) <... when != x when != if (...) { <+...x...+> } x->f = E ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
* generic swap(): iphase: rename swap() to swap_byte_order()Wu Fengguang2009-01-08
| | | | | | | | | In preparation for the introduction of a generic swap() macro. Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
generated by cgit v1.2.2 (git 2.25.0) at 2024-11-29 14:38:26 -0500