diff options
Diffstat (limited to 'tools')
-rw-r--r-- | tools/perf/util/machine.c | 34 | ||||
-rw-r--r-- | tools/perf/util/thread.h | 5 |
2 files changed, 25 insertions, 14 deletions
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 4514e7e9b659..574feb7003ab 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c | |||
@@ -1031,11 +1031,27 @@ out_problem: | |||
1031 | return 0; | 1031 | return 0; |
1032 | } | 1032 | } |
1033 | 1033 | ||
1034 | static void machine__remove_thread(struct machine *machine, struct thread *th) | ||
1035 | { | ||
1036 | machine->last_match = NULL; | ||
1037 | rb_erase(&th->rb_node, &machine->threads); | ||
1038 | /* | ||
1039 | * We may have references to this thread, for instance in some hist_entry | ||
1040 | * instances, so just move them to a separate list. | ||
1041 | */ | ||
1042 | list_add_tail(&th->node, &machine->dead_threads); | ||
1043 | } | ||
1044 | |||
1034 | int machine__process_fork_event(struct machine *machine, union perf_event *event) | 1045 | int machine__process_fork_event(struct machine *machine, union perf_event *event) |
1035 | { | 1046 | { |
1036 | struct thread *thread = machine__findnew_thread(machine, event->fork.tid); | 1047 | struct thread *thread = machine__find_thread(machine, event->fork.tid); |
1037 | struct thread *parent = machine__findnew_thread(machine, event->fork.ptid); | 1048 | struct thread *parent = machine__findnew_thread(machine, event->fork.ptid); |
1038 | 1049 | ||
1050 | /* if a thread currently exists for the thread id remove it */ | ||
1051 | if (thread != NULL) | ||
1052 | machine__remove_thread(machine, thread); | ||
1053 | |||
1054 | thread = machine__findnew_thread(machine, event->fork.tid); | ||
1039 | if (dump_trace) | 1055 | if (dump_trace) |
1040 | perf_event__fprintf_task(event, stdout); | 1056 | perf_event__fprintf_task(event, stdout); |
1041 | 1057 | ||
@@ -1048,18 +1064,8 @@ int machine__process_fork_event(struct machine *machine, union perf_event *event | |||
1048 | return 0; | 1064 | return 0; |
1049 | } | 1065 | } |
1050 | 1066 | ||
1051 | static void machine__remove_thread(struct machine *machine, struct thread *th) | 1067 | int machine__process_exit_event(struct machine *machine __maybe_unused, |
1052 | { | 1068 | union perf_event *event) |
1053 | machine->last_match = NULL; | ||
1054 | rb_erase(&th->rb_node, &machine->threads); | ||
1055 | /* | ||
1056 | * We may have references to this thread, for instance in some hist_entry | ||
1057 | * instances, so just move them to a separate list. | ||
1058 | */ | ||
1059 | list_add_tail(&th->node, &machine->dead_threads); | ||
1060 | } | ||
1061 | |||
1062 | int machine__process_exit_event(struct machine *machine, union perf_event *event) | ||
1063 | { | 1069 | { |
1064 | struct thread *thread = machine__find_thread(machine, event->fork.tid); | 1070 | struct thread *thread = machine__find_thread(machine, event->fork.tid); |
1065 | 1071 | ||
@@ -1067,7 +1073,7 @@ int machine__process_exit_event(struct machine *machine, union perf_event *event | |||
1067 | perf_event__fprintf_task(event, stdout); | 1073 | perf_event__fprintf_task(event, stdout); |
1068 | 1074 | ||
1069 | if (thread != NULL) | 1075 | if (thread != NULL) |
1070 | machine__remove_thread(machine, thread); | 1076 | thread__exited(thread); |
1071 | 1077 | ||
1072 | return 0; | 1078 | return 0; |
1073 | } | 1079 | } |
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h index 13c62c909392..32d060164b52 100644 --- a/tools/perf/util/thread.h +++ b/tools/perf/util/thread.h | |||
@@ -16,6 +16,7 @@ struct thread { | |||
16 | pid_t ppid; | 16 | pid_t ppid; |
17 | char shortname[3]; | 17 | char shortname[3]; |
18 | bool comm_set; | 18 | bool comm_set; |
19 | bool dead; /* if set thread has exited */ | ||
19 | char *comm; | 20 | char *comm; |
20 | int comm_len; | 21 | int comm_len; |
21 | 22 | ||
@@ -26,6 +27,10 @@ struct machine; | |||
26 | 27 | ||
27 | struct thread *thread__new(pid_t tid); | 28 | struct thread *thread__new(pid_t tid); |
28 | void thread__delete(struct thread *self); | 29 | void thread__delete(struct thread *self); |
30 | static inline void thread__exited(struct thread *thread) | ||
31 | { | ||
32 | thread->dead = true; | ||
33 | } | ||
29 | 34 | ||
30 | int thread__set_comm(struct thread *self, const char *comm); | 35 | int thread__set_comm(struct thread *self, const char *comm); |
31 | int thread__comm_len(struct thread *self); | 36 | int thread__comm_len(struct thread *self); |