1 files changed, 17 insertions, 9 deletions

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index fd3d9c8e90fc..226f44a2357d 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -324,8 +324,7 @@ static inline int elf_sym__is_function(const GElf_Sym *sym)
 {
         return elf_sym__type(sym) == STT_FUNC &&
                sym->st_name != 0 &&
-               sym->st_shndx != SHN_UNDEF &&
-               sym->st_size != 0;
+               sym->st_shndx != SHN_UNDEF;
 }
 
 static inline int elf_sym__is_label(const GElf_Sym *sym)
@@ -414,7 +413,7 @@ static int dso__synthesize_plt_symbols(struct  dso *self, int v)
         if (fd < 0)
                 goto out;
 
-        elf = elf_begin(fd, ELF_C_READ_MMAP, NULL);
+        elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
         if (elf == NULL)
                 goto out_close;
 
@@ -534,7 +533,7 @@ static int dso__load_sym(struct dso *self, int fd, const char *name,
         Elf *elf;
         int nr = 0, kernel = !strcmp("[kernel]", self->name);
 
-        elf = elf_begin(fd, ELF_C_READ_MMAP, NULL);
+        elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
         if (elf == NULL) {
                 if (v)
                         fprintf(stderr, "%s: cannot read %s ELF file.\n",
@@ -676,7 +675,7 @@ static char *dso__read_build_id(struct dso *self, int v)
         if (fd < 0)
                 goto out;
 
-        elf = elf_begin(fd, ELF_C_READ_MMAP, NULL);
+        elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
         if (elf == NULL) {
                 if (v)
                         fprintf(stderr, "%s: cannot read %s ELF file.\n",
@@ -833,7 +832,7 @@ int dso__load_modules(struct dso *self, symbol_filter_t filter, int v)
         struct mod_dso *mods = mod_dso__new_dso("modules");
         struct module *pos;
         struct rb_node *next;
-        int err;
+        int err, count = 0;
 
         err = mod_dso__load_modules(mods);
 
@@ -852,14 +851,16 @@ int dso__load_modules(struct dso *self, symbol_filter_t filter, int v)
                         break;
 
                 next = rb_next(&pos->rb_node);
+                count += err;
         }
 
         if (err < 0) {
                 mod_dso__delete_modules(mods);
                 mod_dso__delete_self(mods);
+                return err;
         }
 
-        return err;
+        return count;
 }
 
 static inline void dso__fill_symbol_holes(struct dso *self)
@@ -913,8 +914,15 @@ int dso__load_kernel(struct dso *self, const char *vmlinux,
 
         if (vmlinux) {
                 err = dso__load_vmlinux(self, vmlinux, filter, v);
-                if (err > 0 && use_modules)
-                        err = dso__load_modules(self, filter, v);
+                if (err > 0 && use_modules) {
+                        int syms = dso__load_modules(self, filter, v);
+
+                        if (syms < 0) {
+                                fprintf(stderr, "dso__load_modules failed!\n");
+                                return syms;
+                        }
+                        err += syms;
+                }
         }
 
         if (err <= 0)