1 files changed, 118 insertions, 182 deletions

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 88dfef70c13d..883406f4b381 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -14,6 +14,7 @@
 #include "util.h"
 #include "cpumap.h"
 #include "perf_regs.h"
+#include "asm/bug.h"
 
 static int perf_session__open(struct perf_session *session)
 {
@@ -66,6 +67,25 @@ static void perf_session__destroy_kernel_maps(struct perf_session *session)
         machines__destroy_kernel_maps(&session->machines);
 }
 
+static bool perf_session__has_comm_exec(struct perf_session *session)
+{
+        struct perf_evsel *evsel;
+
+        evlist__for_each(session->evlist, evsel) {
+                if (evsel->attr.comm_exec)
+                        return true;
+        }
+
+        return false;
+}
+
+static void perf_session__set_comm_exec(struct perf_session *session)
+{
+        bool comm_exec = perf_session__has_comm_exec(session);
+
+        machines__set_comm_exec(&session->machines, comm_exec);
+}
+
 struct perf_session *perf_session__new(struct perf_data_file *file,
                                        bool repipe, struct perf_tool *tool)
 {
@@ -75,9 +95,7 @@ struct perf_session *perf_session__new(struct perf_data_file *file,
                 goto out;
 
         session->repipe = repipe;
-        INIT_LIST_HEAD(&session->ordered_samples.samples);
-        INIT_LIST_HEAD(&session->ordered_samples.sample_cache);
-        INIT_LIST_HEAD(&session->ordered_samples.to_free);
+        ordered_events__init(&session->ordered_events);
         machines__init(&session->machines);
 
         if (file) {
@@ -91,6 +109,7 @@ struct perf_session *perf_session__new(struct perf_data_file *file,
                                 goto out_close;
 
                         perf_session__set_id_hdr_size(session);
+                        perf_session__set_comm_exec(session);
                 }
         }
 
@@ -100,13 +119,13 @@ struct perf_session *perf_session__new(struct perf_data_file *file,
                  * kernel MMAP event, in perf_event__process_mmap().
                  */
                 if (perf_session__create_kernel_maps(session) < 0)
-                        goto out_delete;
+                        pr_warning("Cannot read kernel map\n");
         }
 
         if (tool && tool->ordering_requires_timestamps &&
-            tool->ordered_samples && !perf_evlist__sample_id_all(session->evlist)) {
+            tool->ordered_events && !perf_evlist__sample_id_all(session->evlist)) {
                 dump_printf("WARNING: No sample_id_all support, falling back to unordered processing\n");
-                tool->ordered_samples = false;
+                tool->ordered_events = false;
         }
 
         return session;
@@ -238,7 +257,7 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
         if (tool->build_id == NULL)
                 tool->build_id = process_finished_round_stub;
         if (tool->finished_round == NULL) {
-                if (tool->ordered_samples)
+                if (tool->ordered_events)
                         tool->finished_round = process_finished_round;
                 else
                         tool->finished_round = process_finished_round_stub;
@@ -444,87 +463,6 @@ static perf_event__swap_op perf_event__swap_ops[] = {
         [PERF_RECORD_HEADER_MAX]          = NULL,
 };
 
-struct sample_queue {
-        u64                     timestamp;
-        u64                     file_offset;
-        union perf_event        *event;
-        struct list_head        list;
-};
-
-static void perf_session_free_sample_buffers(struct perf_session *session)
-{
-        struct ordered_samples *os = &session->ordered_samples;
-
-        while (!list_empty(&os->to_free)) {
-                struct sample_queue *sq;
-
-                sq = list_entry(os->to_free.next, struct sample_queue, list);
-                list_del(&sq->list);
-                free(sq);
-        }
-}
-
-static int perf_session_deliver_event(struct perf_session *session,
-                                      union perf_event *event,
-                                      struct perf_sample *sample,
-                                      struct perf_tool *tool,
-                                      u64 file_offset);
-
-static int flush_sample_queue(struct perf_session *s,
-                       struct perf_tool *tool)
-{
-        struct ordered_samples *os = &s->ordered_samples;
-        struct list_head *head = &os->samples;
-        struct sample_queue *tmp, *iter;
-        struct perf_sample sample;
-        u64 limit = os->next_flush;
-        u64 last_ts = os->last_sample ? os->last_sample->timestamp : 0ULL;
-        bool show_progress = limit == ULLONG_MAX;
-        struct ui_progress prog;
-        int ret;
-
-        if (!tool->ordered_samples || !limit)
-                return 0;
-
-        if (show_progress)
-                ui_progress__init(&prog, os->nr_samples, "Processing time ordered events...");
-
-        list_for_each_entry_safe(iter, tmp, head, list) {
-                if (session_done())
-                        return 0;
-
-                if (iter->timestamp > limit)
-                        break;
-
-                ret = perf_evlist__parse_sample(s->evlist, iter->event, &sample);
-                if (ret)
-                        pr_err("Can't parse sample, err = %d\n", ret);
-                else {
-                        ret = perf_session_deliver_event(s, iter->event, &sample, tool,
-                                                         iter->file_offset);
-                        if (ret)
-                                return ret;
-                }
-
-                os->last_flush = iter->timestamp;
-                list_del(&iter->list);
-                list_add(&iter->list, &os->sample_cache);
-                os->nr_samples--;
-
-                if (show_progress)
-                        ui_progress__update(&prog, 1);
-        }
-
-        if (list_empty(head)) {
-                os->last_sample = NULL;
-        } else if (last_ts <= limit) {
-                os->last_sample =
-                        list_entry(head->prev, struct sample_queue, list);
-        }
-
-        return 0;
-}
-
 /*
  * When perf record finishes a pass on every buffers, it records this pseudo
  * event.
@@ -568,99 +506,43 @@ static int process_finished_round(struct perf_tool *tool,
                                   union perf_event *event __maybe_unused,
                                   struct perf_session *session)
 {
-        int ret = flush_sample_queue(session, tool);
-        if (!ret)
-                session->ordered_samples.next_flush = session->ordered_samples.max_timestamp;
-
-        return ret;
-}
-
-/* The queue is ordered by time */
-static void __queue_event(struct sample_queue *new, struct perf_session *s)
-{
-        struct ordered_samples *os = &s->ordered_samples;
-        struct sample_queue *sample = os->last_sample;
-        u64 timestamp = new->timestamp;
-        struct list_head *p;
-
-        ++os->nr_samples;
-        os->last_sample = new;
-
-        if (!sample) {
-                list_add(&new->list, &os->samples);
-                os->max_timestamp = timestamp;
-                return;
-        }
-
-        /*
-         * last_sample might point to some random place in the list as it's
-         * the last queued event. We expect that the new event is close to
-         * this.
-         */
-        if (sample->timestamp <= timestamp) {
-                while (sample->timestamp <= timestamp) {
-                        p = sample->list.next;
-                        if (p == &os->samples) {
-                                list_add_tail(&new->list, &os->samples);
-                                os->max_timestamp = timestamp;
-                                return;
-                        }
-                        sample = list_entry(p, struct sample_queue, list);
-                }
-                list_add_tail(&new->list, &sample->list);
-        } else {
-                while (sample->timestamp > timestamp) {
-                        p = sample->list.prev;
-                        if (p == &os->samples) {
-                                list_add(&new->list, &os->samples);
-                                return;
-                        }
-                        sample = list_entry(p, struct sample_queue, list);
-                }
-                list_add(&new->list, &sample->list);
-        }
+        return ordered_events__flush(session, tool, OE_FLUSH__ROUND);
 }
 
-#define MAX_SAMPLE_BUFFER       (64 * 1024 / sizeof(struct sample_queue))
-
 int perf_session_queue_event(struct perf_session *s, union perf_event *event,
-                                    struct perf_sample *sample, u64 file_offset)
+                             struct perf_tool *tool, struct perf_sample *sample,
+                             u64 file_offset)
 {
-        struct ordered_samples *os = &s->ordered_samples;
-        struct list_head *sc = &os->sample_cache;
+        struct ordered_events *oe = &s->ordered_events;
         u64 timestamp = sample->time;
-        struct sample_queue *new;
+        struct ordered_event *new;
 
         if (!timestamp || timestamp == ~0ULL)
                 return -ETIME;
 
-        if (timestamp < s->ordered_samples.last_flush) {
-                printf("Warning: Timestamp below last timeslice flush\n");
-                return -EINVAL;
+        if (timestamp < oe->last_flush) {
+                WARN_ONCE(1, "Timestamp below last timeslice flush\n");
+
+                pr_oe_time(timestamp,      "out of order event");
+                pr_oe_time(oe->last_flush, "last flush, last_flush_type %d\n",
+                           oe->last_flush_type);
+
+                /* We could get out of order messages after forced flush. */
+                if (oe->last_flush_type != OE_FLUSH__HALF)
+                        return -EINVAL;
         }
 
-        if (!list_empty(sc)) {
-                new = list_entry(sc->next, struct sample_queue, list);
-                list_del(&new->list);
-        } else if (os->sample_buffer) {
-                new = os->sample_buffer + os->sample_buffer_idx;
-                if (++os->sample_buffer_idx == MAX_SAMPLE_BUFFER)
-                        os->sample_buffer = NULL;
-        } else {
-                os->sample_buffer = malloc(MAX_SAMPLE_BUFFER * sizeof(*new));
-                if (!os->sample_buffer)
-                        return -ENOMEM;
-                list_add(&os->sample_buffer->list, &os->to_free);
-                os->sample_buffer_idx = 2;
-                new = os->sample_buffer + 1;
+        new = ordered_events__new(oe, timestamp);
+        if (!new) {
+                ordered_events__flush(s, tool, OE_FLUSH__HALF);
+                new = ordered_events__new(oe, timestamp);
         }
 
-        new->timestamp = timestamp;
+        if (!new)
+                return -ENOMEM;
+
         new->file_offset = file_offset;
         new->event = event;
-
-        __queue_event(new, s);
-
         return 0;
 }
 
@@ -920,11 +802,10 @@ perf_session__deliver_sample(struct perf_session *session,
                                             &sample->read.one, machine);
 }
 
-static int perf_session_deliver_event(struct perf_session *session,
-                                      union perf_event *event,
-                                      struct perf_sample *sample,
-                                      struct perf_tool *tool,
-                                      u64 file_offset)
+int perf_session__deliver_event(struct perf_session *session,
+                                union perf_event *event,
+                                struct perf_sample *sample,
+                                struct perf_tool *tool, u64 file_offset)
 {
         struct perf_evsel *evsel;
         struct machine *machine;
@@ -1005,8 +886,10 @@ static s64 perf_session__process_user_event(struct perf_session *session,
         switch (event->header.type) {
         case PERF_RECORD_HEADER_ATTR:
                 err = tool->attr(tool, event, &session->evlist);
-                if (err == 0)
+                if (err == 0) {
                         perf_session__set_id_hdr_size(session);
+                        perf_session__set_comm_exec(session);
+                }
                 return err;
         case PERF_RECORD_HEADER_EVENT_TYPE:
                 /*
@@ -1036,6 +919,61 @@ static void event_swap(union perf_event *event, bool sample_id_all)
                 swap(event, sample_id_all);
 }
 
+int perf_session__peek_event(struct perf_session *session, off_t file_offset,
+                             void *buf, size_t buf_sz,
+                             union perf_event **event_ptr,
+                             struct perf_sample *sample)
+{
+        union perf_event *event;
+        size_t hdr_sz, rest;
+        int fd;
+
+        if (session->one_mmap && !session->header.needs_swap) {
+                event = file_offset - session->one_mmap_offset +
+                        session->one_mmap_addr;
+                goto out_parse_sample;
+        }
+
+        if (perf_data_file__is_pipe(session->file))
+                return -1;
+
+        fd = perf_data_file__fd(session->file);
+        hdr_sz = sizeof(struct perf_event_header);
+
+        if (buf_sz < hdr_sz)
+                return -1;
+
+        if (lseek(fd, file_offset, SEEK_SET) == (off_t)-1 ||
+            readn(fd, &buf, hdr_sz) != (ssize_t)hdr_sz)
+                return -1;
+
+        event = (union perf_event *)buf;
+
+        if (session->header.needs_swap)
+                perf_event_header__bswap(&event->header);
+
+        if (event->header.size < hdr_sz)
+                return -1;
+
+        rest = event->header.size - hdr_sz;
+
+        if (readn(fd, &buf, rest) != (ssize_t)rest)
+                return -1;
+
+        if (session->header.needs_swap)
+                event_swap(event, perf_evlist__sample_id_all(session->evlist));
+
+out_parse_sample:
+
+        if (sample && event->header.type < PERF_RECORD_USER_TYPE_START &&
+            perf_evlist__parse_sample(session->evlist, event, sample))
+                return -1;
+
+        *event_ptr = event;
+
+        return 0;
+}
+
 static s64 perf_session__process_event(struct perf_session *session,
                                        union perf_event *event,
                                        struct perf_tool *tool,
@@ -1062,15 +1000,15 @@ static s64 perf_session__process_event(struct perf_session *session,
         if (ret)
                 return ret;
 
-        if (tool->ordered_samples) {
-                ret = perf_session_queue_event(session, event, &sample,
+        if (tool->ordered_events) {
+                ret = perf_session_queue_event(session, event, tool, &sample,
                                                file_offset);
                 if (ret != -ETIME)
                         return ret;
         }
 
-        return perf_session_deliver_event(session, event, &sample, tool,
-                                          file_offset);
+        return perf_session__deliver_event(session, event, &sample, tool,
+                                           file_offset);
 }
 
 void perf_event_header__bswap(struct perf_event_header *hdr)
@@ -1222,12 +1160,11 @@ more:
                 goto more;
 done:
         /* do the final flush for ordered samples */
-        session->ordered_samples.next_flush = ULLONG_MAX;
-        err = flush_sample_queue(session, tool);
+        err = ordered_events__flush(session, tool, OE_FLUSH__FINAL);
 out_err:
         free(buf);
         perf_session__warn_about_errors(session, tool);
-        perf_session_free_sample_buffers(session);
+        ordered_events__free(&session->ordered_events);
         return err;
 }
 
@@ -1368,12 +1305,11 @@ more:
 
 out:
         /* do the final flush for ordered samples */
-        session->ordered_samples.next_flush = ULLONG_MAX;
-        err = flush_sample_queue(session, tool);
+        err = ordered_events__flush(session, tool, OE_FLUSH__FINAL);
 out_err:
         ui_progress__finish();
         perf_session__warn_about_errors(session, tool);
-        perf_session_free_sample_buffers(session);
+        ordered_events__free(&session->ordered_events);
         session->one_mmap = false;
         return err;
 }