diff options
Diffstat (limited to 'tools/perf/util/probe-event.c')
-rw-r--r-- | tools/perf/util/probe-event.c | 34 |
1 files changed, 19 insertions, 15 deletions
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4fb480367c3e..9ded38ced234 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c | |||
@@ -150,7 +150,8 @@ static int convert_to_perf_probe_point(struct kprobe_trace_point *tp, | |||
150 | 150 | ||
151 | /* Try to find perf_probe_event with debuginfo */ | 151 | /* Try to find perf_probe_event with debuginfo */ |
152 | static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, | 152 | static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, |
153 | struct kprobe_trace_event **tevs) | 153 | struct kprobe_trace_event **tevs, |
154 | int max_tevs) | ||
154 | { | 155 | { |
155 | bool need_dwarf = perf_probe_event_need_dwarf(pev); | 156 | bool need_dwarf = perf_probe_event_need_dwarf(pev); |
156 | int fd, ntevs; | 157 | int fd, ntevs; |
@@ -166,7 +167,7 @@ static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, | |||
166 | } | 167 | } |
167 | 168 | ||
168 | /* Searching trace events corresponding to probe event */ | 169 | /* Searching trace events corresponding to probe event */ |
169 | ntevs = find_kprobe_trace_events(fd, pev, tevs); | 170 | ntevs = find_kprobe_trace_events(fd, pev, tevs, max_tevs); |
170 | close(fd); | 171 | close(fd); |
171 | 172 | ||
172 | if (ntevs > 0) { /* Succeeded to find trace events */ | 173 | if (ntevs > 0) { /* Succeeded to find trace events */ |
@@ -180,15 +181,16 @@ static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, | |||
180 | return -ENOENT; | 181 | return -ENOENT; |
181 | } | 182 | } |
182 | /* Error path : ntevs < 0 */ | 183 | /* Error path : ntevs < 0 */ |
183 | if (need_dwarf) { | 184 | pr_debug("An error occurred in debuginfo analysis (%d).\n", ntevs); |
184 | if (ntevs == -EBADF) | 185 | if (ntevs == -EBADF) { |
185 | pr_warning("No dwarf info found in the vmlinux - " | 186 | pr_warning("Warning: No dwarf info found in the vmlinux - " |
186 | "please rebuild with CONFIG_DEBUG_INFO=y.\n"); | 187 | "please rebuild kernel with CONFIG_DEBUG_INFO=y.\n"); |
187 | return ntevs; | 188 | if (!need_dwarf) { |
189 | pr_debug("Trying to use symbols.\nn"); | ||
190 | return 0; | ||
191 | } | ||
188 | } | 192 | } |
189 | pr_debug("An error occurred in debuginfo analysis." | 193 | return ntevs; |
190 | " Try to use symbols.\n"); | ||
191 | return 0; | ||
192 | } | 194 | } |
193 | 195 | ||
194 | #define LINEBUF_SIZE 256 | 196 | #define LINEBUF_SIZE 256 |
@@ -317,7 +319,8 @@ static int convert_to_perf_probe_point(struct kprobe_trace_point *tp, | |||
317 | } | 319 | } |
318 | 320 | ||
319 | static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, | 321 | static int try_to_find_kprobe_trace_events(struct perf_probe_event *pev, |
320 | struct kprobe_trace_event **tevs __unused) | 322 | struct kprobe_trace_event **tevs __unused, |
323 | int max_tevs __unused) | ||
321 | { | 324 | { |
322 | if (perf_probe_event_need_dwarf(pev)) { | 325 | if (perf_probe_event_need_dwarf(pev)) { |
323 | pr_warning("Debuginfo-analysis is not supported.\n"); | 326 | pr_warning("Debuginfo-analysis is not supported.\n"); |
@@ -1407,14 +1410,15 @@ static int __add_kprobe_trace_events(struct perf_probe_event *pev, | |||
1407 | } | 1410 | } |
1408 | 1411 | ||
1409 | static int convert_to_kprobe_trace_events(struct perf_probe_event *pev, | 1412 | static int convert_to_kprobe_trace_events(struct perf_probe_event *pev, |
1410 | struct kprobe_trace_event **tevs) | 1413 | struct kprobe_trace_event **tevs, |
1414 | int max_tevs) | ||
1411 | { | 1415 | { |
1412 | struct symbol *sym; | 1416 | struct symbol *sym; |
1413 | int ret = 0, i; | 1417 | int ret = 0, i; |
1414 | struct kprobe_trace_event *tev; | 1418 | struct kprobe_trace_event *tev; |
1415 | 1419 | ||
1416 | /* Convert perf_probe_event with debuginfo */ | 1420 | /* Convert perf_probe_event with debuginfo */ |
1417 | ret = try_to_find_kprobe_trace_events(pev, tevs); | 1421 | ret = try_to_find_kprobe_trace_events(pev, tevs, max_tevs); |
1418 | if (ret != 0) | 1422 | if (ret != 0) |
1419 | return ret; | 1423 | return ret; |
1420 | 1424 | ||
@@ -1486,7 +1490,7 @@ struct __event_package { | |||
1486 | }; | 1490 | }; |
1487 | 1491 | ||
1488 | int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, | 1492 | int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, |
1489 | bool force_add) | 1493 | bool force_add, int max_tevs) |
1490 | { | 1494 | { |
1491 | int i, j, ret; | 1495 | int i, j, ret; |
1492 | struct __event_package *pkgs; | 1496 | struct __event_package *pkgs; |
@@ -1505,7 +1509,7 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, | |||
1505 | pkgs[i].pev = &pevs[i]; | 1509 | pkgs[i].pev = &pevs[i]; |
1506 | /* Convert with or without debuginfo */ | 1510 | /* Convert with or without debuginfo */ |
1507 | ret = convert_to_kprobe_trace_events(pkgs[i].pev, | 1511 | ret = convert_to_kprobe_trace_events(pkgs[i].pev, |
1508 | &pkgs[i].tevs); | 1512 | &pkgs[i].tevs, max_tevs); |
1509 | if (ret < 0) | 1513 | if (ret < 0) |
1510 | goto end; | 1514 | goto end; |
1511 | pkgs[i].ntevs = ret; | 1515 | pkgs[i].ntevs = ret; |