1 files changed, 19 insertions, 30 deletions

diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 822903eaa201..e4e6249b87d4 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1,4 +1,3 @@
-#include "annotate.h"
 #include "util.h"
 #include "build-id.h"
 #include "hist.h"
@@ -182,21 +181,21 @@ void hists__output_recalc_col_len(struct hists *hists, int max_rows)
         }
 }
 
-static void hist_entry__add_cpumode_period(struct hist_entry *he,
-                                           unsigned int cpumode, u64 period)
+static void he_stat__add_cpumode_period(struct he_stat *he_stat,
+                                        unsigned int cpumode, u64 period)
 {
         switch (cpumode) {
         case PERF_RECORD_MISC_KERNEL:
-                he->stat.period_sys += period;
+                he_stat->period_sys += period;
                 break;
         case PERF_RECORD_MISC_USER:
-                he->stat.period_us += period;
+                he_stat->period_us += period;
                 break;
         case PERF_RECORD_MISC_GUEST_KERNEL:
-                he->stat.period_guest_sys += period;
+                he_stat->period_guest_sys += period;
                 break;
         case PERF_RECORD_MISC_GUEST_USER:
-                he->stat.period_guest_us += period;
+                he_stat->period_guest_us += period;
                 break;
         default:
                 break;
@@ -223,10 +222,10 @@ static void he_stat__add_stat(struct he_stat *dest, struct he_stat *src)
         dest->weight            += src->weight;
 }
 
-static void hist_entry__decay(struct hist_entry *he)
+static void he_stat__decay(struct he_stat *he_stat)
 {
-        he->stat.period = (he->stat.period * 7) / 8;
-        he->stat.nr_events = (he->stat.nr_events * 7) / 8;
+        he_stat->period = (he_stat->period * 7) / 8;
+        he_stat->nr_events = (he_stat->nr_events * 7) / 8;
         /* XXX need decay for weight too? */
 }
 
@@ -237,7 +236,7 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he)
         if (prev_period == 0)
                 return true;
 
-        hist_entry__decay(he);
+        he_stat__decay(&he->stat);
 
         if (!he->filtered)
                 hists->stats.total_period -= prev_period - he->stat.period;
@@ -342,15 +341,15 @@ static u8 symbol__parent_filter(const struct symbol *parent)
 }
 
 static struct hist_entry *add_hist_entry(struct hists *hists,
-                                      struct hist_entry *entry,
-                                      struct addr_location *al,
-                                      u64 period,
-                                      u64 weight)
+                                         struct hist_entry *entry,
+                                         struct addr_location *al)
 {
         struct rb_node **p;
         struct rb_node *parent = NULL;
         struct hist_entry *he;
         int64_t cmp;
+        u64 period = entry->stat.period;
+        u64 weight = entry->stat.weight;
 
         p = &hists->entries_in->rb_node;
 
@@ -373,7 +372,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
                          * This mem info was allocated from machine__resolve_mem
                          * and will not be used anymore.
                          */
-                        free(entry->mem_info);
+                        zfree(&entry->mem_info);
 
                         /* If the map of an existing hist_entry has
                          * become out-of-date due to an exec() or
@@ -403,7 +402,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists,
         rb_link_node(&he->rb_node_in, parent, p);
         rb_insert_color(&he->rb_node_in, hists->entries_in);
 out:
-        hist_entry__add_cpumode_period(he, al->cpumode, period);
+        he_stat__add_cpumode_period(&he->stat, al->cpumode, period);
         return he;
 }
 
@@ -437,7 +436,7 @@ struct hist_entry *__hists__add_entry(struct hists *hists,
                 .transaction = transaction,
         };
 
-        return add_hist_entry(hists, &entry, al, period, weight);
+        return add_hist_entry(hists, &entry, al);
 }
 
 int64_t
@@ -476,8 +475,8 @@ hist_entry__collapse(struct hist_entry *left, struct hist_entry *right)
 
 void hist_entry__free(struct hist_entry *he)
 {
-        free(he->branch_info);
-        free(he->mem_info);
+        zfree(&he->branch_info);
+        zfree(&he->mem_info);
         free_srcline(he->srcline);
         free(he);
 }
@@ -807,16 +806,6 @@ void hists__filter_by_symbol(struct hists *hists)
         }
 }
 
-int hist_entry__inc_addr_samples(struct hist_entry *he, int evidx, u64 ip)
-{
-        return symbol__inc_addr_samples(he->ms.sym, he->ms.map, evidx, ip);
-}
-
-int hist_entry__annotate(struct hist_entry *he, size_t privsize)
-{
-        return symbol__annotate(he->ms.sym, he->ms.map, privsize);
-}
-
 void events_stats__inc(struct events_stats *stats, u32 type)
 {
         ++stats->nr_events[0];