1 files changed, 32 insertions, 22 deletions

diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
index ed5696198d3d..5dcdba653d70 100644
--- a/tools/perf/builtin-test.c
+++ b/tools/perf/builtin-test.c
@@ -146,7 +146,7 @@ next_pair:
                                 if (llabs(skew) < page_size)
                                         continue;
 
-                                pr_debug("%#Lx: diff end addr for %s v: %#Lx k: %#Lx\n",
+                                pr_debug("%#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
                                          sym->start, sym->name, sym->end, pair->end);
                         } else {
                                 struct rb_node *nnd;
@@ -168,11 +168,11 @@ detour:
                                         goto detour;
                                 }
 
-                                pr_debug("%#Lx: diff name v: %s k: %s\n",
+                                pr_debug("%#" PRIx64 ": diff name v: %s k: %s\n",
                                          sym->start, sym->name, pair->name);
                         }
                 } else
-                        pr_debug("%#Lx: %s not on kallsyms\n", sym->start, sym->name);
+                        pr_debug("%#" PRIx64 ": %s not on kallsyms\n", sym->start, sym->name);
 
                 err = -1;
         }
@@ -211,10 +211,10 @@ detour:
 
                 if (pair->start == pos->start) {
                         pair->priv = 1;
-                        pr_info(" %Lx-%Lx %Lx %s in kallsyms as",
+                        pr_info(" %" PRIx64 "-%" PRIx64 " %" PRIx64 " %s in kallsyms as",
                                 pos->start, pos->end, pos->pgoff, pos->dso->name);
                         if (pos->pgoff != pair->pgoff || pos->end != pair->end)
-                                pr_info(": \n*%Lx-%Lx %Lx",
+                                pr_info(": \n*%" PRIx64 "-%" PRIx64 " %" PRIx64 "",
                                         pair->start, pair->end, pair->pgoff);
                         pr_info(" %s\n", pair->dso->name);
                         pair->priv = 1;
@@ -307,7 +307,7 @@ static int test__open_syscall_event(void)
         }
 
         if (evsel->counts->cpu[0].val != nr_open_calls) {
-                pr_debug("perf_evsel__read_on_cpu: expected to intercept %d calls, got %Ld\n",
+                pr_debug("perf_evsel__read_on_cpu: expected to intercept %d calls, got %" PRIu64 "\n",
                          nr_open_calls, evsel->counts->cpu[0].val);
                 goto out_close_fd;
         }
@@ -332,8 +332,7 @@ static int test__open_syscall_event_on_all_cpus(void)
         struct perf_evsel *evsel;
         struct perf_event_attr attr;
         unsigned int nr_open_calls = 111, i;
-        cpu_set_t *cpu_set;
-        size_t cpu_set_size;
+        cpu_set_t cpu_set;
         int id = trace_event__id("sys_enter_open");
 
         if (id < 0) {
@@ -353,13 +352,8 @@ static int test__open_syscall_event_on_all_cpus(void)
                 return -1;
         }
 
-        cpu_set = CPU_ALLOC(cpus->nr);
 
-        if (cpu_set == NULL)
-                goto out_thread_map_delete;
-
-        cpu_set_size = CPU_ALLOC_SIZE(cpus->nr);
-        CPU_ZERO_S(cpu_set_size, cpu_set);
+        CPU_ZERO(&cpu_set);
 
         memset(&attr, 0, sizeof(attr));
         attr.type = PERF_TYPE_TRACEPOINT;
@@ -367,7 +361,7 @@ static int test__open_syscall_event_on_all_cpus(void)
         evsel = perf_evsel__new(&attr, 0);
         if (evsel == NULL) {
                 pr_debug("perf_evsel__new\n");
-                goto out_cpu_free;
+                goto out_thread_map_delete;
         }
 
         if (perf_evsel__open(evsel, cpus, threads) < 0) {
@@ -379,14 +373,29 @@ static int test__open_syscall_event_on_all_cpus(void)
 
         for (cpu = 0; cpu < cpus->nr; ++cpu) {
                 unsigned int ncalls = nr_open_calls + cpu;
+                /*
+                 * XXX eventually lift this restriction in a way that
+                 * keeps perf building on older glibc installations
+                 * without CPU_ALLOC. 1024 cpus in 2010 still seems
+                 * a reasonable upper limit tho :-)
+                 */
+                if (cpus->map[cpu] >= CPU_SETSIZE) {
+                        pr_debug("Ignoring CPU %d\n", cpus->map[cpu]);
+                        continue;
+                }
 
-                CPU_SET(cpu, cpu_set);
-                sched_setaffinity(0, cpu_set_size, cpu_set);
+                CPU_SET(cpus->map[cpu], &cpu_set);
+                if (sched_setaffinity(0, sizeof(cpu_set), &cpu_set) < 0) {
+                        pr_debug("sched_setaffinity() failed on CPU %d: %s ",
+                                 cpus->map[cpu],
+                                 strerror(errno));
+                        goto out_close_fd;
+                }
                 for (i = 0; i < ncalls; ++i) {
                         fd = open("/etc/passwd", O_RDONLY);
                         close(fd);
                 }
-                CPU_CLR(cpu, cpu_set);
+                CPU_CLR(cpus->map[cpu], &cpu_set);
         }
 
         /*
@@ -402,6 +411,9 @@ static int test__open_syscall_event_on_all_cpus(void)
         for (cpu = 0; cpu < cpus->nr; ++cpu) {
                 unsigned int expected;
 
+                if (cpus->map[cpu] >= CPU_SETSIZE)
+                        continue;
+
                 if (perf_evsel__read_on_cpu(evsel, cpu, 0) < 0) {
                         pr_debug("perf_evsel__open_read_on_cpu\n");
                         goto out_close_fd;
@@ -409,8 +421,8 @@ static int test__open_syscall_event_on_all_cpus(void)
 
                 expected = nr_open_calls + cpu;
                 if (evsel->counts->cpu[cpu].val != expected) {
-                        pr_debug("perf_evsel__read_on_cpu: expected to intercept %d calls on cpu %d, got %Ld\n",
-                                 expected, cpu, evsel->counts->cpu[cpu].val);
+                        pr_debug("perf_evsel__read_on_cpu: expected to intercept %d calls on cpu %d, got %" PRIu64 "\n",
+                                 expected, cpus->map[cpu], evsel->counts->cpu[cpu].val);
                         goto out_close_fd;
                 }
         }
@@ -420,8 +432,6 @@ out_close_fd:
         perf_evsel__close_fd(evsel, 1, threads->nr);
 out_evsel_delete:
         perf_evsel__delete(evsel);
-out_cpu_free:
-        CPU_FREE(cpu_set);
 out_thread_map_delete:
         thread_map__delete(threads);
         return err;