1 files changed, 438 insertions, 255 deletions

diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
index e12c844df1e2..821c1586a22b 100644
--- a/tools/perf/builtin-lock.c
+++ b/tools/perf/builtin-lock.c
@@ -23,6 +23,8 @@
 #include <linux/list.h>
 #include <linux/hash.h>
 
+static struct perf_session *session;
+
 /* based on kernel/lockdep.c */
 #define LOCKHASH_BITS           12
 #define LOCKHASH_SIZE           (1UL << LOCKHASH_BITS)
@@ -32,9 +34,6 @@ static struct list_head lockhash_table[LOCKHASH_SIZE];
 #define __lockhashfn(key)       hash_long((unsigned long)key, LOCKHASH_BITS)
 #define lockhashentry(key)      (lockhash_table + __lockhashfn((key)))
 
-#define LOCK_STATE_UNLOCKED     0              /* initial state */
-#define LOCK_STATE_LOCKED       1
-
 struct lock_stat {
         struct list_head        hash_entry;
         struct rb_node          rb;             /* used for sorting */
@@ -47,20 +46,151 @@ struct lock_stat {
         void                    *addr;          /* address of lockdep_map, used as ID */
         char                    *name;          /* for strcpy(), we cannot use const */
 
-        int                     state;
-        u64                     prev_event_time; /* timestamp of previous event */
-
-        unsigned int            nr_acquired;
         unsigned int            nr_acquire;
+        unsigned int            nr_acquired;
         unsigned int            nr_contended;
         unsigned int            nr_release;
 
+        unsigned int            nr_readlock;
+        unsigned int            nr_trylock;
         /* these times are in nano sec. */
         u64                     wait_time_total;
         u64                     wait_time_min;
         u64                     wait_time_max;
+
+        int                     discard; /* flag of blacklist */
 };
 
+/*
+ * States of lock_seq_stat
+ *
+ * UNINITIALIZED is required for detecting first event of acquire.
+ * As the nature of lock events, there is no guarantee
+ * that the first event for the locks are acquire,
+ * it can be acquired, contended or release.
+ */
+#define SEQ_STATE_UNINITIALIZED      0         /* initial state */
+#define SEQ_STATE_RELEASED      1
+#define SEQ_STATE_ACQUIRING     2
+#define SEQ_STATE_ACQUIRED      3
+#define SEQ_STATE_READ_ACQUIRED 4
+#define SEQ_STATE_CONTENDED     5
+
+/*
+ * MAX_LOCK_DEPTH
+ * Imported from include/linux/sched.h.
+ * Should this be synchronized?
+ */
+#define MAX_LOCK_DEPTH 48
+
+/*
+ * struct lock_seq_stat:
+ * Place to put on state of one lock sequence
+ * 1) acquire -> acquired -> release
+ * 2) acquire -> contended -> acquired -> release
+ * 3) acquire (with read or try) -> release
+ * 4) Are there other patterns?
+ */
+struct lock_seq_stat {
+        struct list_head        list;
+        int                     state;
+        u64                     prev_event_time;
+        void                    *addr;
+
+        int                     read_count;
+};
+
+struct thread_stat {
+        struct rb_node          rb;
+
+        u32                     tid;
+        struct list_head        seq_list;
+};
+
+static struct rb_root           thread_stats;
+
+static struct thread_stat *thread_stat_find(u32 tid)
+{
+        struct rb_node *node;
+        struct thread_stat *st;
+
+        node = thread_stats.rb_node;
+        while (node) {
+                st = container_of(node, struct thread_stat, rb);
+                if (st->tid == tid)
+                        return st;
+                else if (tid < st->tid)
+                        node = node->rb_left;
+                else
+                        node = node->rb_right;
+        }
+
+        return NULL;
+}
+
+static void thread_stat_insert(struct thread_stat *new)
+{
+        struct rb_node **rb = &thread_stats.rb_node;
+        struct rb_node *parent = NULL;
+        struct thread_stat *p;
+
+        while (*rb) {
+                p = container_of(*rb, struct thread_stat, rb);
+                parent = *rb;
+
+                if (new->tid < p->tid)
+                        rb = &(*rb)->rb_left;
+                else if (new->tid > p->tid)
+                        rb = &(*rb)->rb_right;
+                else
+                        BUG_ON("inserting invalid thread_stat\n");
+        }
+
+        rb_link_node(&new->rb, parent, rb);
+        rb_insert_color(&new->rb, &thread_stats);
+}
+
+static struct thread_stat *thread_stat_findnew_after_first(u32 tid)
+{
+        struct thread_stat *st;
+
+        st = thread_stat_find(tid);
+        if (st)
+                return st;
+
+        st = zalloc(sizeof(struct thread_stat));
+        if (!st)
+                die("memory allocation failed\n");
+
+        st->tid = tid;
+        INIT_LIST_HEAD(&st->seq_list);
+
+        thread_stat_insert(st);
+
+        return st;
+}
+
+static struct thread_stat *thread_stat_findnew_first(u32 tid);
+static struct thread_stat *(*thread_stat_findnew)(u32 tid) =
+        thread_stat_findnew_first;
+
+static struct thread_stat *thread_stat_findnew_first(u32 tid)
+{
+        struct thread_stat *st;
+
+        st = zalloc(sizeof(struct thread_stat));
+        if (!st)
+                die("memory allocation failed\n");
+        st->tid = tid;
+        INIT_LIST_HEAD(&st->seq_list);
+
+        rb_link_node(&st->rb, NULL, &thread_stats.rb_node);
+        rb_insert_color(&st->rb, &thread_stats);
+
+        thread_stat_findnew = thread_stat_findnew_after_first;
+        return st;
+}
+
 /* build simple key function one is bigger than two */
 #define SINGLE_KEY(member)                                              \
         static int lock_stat_key_ ## member(struct lock_stat *one,      \
@@ -175,8 +305,6 @@ static struct lock_stat *lock_stat_findnew(void *addr, const char *name)
                 goto alloc_failed;
         strcpy(new->name, name);
 
-        /* LOCK_STATE_UNLOCKED == 0 isn't guaranteed forever */
-        new->state = LOCK_STATE_UNLOCKED;
         new->wait_time_min = ULLONG_MAX;
 
         list_add(&new->hash_entry, entry);
@@ -188,8 +316,6 @@ alloc_failed:
 
 static char                     const *input_name = "perf.data";
 
-static int                      profile_cpu = -1;
-
 struct raw_event_sample {
         u32                     size;
         char                    data[0];
@@ -198,6 +324,7 @@ struct raw_event_sample {
 struct trace_acquire_event {
         void                    *addr;
         const char              *name;
+        int                     flag;
 };
 
 struct trace_acquired_event {
@@ -241,120 +368,258 @@ struct trace_lock_handler {
                               struct thread *thread);
 };
 
+static struct lock_seq_stat *get_seq(struct thread_stat *ts, void *addr)
+{
+        struct lock_seq_stat *seq;
+
+        list_for_each_entry(seq, &ts->seq_list, list) {
+                if (seq->addr == addr)
+                        return seq;
+        }
+
+        seq = zalloc(sizeof(struct lock_seq_stat));
+        if (!seq)
+                die("Not enough memory\n");
+        seq->state = SEQ_STATE_UNINITIALIZED;
+        seq->addr = addr;
+
+        list_add(&seq->list, &ts->seq_list);
+        return seq;
+}
+
+enum broken_state {
+        BROKEN_ACQUIRE,
+        BROKEN_ACQUIRED,
+        BROKEN_CONTENDED,
+        BROKEN_RELEASE,
+        BROKEN_MAX,
+};
+
+static int bad_hist[BROKEN_MAX];
+
+enum acquire_flags {
+        TRY_LOCK = 1,
+        READ_LOCK = 2,
+};
+
 static void
 report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                         struct event *__event __used,
                         int cpu __used,
-                        u64 timestamp,
+                        u64 timestamp __used,
                         struct thread *thread __used)
 {
-        struct lock_stat *st;
+        struct lock_stat *ls;
+        struct thread_stat *ts;
+        struct lock_seq_stat *seq;
+
+        ls = lock_stat_findnew(acquire_event->addr, acquire_event->name);
+        if (ls->discard)
+                return;
 
-        st = lock_stat_findnew(acquire_event->addr, acquire_event->name);
+        ts = thread_stat_findnew(thread->pid);
+        seq = get_seq(ts, acquire_event->addr);
 
-        switch (st->state) {
-        case LOCK_STATE_UNLOCKED:
+        switch (seq->state) {
+        case SEQ_STATE_UNINITIALIZED:
+        case SEQ_STATE_RELEASED:
+                if (!acquire_event->flag) {
+                        seq->state = SEQ_STATE_ACQUIRING;
+                } else {
+                        if (acquire_event->flag & TRY_LOCK)
+                                ls->nr_trylock++;
+                        if (acquire_event->flag & READ_LOCK)
+                                ls->nr_readlock++;
+                        seq->state = SEQ_STATE_READ_ACQUIRED;
+                        seq->read_count = 1;
+                        ls->nr_acquired++;
+                }
+                break;
+        case SEQ_STATE_READ_ACQUIRED:
+                if (acquire_event->flag & READ_LOCK) {
+                        seq->read_count++;
+                        ls->nr_acquired++;
+                        goto end;
+                } else {
+                        goto broken;
+                }
                 break;
-        case LOCK_STATE_LOCKED:
+        case SEQ_STATE_ACQUIRED:
+        case SEQ_STATE_ACQUIRING:
+        case SEQ_STATE_CONTENDED:
+broken:
+                /* broken lock sequence, discard it */
+                ls->discard = 1;
+                bad_hist[BROKEN_ACQUIRE]++;
+                list_del(&seq->list);
+                free(seq);
+                goto end;
                 break;
         default:
-                BUG_ON(1);
+                BUG_ON("Unknown state of lock sequence found!\n");
                 break;
         }
 
-        st->prev_event_time = timestamp;
+        ls->nr_acquire++;
+        seq->prev_event_time = timestamp;
+end:
+        return;
 }
 
 static void
 report_lock_acquired_event(struct trace_acquired_event *acquired_event,
                          struct event *__event __used,
                          int cpu __used,
-                         u64 timestamp,
+                         u64 timestamp __used,
                          struct thread *thread __used)
 {
-        struct lock_stat *st;
+        struct lock_stat *ls;
+        struct thread_stat *ts;
+        struct lock_seq_stat *seq;
+        u64 contended_term;
+
+        ls = lock_stat_findnew(acquired_event->addr, acquired_event->name);
+        if (ls->discard)
+                return;
 
-        st = lock_stat_findnew(acquired_event->addr, acquired_event->name);
+        ts = thread_stat_findnew(thread->pid);
+        seq = get_seq(ts, acquired_event->addr);
 
-        switch (st->state) {
-        case LOCK_STATE_UNLOCKED:
-                st->state = LOCK_STATE_LOCKED;
-                st->nr_acquired++;
+        switch (seq->state) {
+        case SEQ_STATE_UNINITIALIZED:
+                /* orphan event, do nothing */
+                return;
+        case SEQ_STATE_ACQUIRING:
+                break;
+        case SEQ_STATE_CONTENDED:
+                contended_term = timestamp - seq->prev_event_time;
+                ls->wait_time_total += contended_term;
+                if (contended_term < ls->wait_time_min)
+                        ls->wait_time_min = contended_term;
+                if (ls->wait_time_max < contended_term)
+                        ls->wait_time_max = contended_term;
                 break;
-        case LOCK_STATE_LOCKED:
+        case SEQ_STATE_RELEASED:
+        case SEQ_STATE_ACQUIRED:
+        case SEQ_STATE_READ_ACQUIRED:
+                /* broken lock sequence, discard it */
+                ls->discard = 1;
+                bad_hist[BROKEN_ACQUIRED]++;
+                list_del(&seq->list);
+                free(seq);
+                goto end;
                 break;
+
         default:
-                BUG_ON(1);
+                BUG_ON("Unknown state of lock sequence found!\n");
                 break;
         }
 
-        st->prev_event_time = timestamp;
+        seq->state = SEQ_STATE_ACQUIRED;
+        ls->nr_acquired++;
+        seq->prev_event_time = timestamp;
+end:
+        return;
 }
 
 static void
 report_lock_contended_event(struct trace_contended_event *contended_event,
                           struct event *__event __used,
                           int cpu __used,
-                          u64 timestamp,
+                          u64 timestamp __used,
                           struct thread *thread __used)
 {
-        struct lock_stat *st;
+        struct lock_stat *ls;
+        struct thread_stat *ts;
+        struct lock_seq_stat *seq;
 
-        st = lock_stat_findnew(contended_event->addr, contended_event->name);
+        ls = lock_stat_findnew(contended_event->addr, contended_event->name);
+        if (ls->discard)
+                return;
 
-        switch (st->state) {
-        case LOCK_STATE_UNLOCKED:
+        ts = thread_stat_findnew(thread->pid);
+        seq = get_seq(ts, contended_event->addr);
+
+        switch (seq->state) {
+        case SEQ_STATE_UNINITIALIZED:
+                /* orphan event, do nothing */
+                return;
+        case SEQ_STATE_ACQUIRING:
                 break;
-        case LOCK_STATE_LOCKED:
-                st->nr_contended++;
+        case SEQ_STATE_RELEASED:
+        case SEQ_STATE_ACQUIRED:
+        case SEQ_STATE_READ_ACQUIRED:
+        case SEQ_STATE_CONTENDED:
+                /* broken lock sequence, discard it */
+                ls->discard = 1;
+                bad_hist[BROKEN_CONTENDED]++;
+                list_del(&seq->list);
+                free(seq);
+                goto end;
                 break;
         default:
-                BUG_ON(1);
+                BUG_ON("Unknown state of lock sequence found!\n");
                 break;
         }
 
-        st->prev_event_time = timestamp;
+        seq->state = SEQ_STATE_CONTENDED;
+        ls->nr_contended++;
+        seq->prev_event_time = timestamp;
+end:
+        return;
 }
 
 static void
 report_lock_release_event(struct trace_release_event *release_event,
                         struct event *__event __used,
                         int cpu __used,
-                        u64 timestamp,
+                        u64 timestamp __used,
                         struct thread *thread __used)
 {
-        struct lock_stat *st;
-        u64 hold_time;
+        struct lock_stat *ls;
+        struct thread_stat *ts;
+        struct lock_seq_stat *seq;
 
-        st = lock_stat_findnew(release_event->addr, release_event->name);
+        ls = lock_stat_findnew(release_event->addr, release_event->name);
+        if (ls->discard)
+                return;
 
-        switch (st->state) {
-        case LOCK_STATE_UNLOCKED:
-                break;
-        case LOCK_STATE_LOCKED:
-                st->state = LOCK_STATE_UNLOCKED;
-                hold_time = timestamp - st->prev_event_time;
+        ts = thread_stat_findnew(thread->pid);
+        seq = get_seq(ts, release_event->addr);
 
-                if (timestamp < st->prev_event_time) {
-                        /* terribly, this can happen... */
+        switch (seq->state) {
+        case SEQ_STATE_UNINITIALIZED:
+                goto end;
+                break;
+        case SEQ_STATE_ACQUIRED:
+                break;
+        case SEQ_STATE_READ_ACQUIRED:
+                seq->read_count--;
+                BUG_ON(seq->read_count < 0);
+                if (!seq->read_count) {
+                        ls->nr_release++;
                         goto end;
                 }
-
-                if (st->wait_time_min > hold_time)
-                        st->wait_time_min = hold_time;
-                if (st->wait_time_max < hold_time)
-                        st->wait_time_max = hold_time;
-                st->wait_time_total += hold_time;
-
-                st->nr_release++;
+                break;
+        case SEQ_STATE_ACQUIRING:
+        case SEQ_STATE_CONTENDED:
+        case SEQ_STATE_RELEASED:
+                /* broken lock sequence, discard it */
+                ls->discard = 1;
+                bad_hist[BROKEN_RELEASE]++;
+                goto free_seq;
                 break;
         default:
-                BUG_ON(1);
+                BUG_ON("Unknown state of lock sequence found!\n");
                 break;
         }
 
+        ls->nr_release++;
+free_seq:
+        list_del(&seq->list);
+        free(seq);
 end:
-        st->prev_event_time = timestamp;
+        return;
 }
 
 /* lock oriented handlers */
@@ -381,6 +646,7 @@ process_lock_acquire_event(void *data,
         tmp = raw_field_value(event, "lockdep_addr", data);
         memcpy(&acquire_event.addr, &tmp, sizeof(void *));
         acquire_event.name = (char *)raw_field_ptr(event, "name", data);
+        acquire_event.flag = (int)raw_field_value(event, "flag", data);
 
         if (trace_handler->acquire_event)
                 trace_handler->acquire_event(&acquire_event, event, cpu, timestamp, thread);
@@ -441,8 +707,7 @@ process_lock_release_event(void *data,
 }
 
 static void
-process_raw_event(void *data, int cpu,
-                  u64 timestamp, struct thread *thread)
+process_raw_event(void *data, int cpu, u64 timestamp, struct thread *thread)
 {
         struct event *event;
         int type;
@@ -460,173 +725,19 @@ process_raw_event(void *data, int cpu,
                 process_lock_release_event(data, event, cpu, timestamp, thread);
 }
 
-struct raw_event_queue {
-        u64                     timestamp;
-        int                     cpu;
-        void                    *data;
-        struct thread           *thread;
-        struct list_head        list;
-};
-
-static LIST_HEAD(raw_event_head);
-
-#define FLUSH_PERIOD    (5 * NSEC_PER_SEC)
-
-static u64 flush_limit = ULLONG_MAX;
-static u64 last_flush = 0;
-struct raw_event_queue *last_inserted;
-
-static void flush_raw_event_queue(u64 limit)
-{
-        struct raw_event_queue *tmp, *iter;
-
-        list_for_each_entry_safe(iter, tmp, &raw_event_head, list) {
-                if (iter->timestamp > limit)
-                        return;
-
-                if (iter == last_inserted)
-                        last_inserted = NULL;
-
-                process_raw_event(iter->data, iter->cpu, iter->timestamp,
-                                  iter->thread);
-
-                last_flush = iter->timestamp;
-                list_del(&iter->list);
-                free(iter->data);
-                free(iter);
-        }
-}
-
-static void __queue_raw_event_end(struct raw_event_queue *new)
-{
-        struct raw_event_queue *iter;
-
-        list_for_each_entry_reverse(iter, &raw_event_head, list) {
-                if (iter->timestamp < new->timestamp) {
-                        list_add(&new->list, &iter->list);
-                        return;
-                }
-        }
-
-        list_add(&new->list, &raw_event_head);
-}
-
-static void __queue_raw_event_before(struct raw_event_queue *new,
-                                     struct raw_event_queue *iter)
+static void print_bad_events(int bad, int total)
 {
-        list_for_each_entry_continue_reverse(iter, &raw_event_head, list) {
-                if (iter->timestamp < new->timestamp) {
-                        list_add(&new->list, &iter->list);
-                        return;
-                }
-        }
-
-        list_add(&new->list, &raw_event_head);
-}
-
-static void __queue_raw_event_after(struct raw_event_queue *new,
-                                     struct raw_event_queue *iter)
-{
-        list_for_each_entry_continue(iter, &raw_event_head, list) {
-                if (iter->timestamp > new->timestamp) {
-                        list_add_tail(&new->list, &iter->list);
-                        return;
-                }
-        }
-        list_add_tail(&new->list, &raw_event_head);
-}
-
-/* The queue is ordered by time */
-static void __queue_raw_event(struct raw_event_queue *new)
-{
-        if (!last_inserted) {
-                __queue_raw_event_end(new);
-                return;
-        }
-
-        /*
-         * Most of the time the current event has a timestamp
-         * very close to the last event inserted, unless we just switched
-         * to another event buffer. Having a sorting based on a list and
-         * on the last inserted event that is close to the current one is
-         * probably more efficient than an rbtree based sorting.
-         */
-        if (last_inserted->timestamp >= new->timestamp)
-                __queue_raw_event_before(new, last_inserted);
-        else
-                __queue_raw_event_after(new, last_inserted);
-}
-
-static void queue_raw_event(void *data, int raw_size, int cpu,
-                            u64 timestamp, struct thread *thread)
-{
-        struct raw_event_queue *new;
-
-        if (flush_limit == ULLONG_MAX)
-                flush_limit = timestamp + FLUSH_PERIOD;
-
-        if (timestamp < last_flush) {
-                printf("Warning: Timestamp below last timeslice flush\n");
-                return;
-        }
-
-        new = malloc(sizeof(*new));
-        if (!new)
-                die("Not enough memory\n");
-
-        new->timestamp = timestamp;
-        new->cpu = cpu;
-        new->thread = thread;
-
-        new->data = malloc(raw_size);
-        if (!new->data)
-                die("Not enough memory\n");
-
-        memcpy(new->data, data, raw_size);
-
-        __queue_raw_event(new);
-        last_inserted = new;
-
-        /*
-         * We want to have a slice of events covering 2 * FLUSH_PERIOD
-         * If FLUSH_PERIOD is big enough, it ensures every events that occured
-         * in the first half of the timeslice have all been buffered and there
-         * are none remaining (we need that because of the weakly ordered
-         * event recording we have). Then once we reach the 2 * FLUSH_PERIOD
-         * timeslice, we flush the first half to be gentle with the memory
-         * (the second half can still get new events in the middle, so wait
-         * another period to flush it)
-         */
-        if (new->timestamp > flush_limit &&
-                new->timestamp - flush_limit > FLUSH_PERIOD) {
-                flush_limit += FLUSH_PERIOD;
-                flush_raw_event_queue(flush_limit);
-        }
-}
-
-static int process_sample_event(event_t *event, struct perf_session *session)
-{
-        struct thread *thread;
-        struct sample_data data;
-
-        bzero(&data, sizeof(struct sample_data));
-        event__parse_sample(event, session->sample_type, &data);
-        thread = perf_session__findnew(session, data.pid);
-
-        if (thread == NULL) {
-                pr_debug("problem processing %d event, skipping it.\n",
-                         event->header.type);
-                return -1;
-        }
-
-        dump_printf(" ... thread: %s:%d\n", thread->comm, thread->pid);
-
-        if (profile_cpu != -1 && profile_cpu != (int) data.cpu)
-                return 0;
-
-        queue_raw_event(data.raw_data, data.raw_size, data.cpu, data.time, thread);
-
-        return 0;
+        /* Output for debug, this have to be removed */
+        int i;
+        const char *name[4] =
+                { "acquire", "acquired", "contended", "release" };
+
+        pr_info("\n=== output for debug===\n\n");
+        pr_info("bad: %d, total: %d\n", bad, total);
+        pr_info("bad rate: %f %%\n", (double)bad / (double)total * 100);
+        pr_info("histogram of events caused bad sequence\n");
+        for (i = 0; i < BROKEN_MAX; i++)
+                pr_info(" %10s: %d\n", name[i], bad_hist[i]);
 }
 
 /* TODO: various way to print, coloring, nano or milli sec */
@@ -634,26 +745,30 @@ static void print_result(void)
 {
         struct lock_stat *st;
         char cut_name[20];
+        int bad, total;
 
-        printf("%18s ", "ID");
-        printf("%20s ", "Name");
-        printf("%10s ", "acquired");
-        printf("%10s ", "contended");
+        pr_info("%20s ", "Name");
+        pr_info("%10s ", "acquired");
+        pr_info("%10s ", "contended");
 
-        printf("%15s ", "total wait (ns)");
-        printf("%15s ", "max wait (ns)");
-        printf("%15s ", "min wait (ns)");
+        pr_info("%15s ", "total wait (ns)");
+        pr_info("%15s ", "max wait (ns)");
+        pr_info("%15s ", "min wait (ns)");
 
-        printf("\n\n");
+        pr_info("\n\n");
 
+        bad = total = 0;
         while ((st = pop_from_result())) {
+                total++;
+                if (st->discard) {
+                        bad++;
+                        continue;
+                }
                 bzero(cut_name, 20);
 
-                printf("%p ", st->addr);
-
                 if (strlen(st->name) < 16) {
                         /* output raw name */
-                        printf("%20s ", st->name);
+                        pr_info("%20s ", st->name);
                 } else {
                         strncpy(cut_name, st->name, 16);
                         cut_name[16] = '.';
@@ -661,18 +776,39 @@ static void print_result(void)
                         cut_name[18] = '.';
                         cut_name[19] = '\0';
                         /* cut off name for saving output style */
-                        printf("%20s ", cut_name);
+                        pr_info("%20s ", cut_name);
                 }
 
-                printf("%10u ", st->nr_acquired);
-                printf("%10u ", st->nr_contended);
+                pr_info("%10u ", st->nr_acquired);
+                pr_info("%10u ", st->nr_contended);
 
-                printf("%15llu ", st->wait_time_total);
-                printf("%15llu ", st->wait_time_max);
-                printf("%15llu ", st->wait_time_min == ULLONG_MAX ?
+                pr_info("%15llu ", st->wait_time_total);
+                pr_info("%15llu ", st->wait_time_max);
+                pr_info("%15llu ", st->wait_time_min == ULLONG_MAX ?
                        0 : st->wait_time_min);
-                printf("\n");
+                pr_info("\n");
         }
+
+        print_bad_events(bad, total);
+}
+
+static bool info_threads, info_map;
+
+static void dump_threads(void)
+{
+        struct thread_stat *st;
+        struct rb_node *node;
+        struct thread *t;
+
+        pr_info("%10s: comm\n", "Thread ID");
+
+        node = rb_first(&thread_stats);
+        while (node) {
+                st = container_of(node, struct thread_stat, rb);
+                t = perf_session__findnew(session, st->tid);
+                pr_info("%10d: %s\n", st->tid, t->comm);
+                node = rb_next(node);
+        };
 }
 
 static void dump_map(void)
@@ -680,23 +816,53 @@ static void dump_map(void)
         unsigned int i;
         struct lock_stat *st;
 
+        pr_info("Address of instance: name of class\n");
         for (i = 0; i < LOCKHASH_SIZE; i++) {
                 list_for_each_entry(st, &lockhash_table[i], hash_entry) {
-                        printf("%p: %s\n", st->addr, st->name);
+                        pr_info(" %p: %s\n", st->addr, st->name);
                 }
         }
 }
 
+static void dump_info(void)
+{
+        if (info_threads)
+                dump_threads();
+        else if (info_map)
+                dump_map();
+        else
+                die("Unknown type of information\n");
+}
+
+static int process_sample_event(event_t *self, struct perf_session *s)
+{
+        struct sample_data data;
+        struct thread *thread;
+
+        bzero(&data, sizeof(data));
+        event__parse_sample(self, s->sample_type, &data);
+
+        thread = perf_session__findnew(s, data.tid);
+        if (thread == NULL) {
+                pr_debug("problem processing %d event, skipping it.\n",
+                        self->header.type);
+                return -1;
+        }
+
+        process_raw_event(data.raw_data, data.cpu, data.time, thread);
+
+        return 0;
+}
+
 static struct perf_event_ops eops = {
         .sample                 = process_sample_event,
         .comm                   = event__process_comm,
+        .ordered_samples        = true,
 };
 
-static struct perf_session *session;
-
 static int read_events(void)
 {
-        session = perf_session__new(input_name, O_RDONLY, 0);
+        session = perf_session__new(input_name, O_RDONLY, 0, false);
         if (!session)
                 die("Initializing perf session failed\n");
 
@@ -720,7 +886,6 @@ static void __cmd_report(void)
         setup_pager();
         select_key();
         read_events();
-        flush_raw_event_queue(ULLONG_MAX);
         sort_result();
         print_result();
 }
@@ -737,6 +902,19 @@ static const struct option report_options[] = {
         OPT_END()
 };
 
+static const char * const info_usage[] = {
+        "perf lock info [<options>]",
+        NULL
+};
+
+static const struct option info_options[] = {
+        OPT_BOOLEAN('t', "threads", &info_threads,
+                    "dump thread list in perf.data"),
+        OPT_BOOLEAN('m', "map", &info_map,
+                    "map of lock instances (name:address table)"),
+        OPT_END()
+};
+
 static const char * const lock_usage[] = {
         "perf lock [<options>] {record|trace|report}",
         NULL
@@ -744,14 +922,13 @@ static const char * const lock_usage[] = {
 
 static const struct option lock_options[] = {
         OPT_STRING('i', "input", &input_name, "file", "input file name"),
-        OPT_BOOLEAN('v', "verbose", &verbose, "be more verbose (show symbol address, etc)"),
+        OPT_INCR('v', "verbose", &verbose, "be more verbose (show symbol address, etc)"),
         OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, "dump raw trace in ASCII"),
         OPT_END()
 };
 
 static const char *record_args[] = {
         "record",
-        "-a",
         "-R",
         "-f",
         "-m", "1024",
@@ -808,12 +985,18 @@ int cmd_lock(int argc, const char **argv, const char *prefix __used)
         } else if (!strcmp(argv[0], "trace")) {
                 /* Aliased to 'perf trace' */
                 return cmd_trace(argc, argv, prefix);
-        } else if (!strcmp(argv[0], "map")) {
+        } else if (!strcmp(argv[0], "info")) {
+                if (argc) {
+                        argc = parse_options(argc, argv,
+                                             info_options, info_usage, 0);
+                        if (argc)
+                                usage_with_options(info_usage, info_options);
+                }
                 /* recycling report_lock_ops */
                 trace_handler = &report_lock_ops;
                 setup_pager();
                 read_events();
-                dump_map();
+                dump_info();
         } else {
                 usage_with_options(lock_usage, lock_options);
         }