1 files changed, 56 insertions, 71 deletions

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index bd71b8ceafb7..a6e2fdc7a04e 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -19,22 +19,15 @@
 static char const *input_old = "perf.data.old",
                   *input_new = "perf.data";
 static char       diff__default_sort_order[] = "dso,symbol";
-static int  force;
+static bool  force;
 static bool show_displacement;
 
-static int perf_session__add_hist_entry(struct perf_session *self,
-                                        struct addr_location *al, u64 count)
+static int hists__add_entry(struct hists *self,
+                            struct addr_location *al, u64 period)
 {
-        bool hit;
-        struct hist_entry *he = __perf_session__add_hist_entry(self, al, NULL,
-                                                               count, &hit);
-        if (he == NULL)
-                return -ENOMEM;
-
-        if (hit)
-                he->count += count;
-
-        return 0;
+        if (__hists__add_entry(self, al, NULL, period) != NULL)
+                return 0;
+        return -ENOMEM;
 }
 
 static int diff__process_sample_event(event_t *event, struct perf_session *session)
@@ -42,8 +35,8 @@ static int diff__process_sample_event(event_t *event, struct perf_session *sessi
         struct addr_location al;
         struct sample_data data = { .period = 1, };
 
-        dump_printf("(IP, %d): %d: %p\n", event->header.misc,
-                    event->ip.pid, (void *)(long)event->ip.ip);
+        dump_printf("(IP, %d): %d: %#Lx\n", event->header.misc,
+                    event->ip.pid, event->ip.ip);
 
         if (event__preprocess_sample(event, session, &al, NULL) < 0) {
                 pr_warning("problem processing %d event, skipping it.\n",
@@ -51,27 +44,27 @@ static int diff__process_sample_event(event_t *event, struct perf_session *sessi
                 return -1;
         }
 
-        if (al.filtered)
+        if (al.filtered || al.sym == NULL)
                 return 0;
 
         event__parse_sample(event, session->sample_type, &data);
 
-        if (al.sym && perf_session__add_hist_entry(session, &al, data.period)) {
-                pr_warning("problem incrementing symbol count, skipping event\n");
+        if (hists__add_entry(&session->hists, &al, data.period)) {
+                pr_warning("problem incrementing symbol period, skipping event\n");
                 return -1;
         }
 
-        session->events_stats.total += data.period;
+        session->hists.stats.total_period += data.period;
         return 0;
 }
 
 static struct perf_event_ops event_ops = {
-        .process_sample_event = diff__process_sample_event,
-        .process_mmap_event   = event__process_mmap,
-        .process_comm_event   = event__process_comm,
-        .process_exit_event   = event__process_task,
-        .process_fork_event   = event__process_task,
-        .process_lost_event   = event__process_lost,
+        .sample = diff__process_sample_event,
+        .mmap   = event__process_mmap,
+        .comm   = event__process_comm,
+        .exit   = event__process_task,
+        .fork   = event__process_task,
+        .lost   = event__process_lost,
 };
 
 static void perf_session__insert_hist_entry_by_name(struct rb_root *root,
@@ -82,84 +75,69 @@ static void perf_session__insert_hist_entry_by_name(struct rb_root *root,
         struct hist_entry *iter;
 
         while (*p != NULL) {
-                int cmp;
                 parent = *p;
                 iter = rb_entry(parent, struct hist_entry, rb_node);
-
-                cmp = strcmp(he->map->dso->name, iter->map->dso->name);
-                if (cmp > 0)
+                if (hist_entry__cmp(he, iter) < 0)
                         p = &(*p)->rb_left;
-                else if (cmp < 0)
+                else
                         p = &(*p)->rb_right;
-                else {
-                        cmp = strcmp(he->sym->name, iter->sym->name);
-                        if (cmp > 0)
-                                p = &(*p)->rb_left;
-                        else
-                                p = &(*p)->rb_right;
-                }
         }
 
         rb_link_node(&he->rb_node, parent, p);
         rb_insert_color(&he->rb_node, root);
 }
 
-static void perf_session__resort_by_name(struct perf_session *self)
+static void hists__resort_entries(struct hists *self)
 {
         unsigned long position = 1;
         struct rb_root tmp = RB_ROOT;
-        struct rb_node *next = rb_first(&self->hists);
+        struct rb_node *next = rb_first(&self->entries);
 
         while (next != NULL) {
                 struct hist_entry *n = rb_entry(next, struct hist_entry, rb_node);
 
                 next = rb_next(&n->rb_node);
-                rb_erase(&n->rb_node, &self->hists);
+                rb_erase(&n->rb_node, &self->entries);
                 n->position = position++;
                 perf_session__insert_hist_entry_by_name(&tmp, n);
         }
 
-        self->hists = tmp;
+        self->entries = tmp;
 }
 
-static struct hist_entry *
-perf_session__find_hist_entry_by_name(struct perf_session *self,
-                                      struct hist_entry *he)
+static void hists__set_positions(struct hists *self)
 {
-        struct rb_node *n = self->hists.rb_node;
+        hists__output_resort(self);
+        hists__resort_entries(self);
+}
+
+static struct hist_entry *hists__find_entry(struct hists *self,
+                                            struct hist_entry *he)
+{
+        struct rb_node *n = self->entries.rb_node;
 
         while (n) {
                 struct hist_entry *iter = rb_entry(n, struct hist_entry, rb_node);
-                int cmp = strcmp(he->map->dso->name, iter->map->dso->name);
+                int64_t cmp = hist_entry__cmp(he, iter);
 
-                if (cmp > 0)
+                if (cmp < 0)
                         n = n->rb_left;
-                else if (cmp < 0)
+                else if (cmp > 0)
                         n = n->rb_right;
-                else {
-                        cmp = strcmp(he->sym->name, iter->sym->name);
-                        if (cmp > 0)
-                                n = n->rb_left;
-                        else if (cmp < 0)
-                                n = n->rb_right;
-                        else
-                                return iter;
-                }
+                else 
+                        return iter;
         }
 
         return NULL;
 }
 
-static void perf_session__match_hists(struct perf_session *old_session,
-                                      struct perf_session *new_session)
+static void hists__match(struct hists *older, struct hists *newer)
 {
         struct rb_node *nd;
 
-        perf_session__resort_by_name(old_session);
-
-        for (nd = rb_first(&new_session->hists); nd; nd = rb_next(nd)) {
+        for (nd = rb_first(&newer->entries); nd; nd = rb_next(nd)) {
                 struct hist_entry *pos = rb_entry(nd, struct hist_entry, rb_node);
-                pos->pair = perf_session__find_hist_entry_by_name(old_session, pos);
+                pos->pair = hists__find_entry(older, pos);
         }
 }
 
@@ -168,8 +146,8 @@ static int __cmd_diff(void)
         int ret, i;
         struct perf_session *session[2];
 
-        session[0] = perf_session__new(input_old, O_RDONLY, force);
-        session[1] = perf_session__new(input_new, O_RDONLY, force);
+        session[0] = perf_session__new(input_old, O_RDONLY, force, false);
+        session[1] = perf_session__new(input_new, O_RDONLY, force, false);
         if (session[0] == NULL || session[1] == NULL)
                 return -ENOMEM;
 
@@ -177,12 +155,15 @@ static int __cmd_diff(void)
                 ret = perf_session__process_events(session[i], &event_ops);
                 if (ret)
                         goto out_delete;
-                perf_session__output_resort(session[i], session[i]->events_stats.total);
         }
 
-        perf_session__match_hists(session[0], session[1]);
-        perf_session__fprintf_hists(session[1], session[0],
-                                    show_displacement, stdout);
+        hists__output_resort(&session[1]->hists);
+        if (show_displacement)
+                hists__set_positions(&session[0]->hists);
+
+        hists__match(&session[0]->hists, &session[1]->hists);
+        hists__fprintf(&session[1]->hists, &session[0]->hists,
+                       show_displacement, stdout);
 out_delete:
         for (i = 0; i < 2; ++i)
                 perf_session__delete(session[i]);
@@ -195,7 +176,7 @@ static const char * const diff_usage[] = {
 };
 
 static const struct option options[] = {
-        OPT_BOOLEAN('v', "verbose", &verbose,
+        OPT_INCR('v', "verbose", &verbose,
                     "be more verbose (show symbol address, etc)"),
         OPT_BOOLEAN('m', "displacement", &show_displacement,
                     "Show position displacement relative to baseline"),
@@ -204,7 +185,7 @@ static const struct option options[] = {
         OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
         OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
                     "load module symbols - WARNING: use only with -k and LIVE kernel"),
-        OPT_BOOLEAN('P', "full-paths", &event_ops.full_paths,
+        OPT_BOOLEAN('P', "full-paths", &symbol_conf.full_paths,
                     "Don't shorten the pathnames taking into account the cwd"),
         OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
                    "only consider symbols in these dsos"),
@@ -232,6 +213,10 @@ int cmd_diff(int argc, const char **argv, const char *prefix __used)
                         input_new = argv[1];
                 } else
                         input_new = argv[0];
+        } else if (symbol_conf.default_guest_vmlinux_name ||
+                   symbol_conf.default_guest_kallsyms) {
+                input_old = "perf.data.host";
+                input_new = "perf.data.guest";
         }
 
         symbol_conf.exclude_other = false;