6 files changed, 41 insertions, 47 deletions

diff --git a/tools/perf/bench/bench.h b/tools/perf/bench/bench.h
index eba46709b279..3c4dd44d45cb 100644
--- a/tools/perf/bench/bench.h
+++ b/tools/perf/bench/bench.h
@@ -43,5 +43,6 @@ extern int bench_futex_requeue(int argc, const char **argv, const char *prefix);
 #define BENCH_FORMAT_UNKNOWN            -1
 
 extern int bench_format;
+extern unsigned int bench_repeat;
 
 #endif
diff --git a/tools/perf/bench/futex-requeue.c b/tools/perf/bench/futex-requeue.c
index a16255876f1d..732403bfd31a 100644
--- a/tools/perf/bench/futex-requeue.c
+++ b/tools/perf/bench/futex-requeue.c
@@ -29,13 +29,6 @@ static u_int32_t futex1 = 0, futex2 = 0;
  */
 static unsigned int nrequeue = 1;
 
-/*
- * There can be significant variance from run to run,
- * the more repeats, the more exact the overall avg and
- * the better idea of the futex latency.
- */
-static unsigned int repeat = 10;
-
 static pthread_t *worker;
 static bool done = 0, silent = 0;
 static pthread_mutex_t thread_lock;
@@ -46,7 +39,6 @@ static unsigned int ncpus, threads_starting, nthreads = 0;
 static const struct option options[] = {
         OPT_UINTEGER('t', "threads",  &nthreads, "Specify amount of threads"),
         OPT_UINTEGER('q', "nrequeue", &nrequeue, "Specify amount of threads to requeue at once"),
-        OPT_UINTEGER('r', "repeat",   &repeat,   "Specify amount of times to repeat the run"),
         OPT_BOOLEAN( 's', "silent",   &silent,   "Silent mode: do not display data/details"),
         OPT_END()
 };
@@ -146,7 +138,7 @@ int bench_futex_requeue(int argc, const char **argv,
         pthread_cond_init(&thread_parent, NULL);
         pthread_cond_init(&thread_worker, NULL);
 
-        for (j = 0; j < repeat && !done; j++) {
+        for (j = 0; j < bench_repeat && !done; j++) {
                 unsigned int nrequeued = 0;
                 struct timeval start, end, runtime;
 
diff --git a/tools/perf/bench/futex-wake.c b/tools/perf/bench/futex-wake.c
index d096169b161e..50022cbce87e 100644
--- a/tools/perf/bench/futex-wake.c
+++ b/tools/perf/bench/futex-wake.c
@@ -30,15 +30,8 @@ static u_int32_t futex1 = 0;
  */
 static unsigned int nwakes = 1;
 
-/*
- * There can be significant variance from run to run,
- * the more repeats, the more exact the overall avg and
- * the better idea of the futex latency.
- */
-static unsigned int repeat = 10;
-
 pthread_t *worker;
-static bool done = 0, silent = 0;
+static bool done = false, silent = false;
 static pthread_mutex_t thread_lock;
 static pthread_cond_t thread_parent, thread_worker;
 static struct stats waketime_stats, wakeup_stats;
@@ -47,7 +40,6 @@ static unsigned int ncpus, threads_starting, nthreads = 0;
 static const struct option options[] = {
         OPT_UINTEGER('t', "threads", &nthreads, "Specify amount of threads"),
         OPT_UINTEGER('w', "nwakes",  &nwakes,   "Specify amount of threads to wake at once"),
-        OPT_UINTEGER('r', "repeat",  &repeat,   "Specify amount of times to repeat the run"),
         OPT_BOOLEAN( 's', "silent",  &silent,   "Silent mode: do not display data/details"),
         OPT_END()
 };
@@ -149,7 +141,7 @@ int bench_futex_wake(int argc, const char **argv,
         pthread_cond_init(&thread_parent, NULL);
         pthread_cond_init(&thread_worker, NULL);
 
-        for (j = 0; j < repeat && !done; j++) {
+        for (j = 0; j < bench_repeat && !done; j++) {
                 unsigned int nwoken = 0;
                 struct timeval start, end, runtime;
 
diff --git a/tools/perf/bench/mem-memcpy.c b/tools/perf/bench/mem-memcpy.c
index 5ce71d3b72cf..2465141b554b 100644
--- a/tools/perf/bench/mem-memcpy.c
+++ b/tools/perf/bench/mem-memcpy.c
@@ -10,6 +10,7 @@
 #include "../util/util.h"
 #include "../util/parse-options.h"
 #include "../util/header.h"
+#include "../util/cloexec.h"
 #include "bench.h"
 #include "mem-memcpy-arch.h"
 
@@ -83,7 +84,8 @@ static struct perf_event_attr cycle_attr = {
 
 static void init_cycle(void)
 {
-        cycle_fd = sys_perf_event_open(&cycle_attr, getpid(), -1, -1, 0);
+        cycle_fd = sys_perf_event_open(&cycle_attr, getpid(), -1, -1,
+                                       perf_event_open_cloexec_flag());
 
         if (cycle_fd < 0 && errno == ENOSYS)
                 die("No CONFIG_PERF_EVENTS=y kernel support configured?\n");
@@ -189,6 +191,11 @@ int bench_mem_memcpy(int argc, const char **argv,
         argc = parse_options(argc, argv, options,
                              bench_mem_memcpy_usage, 0);
 
+        if (no_prefault && only_prefault) {
+                fprintf(stderr, "Invalid options: -o and -n are mutually exclusive\n");
+                return 1;
+        }
+
         if (use_cycle)
                 init_cycle();
 
diff --git a/tools/perf/bench/mem-memset.c b/tools/perf/bench/mem-memset.c
index 9af79d2b18e5..75fc3e65fb2a 100644
--- a/tools/perf/bench/mem-memset.c
+++ b/tools/perf/bench/mem-memset.c
@@ -10,6 +10,7 @@
 #include "../util/util.h"
 #include "../util/parse-options.h"
 #include "../util/header.h"
+#include "../util/cloexec.h"
 #include "bench.h"
 #include "mem-memset-arch.h"
 
@@ -83,7 +84,8 @@ static struct perf_event_attr cycle_attr = {
 
 static void init_cycle(void)
 {
-        cycle_fd = sys_perf_event_open(&cycle_attr, getpid(), -1, -1, 0);
+        cycle_fd = sys_perf_event_open(&cycle_attr, getpid(), -1, -1,
+                                       perf_event_open_cloexec_flag());
 
         if (cycle_fd < 0 && errno == ENOSYS)
                 die("No CONFIG_PERF_EVENTS=y kernel support configured?\n");
@@ -181,6 +183,11 @@ int bench_mem_memset(int argc, const char **argv,
         argc = parse_options(argc, argv, options,
                              bench_mem_memset_usage, 0);
 
+        if (no_prefault && only_prefault) {
+                fprintf(stderr, "Invalid options: -o and -n are mutually exclusive\n");
+                return 1;
+        }
+
         if (use_cycle)
                 init_cycle();
 
diff --git a/tools/perf/bench/sched-messaging.c b/tools/perf/bench/sched-messaging.c
index cc1190a0849b..52a56599a543 100644
--- a/tools/perf/bench/sched-messaging.c
+++ b/tools/perf/bench/sched-messaging.c
@@ -28,6 +28,7 @@
 #include <sys/time.h>
 #include <sys/poll.h>
 #include <limits.h>
+#include <err.h>
 
 #define DATASIZE 100
 
@@ -50,12 +51,6 @@ struct receiver_context {
         int wakefd;
 };
 
-static void barf(const char *msg)
-{
-        fprintf(stderr, "%s (error: %s)\n", msg, strerror(errno));
-        exit(1);
-}
-
 static void fdpair(int fds[2])
 {
         if (use_pipes) {
@@ -66,7 +61,7 @@ static void fdpair(int fds[2])
                         return;
         }
 
-        barf(use_pipes ? "pipe()" : "socketpair()");
+        err(EXIT_FAILURE, use_pipes ? "pipe()" : "socketpair()");
 }
 
 /* Block until we're ready to go */
@@ -77,11 +72,11 @@ static void ready(int ready_out, int wakefd)
 
         /* Tell them we're ready. */
         if (write(ready_out, &dummy, 1) != 1)
-                barf("CLIENT: ready write");
+                err(EXIT_FAILURE, "CLIENT: ready write");
 
         /* Wait for "GO" signal */
         if (poll(&pollfd, 1, -1) != 1)
-                barf("poll");
+                err(EXIT_FAILURE, "poll");
 }
 
 /* Sender sprays loops messages down each file descriptor */
@@ -101,7 +96,7 @@ again:
                         ret = write(ctx->out_fds[j], data + done,
                                     sizeof(data)-done);
                         if (ret < 0)
-                                barf("SENDER: write");
+                                err(EXIT_FAILURE, "SENDER: write");
                         done += ret;
                         if (done < DATASIZE)
                                 goto again;
@@ -131,7 +126,7 @@ static void *receiver(struct receiver_context* ctx)
 again:
                 ret = read(ctx->in_fds[0], data + done, DATASIZE - done);
                 if (ret < 0)
-                        barf("SERVER: read");
+                        err(EXIT_FAILURE, "SERVER: read");
                 done += ret;
                 if (done < DATASIZE)
                         goto again;
@@ -144,14 +139,14 @@ static pthread_t create_worker(void *ctx, void *(*func)(void *))
 {
         pthread_attr_t attr;
         pthread_t childid;
-        int err;
+        int ret;
 
         if (!thread_mode) {
                 /* process mode */
                 /* Fork the receiver. */
                 switch (fork()) {
                 case -1:
-                        barf("fork()");
+                        err(EXIT_FAILURE, "fork()");
                         break;
                 case 0:
                         (*func) (ctx);
@@ -165,19 +160,17 @@ static pthread_t create_worker(void *ctx, void *(*func)(void *))
         }
 
         if (pthread_attr_init(&attr) != 0)
-                barf("pthread_attr_init:");
+                err(EXIT_FAILURE, "pthread_attr_init:");
 
 #ifndef __ia64__
         if (pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN) != 0)
-                barf("pthread_attr_setstacksize");
+                err(EXIT_FAILURE, "pthread_attr_setstacksize");
 #endif
 
-        err = pthread_create(&childid, &attr, func, ctx);
-        if (err != 0) {
-                fprintf(stderr, "pthread_create failed: %s (%d)\n",
-                        strerror(err), err);
-                exit(-1);
-        }
+        ret = pthread_create(&childid, &attr, func, ctx);
+        if (ret != 0)
+                err(EXIT_FAILURE, "pthread_create failed");
+
         return childid;
 }
 
@@ -207,14 +200,14 @@ static unsigned int group(pthread_t *pth,
                         + num_fds * sizeof(int));
 
         if (!snd_ctx)
-                barf("malloc()");
+                err(EXIT_FAILURE, "malloc()");
 
         for (i = 0; i < num_fds; i++) {
                 int fds[2];
                 struct receiver_context *ctx = malloc(sizeof(*ctx));
 
                 if (!ctx)
-                        barf("malloc()");
+                        err(EXIT_FAILURE, "malloc()");
 
 
                 /* Create the pipe between client and server */
@@ -281,7 +274,7 @@ int bench_sched_messaging(int argc, const char **argv,
 
         pth_tab = malloc(num_fds * 2 * num_groups * sizeof(pthread_t));
         if (!pth_tab)
-                barf("main:malloc()");
+                err(EXIT_FAILURE, "main:malloc()");
 
         fdpair(readyfds);
         fdpair(wakefds);
@@ -294,13 +287,13 @@ int bench_sched_messaging(int argc, const char **argv,
         /* Wait for everyone to be ready */
         for (i = 0; i < total_children; i++)
                 if (read(readyfds[0], &dummy, 1) != 1)
-                        barf("Reading for readyfds");
+                        err(EXIT_FAILURE, "Reading for readyfds");
 
         gettimeofday(&start, NULL);
 
         /* Kick them off */
         if (write(wakefds[1], &dummy, 1) != 1)
-                barf("Writing to start them");
+                err(EXIT_FAILURE, "Writing to start them");
 
         /* Reap them all */
         for (i = 0; i < total_children; i++)
@@ -332,5 +325,7 @@ int bench_sched_messaging(int argc, const char **argv,
                 break;
         }
 
+        free(pth_tab);
+
         return 0;
 }