145 files changed, 1189 insertions, 1046 deletions
diff --git a/sound/aoa/core/alsa.c b/sound/aoa/core/alsa.c
index 617850463582..0fa3855b4790 100644
--- a/sound/aoa/core/alsa.c
+++ b/sound/aoa/core/alsa.c
@@ -23,9 +23,10 @@ int aoa_alsa_init(char *name, struct module *mod, struct device *dev)
                /* cannot be EEXIST due to usage in aoa_fabric_register */
                return -EBUSY;
-        alsa_card = snd_card_new(index, name, mod, sizeof(struct aoa_card));
+        err = snd_card_create(index, name, mod, sizeof(struct aoa_card),
-        if (!alsa_card)
+                              &alsa_card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        aoa_card = alsa_card->private_data;
        aoa_card->alsa_card = alsa_card;
        alsa_card->dev = dev;
diff --git a/sound/arm/aaci.c b/sound/arm/aaci.c
index 89096e811a4b..7fbd68fab944 100644
--- a/sound/arm/aaci.c
+++ b/sound/arm/aaci.c
@@ -90,7 +90,7 @@ static void aaci_ac97_write(struct snd_ac97 *ac97, unsigned short reg,
         */
        do {
                v = readl(aaci->base + AACI_SLFR);
-        } while ((v & (SLFR_1TXB|SLFR_2TXB)) && timeout--);
+        } while ((v & (SLFR_1TXB|SLFR_2TXB)) && --timeout);
        if (!timeout)
                dev_err(&aaci->dev->dev,
@@ -126,7 +126,7 @@ static unsigned short aaci_ac97_read(struct snd_ac97 *ac97, unsigned short reg)
         */
        do {
                v = readl(aaci->base + AACI_SLFR);
-        } while ((v & SLFR_1TXB) && timeout--);
+        } while ((v & SLFR_1TXB) && --timeout);
        if (!timeout) {
                dev_err(&aaci->dev->dev, "timeout on slot 1 TX busy\n");
@@ -147,7 +147,7 @@ static unsigned short aaci_ac97_read(struct snd_ac97 *ac97, unsigned short reg)
        do {
                cond_resched();
                v = readl(aaci->base + AACI_SLFR) & (SLFR_1RXV|SLFR_2RXV);
-        } while ((v != (SLFR_1RXV|SLFR_2RXV)) && timeout--);
+        } while ((v != (SLFR_1RXV|SLFR_2RXV)) && --timeout);
        if (!timeout) {
                dev_err(&aaci->dev->dev, "timeout on RX valid\n");
@@ -995,10 +995,11 @@ static struct aaci * __devinit aaci_init_card(struct amba_device *dev)
 {
        struct aaci *aaci;
        struct snd_card *card;
+        int err;
-        card = snd_card_new(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1,
+        err = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1,
-                            THIS_MODULE, sizeof(struct aaci));
+                              THIS_MODULE, sizeof(struct aaci), &card);
-        if (card == NULL)
+        if (err < 0)
                return NULL;
        card->private_free = aaci_free_card;
diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index 85cf591d4e11..7ed100c80a5f 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -173,10 +173,9 @@ static int __devinit pxa2xx_ac97_probe(struct platform_device *dev)
        struct snd_ac97_template ac97_template;
        int ret;
-        ret = -ENOMEM;
+        ret = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1,
-        card = snd_card_new(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1,
+                              THIS_MODULE, 0, &card);
-                            THIS_MODULE, 0);
+        if (ret < 0)
-        if (!card)
                goto err;
        card->dev = &dev->dev;
diff --git a/sound/arm/sa11xx-uda1341.c b/sound/arm/sa11xx-uda1341.c
index ed481a866a3e..7101d3d8bae6 100644
--- a/sound/arm/sa11xx-uda1341.c
+++ b/sound/arm/sa11xx-uda1341.c
@@ -887,9 +887,10 @@ static int __devinit sa11xx_uda1341_probe(struct platform_device *devptr)
        struct sa11xx_uda1341 *chip;
        /* register the soundcard */
-        card = snd_card_new(-1, id, THIS_MODULE, sizeof(struct sa11xx_uda1341));
+        err = snd_card_create(-1, id, THIS_MODULE,
-        if (card == NULL)
+                              sizeof(struct sa11xx_uda1341), &card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        chip = card->private_data;
        spin_lock_init(&chip->s[0].dma_lock);
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 195cafc5a553..a70ee7f1ed98 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -99,9 +99,6 @@ static int snd_hwdep_open(struct inode *inode, struct file * file)
        if (hw == NULL)
                return -ENODEV;
-        if (!hw->ops.open)
-                return -ENXIO;
        if (!try_module_get(hw->card->module))
                return -EFAULT;
@@ -113,6 +110,10 @@ static int snd_hwdep_open(struct inode *inode, struct file * file)
                        err = -EBUSY;
                        break;
                }
+                if (!hw->ops.open) {
+                        err = 0;
+                        break;
+                }
                err = hw->ops.open(hw, file);
                if (err >= 0)
                        break;
@@ -151,7 +152,7 @@ static int snd_hwdep_open(struct inode *inode, struct file * file)
 static int snd_hwdep_release(struct inode *inode, struct file * file)
 {
-        int err = -ENXIO;
+        int err = 0;
        struct snd_hwdep *hw = file->private_data;
        struct module *mod = hw->card->module;
diff --git a/sound/core/init.c b/sound/core/init.c
index 0d5520c415d3..fd56afe846ed 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -121,31 +121,44 @@ static inline int init_info_for_card(struct snd_card *card)
 #endif
 /**
- *  snd_card_new - create and initialize a soundcard structure
+ *  snd_card_create - create and initialize a soundcard structure
 *  @idx: card index (address) [0 ... (SNDRV_CARDS-1)]
 *  @xid: card identification (ASCII string)
 *  @module: top level module for locking
 *  @extra_size: allocate this extra size after the main soundcard structure
+ *  @card_ret: the pointer to store the created card instance
 *
 *  Creates and initializes a soundcard structure.
 *
- *  Returns kmallocated snd_card structure. Creates the ALSA control interface
+ *  The function allocates snd_card instance via kzalloc with the given
- *  (which is blocked until snd_card_register function is called).
+ *  space for the driver to use freely.  The allocated struct is stored
+ *  in the given card_ret pointer.
+ *
+ *  Returns zero if successful or a negative error code.
 */
-struct snd_card *snd_card_new(int idx, const char *xid,
+int snd_card_create(int idx, const char *xid,
-                         struct module *module, int extra_size)
+                    struct module *module, int extra_size,
+                    struct snd_card **card_ret)
 {
        struct snd_card *card;
        int err, idx2;
+        if (snd_BUG_ON(!card_ret))
+                return -EINVAL;
+        *card_ret = NULL;
        if (extra_size < 0)
                extra_size = 0;
        card = kzalloc(sizeof(*card) + extra_size, GFP_KERNEL);
-        if (card == NULL)
+        if (!card)
-                return NULL;
+                return -ENOMEM;
        if (xid) {
-                if (!snd_info_check_reserved_words(xid))
+                if (!snd_info_check_reserved_words(xid)) {
+                        snd_printk(KERN_ERR
+                                   "given id string '%s' is reserved.\n", xid);
+                        err = -EBUSY;
                        goto __error;
+                }
                strlcpy(card->id, xid, sizeof(card->id));
        }
        err = 0;
@@ -195,6 +208,7 @@ struct snd_card *snd_card_new(int idx, const char *xid,
        INIT_LIST_HEAD(&card->controls);
        INIT_LIST_HEAD(&card->ctl_files);
        spin_lock_init(&card->files_lock);
+        INIT_LIST_HEAD(&card->files_list);
        init_waitqueue_head(&card->shutdown_sleep);
 #ifdef CONFIG_PM
        mutex_init(&card->power_lock);
@@ -202,26 +216,28 @@ struct snd_card *snd_card_new(int idx, const char *xid,
 #endif
        /* the control interface cannot be accessed from the user space until */
        /* snd_cards_bitmask and snd_cards are set with snd_card_register */
-        if ((err = snd_ctl_create(card)) < 0) {
+        err = snd_ctl_create(card);
-                snd_printd("unable to register control minors\n");
+        if (err < 0) {
+                snd_printk(KERN_ERR "unable to register control minors\n");
                goto __error;
        }
-        if ((err = snd_info_card_create(card)) < 0) {
+        err = snd_info_card_create(card);
-                snd_printd("unable to create card info\n");
+        if (err < 0) {
+                snd_printk(KERN_ERR "unable to create card info\n");
                goto __error_ctl;
        }
        if (extra_size > 0)
                card->private_data = (char *)card + sizeof(struct snd_card);
-        return card;
+        *card_ret = card;
+        return 0;
      __error_ctl:
        snd_device_free_all(card, SNDRV_DEV_CMD_PRE);
      __error:
        kfree(card);
-        return NULL;
+        return err;
 }
+EXPORT_SYMBOL(snd_card_create);
-EXPORT_SYMBOL(snd_card_new);
 /* return non-zero if a card is already locked */
 int snd_card_locked(int card)
@@ -259,6 +275,7 @@ static int snd_disconnect_release(struct inode *inode, struct file *file)
        list_for_each_entry(_df, &shutdown_files, shutdown_list) {
                if (_df->file == file) {
                        df = _df;
+                        list_del_init(&df->shutdown_list);
                        break;
                }
        }
@@ -347,8 +364,7 @@ int snd_card_disconnect(struct snd_card *card)
        /* phase 2: replace file->f_op with special dummy operations */
        
        spin_lock(&card->files_lock);
-        mfile = card->files;
+        list_for_each_entry(mfile, &card->files_list, list) {
-        while (mfile) {
                file = mfile->file;
                /* it's critical part, use endless loop */
@@ -361,8 +377,6 @@ int snd_card_disconnect(struct snd_card *card)
                mfile->file->f_op = &snd_shutdown_f_ops;
                fops_get(mfile->file->f_op);
-                
-                mfile = mfile->next;
        }
        spin_unlock(&card->files_lock); 
@@ -442,7 +456,7 @@ int snd_card_free_when_closed(struct snd_card *card)
                return ret;
        spin_lock(&card->files_lock);
-        if (card->files == NULL)
+        if (list_empty(&card->files_list))
                free_now = 1;
        else
                card->free_on_last_close = 1;
@@ -462,7 +476,7 @@ int snd_card_free(struct snd_card *card)
                return ret;
        /* wait, until all devices are ready for the free operation */
-        wait_event(card->shutdown_sleep, card->files == NULL);
+        wait_event(card->shutdown_sleep, list_empty(&card->files_list));
        snd_card_do_free(card);
        return 0;
 }
@@ -809,15 +823,13 @@ int snd_card_file_add(struct snd_card *card, struct file *file)
                return -ENOMEM;
        mfile->file = file;
        mfile->disconnected_f_op = NULL;
-        mfile->next = NULL;
        spin_lock(&card->files_lock);
        if (card->shutdown) {
                spin_unlock(&card->files_lock);
                kfree(mfile);
                return -ENODEV;
        }
-        mfile->next = card->files;
+        list_add(&mfile->list, &card->files_list);
-        card->files = mfile;
        spin_unlock(&card->files_lock);
        return 0;
 }
@@ -839,29 +851,20 @@ EXPORT_SYMBOL(snd_card_file_add);
 */
 int snd_card_file_remove(struct snd_card *card, struct file *file)
 {
-        struct snd_monitor_file *mfile, *pfile = NULL;
+        struct snd_monitor_file *mfile, *found = NULL;
        int last_close = 0;
        spin_lock(&card->files_lock);
-        mfile = card->files;
+        list_for_each_entry(mfile, &card->files_list, list) {
-        while (mfile) {
                if (mfile->file == file) {
-                        if (pfile)
+                        list_del(&mfile->list);
-                                pfile->next = mfile->next;
+                        if (mfile->disconnected_f_op)
-                        else
+                                fops_put(mfile->disconnected_f_op);
-                                card->files = mfile->next;
+                        found = mfile;
                        break;
                }
-                pfile = mfile;
-                mfile = mfile->next;
-        }
-        if (mfile && mfile->disconnected_f_op) {
-                fops_put(mfile->disconnected_f_op);
-                spin_lock(&shutdown_lock);
-                list_del(&mfile->shutdown_list);
-                spin_unlock(&shutdown_lock);
        }
-        if (card->files == NULL)
+        if (list_empty(&card->files_list))
                last_close = 1;
        spin_unlock(&card->files_lock);
        if (last_close) {
@@ -869,11 +872,11 @@ int snd_card_file_remove(struct snd_card *card, struct file *file)
                if (card->free_on_last_close)
                        snd_card_do_free(card);
        }
-        if (!mfile) {
+        if (!found) {
                snd_printk(KERN_ERR "ALSA card file remove problem (%p)\n", file);
                return -ENOENT;
        }
-        kfree(mfile);
+        kfree(found);
        return 0;
 }
diff --git a/sound/core/jack.c b/sound/core/jack.c
index dd4a12dc09aa..c8254c667c62 100644
--- a/sound/core/jack.c
+++ b/sound/core/jack.c
@@ -23,6 +23,14 @@
 #include <sound/jack.h>
 #include <sound/core.h>
+static int jack_types[] = {
+        SW_HEADPHONE_INSERT,
+        SW_MICROPHONE_INSERT,
+        SW_LINEOUT_INSERT,
+        SW_JACK_PHYSICAL_INSERT,
+        SW_VIDEOOUT_INSERT,
+};
 static int snd_jack_dev_free(struct snd_device *device)
 {
        struct snd_jack *jack = device->device_data;
@@ -47,7 +55,7 @@ static int snd_jack_dev_register(struct snd_device *device)
        int err;
        snprintf(jack->name, sizeof(jack->name), "%s %s",
-                 card->longname, jack->id);
+                 card->shortname, jack->id);
        jack->input_dev->name = jack->name;
        /* Default to the sound card device. */
@@ -79,6 +87,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
 {
        struct snd_jack *jack;
        int err;
+        int i;
        static struct snd_device_ops ops = {
                .dev_free = snd_jack_dev_free,
                .dev_register = snd_jack_dev_register,
@@ -100,18 +109,10 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
        jack->type = type;
-        if (type & SND_JACK_HEADPHONE)
+        for (i = 0; i < ARRAY_SIZE(jack_types); i++)
-                input_set_capability(jack->input_dev, EV_SW,
+                if (type & (1 << i))
-                                     SW_HEADPHONE_INSERT);
+                        input_set_capability(jack->input_dev, EV_SW,
-        if (type & SND_JACK_LINEOUT)
+                                             jack_types[i]);
-                input_set_capability(jack->input_dev, EV_SW,
-                                     SW_LINEOUT_INSERT);
-        if (type & SND_JACK_MICROPHONE)
-                input_set_capability(jack->input_dev, EV_SW,
-                                     SW_MICROPHONE_INSERT);
-        if (type & SND_JACK_MECHANICAL)
-                input_set_capability(jack->input_dev, EV_SW,
-                                     SW_JACK_PHYSICAL_INSERT);
        err = snd_device_new(card, SNDRV_DEV_JACK, jack, &ops);
        if (err < 0)
@@ -154,21 +155,17 @@ EXPORT_SYMBOL(snd_jack_set_parent);
 */
 void snd_jack_report(struct snd_jack *jack, int status)
 {
+        int i;
        if (!jack)
                return;
-        if (jack->type & SND_JACK_HEADPHONE)
+        for (i = 0; i < ARRAY_SIZE(jack_types); i++) {
-                input_report_switch(jack->input_dev, SW_HEADPHONE_INSERT,
+                int testbit = 1 << i;
-                                    status & SND_JACK_HEADPHONE);
+                if (jack->type & testbit)
-        if (jack->type & SND_JACK_LINEOUT)
+                        input_report_switch(jack->input_dev, jack_types[i],
-                input_report_switch(jack->input_dev, SW_LINEOUT_INSERT,
+                                            status & testbit);
-                                    status & SND_JACK_LINEOUT);
+        }
-        if (jack->type & SND_JACK_MICROPHONE)
-                input_report_switch(jack->input_dev, SW_MICROPHONE_INSERT,
-                                    status & SND_JACK_MICROPHONE);
-        if (jack->type & SND_JACK_MECHANICAL)
-                input_report_switch(jack->input_dev, SW_JACK_PHYSICAL_INSERT,
-                                    status & SND_JACK_MECHANICAL);
        input_sync(jack->input_dev);
 }
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 4690b8b5681f..e570649184e2 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -692,6 +692,9 @@ static int snd_mixer_oss_put_volume1(struct snd_mixer_oss_file *fmixer,
                snd_mixer_oss_put_volume1_vol(fmixer, pslot, slot->numid[SNDRV_MIXER_OSS_ITEM_PVOLUME], left, right);
                if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME)
                        snd_mixer_oss_put_volume1_vol(fmixer, pslot, slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
+        } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_CVOLUME) {
+                snd_mixer_oss_put_volume1_vol(fmixer, pslot,
+                        slot->numid[SNDRV_MIXER_OSS_ITEM_CVOLUME], left, right);
        } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GVOLUME) {
                snd_mixer_oss_put_volume1_vol(fmixer, pslot, slot->numid[SNDRV_MIXER_OSS_ITEM_GVOLUME], left, right);
        } else if (slot->present & SNDRV_MIXER_OSS_PRESENT_GLOBAL) {
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index 4b883595a85a..2864cefb773c 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -1775,7 +1775,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
                       AFMT_S8 | AFMT_U16_LE |
                       AFMT_U16_BE |
                        AFMT_S32_LE | AFMT_S32_BE |
-                        AFMT_S24_LE | AFMT_S24_LE |
+                        AFMT_S24_LE | AFMT_S24_BE |
                        AFMT_S24_PACKED;
        params = kmalloc(sizeof(*params), GFP_KERNEL);
        if (!params)
@@ -2885,7 +2885,7 @@ static void snd_pcm_oss_proc_write(struct snd_info_entry *entry,
                        setup = kmalloc(sizeof(*setup), GFP_KERNEL);
                        if (! setup) {
                                buffer->error = -ENOMEM;
-                                mutex_lock(&pstr->oss.setup_mutex);
+                                mutex_unlock(&pstr->oss.setup_mutex);
                                return;
                        }
                        if (pstr->oss.setup_list == NULL)
@@ -2899,7 +2899,7 @@ static void snd_pcm_oss_proc_write(struct snd_info_entry *entry,
                        if (! template.task_name) {
                                kfree(setup);
                                buffer->error = -ENOMEM;
-                                mutex_lock(&pstr->oss.setup_mutex);
+                                mutex_unlock(&pstr->oss.setup_mutex);
                                return;
                        }
                }
diff --git a/sound/core/oss/rate.c b/sound/core/oss/rate.c
index a466443c4a26..2fa9299a440d 100644
--- a/sound/core/oss/rate.c
+++ b/sound/core/oss/rate.c
@@ -157,7 +157,7 @@ static void resample_shrink(struct snd_pcm_plugin *plugin,
                while (dst_frames1 > 0) {
                        S1 = S2;
                        if (src_frames1-- > 0) {
-                                S1 = *src;
+                                S2 = *src;
                                src += src_step;
                        }
                        if (pos & ~R_MASK) {
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 583453e2355c..145931a9ff30 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -667,7 +667,6 @@ int snd_pcm_new_stream(struct snd_pcm *pcm, int stream, int substream_count)
                spin_lock_init(&substream->self_group.lock);
                INIT_LIST_HEAD(&substream->self_group.substreams);
                list_add_tail(&substream->link_list, &substream->self_group.substreams);
-                spin_lock_init(&substream->timer_lock);
                atomic_set(&substream->mmap_count, 0);
                prev = substream;
        }
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 921691080f35..fbb2e391591e 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -125,23 +125,32 @@ void snd_pcm_playback_silence(struct snd_pcm_substream *substream, snd_pcm_ufram
        }
 }
+#ifdef CONFIG_SND_PCM_XRUN_DEBUG
+#define xrun_debug(substream)   ((substream)->pstr->xrun_debug)
+#else
+#define xrun_debug(substream)   0
+#endif
+#define dump_stack_on_xrun(substream) do {      \
+                if (xrun_debug(substream) > 1)  \
+                        dump_stack();           \
+        } while (0)
 static void xrun(struct snd_pcm_substream *substream)
 {
        snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
-#ifdef CONFIG_SND_PCM_XRUN_DEBUG
+        if (xrun_debug(substream)) {
-        if (substream->pstr->xrun_debug) {
                snd_printd(KERN_DEBUG "XRUN: pcmC%dD%d%c\n",
                           substream->pcm->card->number,
                           substream->pcm->device,
                           substream->stream ? 'c' : 'p');
-                if (substream->pstr->xrun_debug > 1)
+                dump_stack_on_xrun(substream);
-                        dump_stack();
        }
-#endif
 }
-static inline snd_pcm_uframes_t snd_pcm_update_hw_ptr_pos(struct snd_pcm_substream *substream,
+static snd_pcm_uframes_t
-                                                          struct snd_pcm_runtime *runtime)
+snd_pcm_update_hw_ptr_pos(struct snd_pcm_substream *substream,
+                          struct snd_pcm_runtime *runtime)
 {
        snd_pcm_uframes_t pos;
@@ -150,17 +159,21 @@ static inline snd_pcm_uframes_t snd_pcm_update_hw_ptr_pos(struct snd_pcm_substre
        pos = substream->ops->pointer(substream);
        if (pos == SNDRV_PCM_POS_XRUN)
                return pos; /* XRUN */
-#ifdef CONFIG_SND_DEBUG
        if (pos >= runtime->buffer_size) {
-                snd_printk(KERN_ERR  "BUG: stream = %i, pos = 0x%lx, buffer size = 0x%lx, period size = 0x%lx\n", substream->stream, pos, runtime->buffer_size, runtime->period_size);
+                if (printk_ratelimit()) {
+                        snd_printd(KERN_ERR  "BUG: stream = %i, pos = 0x%lx, "
+                                   "buffer size = 0x%lx, period size = 0x%lx\n",
+                                   substream->stream, pos, runtime->buffer_size,
+                                   runtime->period_size);
+                }
+                pos = 0;
        }
-#endif
        pos -= pos % runtime->min_align;
        return pos;
 }
-static inline int snd_pcm_update_hw_ptr_post(struct snd_pcm_substream *substream,
+static int snd_pcm_update_hw_ptr_post(struct snd_pcm_substream *substream,
-                                             struct snd_pcm_runtime *runtime)
+                                      struct snd_pcm_runtime *runtime)
 {
        snd_pcm_uframes_t avail;
@@ -182,11 +195,21 @@ static inline int snd_pcm_update_hw_ptr_post(struct snd_pcm_substream *substream
        return 0;
 }
-static inline int snd_pcm_update_hw_ptr_interrupt(struct snd_pcm_substream *substream)
+#define hw_ptr_error(substream, fmt, args...)                           \
+        do {                                                            \
+                if (xrun_debug(substream)) {                            \
+                        if (printk_ratelimit()) {                       \
+                                snd_printd("PCM: " fmt, ##args);        \
+                        }                                               \
+                        dump_stack_on_xrun(substream);                  \
+                }                                                       \
+        } while (0)
+static int snd_pcm_update_hw_ptr_interrupt(struct snd_pcm_substream *substream)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
        snd_pcm_uframes_t pos;
-        snd_pcm_uframes_t new_hw_ptr, hw_ptr_interrupt;
+        snd_pcm_uframes_t new_hw_ptr, hw_ptr_interrupt, hw_base;
        snd_pcm_sframes_t delta;
        pos = snd_pcm_update_hw_ptr_pos(substream, runtime);
@@ -194,36 +217,53 @@ static inline int snd_pcm_update_hw_ptr_interrupt(struct snd_pcm_substream *subs
                xrun(substream);
                return -EPIPE;
        }
-        if (runtime->period_size == runtime->buffer_size)
+        hw_base = runtime->hw_ptr_base;
-                goto __next_buf;
+        new_hw_ptr = hw_base + pos;
-        new_hw_ptr = runtime->hw_ptr_base + pos;
        hw_ptr_interrupt = runtime->hw_ptr_interrupt + runtime->period_size;
+        delta = new_hw_ptr - hw_ptr_interrupt;
-        delta = hw_ptr_interrupt - new_hw_ptr;
+        if (hw_ptr_interrupt >= runtime->boundary) {
-        if (delta > 0) {
+                hw_ptr_interrupt -= runtime->boundary;
-                if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
+                if (hw_base < runtime->boundary / 2)
-#ifdef CONFIG_SND_PCM_XRUN_DEBUG
+                        /* hw_base was already lapped; recalc delta */
-                        if (runtime->periods > 1 && substream->pstr->xrun_debug) {
+                        delta = new_hw_ptr - hw_ptr_interrupt;
-                                snd_printd(KERN_ERR "Unexpected hw_pointer value [1] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
+        }
-                                if (substream->pstr->xrun_debug > 1)
+        if (delta < 0) {
-                                        dump_stack();
+                delta += runtime->buffer_size;
-                        }
+                if (delta < 0) {
-#endif
+                        hw_ptr_error(substream, 
-                        return 0;
+                                     "Unexpected hw_pointer value "
+                                     "(stream=%i, pos=%ld, intr_ptr=%ld)\n",
+                                     substream->stream, (long)pos,
+                                     (long)hw_ptr_interrupt);
+                        /* rebase to interrupt position */
+                        hw_base = new_hw_ptr = hw_ptr_interrupt;
+                        /* align hw_base to buffer_size */
+                        hw_base -= hw_base % runtime->buffer_size;
+                        delta = 0;
+                } else {
+                        hw_base += runtime->buffer_size;
+                        if (hw_base >= runtime->boundary)
+                                hw_base = 0;
+                        new_hw_ptr = hw_base + pos;
                }
-              __next_buf:
-                runtime->hw_ptr_base += runtime->buffer_size;
-                if (runtime->hw_ptr_base == runtime->boundary)
-                        runtime->hw_ptr_base = 0;
-                new_hw_ptr = runtime->hw_ptr_base + pos;
        }
+        if (delta > runtime->period_size) {
+                hw_ptr_error(substream,
+                             "Lost interrupts? "
+                             "(stream=%i, delta=%ld, intr_ptr=%ld)\n",
+                             substream->stream, (long)delta,
+                             (long)hw_ptr_interrupt);
+                /* rebase hw_ptr_interrupt */
+                hw_ptr_interrupt =
+                        new_hw_ptr - new_hw_ptr % runtime->period_size;
+        }
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK &&
            runtime->silence_size > 0)
                snd_pcm_playback_silence(substream, new_hw_ptr);
+        runtime->hw_ptr_base = hw_base;
        runtime->status->hw_ptr = new_hw_ptr;
-        runtime->hw_ptr_interrupt = new_hw_ptr - new_hw_ptr % runtime->period_size;
+        runtime->hw_ptr_interrupt = hw_ptr_interrupt;
        return snd_pcm_update_hw_ptr_post(substream, runtime);
 }
@@ -233,7 +273,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
        snd_pcm_uframes_t pos;
-        snd_pcm_uframes_t old_hw_ptr, new_hw_ptr;
+        snd_pcm_uframes_t old_hw_ptr, new_hw_ptr, hw_base;
        snd_pcm_sframes_t delta;
        old_hw_ptr = runtime->status->hw_ptr;
@@ -242,29 +282,38 @@ int snd_pcm_update_hw_ptr(struct snd_pcm_substream *substream)
                xrun(substream);
                return -EPIPE;
        }
-        new_hw_ptr = runtime->hw_ptr_base + pos;
+        hw_base = runtime->hw_ptr_base;
+        new_hw_ptr = hw_base + pos;
-        delta = old_hw_ptr - new_hw_ptr;
-        if (delta > 0) {
+        delta = new_hw_ptr - old_hw_ptr;
-                if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
+        if (delta < 0) {
-#ifdef CONFIG_SND_PCM_XRUN_DEBUG
+                delta += runtime->buffer_size;
-                        if (runtime->periods > 2 && substream->pstr->xrun_debug) {
+                if (delta < 0) {
-                                snd_printd(KERN_ERR "Unexpected hw_pointer value [2] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
+                        hw_ptr_error(substream, 
-                                if (substream->pstr->xrun_debug > 1)
+                                     "Unexpected hw_pointer value [2] "
-                                        dump_stack();
+                                     "(stream=%i, pos=%ld, old_ptr=%ld)\n",
-                        }
+                                     substream->stream, (long)pos,
-#endif
+                                     (long)old_hw_ptr);
                        return 0;
                }
-                runtime->hw_ptr_base += runtime->buffer_size;
+                hw_base += runtime->buffer_size;
-                if (runtime->hw_ptr_base == runtime->boundary)
+                if (hw_base >= runtime->boundary)
-                        runtime->hw_ptr_base = 0;
+                        hw_base = 0;
-                new_hw_ptr = runtime->hw_ptr_base + pos;
+                new_hw_ptr = hw_base + pos;
+        }
+        if (delta > runtime->period_size && runtime->periods > 1) {
+                hw_ptr_error(substream,
+                             "hw_ptr skipping! "
+                             "(pos=%ld, delta=%ld, period=%ld)\n",
+                             (long)pos, (long)delta,
+                             (long)runtime->period_size);
+                return 0;
        }
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK &&
            runtime->silence_size > 0)
                snd_pcm_playback_silence(substream, new_hw_ptr);
+        runtime->hw_ptr_base = hw_base;
        runtime->status->hw_ptr = new_hw_ptr;
        return snd_pcm_update_hw_ptr_post(substream, runtime);
diff --git a/sound/core/pcm_timer.c b/sound/core/pcm_timer.c
index 2c89c04f2916..ca8068b63d6c 100644
--- a/sound/core/pcm_timer.c
+++ b/sound/core/pcm_timer.c
@@ -85,25 +85,19 @@ static unsigned long snd_pcm_timer_resolution(struct snd_timer * timer)
 static int snd_pcm_timer_start(struct snd_timer * timer)
 {
-        unsigned long flags;
        struct snd_pcm_substream *substream;
        
        substream = snd_timer_chip(timer);
-        spin_lock_irqsave(&substream->timer_lock, flags);
        substream->timer_running = 1;
-        spin_unlock_irqrestore(&substream->timer_lock, flags);
        return 0;
 }
 static int snd_pcm_timer_stop(struct snd_timer * timer)
 {
-        unsigned long flags;
        struct snd_pcm_substream *substream;
        
        substream = snd_timer_chip(timer);
-        spin_lock_irqsave(&substream->timer_lock, flags);
        substream->timer_running = 0;
-        spin_unlock_irqrestore(&substream->timer_lock, flags);
        return 0;
 }
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c
index 002777ba336a..473247c8e6d3 100644
--- a/sound/core/rawmidi.c
+++ b/sound/core/rawmidi.c
@@ -224,156 +224,143 @@ int snd_rawmidi_drain_input(struct snd_rawmidi_substream *substream)
        return 0;
 }
-int snd_rawmidi_kernel_open(struct snd_card *card, int device, int subdevice,
+/* look for an available substream for the given stream direction;
-                            int mode, struct snd_rawmidi_file * rfile)
+ * if a specific subdevice is given, try to assign it
+ */
+static int assign_substream(struct snd_rawmidi *rmidi, int subdevice,
+                            int stream, int mode,
+                            struct snd_rawmidi_substream **sub_ret)
+{
+        struct snd_rawmidi_substream *substream;
+        struct snd_rawmidi_str *s = &rmidi->streams[stream];
+        static unsigned int info_flags[2] = {
+                [SNDRV_RAWMIDI_STREAM_OUTPUT] = SNDRV_RAWMIDI_INFO_OUTPUT,
+                [SNDRV_RAWMIDI_STREAM_INPUT] = SNDRV_RAWMIDI_INFO_INPUT,
+        };
+        if (!(rmidi->info_flags & info_flags[stream]))
+                return -ENXIO;
+        if (subdevice >= 0 && subdevice >= s->substream_count)
+                return -ENODEV;
+        if (s->substream_opened >= s->substream_count)
+                return -EAGAIN;
+        list_for_each_entry(substream, &s->substreams, list) {
+                if (substream->opened) {
+                        if (stream == SNDRV_RAWMIDI_STREAM_INPUT ||
+                            !(mode & SNDRV_RAWMIDI_LFLG_APPEND))
+                                continue;
+                }
+                if (subdevice < 0 || subdevice == substream->number) {
+                        *sub_ret = substream;
+                        return 0;
+                }
+        }
+        return -EAGAIN;
+}
+/* open and do ref-counting for the given substream */
+static int open_substream(struct snd_rawmidi *rmidi,
+                          struct snd_rawmidi_substream *substream,
+                          int mode)
+{
+        int err;
+        err = snd_rawmidi_runtime_create(substream);
+        if (err < 0)
+                return err;
+        err = substream->ops->open(substream);
+        if (err < 0)
+                return err;
+        substream->opened = 1;
+        if (substream->use_count++ == 0)
+                substream->active_sensing = 1;
+        if (mode & SNDRV_RAWMIDI_LFLG_APPEND)
+                substream->append = 1;
+        rmidi->streams[substream->stream].substream_opened++;
+        return 0;
+}
+static void close_substream(struct snd_rawmidi *rmidi,
+                            struct snd_rawmidi_substream *substream,
+                            int cleanup);
+static int rawmidi_open_priv(struct snd_rawmidi *rmidi, int subdevice, int mode,
+                             struct snd_rawmidi_file *rfile)
 {
-        struct snd_rawmidi *rmidi;
-        struct list_head *list1, *list2;
        struct snd_rawmidi_substream *sinput = NULL, *soutput = NULL;
-        struct snd_rawmidi_runtime *input = NULL, *output = NULL;
        int err;
-        if (rfile)
+        rfile->input = rfile->output = NULL;
-                rfile->input = rfile->output = NULL;
-        mutex_lock(&register_mutex);
-        rmidi = snd_rawmidi_search(card, device);
-        mutex_unlock(&register_mutex);
-        if (rmidi == NULL) {
-                err = -ENODEV;
-                goto __error1;
-        }
-        if (!try_module_get(rmidi->card->module)) {
-                err = -EFAULT;
-                goto __error1;
-        }
-        if (!(mode & SNDRV_RAWMIDI_LFLG_NOOPENLOCK))
-                mutex_lock(&rmidi->open_mutex);
        if (mode & SNDRV_RAWMIDI_LFLG_INPUT) {
-                if (!(rmidi->info_flags & SNDRV_RAWMIDI_INFO_INPUT)) {
+                err = assign_substream(rmidi, subdevice,
-                        err = -ENXIO;
+                                       SNDRV_RAWMIDI_STREAM_INPUT,
-                        goto __error;
+                                       mode, &sinput);
-                }
+                if (err < 0)
-                if (subdevice >= 0 && (unsigned int)subdevice >= rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substream_count) {
-                        err = -ENODEV;
-                        goto __error;
-                }
-                if (rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substream_opened >=
-                    rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substream_count) {
-                        err = -EAGAIN;
                        goto __error;
-                }
        }
        if (mode & SNDRV_RAWMIDI_LFLG_OUTPUT) {
-                if (!(rmidi->info_flags & SNDRV_RAWMIDI_INFO_OUTPUT)) {
+                err = assign_substream(rmidi, subdevice,
-                        err = -ENXIO;
+                                       SNDRV_RAWMIDI_STREAM_OUTPUT,
-                        goto __error;
+                                       mode, &soutput);
-                }
+                if (err < 0)
-                if (subdevice >= 0 && (unsigned int)subdevice >= rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substream_count) {
-                        err = -ENODEV;
-                        goto __error;
-                }
-                if (rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substream_opened >=
-                    rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substream_count) {
-                        err = -EAGAIN;
                        goto __error;
-                }
-        }
-        list1 = rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams.next;
-        while (1) {
-                if (list1 == &rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substreams) {
-                        sinput = NULL;
-                        if (mode & SNDRV_RAWMIDI_LFLG_INPUT) {
-                                err = -EAGAIN;
-                                goto __error;
-                        }
-                        break;
-                }
-                sinput = list_entry(list1, struct snd_rawmidi_substream, list);
-                if ((mode & SNDRV_RAWMIDI_LFLG_INPUT) && sinput->opened)
-                        goto __nexti;
-                if (subdevice < 0 || (subdevice >= 0 && subdevice == sinput->number))
-                        break;
-              __nexti:
-                list1 = list1->next;
        }
-        list2 = rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams.next;
-        while (1) {
+        if (sinput) {
-                if (list2 == &rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substreams) {
+                err = open_substream(rmidi, sinput, mode);
-                        soutput = NULL;
+                if (err < 0)
-                        if (mode & SNDRV_RAWMIDI_LFLG_OUTPUT) {
-                                err = -EAGAIN;
-                                goto __error;
-                        }
-                        break;
-                }
-                soutput = list_entry(list2, struct snd_rawmidi_substream, list);
-                if (mode & SNDRV_RAWMIDI_LFLG_OUTPUT) {
-                        if (mode & SNDRV_RAWMIDI_LFLG_APPEND) {
-                                if (soutput->opened && !soutput->append)
-                                        goto __nexto;
-                        } else {
-                                if (soutput->opened)
-                                        goto __nexto;
-                        }
-                }
-                if (subdevice < 0 || (subdevice >= 0 && subdevice == soutput->number))
-                        break;
-              __nexto:
-                list2 = list2->next;
-        }
-        if (mode & SNDRV_RAWMIDI_LFLG_INPUT) {
-                if ((err = snd_rawmidi_runtime_create(sinput)) < 0)
-                        goto __error;
-                input = sinput->runtime;
-                if ((err = sinput->ops->open(sinput)) < 0)
                        goto __error;
-                sinput->opened = 1;
-                rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substream_opened++;
-        } else {
-                sinput = NULL;
        }
-        if (mode & SNDRV_RAWMIDI_LFLG_OUTPUT) {
+        if (soutput) {
-                if (soutput->opened)
+                err = open_substream(rmidi, soutput, mode);
-                        goto __skip_output;
+                if (err < 0) {
-                if ((err = snd_rawmidi_runtime_create(soutput)) < 0) {
+                        if (sinput)
-                        if (mode & SNDRV_RAWMIDI_LFLG_INPUT)
+                                close_substream(rmidi, sinput, 0);
-                                sinput->ops->close(sinput);
-                        goto __error;
-                }
-                output = soutput->runtime;
-                if ((err = soutput->ops->open(soutput)) < 0) {
-                        if (mode & SNDRV_RAWMIDI_LFLG_INPUT)
-                                sinput->ops->close(sinput);
                        goto __error;
                }
-              __skip_output:
-                soutput->opened = 1;
-                if (mode & SNDRV_RAWMIDI_LFLG_APPEND)
-                        soutput->append = 1;
-                if (soutput->use_count++ == 0)
-                        soutput->active_sensing = 1;
-                rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substream_opened++;
-        } else {
-                soutput = NULL;
-        }
-        if (!(mode & SNDRV_RAWMIDI_LFLG_NOOPENLOCK))
-                mutex_unlock(&rmidi->open_mutex);
-        if (rfile) {
-                rfile->rmidi = rmidi;
-                rfile->input = sinput;
-                rfile->output = soutput;
        }
+        rfile->rmidi = rmidi;
+        rfile->input = sinput;
+        rfile->output = soutput;
        return 0;
      __error:
-        if (input != NULL)
+        if (sinput && sinput->runtime)
                snd_rawmidi_runtime_free(sinput);
-        if (output != NULL)
+        if (soutput && soutput->runtime)
                snd_rawmidi_runtime_free(soutput);
-        module_put(rmidi->card->module);
+        return err;
-        if (!(mode & SNDRV_RAWMIDI_LFLG_NOOPENLOCK))
+}
-                mutex_unlock(&rmidi->open_mutex);
-      __error1:
+/* called from sound/core/seq/seq_midi.c */
+int snd_rawmidi_kernel_open(struct snd_card *card, int device, int subdevice,
+                            int mode, struct snd_rawmidi_file * rfile)
+{
+        struct snd_rawmidi *rmidi;
+        int err;
+        if (snd_BUG_ON(!rfile))
+                return -EINVAL;
+        mutex_lock(&register_mutex);
+        rmidi = snd_rawmidi_search(card, device);
+        if (rmidi == NULL) {
+                mutex_unlock(&register_mutex);
+                return -ENODEV;
+        }
+        if (!try_module_get(rmidi->card->module)) {
+                mutex_unlock(&register_mutex);
+                return -ENXIO;
+        }
+        mutex_unlock(&register_mutex);
+        mutex_lock(&rmidi->open_mutex);
+        err = rawmidi_open_priv(rmidi, subdevice, mode, rfile);
+        mutex_unlock(&rmidi->open_mutex);
+        if (err < 0)
+                module_put(rmidi->card->module);
        return err;
 }
@@ -385,10 +372,13 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
        unsigned short fflags;
        int err;
        struct snd_rawmidi *rmidi;
-        struct snd_rawmidi_file *rawmidi_file;
+        struct snd_rawmidi_file *rawmidi_file = NULL;
        wait_queue_t wait;
        struct snd_ctl_file *kctl;
+        if ((file->f_flags & O_APPEND) && !(file->f_flags & O_NONBLOCK)) 
+                return -EINVAL;         /* invalid combination */
        if (maj == snd_major) {
                rmidi = snd_lookup_minor_data(iminor(inode),
                                              SNDRV_DEVICE_TYPE_RAWMIDI);
@@ -402,24 +392,25 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
        if (rmidi == NULL)
                return -ENODEV;
-        if ((file->f_flags & O_APPEND) && !(file->f_flags & O_NONBLOCK)) 
-                return -EINVAL;         /* invalid combination */
+        if (!try_module_get(rmidi->card->module))
+                return -ENXIO;
+        mutex_lock(&rmidi->open_mutex);
        card = rmidi->card;
        err = snd_card_file_add(card, file);
        if (err < 0)
-                return -ENODEV;
+                goto __error_card;
        fflags = snd_rawmidi_file_flags(file);
        if ((file->f_flags & O_APPEND) || maj == SOUND_MAJOR) /* OSS emul? */
                fflags |= SNDRV_RAWMIDI_LFLG_APPEND;
-        fflags |= SNDRV_RAWMIDI_LFLG_NOOPENLOCK;
        rawmidi_file = kmalloc(sizeof(*rawmidi_file), GFP_KERNEL);
        if (rawmidi_file == NULL) {
-                snd_card_file_remove(card, file);
+                err = -ENOMEM;
-                return -ENOMEM;
+                goto __error;
        }
        init_waitqueue_entry(&wait, current);
        add_wait_queue(&rmidi->open_wait, &wait);
-        mutex_lock(&rmidi->open_mutex);
        while (1) {
                subdevice = -1;
                read_lock(&card->ctl_files_rwlock);
@@ -431,8 +422,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
                        }
                }
                read_unlock(&card->ctl_files_rwlock);
-                err = snd_rawmidi_kernel_open(rmidi->card, rmidi->device,
+                err = rawmidi_open_priv(rmidi, subdevice, fflags, rawmidi_file);
-                                              subdevice, fflags, rawmidi_file);
                if (err >= 0)
                        break;
                if (err == -EAGAIN) {
@@ -451,67 +441,89 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file)
                        break;
                }
        }
+        remove_wait_queue(&rmidi->open_wait, &wait);
+        if (err < 0) {
+                kfree(rawmidi_file);
+                goto __error;
+        }
 #ifdef CONFIG_SND_OSSEMUL
        if (rawmidi_file->input && rawmidi_file->input->runtime)
                rawmidi_file->input->runtime->oss = (maj == SOUND_MAJOR);
        if (rawmidi_file->output && rawmidi_file->output->runtime)
                rawmidi_file->output->runtime->oss = (maj == SOUND_MAJOR);
 #endif
-        remove_wait_queue(&rmidi->open_wait, &wait);
+        file->private_data = rawmidi_file;
-        if (err >= 0) {
+        mutex_unlock(&rmidi->open_mutex);
-                file->private_data = rawmidi_file;
+        return 0;
-        } else {
-                snd_card_file_remove(card, file);
+ __error:
-                kfree(rawmidi_file);
+        snd_card_file_remove(card, file);
-        }
+ __error_card:
        mutex_unlock(&rmidi->open_mutex);
+        module_put(rmidi->card->module);
        return err;
 }
-int snd_rawmidi_kernel_release(struct snd_rawmidi_file * rfile)
+static void close_substream(struct snd_rawmidi *rmidi,
+                            struct snd_rawmidi_substream *substream,
+                            int cleanup)
 {
-        struct snd_rawmidi *rmidi;
+        rmidi->streams[substream->stream].substream_opened--;
-        struct snd_rawmidi_substream *substream;
+        if (--substream->use_count)
-        struct snd_rawmidi_runtime *runtime;
+                return;
-        if (snd_BUG_ON(!rfile))
+        if (cleanup) {
-                return -ENXIO;
+                if (substream->stream == SNDRV_RAWMIDI_STREAM_INPUT)
-        rmidi = rfile->rmidi;
+                        snd_rawmidi_input_trigger(substream, 0);
-        mutex_lock(&rmidi->open_mutex);
+                else {
-        if (rfile->input != NULL) {
-                substream = rfile->input;
-                rfile->input = NULL;
-                runtime = substream->runtime;
-                snd_rawmidi_input_trigger(substream, 0);
-                substream->ops->close(substream);
-                if (runtime->private_free != NULL)
-                        runtime->private_free(substream);
-                snd_rawmidi_runtime_free(substream);
-                substream->opened = 0;
-                rmidi->streams[SNDRV_RAWMIDI_STREAM_INPUT].substream_opened--;
-        }
-        if (rfile->output != NULL) {
-                substream = rfile->output;
-                rfile->output = NULL;
-                if (--substream->use_count == 0) {
-                        runtime = substream->runtime;
                        if (substream->active_sensing) {
                                unsigned char buf = 0xfe;
-                                /* sending single active sensing message to shut the device up */
+                                /* sending single active sensing message
+                                 * to shut the device up
+                                 */
                                snd_rawmidi_kernel_write(substream, &buf, 1);
                        }
                        if (snd_rawmidi_drain_output(substream) == -ERESTARTSYS)
                                snd_rawmidi_output_trigger(substream, 0);
-                        substream->ops->close(substream);
-                        if (runtime->private_free != NULL)
-                                runtime->private_free(substream);
-                        snd_rawmidi_runtime_free(substream);
-                        substream->opened = 0;
-                        substream->append = 0;
                }
-                rmidi->streams[SNDRV_RAWMIDI_STREAM_OUTPUT].substream_opened--;
        }
+        substream->ops->close(substream);
+        if (substream->runtime->private_free)
+                substream->runtime->private_free(substream);
+        snd_rawmidi_runtime_free(substream);
+        substream->opened = 0;
+        substream->append = 0;
+}
+static void rawmidi_release_priv(struct snd_rawmidi_file *rfile)
+{
+        struct snd_rawmidi *rmidi;
+        rmidi = rfile->rmidi;
+        mutex_lock(&rmidi->open_mutex);
+        if (rfile->input) {
+                close_substream(rmidi, rfile->input, 1);
+                rfile->input = NULL;
+        }
+        if (rfile->output) {
+                close_substream(rmidi, rfile->output, 1);
+                rfile->output = NULL;
+        }
+        rfile->rmidi = NULL;
        mutex_unlock(&rmidi->open_mutex);
+        wake_up(&rmidi->open_wait);
+}
+/* called from sound/core/seq/seq_midi.c */
+int snd_rawmidi_kernel_release(struct snd_rawmidi_file *rfile)
+{
+        struct snd_rawmidi *rmidi;
+        if (snd_BUG_ON(!rfile))
+                return -ENXIO;
+        
+        rmidi = rfile->rmidi;
+        rawmidi_release_priv(rfile);
        module_put(rmidi->card->module);
        return 0;
 }
@@ -520,15 +532,14 @@ static int snd_rawmidi_release(struct inode *inode, struct file *file)
 {
        struct snd_rawmidi_file *rfile;
        struct snd_rawmidi *rmidi;
-        int err;
        rfile = file->private_data;
-        err = snd_rawmidi_kernel_release(rfile);
        rmidi = rfile->rmidi;
-        wake_up(&rmidi->open_wait);
+        rawmidi_release_priv(rfile);
        kfree(rfile);
        snd_card_file_remove(rmidi->card, file);
-        return err;
+        module_put(rmidi->card->module);
+        return 0;
 }
 static int snd_rawmidi_info(struct snd_rawmidi_substream *substream,
diff --git a/sound/core/sgbuf.c b/sound/core/sgbuf.c
index d4564edd61d7..4e7ec2b49873 100644
--- a/sound/core/sgbuf.c
+++ b/sound/core/sgbuf.c
@@ -38,6 +38,10 @@ int snd_free_sgbuf_pages(struct snd_dma_buffer *dmab)
        if (! sgbuf)
                return -EINVAL;
+        if (dmab->area)
+                vunmap(dmab->area);
+        dmab->area = NULL;
        tmpb.dev.type = SNDRV_DMA_TYPE_DEV;
        tmpb.dev.dev = sgbuf->dev;
        for (i = 0; i < sgbuf->pages; i++) {
@@ -48,9 +52,6 @@ int snd_free_sgbuf_pages(struct snd_dma_buffer *dmab)
                tmpb.bytes = (sgbuf->table[i].addr & ~PAGE_MASK) << PAGE_SHIFT;
                snd_dma_free_pages(&tmpb);
        }
-        if (dmab->area)
-                vunmap(dmab->area);
-        dmab->area = NULL;
        kfree(sgbuf->table);
        kfree(sgbuf->page_table);
diff --git a/sound/core/vmaster.c b/sound/core/vmaster.c
index 4cc57f902e2c..257624bd1997 100644
--- a/sound/core/vmaster.c
+++ b/sound/core/vmaster.c
@@ -50,18 +50,38 @@ struct link_slave {
        struct link_master *master;
        struct link_ctl_info info;
        int vals[2];            /* current values */
+        unsigned int flags;
        struct snd_kcontrol slave; /* the copy of original control entry */
 };
+static int slave_update(struct link_slave *slave)
+{
+        struct snd_ctl_elem_value *uctl;
+        int err, ch;
+        uctl = kmalloc(sizeof(*uctl), GFP_KERNEL);
+        if (!uctl)
+                return -ENOMEM;
+        uctl->id = slave->slave.id;
+        err = slave->slave.get(&slave->slave, uctl);
+        for (ch = 0; ch < slave->info.count; ch++)
+                slave->vals[ch] = uctl->value.integer.value[ch];
+        kfree(uctl);
+        return 0;
+}
 /* get the slave ctl info and save the initial values */
 static int slave_init(struct link_slave *slave)
 {
        struct snd_ctl_elem_info *uinfo;
-        struct snd_ctl_elem_value *uctl;
+        int err;
-        int err, ch;
-        if (slave->info.count)
+        if (slave->info.count) {
-                return 0; /* already initialized */
+                /* already initialized */
+                if (slave->flags & SND_CTL_SLAVE_NEED_UPDATE)
+                        return slave_update(slave);
+                return 0;
+        }
        uinfo = kmalloc(sizeof(*uinfo), GFP_KERNEL);
        if (!uinfo)
@@ -85,15 +105,7 @@ static int slave_init(struct link_slave *slave)
        slave->info.max_val = uinfo->value.integer.max;
        kfree(uinfo);
-        uctl = kmalloc(sizeof(*uctl), GFP_KERNEL);
+        return slave_update(slave);
-        if (!uctl)
-                return -ENOMEM;
-        uctl->id = slave->slave.id;
-        err = slave->slave.get(&slave->slave, uctl);
-        for (ch = 0; ch < slave->info.count; ch++)
-                slave->vals[ch] = uctl->value.integer.value[ch];
-        kfree(uctl);
-        return 0;
 }
 /* initialize master volume */
@@ -229,7 +241,8 @@ static void slave_free(struct snd_kcontrol *kcontrol)
 * - logarithmic volume control (dB level), no linear volume
 * - master can only attenuate the volume, no gain
 */
-int snd_ctl_add_slave(struct snd_kcontrol *master, struct snd_kcontrol *slave)
+int _snd_ctl_add_slave(struct snd_kcontrol *master, struct snd_kcontrol *slave,
+                       unsigned int flags)
 {
        struct link_master *master_link = snd_kcontrol_chip(master);
        struct link_slave *srec;
@@ -241,6 +254,7 @@ int snd_ctl_add_slave(struct snd_kcontrol *master, struct snd_kcontrol *slave)
        srec->slave = *slave;
        memcpy(srec->slave.vd, slave->vd, slave->count * sizeof(*slave->vd));
        srec->master = master_link;
+        srec->flags = flags;
        /* override callbacks */
        slave->info = slave_info;
@@ -254,8 +268,7 @@ int snd_ctl_add_slave(struct snd_kcontrol *master, struct snd_kcontrol *slave)
        list_add_tail(&srec->list, &master_link->slaves);
        return 0;
 }
+EXPORT_SYMBOL(_snd_ctl_add_slave);
-EXPORT_SYMBOL(snd_ctl_add_slave);
 /*
 * ctl callbacks for master controls
@@ -327,8 +340,20 @@ static void master_free(struct snd_kcontrol *kcontrol)
 }
-/*
+/**
- * Create a virtual master control with the given name
+ * snd_ctl_make_virtual_master - Create a virtual master control
+ * @name: name string of the control element to create
+ * @tlv: optional TLV int array for dB information
+ *
+ * Creates a virtual matster control with the given name string.
+ * Returns the created control element, or NULL for errors (ENOMEM).
+ *
+ * After creating a vmaster element, you can add the slave controls
+ * via snd_ctl_add_slave() or snd_ctl_add_slave_uncached().
+ *
+ * The optional argument @tlv can be used to specify the TLV information
+ * for dB scale of the master control.  It should be a single element
+ * with #SNDRV_CTL_TLVT_DB_SCALE type, and should be the max 0dB.
 */
 struct snd_kcontrol *snd_ctl_make_virtual_master(char *name,
                                                 const unsigned int *tlv)
@@ -367,5 +392,4 @@ struct snd_kcontrol *snd_ctl_make_virtual_master(char *name,
        return kctl;
 }
 EXPORT_SYMBOL(snd_ctl_make_virtual_master);
diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
index 73be7e14a603..54239d2e0997 100644
--- a/sound/drivers/dummy.c
+++ b/sound/drivers/dummy.c
@@ -588,10 +588,10 @@ static int __devinit snd_dummy_probe(struct platform_device *devptr)
        int idx, err;
        int dev = devptr->id;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_dummy));
+                              sizeof(struct snd_dummy), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        dummy = card->private_data;
        dummy->card = card;
        for (idx = 0; idx < MAX_PCM_DEVICES && idx < pcm_devs[dev]; idx++) {
diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c
index 7783843ca9ae..1950ffce2b54 100644
--- a/sound/drivers/ml403-ac97cr.c
+++ b/sound/drivers/ml403-ac97cr.c
@@ -1279,9 +1279,9 @@ static int __devinit snd_ml403_ac97cr_probe(struct platform_device *pfdev)
        if (!enable[dev])
                return -ENOENT;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_ml403_ac97cr_create(card, pfdev, &ml403_ac97cr);
        if (err < 0) {
                PDEBUG(INIT_FAILURE, "probe(): create failed!\n");
diff --git a/sound/drivers/mpu401/mpu401.c b/sound/drivers/mpu401/mpu401.c
index 5b996f3faba5..149d05a8202d 100644
--- a/sound/drivers/mpu401/mpu401.c
+++ b/sound/drivers/mpu401/mpu401.c
@@ -73,9 +73,9 @@ static int snd_mpu401_create(int dev, struct snd_card **rcard)
                snd_printk(KERN_ERR "the uart_enter option is obsolete; remove it\n");
        *rcard = NULL;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "MPU-401 UART");
        strcpy(card->shortname, card->driver);
        sprintf(card->longname, "%s at %#lx, ", card->shortname, port[dev]);
diff --git a/sound/drivers/mtpav.c b/sound/drivers/mtpav.c
index 6b26305ff0e6..2f8f295d6b0c 100644
--- a/sound/drivers/mtpav.c
+++ b/sound/drivers/mtpav.c
@@ -698,9 +698,9 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev)
        int err;
        struct mtpav *mtp_card;
-        card = snd_card_new(index, id, THIS_MODULE, sizeof(*mtp_card));
+        err = snd_card_create(index, id, THIS_MODULE, sizeof(*mtp_card), &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        mtp_card = card->private_data;
        spin_lock_init(&mtp_card->spinlock);
@@ -708,7 +708,6 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev)
        mtp_card->card = card;
        mtp_card->irq = -1;
        mtp_card->share_irq = 0;
-        mtp_card->inmidiport = 0xffffffff;
        mtp_card->inmidistate = 0;
        mtp_card->outmidihwport = 0xffffffff;
        init_timer(&mtp_card->timer);
@@ -721,6 +720,8 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev)
        if (err < 0)
                goto __error;
+        mtp_card->inmidiport = mtp_card->num_ports + MTPAV_PIDX_BROADCAST;
        err = snd_mtpav_get_ISA(mtp_card);
        if (err < 0)
                goto __error;
diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c
index 1a05b2d64c9b..9284829bf927 100644
--- a/sound/drivers/mts64.c
+++ b/sound/drivers/mts64.c
@@ -957,10 +957,10 @@ static int __devinit snd_mts64_probe(struct platform_device *pdev)
        if ((err = snd_mts64_probe_port(p)) < 0)
                return err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printd("Cannot create card\n");
-                return -ENOMEM;
+                return err;
        }
        strcpy(card->driver, DRIVER_NAME);
        strcpy(card->shortname, "ESI " CARD_NAME);
diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c
index c7c744c6fc0b..b60cef257b58 100644
--- a/sound/drivers/pcsp/pcsp.c
+++ b/sound/drivers/pcsp/pcsp.c
@@ -98,9 +98,9 @@ static int __devinit snd_card_pcsp_probe(int devnum, struct device *dev)
        hrtimer_init(&pcsp_chip.timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
        pcsp_chip.timer.function = pcsp_do_timer;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_pcsp_create(card);
        if (err < 0) {
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index b1c047ec19af..60158e2e0eaf 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -746,10 +746,10 @@ static int __devinit snd_portman_probe(struct platform_device *pdev)
        if ((err = snd_portman_probe_port(p)) < 0)
                return err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printd("Cannot create card\n");
-                return -ENOMEM;
+                return err;
        }
        strcpy(card->driver, DRIVER_NAME);
        strcpy(card->shortname, CARD_NAME);
diff --git a/sound/drivers/serial-u16550.c b/sound/drivers/serial-u16550.c
index ff0a41510945..b2b6d50c9425 100644
--- a/sound/drivers/serial-u16550.c
+++ b/sound/drivers/serial-u16550.c
@@ -942,9 +942,9 @@ static int __devinit snd_serial_probe(struct platform_device *devptr)
                return -ENODEV;
        }
-        card  = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err  = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "Serial");
        strcpy(card->shortname, "Serial MIDI (UART16550A)");
diff --git a/sound/drivers/virmidi.c b/sound/drivers/virmidi.c
index 1022e365606f..0e631c3221e3 100644
--- a/sound/drivers/virmidi.c
+++ b/sound/drivers/virmidi.c
@@ -90,10 +90,10 @@ static int __devinit snd_virmidi_probe(struct platform_device *devptr)
        int idx, err;
        int dev = devptr->id;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_card_virmidi));
+                              sizeof(struct snd_card_virmidi), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        vmidi = (struct snd_card_virmidi *)card->private_data;
        vmidi->card = card;
diff --git a/sound/drivers/vx/vx_hwdep.c b/sound/drivers/vx/vx_hwdep.c
index 8d6362e2d4c9..46df8817c18f 100644
--- a/sound/drivers/vx/vx_hwdep.c
+++ b/sound/drivers/vx/vx_hwdep.c
@@ -119,16 +119,6 @@ void snd_vx_free_firmware(struct vx_core *chip)
 #else /* old style firmware loading */
-static int vx_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-static int vx_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
 static int vx_hwdep_dsp_status(struct snd_hwdep *hw,
                               struct snd_hwdep_dsp_status *info)
 {
@@ -243,8 +233,6 @@ int snd_vx_setup_firmware(struct vx_core *chip)
        hw->iface = SNDRV_HWDEP_IFACE_VX;
        hw->private_data = chip;
-        hw->ops.open = vx_hwdep_open;
-        hw->ops.release = vx_hwdep_release;
        hw->ops.dsp_status = vx_hwdep_dsp_status;
        hw->ops.dsp_load = vx_hwdep_dsp_load;
        hw->exclusive = 1;
diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
index 77524244a846..9660e598232c 100644
--- a/sound/isa/ad1816a/ad1816a.c
+++ b/sound/isa/ad1816a/ad1816a.c
@@ -157,9 +157,10 @@ static int __devinit snd_card_ad1816a_probe(int dev, struct pnp_card_link *pcard
        struct snd_ad1816a *chip;
        struct snd_opl3 *opl3;
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        error = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct snd_card_ad1816a))) == NULL)
+                                sizeof(struct snd_card_ad1816a), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        acard = (struct snd_card_ad1816a *)card->private_data;
        if ((error = snd_card_ad1816a_pnp(dev, acard, pcard, pid))) {
diff --git a/sound/isa/ad1848/ad1848.c b/sound/isa/ad1848/ad1848.c
index 223a6c038819..4beeb6f98e0e 100644
--- a/sound/isa/ad1848/ad1848.c
+++ b/sound/isa/ad1848/ad1848.c
@@ -91,9 +91,9 @@ static int __devinit snd_ad1848_probe(struct device *dev, unsigned int n)
        struct snd_pcm *pcm;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card)
+        if (error < 0)
-                return -EINVAL;
+                return error;
        error = snd_wss_create(card, port[n], -1, irq[n], dma1[n], -1,
                        thinkpad[n] ? WSS_HW_THINKPAD : WSS_HW_DETECT,
diff --git a/sound/isa/adlib.c b/sound/isa/adlib.c
index 374b7177e111..7465ae036e0b 100644
--- a/sound/isa/adlib.c
+++ b/sound/isa/adlib.c
@@ -53,10 +53,10 @@ static int __devinit snd_adlib_probe(struct device *dev, unsigned int n)
        struct snd_opl3 *opl3;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card) {
+        if (error < 0) {
                dev_err(dev, "could not create card\n");
-                return -EINVAL;
+                return error;
        }
        card->private_data = request_region(port[n], 4, CRD_NAME);
diff --git a/sound/isa/als100.c b/sound/isa/als100.c
index f1ce30f379c9..5fd52e4d7079 100644
--- a/sound/isa/als100.c
+++ b/sound/isa/als100.c
@@ -163,9 +163,10 @@ static int __devinit snd_card_als100_probe(int dev,
        struct snd_card_als100 *acard;
        struct snd_opl3 *opl3;
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        error = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct snd_card_als100))) == NULL)
+                                sizeof(struct snd_card_als100), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        acard = card->private_data;
        if ((error = snd_card_als100_pnp(dev, acard, pcard, pid))) {
diff --git a/sound/isa/azt2320.c b/sound/isa/azt2320.c
index 3e74d1a3928e..f7aa637b0d18 100644
--- a/sound/isa/azt2320.c
+++ b/sound/isa/azt2320.c
@@ -184,9 +184,10 @@ static int __devinit snd_card_azt2320_probe(int dev,
        struct snd_wss *chip;
        struct snd_opl3 *opl3;
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        error = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct snd_card_azt2320))) == NULL)
+                                sizeof(struct snd_card_azt2320), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        acard = (struct snd_card_azt2320 *)card->private_data;
        if ((error = snd_card_azt2320_pnp(dev, acard, pcard, pid))) {
diff --git a/sound/isa/cmi8330.c b/sound/isa/cmi8330.c
index e49aec700a55..24e60902f8ca 100644
--- a/sound/isa/cmi8330.c
+++ b/sound/isa/cmi8330.c
@@ -467,20 +467,22 @@ static int snd_cmi8330_resume(struct snd_card *card)
 #define PFX     "cmi8330: "
-static struct snd_card *snd_cmi8330_card_new(int dev)
+static int snd_cmi8330_card_new(int dev, struct snd_card **cardp)
 {
        struct snd_card *card;
        struct snd_cmi8330 *acard;
+        int err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_cmi8330));
+                              sizeof(struct snd_cmi8330), &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printk(KERN_ERR PFX "could not get a new card\n");
-                return NULL;
+                return err;
        }
        acard = card->private_data;
        acard->card = card;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_cmi8330_probe(struct snd_card *card, int dev)
@@ -564,9 +566,9 @@ static int __devinit snd_cmi8330_isa_probe(struct device *pdev,
        struct snd_card *card;
        int err;
-        card = snd_cmi8330_card_new(dev);
+        err = snd_cmi8330_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, pdev);
        if ((err = snd_cmi8330_probe(card, dev)) < 0) {
                snd_card_free(card);
@@ -628,9 +630,9 @@ static int __devinit snd_cmi8330_pnp_detect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
                               
-        card = snd_cmi8330_card_new(dev);
+        res = snd_cmi8330_card_new(dev, &card);
-        if (! card)
+        if (res < 0)
-                return -ENOMEM;
+                return res;
        if ((res = snd_cmi8330_pnp(dev, card->private_data, pcard, pid)) < 0) {
                snd_printk(KERN_ERR PFX "PnP detection failed\n");
                snd_card_free(card);
diff --git a/sound/isa/cs423x/cs4231.c b/sound/isa/cs423x/cs4231.c
index f019d449e2d6..cb9153e75b82 100644
--- a/sound/isa/cs423x/cs4231.c
+++ b/sound/isa/cs423x/cs4231.c
@@ -95,9 +95,9 @@ static int __devinit snd_cs4231_probe(struct device *dev, unsigned int n)
        struct snd_pcm *pcm;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card)
+        if (error < 0)
-                return -EINVAL;
+                return error;
        error = snd_wss_create(card, port[n], -1, irq[n], dma1[n], dma2[n],
                        WSS_HW_DETECT, 0, &chip);
diff --git a/sound/isa/cs423x/cs4236.c b/sound/isa/cs423x/cs4236.c
index 019c9401663e..f7845986f467 100644
--- a/sound/isa/cs423x/cs4236.c
+++ b/sound/isa/cs423x/cs4236.c
@@ -382,16 +382,18 @@ static void snd_card_cs4236_free(struct snd_card *card)
        release_and_free_resource(acard->res_sb_port);
 }
-static struct snd_card *snd_cs423x_card_new(int dev)
+static int snd_cs423x_card_new(int dev, struct snd_card **cardp)
 {
        struct snd_card *card;
+        int err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_card_cs4236));
+                              sizeof(struct snd_card_cs4236), &card);
-        if (card == NULL)
+        if (err < 0)
-                return NULL;
+                return err;
        card->private_free = snd_card_cs4236_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_cs423x_probe(struct snd_card *card, int dev)
@@ -512,9 +514,9 @@ static int __devinit snd_cs423x_isa_probe(struct device *pdev,
        struct snd_card *card;
        int err;
-        card = snd_cs423x_card_new(dev);
+        err = snd_cs423x_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, pdev);
        if ((err = snd_cs423x_probe(card, dev)) < 0) {
                snd_card_free(card);
@@ -594,9 +596,9 @@ static int __devinit snd_cs4232_pnpbios_detect(struct pnp_dev *pdev,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_cs423x_card_new(dev);
+        err = snd_cs423x_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_card_cs4232_pnp(dev, card->private_data, pdev)) < 0) {
                printk(KERN_ERR "PnP BIOS detection failed for " IDENT "\n");
                snd_card_free(card);
@@ -656,9 +658,9 @@ static int __devinit snd_cs423x_pnpc_detect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_cs423x_card_new(dev);
+        res = snd_cs423x_card_new(dev, &card);
-        if (! card)
+        if (res < 0)
-                return -ENOMEM;
+                return res;
        if ((res = snd_card_cs423x_pnpc(dev, card->private_data, pcard, pid)) < 0) {
                printk(KERN_ERR "isapnp detection failed and probing for " IDENT
                       " is not supported\n");
diff --git a/sound/isa/dt019x.c b/sound/isa/dt019x.c
index a0242c3b613e..80f5b1af9be8 100644
--- a/sound/isa/dt019x.c
+++ b/sound/isa/dt019x.c
@@ -150,9 +150,10 @@ static int __devinit snd_card_dt019x_probe(int dev, struct pnp_card_link *pcard,
        struct snd_card_dt019x *acard;
        struct snd_opl3 *opl3;
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        error = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct snd_card_dt019x))) == NULL)
+                                sizeof(struct snd_card_dt019x), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        acard = card->private_data;
        snd_card_set_dev(card, &pcard->card->dev);
diff --git a/sound/isa/es1688/es1688.c b/sound/isa/es1688/es1688.c
index b46377139cf8..d746750410ea 100644
--- a/sound/isa/es1688/es1688.c
+++ b/sound/isa/es1688/es1688.c
@@ -122,9 +122,9 @@ static int __devinit snd_es1688_probe(struct device *dev, unsigned int n)
        struct snd_pcm *pcm;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card)
+        if (error < 0)
-                return -EINVAL;
+                return error;
        error = snd_es1688_legacy_create(card, dev, n, &chip);
        if (error < 0)
diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
index 90498e4ca260..8cfbff73a835 100644
--- a/sound/isa/es18xx.c
+++ b/sound/isa/es18xx.c
@@ -2125,10 +2125,10 @@ static int __devinit snd_audiodrive_pnpc(int dev, struct snd_audiodrive *acard,
 #define is_isapnp_selected(dev)         0
 #endif
-static struct snd_card *snd_es18xx_card_new(int dev)
+static int snd_es18xx_card_new(int dev, struct snd_card **cardp)
 {
-        return snd_card_new(index[dev], id[dev], THIS_MODULE,
+        return snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_audiodrive));
+                               sizeof(struct snd_audiodrive), cardp);
 }
 static int __devinit snd_audiodrive_probe(struct snd_card *card, int dev)
@@ -2197,9 +2197,9 @@ static int __devinit snd_es18xx_isa_probe1(int dev, struct device *devptr)
        struct snd_card *card;
        int err;
-        card = snd_es18xx_card_new(dev);
+        err = snd_es18xx_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, devptr);
        if ((err = snd_audiodrive_probe(card, dev)) < 0) {
                snd_card_free(card);
@@ -2303,9 +2303,9 @@ static int __devinit snd_audiodrive_pnp_detect(struct pnp_dev *pdev,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_es18xx_card_new(dev);
+        err = snd_es18xx_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_audiodrive_pnp(dev, card->private_data, pdev)) < 0) {
                snd_card_free(card);
                return err;
@@ -2362,9 +2362,9 @@ static int __devinit snd_audiodrive_pnpc_detect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_es18xx_card_new(dev);
+        res = snd_es18xx_card_new(dev, &card);
-        if (! card)
+        if (res < 0)
-                return -ENOMEM;
+                return res;
        if ((res = snd_audiodrive_pnpc(dev, card->private_data, pcard, pid)) < 0) {
                snd_card_free(card);
diff --git a/sound/isa/gus/gusclassic.c b/sound/isa/gus/gusclassic.c
index 426532a4d730..086b8f0e0f94 100644
--- a/sound/isa/gus/gusclassic.c
+++ b/sound/isa/gus/gusclassic.c
@@ -148,9 +148,9 @@ static int __devinit snd_gusclassic_probe(struct device *dev, unsigned int n)
        struct snd_gus_card *gus;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card)
+        if (error < 0)
-                return -EINVAL;
+                return error;
        if (pcm_channels[n] < 2)
                pcm_channels[n] = 2;
diff --git a/sound/isa/gus/gusextreme.c b/sound/isa/gus/gusextreme.c
index 7ad4c3b41a84..180a8dea6bd9 100644
--- a/sound/isa/gus/gusextreme.c
+++ b/sound/isa/gus/gusextreme.c
@@ -241,9 +241,9 @@ static int __devinit snd_gusextreme_probe(struct device *dev, unsigned int n)
        struct snd_opl3 *opl3;
        int error;
-        card = snd_card_new(index[n], id[n], THIS_MODULE, 0);
+        error = snd_card_create(index[n], id[n], THIS_MODULE, 0, &card);
-        if (!card)
+        if (error < 0)
-                return -EINVAL;
+                return error;
        if (mpu_port[n] == SNDRV_AUTO_PORT)
                mpu_port[n] = 0;
diff --git a/sound/isa/gus/gusmax.c b/sound/isa/gus/gusmax.c
index f94c1976e632..f26eac8d8110 100644
--- a/sound/isa/gus/gusmax.c
+++ b/sound/isa/gus/gusmax.c
@@ -214,10 +214,10 @@ static int __devinit snd_gusmax_probe(struct device *pdev, unsigned int dev)
        struct snd_wss *wss;
        struct snd_gusmax *maxcard;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_gusmax));
+                              sizeof(struct snd_gusmax), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        card->private_free = snd_gusmax_free;
        maxcard = (struct snd_gusmax *)card->private_data;
        maxcard->card = card;
diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c
index 5faecfb602d3..50e429a120da 100644
--- a/sound/isa/gus/interwave.c
+++ b/sound/isa/gus/interwave.c
@@ -626,20 +626,22 @@ static void snd_interwave_free(struct snd_card *card)
                free_irq(iwcard->irq, (void *)iwcard);
 }
-static struct snd_card *snd_interwave_card_new(int dev)
+static int snd_interwave_card_new(int dev, struct snd_card **cardp)
 {
        struct snd_card *card;
        struct snd_interwave *iwcard;
+        int err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_interwave));
+                              sizeof(struct snd_interwave), &card);
-        if (card == NULL)
+        if (err < 0)
-                return NULL;
+                return err;
        iwcard = card->private_data;
        iwcard->card = card;
        iwcard->irq = -1;
        card->private_free = snd_interwave_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_interwave_probe(struct snd_card *card, int dev)
@@ -778,9 +780,9 @@ static int __devinit snd_interwave_isa_probe1(int dev, struct device *devptr)
        struct snd_card *card;
        int err;
-        card = snd_interwave_card_new(dev);
+        err = snd_interwave_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, devptr);
        if ((err = snd_interwave_probe(card, dev)) < 0) {
@@ -876,9 +878,9 @@ static int __devinit snd_interwave_pnp_detect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
                                
-        card = snd_interwave_card_new(dev);
+        res = snd_interwave_card_new(dev, &card);
-        if (! card)
+        if (res < 0)
-                return -ENOMEM;
+                return res;
        if ((res = snd_interwave_pnp(dev, card->private_data, pcard, pid)) < 0) {
                snd_card_free(card);
diff --git a/sound/isa/opl3sa2.c b/sound/isa/opl3sa2.c
index 58c972b2af03..63e51373ddc7 100644
--- a/sound/isa/opl3sa2.c
+++ b/sound/isa/opl3sa2.c
@@ -550,21 +550,27 @@ static int __devinit snd_opl3sa2_mixer(struct snd_card *card)
 #ifdef CONFIG_PM
 static int snd_opl3sa2_suspend(struct snd_card *card, pm_message_t state)
 {
-        struct snd_opl3sa2 *chip = card->private_data;
+        if (card) {
+                struct snd_opl3sa2 *chip = card->private_data;
-        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+                snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
-        chip->wss->suspend(chip->wss);
+                chip->wss->suspend(chip->wss);
-        /* power down */
+                /* power down */
-        snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D3);
+                snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D3);
+        }
        return 0;
 }
 static int snd_opl3sa2_resume(struct snd_card *card)
 {
-        struct snd_opl3sa2 *chip = card->private_data;
+        struct snd_opl3sa2 *chip;
        int i;
+        if (!card)
+                return 0;
+        chip = card->private_data;
        /* power up */
        snd_opl3sa2_write(chip, OPL3SA2_PM_CTRL, OPL3SA2_PM_D0);
@@ -617,21 +623,24 @@ static void snd_opl3sa2_free(struct snd_card *card)
        release_and_free_resource(chip->res_port);
 }
-static struct snd_card *snd_opl3sa2_card_new(int dev)
+static int snd_opl3sa2_card_new(int dev, struct snd_card **cardp)
 {
        struct snd_card *card;
        struct snd_opl3sa2 *chip;
+        int err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, sizeof(struct snd_opl3sa2));
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-        if (card == NULL)
+                              sizeof(struct snd_opl3sa2), &card);
-                return NULL;
+        if (err < 0)
+                return err;
        strcpy(card->driver, "OPL3SA2");
        strcpy(card->shortname, "Yamaha OPL3-SA2");
        chip = card->private_data;
        spin_lock_init(&chip->reg_lock);
        chip->irq = -1;
        card->private_free = snd_opl3sa2_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_opl3sa2_probe(struct snd_card *card, int dev)
@@ -723,9 +732,9 @@ static int __devinit snd_opl3sa2_pnp_detect(struct pnp_dev *pdev,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_opl3sa2_card_new(dev);
+        err = snd_opl3sa2_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_opl3sa2_pnp(dev, card->private_data, pdev)) < 0) {
                snd_card_free(card);
                return err;
@@ -789,9 +798,9 @@ static int __devinit snd_opl3sa2_pnp_cdetect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_opl3sa2_card_new(dev);
+        err = snd_opl3sa2_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_opl3sa2_pnp(dev, card->private_data, pdev)) < 0) {
                snd_card_free(card);
                return err;
@@ -870,9 +879,9 @@ static int __devinit snd_opl3sa2_isa_probe(struct device *pdev,
        struct snd_card *card;
        int err;
-        card = snd_opl3sa2_card_new(dev);
+        err = snd_opl3sa2_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, pdev);
        if ((err = snd_opl3sa2_probe(card, dev)) < 0) {
                snd_card_free(card);
diff --git a/sound/isa/opti9xx/miro.c b/sound/isa/opti9xx/miro.c
index 440755cc0013..02e30d7c6a93 100644
--- a/sound/isa/opti9xx/miro.c
+++ b/sound/isa/opti9xx/miro.c
@@ -1228,9 +1228,10 @@ static int __devinit snd_miro_probe(struct device *devptr, unsigned int n)
        struct snd_pcm *pcm;
        struct snd_rawmidi *rmidi;
-        if (!(card = snd_card_new(index, id, THIS_MODULE,
+        error = snd_card_create(index, id, THIS_MODULE,
-                                  sizeof(struct snd_miro))))
+                                sizeof(struct snd_miro), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        card->private_free = snd_card_miro_free;
        miro = card->private_data;
diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 19706b0d8497..cd6e60a6a4ea 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -830,15 +830,18 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card)
        return snd_card_register(card);
 }
-static struct snd_card *snd_opti9xx_card_new(void)
+static int snd_opti9xx_card_new(struct snd_card **cardp)
 {
        struct snd_card *card;
+        int err;
-        card = snd_card_new(index, id, THIS_MODULE, sizeof(struct snd_opti9xx));
+        err = snd_card_create(index, id, THIS_MODULE,
-        if (! card)
+                              sizeof(struct snd_opti9xx), &card);
-                return NULL;
+        if (err < 0)
+                return err;
        card->private_free = snd_card_opti9xx_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_opti9xx_isa_match(struct device *devptr,
@@ -903,9 +906,9 @@ static int __devinit snd_opti9xx_isa_probe(struct device *devptr,
        }
 #endif
-        card = snd_opti9xx_card_new();
+        error = snd_opti9xx_card_new(&card);
-        if (! card)
+        if (error < 0)
-                return -ENOMEM;
+                return error;
        if ((error = snd_card_opti9xx_detect(card, card->private_data)) < 0) {
                snd_card_free(card);
@@ -950,9 +953,9 @@ static int __devinit snd_opti9xx_pnp_probe(struct pnp_card_link *pcard,
                return -EBUSY;
        if (! isapnp)
                return -ENODEV;
-        card = snd_opti9xx_card_new();
+        error = snd_opti9xx_card_new(&card);
-        if (! card)
+        if (error < 0)
-                return -ENOMEM;
+                return error;
        chip = card->private_data;
        hw = snd_card_opti9xx_pnp(chip, pcard, pid);
diff --git a/sound/isa/sb/es968.c b/sound/isa/sb/es968.c
index c8c8e214c843..cafc3a7316a8 100644
--- a/sound/isa/sb/es968.c
+++ b/sound/isa/sb/es968.c
@@ -108,9 +108,10 @@ static int __devinit snd_card_es968_probe(int dev,
        struct snd_card *card;
        struct snd_card_es968 *acard;
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        error = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct snd_card_es968))) == NULL)
+                                sizeof(struct snd_card_es968), &card);
-                return -ENOMEM;
+        if (error < 0)
+                return error;
        acard = card->private_data;
        if ((error = snd_card_es968_pnp(dev, acard, pcard, pid))) {
                snd_card_free(card);
diff --git a/sound/isa/sb/sb16.c b/sound/isa/sb/sb16.c
index 2c201f78ce50..519c36346dec 100644
--- a/sound/isa/sb/sb16.c
+++ b/sound/isa/sb/sb16.c
@@ -324,14 +324,18 @@ static void snd_sb16_free(struct snd_card *card)
 #define is_isapnp_selected(dev)         0
 #endif
-static struct snd_card *snd_sb16_card_new(int dev)
+static int snd_sb16_card_new(int dev, struct snd_card **cardp)
 {
-        struct snd_card *card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        struct snd_card *card;
-                                        sizeof(struct snd_card_sb16));
+        int err;
-        if (card == NULL)
-                return NULL;
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
+                              sizeof(struct snd_card_sb16), &card);
+        if (err < 0)
+                return err;
        card->private_free = snd_sb16_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit snd_sb16_probe(struct snd_card *card, int dev)
@@ -489,9 +493,9 @@ static int __devinit snd_sb16_isa_probe1(int dev, struct device *pdev)
        struct snd_card *card;
        int err;
-        card = snd_sb16_card_new(dev);
+        err = snd_sb16_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        acard = card->private_data;
        /* non-PnP FM port address is hardwired with base port address */
@@ -610,9 +614,9 @@ static int __devinit snd_sb16_pnp_detect(struct pnp_card_link *pcard,
        for ( ; dev < SNDRV_CARDS; dev++) {
                if (!enable[dev] || !isapnp[dev])
                        continue;
-                card = snd_sb16_card_new(dev);
+                res = snd_sb16_card_new(dev, &card);
-                if (! card)
+                if (res < 0)
-                        return -ENOMEM;
+                        return res;
                snd_card_set_dev(card, &pcard->card->dev);
                if ((res = snd_card_sb16_pnp(dev, card->private_data, pcard, pid)) < 0 ||
                    (res = snd_sb16_probe(card, dev)) < 0) {
diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
index ea06877be4b1..3cd57ee54660 100644
--- a/sound/isa/sb/sb8.c
+++ b/sound/isa/sb/sb8.c
@@ -103,10 +103,10 @@ static int __devinit snd_sb8_probe(struct device *pdev, unsigned int dev)
        struct snd_opl3 *opl3;
        int err;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_sb8));
+                              sizeof(struct snd_sb8), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        acard = card->private_data;
        card->private_free = snd_sb8_free;
diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
index ca35924dc3b3..7a1470376c6d 100644
--- a/sound/isa/sc6000.c
+++ b/sound/isa/sc6000.c
@@ -489,9 +489,9 @@ static int __devinit snd_sc6000_probe(struct device *devptr, unsigned int dev)
        char __iomem *vmss_port;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if (xirq == SNDRV_AUTO_IRQ) {
                xirq = snd_legacy_find_free_irq(possible_irqs);
diff --git a/sound/isa/sgalaxy.c b/sound/isa/sgalaxy.c
index 2c7503bf1271..6fe27b9d9440 100644
--- a/sound/isa/sgalaxy.c
+++ b/sound/isa/sgalaxy.c
@@ -243,9 +243,9 @@ static int __devinit snd_sgalaxy_probe(struct device *devptr, unsigned int dev)
        struct snd_card *card;
        struct snd_wss *chip;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        xirq = irq[dev];
        if (xirq == SNDRV_AUTO_IRQ) {
diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 48a16d865834..4025fb558c50 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -1357,10 +1357,10 @@ static int __devinit snd_sscape_probe(struct device *pdev, unsigned int dev)
        struct soundscape *sscape;
        int ret;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        ret = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct soundscape));
+                              sizeof(struct soundscape), &card);
-        if (!card)
+        if (ret < 0)
-                return -ENOMEM;
+                return ret;
        sscape = get_card_soundscape(card);
        sscape->type = SSCAPE;
@@ -1462,10 +1462,10 @@ static int __devinit sscape_pnp_detect(struct pnp_card_link *pcard,
         * Create a new ALSA sound card entry, in anticipation
         * of detecting our hardware ...
         */
-        card = snd_card_new(index[idx], id[idx], THIS_MODULE,
+        ret = snd_card_create(index[idx], id[idx], THIS_MODULE,
-                            sizeof(struct soundscape));
+                              sizeof(struct soundscape), &card);
-        if (!card)
+        if (ret < 0)
-                return -ENOMEM;
+                return ret;
        sscape = get_card_soundscape(card);
diff --git a/sound/isa/wavefront/wavefront.c b/sound/isa/wavefront/wavefront.c
index 4c095bc7c729..95898b2b7b58 100644
--- a/sound/isa/wavefront/wavefront.c
+++ b/sound/isa/wavefront/wavefront.c
@@ -338,15 +338,16 @@ snd_wavefront_free(struct snd_card *card)
        }
 }
-static struct snd_card *snd_wavefront_card_new(int dev)
+static int snd_wavefront_card_new(int dev, struct snd_card **cardp)
 {
        struct snd_card *card;
        snd_wavefront_card_t *acard;
+        int err;
-        card = snd_card_new (index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                             sizeof(snd_wavefront_card_t));
+                              sizeof(snd_wavefront_card_t), &card);
-        if (card == NULL)
+        if (err < 0)
-                return NULL;
+                return err;
        acard = card->private_data;
        acard->wavefront.irq = -1;
@@ -357,7 +358,8 @@ static struct snd_card *snd_wavefront_card_new(int dev)
        acard->wavefront.card = card;
        card->private_free = snd_wavefront_free;
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit
@@ -567,9 +569,9 @@ static int __devinit snd_wavefront_isa_probe(struct device *pdev,
        struct snd_card *card;
        int err;
-        card = snd_wavefront_card_new(dev);
+        err = snd_wavefront_card_new(dev, &card);
-        if (! card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, pdev);
        if ((err = snd_wavefront_probe(card, dev)) < 0) {
                snd_card_free(card);
@@ -616,9 +618,9 @@ static int __devinit snd_wavefront_pnp_detect(struct pnp_card_link *pcard,
        if (dev >= SNDRV_CARDS)
                return -ENODEV;
-        card = snd_wavefront_card_new(dev);
+        res = snd_wavefront_card_new(dev, &card);
-        if (! card)
+        if (res < 0)
-                return -ENOMEM;
+                return res;
        if (snd_wavefront_pnp (dev, card->private_data, pcard, pid) < 0) {
                if (cs4232_pcm_port[dev] == SNDRV_AUTO_PORT) {
diff --git a/sound/mips/au1x00.c b/sound/mips/au1x00.c
index 7c1afc96ab87..3e763d6a5d67 100644
--- a/sound/mips/au1x00.c
+++ b/sound/mips/au1x00.c
@@ -636,9 +636,10 @@ au1000_init(void)
        struct snd_card *card;
        struct snd_au1000 *au1000;
-        card = snd_card_new(-1, "AC97", THIS_MODULE, sizeof(struct snd_au1000));
+        err = snd_card_create(-1, "AC97", THIS_MODULE,
-        if (card == NULL)
+                              sizeof(struct snd_au1000), &card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        card->private_free = snd_au1000_free;
        au1000 = card->private_data;
diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c
index db495be01861..c52691c2fc46 100644
--- a/sound/mips/hal2.c
+++ b/sound/mips/hal2.c
@@ -878,9 +878,9 @@ static int __devinit hal2_probe(struct platform_device *pdev)
        struct snd_hal2 *chip;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = hal2_create(card, &chip);
        if (err < 0) {
diff --git a/sound/mips/sgio2audio.c b/sound/mips/sgio2audio.c
index 4c63504348dc..66f3b48ceafc 100644
--- a/sound/mips/sgio2audio.c
+++ b/sound/mips/sgio2audio.c
@@ -936,9 +936,9 @@ static int __devinit snd_sgio2audio_probe(struct platform_device *pdev)
        struct snd_sgio2audio *chip;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_sgio2audio_create(card, &chip);
        if (err < 0) {
diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c
index 57d9f154c88b..38931f2f6967 100644
--- a/sound/oss/dmasound/dmasound_atari.c
+++ b/sound/oss/dmasound/dmasound_atari.c
@@ -847,23 +847,23 @@ static int __init AtaIrqInit(void)
           of events. So all we need to keep the music playing is
           to provide the sound hardware with new data upon
           an interrupt from timer A. */
-        mfp.tim_ct_a = 0;       /* ++roman: Stop timer before programming! */
+        st_mfp.tim_ct_a = 0;    /* ++roman: Stop timer before programming! */
-        mfp.tim_dt_a = 1;       /* Cause interrupt after first event. */
+        st_mfp.tim_dt_a = 1;    /* Cause interrupt after first event. */
-        mfp.tim_ct_a = 8;       /* Turn on event counting. */
+        st_mfp.tim_ct_a = 8;    /* Turn on event counting. */
        /* Register interrupt handler. */
        if (request_irq(IRQ_MFP_TIMA, AtaInterrupt, IRQ_TYPE_SLOW, "DMA sound",
                        AtaInterrupt))
                return 0;
-        mfp.int_en_a |= 0x20;   /* Turn interrupt on. */
+        st_mfp.int_en_a |= 0x20;        /* Turn interrupt on. */
-        mfp.int_mk_a |= 0x20;
+        st_mfp.int_mk_a |= 0x20;
        return 1;
 }
 #ifdef MODULE
 static void AtaIrqCleanUp(void)
 {
-        mfp.tim_ct_a = 0;       /* stop timer */
+        st_mfp.tim_ct_a = 0;            /* stop timer */
-        mfp.int_en_a &= ~0x20;  /* turn interrupt off */
+        st_mfp.int_en_a &= ~0x20;       /* turn interrupt off */
        free_irq(IRQ_MFP_TIMA, AtaInterrupt);
 }
 #endif /* MODULE */
@@ -1599,7 +1599,7 @@ static int __init dmasound_atari_init(void)
                is_falcon = 0;
            } else
                return -ENODEV;
-            if ((mfp.int_en_a & mfp.int_mk_a & 0x20) == 0)
+            if ((st_mfp.int_en_a & st_mfp.int_mk_a & 0x20) == 0)
                return dmasound_init();
            else {
                printk("DMA sound driver: Timer A interrupt already in use\n");
diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c
index 41f870f8a11d..6055fd6d3b38 100644
--- a/sound/parisc/harmony.c
+++ b/sound/parisc/harmony.c
@@ -975,9 +975,9 @@ snd_harmony_probe(struct parisc_device *padev)
        struct snd_card *card;
        struct snd_harmony *h;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_harmony_create(card, padev, &h);
        if (err < 0)
diff --git a/sound/pci/ad1889.c b/sound/pci/ad1889.c
index a7f38e63303f..d1f242bd0ac5 100644
--- a/sound/pci/ad1889.c
+++ b/sound/pci/ad1889.c
@@ -995,10 +995,10 @@ snd_ad1889_probe(struct pci_dev *pci,
        }
        /* (2) */
-        card = snd_card_new(index[devno], id[devno], THIS_MODULE, 0);
+        err = snd_card_create(index[devno], id[devno], THIS_MODULE, 0, &card);
        /* XXX REVISIT: we can probably allocate chip in this call */
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "AD1889");
        strcpy(card->shortname, "Analog Devices AD1889");
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
index 9069c78c2dc7..4edf270a7809 100644
--- a/sound/pci/ali5451/ali5451.c
+++ b/sound/pci/ali5451/ali5451.c
@@ -2307,9 +2307,9 @@ static int __devinit snd_ali_probe(struct pci_dev *pci,
        snd_ali_printk("probe ...\n");
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_ali_create(card, pci, pcm_channels, spdif, &codec);
        if (err < 0)
diff --git a/sound/pci/als300.c b/sound/pci/als300.c
index a2c35c1081c3..009b4c8225a5 100644
--- a/sound/pci/als300.c
+++ b/sound/pci/als300.c
@@ -812,10 +812,10 @@ static int __devinit snd_als300_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        chip_type = pci_id->driver_data;
diff --git a/sound/pci/als4000.c b/sound/pci/als4000.c
index ba570053d4d5..542a0c65a92c 100644
--- a/sound/pci/als4000.c
+++ b/sound/pci/als4000.c
@@ -889,12 +889,13 @@ static int __devinit snd_card_als4000_probe(struct pci_dev *pci,
        pci_write_config_word(pci, PCI_COMMAND, word | PCI_COMMAND_IO);
        pci_set_master(pci);
        
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 
-                            sizeof(*acard) /* private_data: acard */);
+                              sizeof(*acard) /* private_data: acard */,
-        if (card == NULL) {
+                              &card);
+        if (err < 0) {
                pci_release_regions(pci);
                pci_disable_device(pci);
-                return -ENOMEM;
+                return err;
        }
        acard = card->private_data;
diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
index 226fe8237d31..9ce8548c03e4 100644
--- a/sound/pci/atiixp.c
+++ b/sound/pci/atiixp.c
@@ -1645,9 +1645,9 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci,
        struct atiixp *chip;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, spdif_aclink ? "ATIIXP" : "ATIIXP-SPDMA");
        strcpy(card->shortname, "ATI IXP");
diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c
index 0e6e5cc1c501..c3136cccc559 100644
--- a/sound/pci/atiixp_modem.c
+++ b/sound/pci/atiixp_modem.c
@@ -1288,9 +1288,9 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci,
        struct atiixp_modem *chip;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "ATIIXP-MODEM");
        strcpy(card->shortname, "ATI IXP Modem");
diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c
index a36d4d1fd419..9ec122383eef 100644
--- a/sound/pci/au88x0/au88x0.c
+++ b/sound/pci/au88x0/au88x0.c
@@ -250,9 +250,9 @@ snd_vortex_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
                return -ENOENT;
        }
        // (2)
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        // (3)
        if ((err = snd_vortex_create(card, pci, &chip)) < 0) {
diff --git a/sound/pci/aw2/aw2-alsa.c b/sound/pci/aw2/aw2-alsa.c
index 3f00ddf450f8..8eea29fc42fe 100644
--- a/sound/pci/aw2/aw2-alsa.c
+++ b/sound/pci/aw2/aw2-alsa.c
@@ -165,7 +165,7 @@ module_param_array(enable, bool, NULL, 0444);
 MODULE_PARM_DESC(enable, "Enable Audiowerk2 soundcard.");
 static struct pci_device_id snd_aw2_ids[] = {
-        {PCI_VENDOR_ID_SAA7146, PCI_DEVICE_ID_SAA7146, PCI_ANY_ID, PCI_ANY_ID,
+        {PCI_VENDOR_ID_SAA7146, PCI_DEVICE_ID_SAA7146, 0, 0,
         0, 0, 0},
        {0}
 };
@@ -368,9 +368,9 @@ static int __devinit snd_aw2_probe(struct pci_dev *pci,
        }
        /* (2) Create card instance */
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        /* (3) Create main component */
        err = snd_aw2_create(card, pci, &chip);
diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c
index 8121763b0c10..e9e9b5821d41 100644
--- a/sound/pci/azt3328.c
+++ b/sound/pci/azt3328.c
@@ -2216,9 +2216,9 @@ snd_azf3328_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "AZF3328");
        strcpy(card->shortname, "Aztech AZF3328 (PCI168)");
diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
index 1aa1c0402540..a299340519df 100644
--- a/sound/pci/bt87x.c
+++ b/sound/pci/bt87x.c
@@ -888,9 +888,9 @@ static int __devinit snd_bt87x_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_bt87x_create(card, pci, &chip);
        if (err < 0)
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index f2f8fd17ea4d..a38ff9dd07eb 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -1758,9 +1758,9 @@ static int __devinit snd_ca0106_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_ca0106_create(dev, card, pci, &chip);
        if (err < 0)
diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
index 1a74ca62c314..c7899c32aba1 100644
--- a/sound/pci/cmipci.c
+++ b/sound/pci/cmipci.c
@@ -3272,9 +3272,9 @@ static int __devinit snd_cmipci_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        
        switch (pci->device) {
        case PCI_DEVICE_ID_CMEDIA_CM8738:
diff --git a/sound/pci/cs4281.c b/sound/pci/cs4281.c
index 415e88f2c62f..f6286f84a221 100644
--- a/sound/pci/cs4281.c
+++ b/sound/pci/cs4281.c
@@ -1929,9 +1929,9 @@ static int __devinit snd_cs4281_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_cs4281_create(card, pci, &chip, dual_codec[dev])) < 0) {
                snd_card_free(card);
diff --git a/sound/pci/cs46xx/cs46xx.c b/sound/pci/cs46xx/cs46xx.c
index e876b3263e46..c9b3e3d48cbc 100644
--- a/sound/pci/cs46xx/cs46xx.c
+++ b/sound/pci/cs46xx/cs46xx.c
@@ -88,9 +88,9 @@ static int __devinit snd_card_cs46xx_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_cs46xx_create(card, pci,
                                     external_amp[dev], thinkpad[dev],
                                     &chip)) < 0) {
diff --git a/sound/pci/cs5530.c b/sound/pci/cs5530.c
index 6dea5b5cc774..dc464321d0f3 100644
--- a/sound/pci/cs5530.c
+++ b/sound/pci/cs5530.c
@@ -258,10 +258,10 @@ static int __devinit snd_cs5530_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        err = snd_cs5530_create(card, pci, &chip);
        if (err < 0) {
diff --git a/sound/pci/cs5535audio/cs5535audio.c b/sound/pci/cs5535audio/cs5535audio.c
index 6506201d56f6..c89ed1f5bc2b 100644
--- a/sound/pci/cs5535audio/cs5535audio.c
+++ b/sound/pci/cs5535audio/cs5535audio.c
@@ -353,9 +353,9 @@ static int __devinit snd_cs5535audio_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_cs5535audio_create(card, pci, &cs5535au)) < 0)
                goto probefail_out;
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index 8dbc5c4ba421..9d015a76eb69 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -1997,9 +1997,9 @@ static int __devinit snd_echo_probe(struct pci_dev *pci,
        DE_INIT(("Echoaudio driver starting...\n"));
        i = 0;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        snd_card_set_dev(card, &pci->dev);
diff --git a/sound/pci/emu10k1/emu10k1.c b/sound/pci/emu10k1/emu10k1.c
index 8354c1a83312..c7f3b994101c 100644
--- a/sound/pci/emu10k1/emu10k1.c
+++ b/sound/pci/emu10k1/emu10k1.c
@@ -114,9 +114,9 @@ static int __devinit snd_card_emu10k1_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if (max_buffer_size[dev] < 32)
                max_buffer_size[dev] = 32;
        else if (max_buffer_size[dev] > 1024)
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index 7958006a1d66..101a1c13a20d 100644
--- a/sound/pci/emu10k1/emu10k1_main.c
+++ b/sound/pci/emu10k1/emu10k1_main.c
@@ -1528,6 +1528,7 @@ static struct snd_emu_chip_details emu_chip_details[] = {
         .ca0151_chip = 1,
         .spk71 = 1,
         .spdif_bug = 1,
+         .invert_shared_spdif = 1,      /* digital/analog switch swapped */
         .ac97_chip = 1} ,
        {.vendor = 0x1102, .device = 0x0004, .subsystem = 0x10021102,
         .driver = "Audigy2", .name = "SB Audigy 2 Platinum [SB0240P]",
diff --git a/sound/pci/emu10k1/emu10k1x.c b/sound/pci/emu10k1/emu10k1x.c
index 5ff4dbb62dad..31542adc6b7e 100644
--- a/sound/pci/emu10k1/emu10k1x.c
+++ b/sound/pci/emu10k1/emu10k1x.c
@@ -1544,9 +1544,9 @@ static int __devinit snd_emu10k1x_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_emu10k1x_create(card, pci, &chip)) < 0) {
                snd_card_free(card);
diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c
index 17674b3406bd..18f4d1e98c46 100644
--- a/sound/pci/ens1370.c
+++ b/sound/pci/ens1370.c
@@ -2410,9 +2410,9 @@ static int __devinit snd_audiopci_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_ensoniq_create(card, pci, &ensoniq)) < 0) {
                snd_card_free(card);
diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c
index e4ba84bed4ad..dd63b132fb8e 100644
--- a/sound/pci/es1938.c
+++ b/sound/pci/es1938.c
@@ -1806,9 +1806,9 @@ static int __devinit snd_es1938_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        for (idx = 0; idx < 5; idx++) {
                if (pci_resource_start(pci, idx) == 0 ||
                    !(pci_resource_flags(pci, idx) & IORESOURCE_IO)) {
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
index e9c3794bbcb8..dc97e8116141 100644
--- a/sound/pci/es1968.c
+++ b/sound/pci/es1968.c
@@ -2645,9 +2645,9 @@ static int __devinit snd_es1968_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
                
        if (total_bufsize[dev] < 128)
                total_bufsize[dev] = 128;
diff --git a/sound/pci/fm801.c b/sound/pci/fm801.c
index c129f9e2072c..60cdb9e0b68d 100644
--- a/sound/pci/fm801.c
+++ b/sound/pci/fm801.c
@@ -1468,9 +1468,9 @@ static int __devinit snd_card_fm801_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_fm801_create(card, pci, tea575x_tuner[dev], &chip)) < 0) {
                snd_card_free(card);
                return err;
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index b7bba7dc7cf1..d03f99298be9 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -487,7 +487,6 @@ int /*__devinit*/ snd_hda_bus_new(struct snd_card *card,
 {
        struct hda_bus *bus;
        int err;
-        char qname[8];
        static struct snd_device_ops dev_ops = {
                .dev_register = snd_hda_bus_dev_register,
                .dev_free = snd_hda_bus_dev_free,
@@ -517,10 +516,12 @@ int /*__devinit*/ snd_hda_bus_new(struct snd_card *card,
        mutex_init(&bus->cmd_mutex);
        INIT_LIST_HEAD(&bus->codec_list);
-        snprintf(qname, sizeof(qname), "hda%d", card->number);
+        snprintf(bus->workq_name, sizeof(bus->workq_name),
-        bus->workq = create_workqueue(qname);
+                 "hd-audio%d", card->number);
+        bus->workq = create_singlethread_workqueue(bus->workq_name);
        if (!bus->workq) {
-                snd_printk(KERN_ERR "cannot create workqueue %s\n", qname);
+                snd_printk(KERN_ERR "cannot create workqueue %s\n",
+                           bus->workq_name);
                kfree(bus);
                return -ENOMEM;
        }
@@ -3087,6 +3088,16 @@ int snd_hda_multi_out_dig_prepare(struct hda_codec *codec,
 }
 EXPORT_SYMBOL_HDA(snd_hda_multi_out_dig_prepare);
+int snd_hda_multi_out_dig_cleanup(struct hda_codec *codec,
+                                  struct hda_multi_out *mout)
+{
+        mutex_lock(&codec->spdif_mutex);
+        cleanup_dig_out_stream(codec, mout->dig_out_nid);
+        mutex_unlock(&codec->spdif_mutex);
+        return 0;
+}
+EXPORT_SYMBOL_HDA(snd_hda_multi_out_dig_cleanup);
 /*
 * release the digital out
 */
diff --git a/sound/pci/hda/hda_codec.h b/sound/pci/hda/hda_codec.h
index 5810ef588402..09a332ada0c6 100644
--- a/sound/pci/hda/hda_codec.h
+++ b/sound/pci/hda/hda_codec.h
@@ -614,6 +614,7 @@ struct hda_bus {
        /* unsolicited event queue */
        struct hda_bus_unsolicited *unsol;
+        char workq_name[16];
        struct workqueue_struct *workq; /* common workqueue for codecs */
        /* assigned PCMs */
diff --git a/sound/pci/hda/hda_hwdep.c b/sound/pci/hda/hda_hwdep.c
index 300ab407cf42..4ae51dcb81af 100644
--- a/sound/pci/hda/hda_hwdep.c
+++ b/sound/pci/hda/hda_hwdep.c
@@ -175,7 +175,7 @@ static int reconfig_codec(struct hda_codec *codec)
        err = snd_hda_codec_build_controls(codec);
        if (err < 0)
                return err;
-        return 0;
+        return snd_card_register(codec->bus->card);
 }
 /*
@@ -277,18 +277,19 @@ static ssize_t init_verbs_store(struct device *dev,
 {
        struct snd_hwdep *hwdep = dev_get_drvdata(dev);
        struct hda_codec *codec = hwdep->private_data;
-        char *p;
+        struct hda_verb *v;
-        struct hda_verb verb, *v;
+        int nid, verb, param;
-        verb.nid = simple_strtoul(buf, &p, 0);
+        if (sscanf(buf, "%i %i %i", &nid, &verb, &param) != 3)
-        verb.verb = simple_strtoul(p, &p, 0);
+                return -EINVAL;
-        verb.param = simple_strtoul(p, &p, 0);
+        if (!nid || !verb)
-        if (!verb.nid || !verb.verb || !verb.param)
                return -EINVAL;
        v = snd_array_new(&codec->init_verbs);
        if (!v)
                return -ENOMEM;
-        *v = verb;
+        v->nid = nid;
+        v->verb = verb;
+        v->param = param;
        return count;
 }
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 11e791b965f6..3683978324e8 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1947,16 +1947,13 @@ static int azx_suspend(struct pci_dev *pci, pm_message_t state)
        return 0;
 }
-static int azx_resume_early(struct pci_dev *pci)
-{
-        return pci_restore_state(pci);
-}
 static int azx_resume(struct pci_dev *pci)
 {
        struct snd_card *card = pci_get_drvdata(pci);
        struct azx *chip = card->private_data;
+        pci_set_power_state(pci, PCI_D0);
+        pci_restore_state(pci);
        if (pci_enable_device(pci) < 0) {
                printk(KERN_ERR "hda-intel: pci_enable_device failed, "
                       "disabling device\n");
@@ -2062,26 +2059,31 @@ static int __devinit check_position_fix(struct azx *chip, int fix)
 {
        const struct snd_pci_quirk *q;
-        /* Check VIA HD Audio Controller exist */
+        switch (fix) {
-        if (chip->pci->vendor == PCI_VENDOR_ID_VIA &&
+        case POS_FIX_LPIB:
-            chip->pci->device == VIA_HDAC_DEVICE_ID) {
+        case POS_FIX_POSBUF:
+                return fix;
+        }
+        /* Check VIA/ATI HD Audio Controller exist */
+        switch (chip->driver_type) {
+        case AZX_DRIVER_VIA:
+        case AZX_DRIVER_ATI:
                chip->via_dmapos_patch = 1;
                /* Use link position directly, avoid any transfer problem. */
                return POS_FIX_LPIB;
        }
        chip->via_dmapos_patch = 0;
-        if (fix == POS_FIX_AUTO) {
+        q = snd_pci_quirk_lookup(chip->pci, position_fix_list);
-                q = snd_pci_quirk_lookup(chip->pci, position_fix_list);
+        if (q) {
-                if (q) {
+                printk(KERN_INFO
-                        printk(KERN_INFO
+                       "hda_intel: position_fix set to %d "
-                                    "hda_intel: position_fix set to %d "
+                       "for device %04x:%04x\n",
-                                    "for device %04x:%04x\n",
+                       q->value, q->subvendor, q->subdevice);
-                                    q->value, q->subvendor, q->subdevice);
+                return q->value;
-                        return q->value;
-                }
        }
-        return fix;
+        return POS_FIX_AUTO;
 }
 /*
@@ -2098,6 +2100,8 @@ static struct snd_pci_quirk probe_mask_list[] __devinitdata = {
        SND_PCI_QUIRK(0x1028, 0x20ac, "Dell Studio Desktop", 0x01),
        /* including bogus ALC268 in slot#2 that conflicts with ALC888 */
        SND_PCI_QUIRK(0x17c0, 0x4085, "Medion MD96630", 0x01),
+        /* conflict of ALC268 in slot#3 (digital I/O); a temporary fix */
+        SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba laptop", 0x03),
        {}
 };
@@ -2211,9 +2215,17 @@ static int __devinit azx_create(struct snd_card *card, struct pci_dev *pci,
        gcap = azx_readw(chip, GCAP);
        snd_printdd("chipset global capabilities = 0x%x\n", gcap);
+        /* ATI chips seems buggy about 64bit DMA addresses */
+        if (chip->driver_type == AZX_DRIVER_ATI)
+                gcap &= ~0x01;
        /* allow 64bit DMA address if supported by H/W */
        if ((gcap & 0x01) && !pci_set_dma_mask(pci, DMA_64BIT_MASK))
                pci_set_consistent_dma_mask(pci, DMA_64BIT_MASK);
+        else {
+                pci_set_dma_mask(pci, DMA_32BIT_MASK);
+                pci_set_consistent_dma_mask(pci, DMA_32BIT_MASK);
+        }
        /* read number of streams from GCAP register instead of using
         * hardcoded value
@@ -2335,10 +2347,10 @@ static int __devinit azx_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (!card) {
+        if (err < 0) {
                snd_printk(KERN_ERR SFX "Error creating card!\n");
-                return -ENOMEM;
+                return err;
        }
        err = azx_create(card, pci, dev, pci_id->driver_data, &chip);
@@ -2468,7 +2480,6 @@ static struct pci_driver driver = {
        .remove = __devexit_p(azx_remove),
 #ifdef CONFIG_PM
        .suspend = azx_suspend,
-        .resume_early = azx_resume_early,
        .resume = azx_resume,
 #endif
 };
diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h
index 1dd8716c387f..44f189cb97ae 100644
--- a/sound/pci/hda/hda_local.h
+++ b/sound/pci/hda/hda_local.h
@@ -251,6 +251,8 @@ int snd_hda_multi_out_dig_prepare(struct hda_codec *codec,
                                  unsigned int stream_tag,
                                  unsigned int format,
                                  struct snd_pcm_substream *substream);
+int snd_hda_multi_out_dig_cleanup(struct hda_codec *codec,
+                                  struct hda_multi_out *mout);
 int snd_hda_multi_out_analog_open(struct hda_codec *codec,
                                  struct hda_multi_out *mout,
                                  struct snd_pcm_substream *substream,
diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c
index 7ca66d654148..144b85276d5a 100644
--- a/sound/pci/hda/hda_proc.c
+++ b/sound/pci/hda/hda_proc.c
@@ -399,7 +399,8 @@ static void print_conn_list(struct snd_info_buffer *buffer,
 {
        int c, curr = -1;
-        if (conn_len > 1 && wid_type != AC_WID_AUD_MIX)
+        if (conn_len > 1 && wid_type != AC_WID_AUD_MIX &&
+            wid_type != AC_WID_VOL_KNB)
                curr = snd_hda_codec_read(codec, nid, 0,
                                          AC_VERB_GET_CONNECT_SEL, 0);
        snd_iprintf(buffer, "  Connection: %d\n", conn_len);
diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c
index 2e7371ec2e23..e48612323aa0 100644
--- a/sound/pci/hda/patch_analog.c
+++ b/sound/pci/hda/patch_analog.c
@@ -275,6 +275,14 @@ static int ad198x_dig_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
                                             format, substream);
 }
+static int ad198x_dig_playback_pcm_cleanup(struct hda_pcm_stream *hinfo,
+                                           struct hda_codec *codec,
+                                           struct snd_pcm_substream *substream)
+{
+        struct ad198x_spec *spec = codec->spec;
+        return snd_hda_multi_out_dig_cleanup(codec, &spec->multiout);
+}
 /*
 * Analog capture
 */
@@ -333,7 +341,8 @@ static struct hda_pcm_stream ad198x_pcm_digital_playback = {
        .ops = {
                .open = ad198x_dig_playback_pcm_open,
                .close = ad198x_dig_playback_pcm_close,
-                .prepare = ad198x_dig_playback_pcm_prepare
+                .prepare = ad198x_dig_playback_pcm_prepare,
+                .cleanup = ad198x_dig_playback_pcm_cleanup
        },
 };
@@ -1885,8 +1894,8 @@ static hda_nid_t ad1988_capsrc_nids[3] = {
 #define AD1988_SPDIF_OUT_HDMI   0x0b
 #define AD1988_SPDIF_IN         0x07
-static hda_nid_t ad1989b_slave_dig_outs[2] = {
+static hda_nid_t ad1989b_slave_dig_outs[] = {
-        AD1988_SPDIF_OUT, AD1988_SPDIF_OUT_HDMI
+        AD1988_SPDIF_OUT, AD1988_SPDIF_OUT_HDMI, 0
 };
 static struct hda_input_mux ad1988_6stack_capture_source = {
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 75de40aaab0a..0177ef8f4c9e 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -347,6 +347,7 @@ static int conexant_mux_enum_put(struct snd_kcontrol *kcontrol,
                                     &spec->cur_mux[adc_idx]);
 }
+#ifdef CONFIG_SND_JACK
 static int conexant_add_jack(struct hda_codec *codec,
                hda_nid_t nid, int type)
 {
@@ -394,7 +395,6 @@ static void conexant_report_jack(struct hda_codec *codec, hda_nid_t nid)
 static int conexant_init_jacks(struct hda_codec *codec)
 {
-#ifdef CONFIG_SND_JACK
        struct conexant_spec *spec = codec->spec;
        int i;
@@ -422,10 +422,19 @@ static int conexant_init_jacks(struct hda_codec *codec)
                        ++hv;
                }
        }
-#endif
        return 0;
 }
+#else
+static inline void conexant_report_jack(struct hda_codec *codec, hda_nid_t nid)
+{
+}
+static inline int conexant_init_jacks(struct hda_codec *codec)
+{
+        return 0;
+}
+#endif
 static int conexant_init(struct hda_codec *codec)
 {
@@ -1566,6 +1575,7 @@ static struct snd_pci_quirk cxt5047_cfg_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x30a5, "HP DV5200T/DV8000T", CXT5047_LAPTOP_HP),
        SND_PCI_QUIRK(0x103c, 0x30b2, "HP DV2000T/DV3000T", CXT5047_LAPTOP),
        SND_PCI_QUIRK(0x103c, 0x30b5, "HP DV2000Z", CXT5047_LAPTOP),
+        SND_PCI_QUIRK(0x103c, 0x30cf, "HP DV6700", CXT5047_LAPTOP),
        SND_PCI_QUIRK(0x1179, 0xff31, "Toshiba P100", CXT5047_LAPTOP_EAPD),
        {}
 };
diff --git a/sound/pci/hda/patch_intelhdmi.c b/sound/pci/hda/patch_intelhdmi.c
index 3564f4e4b74c..fcc77fec4487 100644
--- a/sound/pci/hda/patch_intelhdmi.c
+++ b/sound/pci/hda/patch_intelhdmi.c
@@ -49,11 +49,6 @@ static struct hda_verb pinout_enable_verb[] = {
        {} /* terminator */
 };
-static struct hda_verb pinout_disable_verb[] = {
-        {PIN_NID, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x00},
-        {}
-};
 static struct hda_verb unsolicited_response_verb[] = {
        {PIN_NID, AC_VERB_SET_UNSOLICITED_ENABLE, AC_USRSP_EN |
                                                  INTEL_HDMI_EVENT_TAG},
@@ -248,10 +243,6 @@ static void hdmi_write_dip_byte(struct hda_codec *codec, hda_nid_t nid,
 static void hdmi_enable_output(struct hda_codec *codec)
 {
-        /* Enable Audio InfoFrame Transmission */
-        hdmi_set_dip_index(codec, PIN_NID, 0x0, 0x0);
-        snd_hda_codec_write(codec, PIN_NID, 0, AC_VERB_SET_HDMI_DIP_XMIT,
-                                                AC_DIPXMIT_BEST);
        /* Unmute */
        if (get_wcaps(codec, PIN_NID) & AC_WCAP_OUT_AMP)
                snd_hda_codec_write(codec, PIN_NID, 0,
@@ -260,17 +251,24 @@ static void hdmi_enable_output(struct hda_codec *codec)
        snd_hda_sequence_write(codec, pinout_enable_verb);
 }
-static void hdmi_disable_output(struct hda_codec *codec)
+/*
+ * Enable Audio InfoFrame Transmission
+ */
+static void hdmi_start_infoframe_trans(struct hda_codec *codec)
 {
-        snd_hda_sequence_write(codec, pinout_disable_verb);
+        hdmi_set_dip_index(codec, PIN_NID, 0x0, 0x0);
-        if (get_wcaps(codec, PIN_NID) & AC_WCAP_OUT_AMP)
+        snd_hda_codec_write(codec, PIN_NID, 0, AC_VERB_SET_HDMI_DIP_XMIT,
-                snd_hda_codec_write(codec, PIN_NID, 0,
+                                                AC_DIPXMIT_BEST);
-                                AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_MUTE);
+}
-        /*
+/*
-         * FIXME: noises may arise when playing music after reloading the
+ * Disable Audio InfoFrame Transmission
-         * kernel module, until the next X restart or monitor repower.
+ */
-         */
+static void hdmi_stop_infoframe_trans(struct hda_codec *codec)
+{
+        hdmi_set_dip_index(codec, PIN_NID, 0x0, 0x0);
+        snd_hda_codec_write(codec, PIN_NID, 0, AC_VERB_SET_HDMI_DIP_XMIT,
+                                                AC_DIPXMIT_DISABLE);
 }
 static int hdmi_get_channel_count(struct hda_codec *codec)
@@ -368,11 +366,16 @@ static void hdmi_fill_audio_infoframe(struct hda_codec *codec,
                                        struct hdmi_audio_infoframe *ai)
 {
        u8 *params = (u8 *)ai;
+        u8 sum = 0;
        int i;
        hdmi_debug_dip_size(codec);
        hdmi_clear_dip_buffers(codec); /* be paranoid */
+        for (i = 0; i < sizeof(ai); i++)
+                sum += params[i];
+        ai->checksum = - sum;
        hdmi_set_dip_index(codec, PIN_NID, 0x0, 0x0);
        for (i = 0; i < sizeof(ai); i++)
                hdmi_write_dip_byte(codec, PIN_NID, params[i]);
@@ -419,14 +422,18 @@ static int hdmi_setup_channel_allocation(struct hda_codec *codec,
        /*
         * CA defaults to 0 for basic stereo audio
         */
-        if (!eld->eld_ver)
-                return 0;
-        if (!eld->spk_alloc)
-                return 0;
        if (channels <= 2)
                return 0;
        /*
+         * HDMI sink's ELD info cannot always be retrieved for now, e.g.
+         * in console or for audio devices. Assume the highest speakers
+         * configuration, to _not_ prohibit multi-channel audio playback.
+         */
+        if (!eld->spk_alloc)
+                eld->spk_alloc = 0xffff;
+        /*
         * expand ELD's speaker allocation mask
         *
         * ELD tells the speaker mask in a compact(paired) form,
@@ -485,6 +492,7 @@ static void hdmi_setup_audio_infoframe(struct hda_codec *codec,
        hdmi_setup_channel_mapping(codec, &ai);
        hdmi_fill_audio_infoframe(codec, &ai);
+        hdmi_start_infoframe_trans(codec);
 }
@@ -562,7 +570,7 @@ static int intel_hdmi_playback_pcm_close(struct hda_pcm_stream *hinfo,
 {
        struct intel_hdmi_spec *spec = codec->spec;
-        hdmi_disable_output(codec);
+        hdmi_stop_infoframe_trans(codec);
        return snd_hda_multi_out_dig_close(codec, &spec->multiout);
 }
@@ -582,8 +590,6 @@ static int intel_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
        hdmi_setup_audio_infoframe(codec, substream);
-        hdmi_enable_output(codec);
        return 0;
 }
@@ -628,8 +634,7 @@ static int intel_hdmi_build_controls(struct hda_codec *codec)
 static int intel_hdmi_init(struct hda_codec *codec)
 {
-        /* disable audio output as early as possible */
+        hdmi_enable_output(codec);
-        hdmi_disable_output(codec);
        snd_hda_sequence_write(codec, unsolicited_response_verb);
@@ -679,6 +684,7 @@ static struct hda_codec_preset snd_hda_preset_intelhdmi[] = {
        { .id = 0x80862801, .name = "G45 DEVBLC", .patch = patch_intel_hdmi },
        { .id = 0x80862802, .name = "G45 DEVCTG", .patch = patch_intel_hdmi },
        { .id = 0x80862803, .name = "G45 DEVELK", .patch = patch_intel_hdmi },
+        { .id = 0x80862804, .name = "G45 DEVIBX", .patch = patch_intel_hdmi },
        { .id = 0x10951392, .name = "SiI1392 HDMI",     .patch = patch_intel_hdmi },
        {} /* terminator */
 };
@@ -687,6 +693,7 @@ MODULE_ALIAS("snd-hda-codec-id:808629fb");
 MODULE_ALIAS("snd-hda-codec-id:80862801");
 MODULE_ALIAS("snd-hda-codec-id:80862802");
 MODULE_ALIAS("snd-hda-codec-id:80862803");
+MODULE_ALIAS("snd-hda-codec-id:80862804");
 MODULE_ALIAS("snd-hda-codec-id:10951392");
 MODULE_LICENSE("GPL");
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 5d249a547fbf..6c26afcb8262 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -1037,6 +1037,7 @@ do_sku:
                case 0x10ec0267:
                case 0x10ec0268:
                case 0x10ec0269:
+                case 0x10ec0272:
                case 0x10ec0660:
                case 0x10ec0662:
                case 0x10ec0663:
@@ -1065,6 +1066,7 @@ do_sku:
                case 0x10ec0882:
                case 0x10ec0883:
                case 0x10ec0885:
+                case 0x10ec0887:
                case 0x10ec0889:
                        snd_hda_codec_write(codec, 0x20, 0,
                                            AC_VERB_SET_COEF_INDEX, 7);
@@ -7012,12 +7014,15 @@ static int patch_alc882(struct hda_codec *codec)
                        break;
                case 0x106b1000: /* iMac 24 */
                case 0x106b2800: /* AppleTV */
+                case 0x106b3e00: /* iMac 24 Aluminium */
                        board_config = ALC885_IMAC24;
                        break;
+                case 0x106b00a0: /* MacBookPro3,1 - Another revision */
                case 0x106b00a1: /* Macbook (might be wrong - PCI SSID?) */
                case 0x106b00a4: /* MacbookPro4,1 */
                case 0x106b2c00: /* Macbook Pro rev3 */
                case 0x106b3600: /* Macbook 3.1 */
+                case 0x106b3800: /* MacbookPro4,1 - latter revision */
                        board_config = ALC885_MBP3;
                        break;
                default:
@@ -8465,6 +8470,8 @@ static struct snd_pci_quirk alc883_cfg_tbl[] = {
                ALC888_ACER_ASPIRE_4930G),
        SND_PCI_QUIRK(0x1025, 0x015e, "Acer Aspire 6930G",
                ALC888_ACER_ASPIRE_4930G),
+        SND_PCI_QUIRK(0x1025, 0x0166, "Acer Aspire 6530G",
+                ALC888_ACER_ASPIRE_4930G),
        SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER), /* default Acer */
        SND_PCI_QUIRK(0x1028, 0x020d, "Dell Inspiron 530", ALC888_6ST_DELL),
        SND_PCI_QUIRK(0x103c, 0x2a3d, "HP Pavillion", ALC883_6ST_DIG),
@@ -8474,6 +8481,7 @@ static struct snd_pci_quirk alc883_cfg_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x2a66, "HP Acacia", ALC888_3ST_HP),
        SND_PCI_QUIRK(0x1043, 0x1873, "Asus M90V", ALC888_ASUS_M90V),
        SND_PCI_QUIRK(0x1043, 0x8249, "Asus M2A-VM HDMI", ALC883_3ST_6ch_DIG),
+        SND_PCI_QUIRK(0x1043, 0x8284, "Asus Z37E", ALC883_6ST_DIG),
        SND_PCI_QUIRK(0x1043, 0x82fe, "Asus P5Q-EM HDMI", ALC1200_ASUS_P5Q),
        SND_PCI_QUIRK(0x1043, 0x835f, "Asus Eee 1601", ALC888_ASUS_EEE1601),
        SND_PCI_QUIRK(0x105b, 0x0ce8, "Foxconn P35AX-S", ALC883_6ST_DIG),
@@ -8513,6 +8521,8 @@ static struct snd_pci_quirk alc883_cfg_tbl[] = {
        SND_PCI_QUIRK(0x1558, 0, "Clevo laptop", ALC883_LAPTOP_EAPD),
        SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch),
        SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION),
+        SND_PCI_QUIRK(0x1734, 0x1107, "FSC AMILO Xi2550",
+                      ALC883_FUJITSU_PI2515),
        SND_PCI_QUIRK(0x1734, 0x1108, "Fujitsu AMILO Pi2515", ALC883_FUJITSU_PI2515),
        SND_PCI_QUIRK(0x1734, 0x113d, "Fujitsu AMILO Xa3530",
                ALC888_FUJITSU_XA3530),
@@ -10547,6 +10557,7 @@ static struct snd_pci_quirk alc262_cfg_tbl[] = {
        SND_PCI_QUIRK(0x103c, 0x1309, "HP xw4*00", ALC262_HP_BPC),
        SND_PCI_QUIRK(0x103c, 0x130a, "HP xw6*00", ALC262_HP_BPC),
        SND_PCI_QUIRK(0x103c, 0x130b, "HP xw8*00", ALC262_HP_BPC),
+        SND_PCI_QUIRK(0x103c, 0x170b, "HP xw*", ALC262_HP_BPC),
        SND_PCI_QUIRK(0x103c, 0x2800, "HP D7000", ALC262_HP_BPC_D7000_WL),
        SND_PCI_QUIRK(0x103c, 0x2801, "HP D7000", ALC262_HP_BPC_D7000_WF),
        SND_PCI_QUIRK(0x103c, 0x2802, "HP D7000", ALC262_HP_BPC_D7000_WL),
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 3dd4eee70b7c..6094344fb223 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -1207,7 +1207,7 @@ static const char *slave_vols[] = {
        "LFE Playback Volume",
        "Side Playback Volume",
        "Headphone Playback Volume",
-        "Headphone Playback Volume",
+        "Headphone2 Playback Volume",
        "Speaker Playback Volume",
        "External Speaker Playback Volume",
        "Speaker2 Playback Volume",
@@ -1221,7 +1221,7 @@ static const char *slave_sws[] = {
        "LFE Playback Switch",
        "Side Playback Switch",
        "Headphone Playback Switch",
-        "Headphone Playback Switch",
+        "Headphone2 Playback Switch",
        "Speaker Playback Switch",
        "External Speaker Playback Switch",
        "Speaker2 Playback Switch",
@@ -1799,11 +1799,13 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = {
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f2,
                      "HP dv5", STAC_HP_M4),
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f4,
-                      "HP dv7", STAC_HP_M4),
+                      "HP dv7", STAC_HP_DV5),
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30f7,
                      "HP dv4", STAC_HP_DV5),
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
                      "HP dv7", STAC_HP_M4),
+        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3600,
+                      "HP dv5", STAC_HP_DV5),
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x3603,
                      "HP dv5", STAC_HP_DV5),
        SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x361a,
@@ -2440,6 +2442,14 @@ static int stac92xx_dig_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
                                             stream_tag, format, substream);
 }
+static int stac92xx_dig_playback_pcm_cleanup(struct hda_pcm_stream *hinfo,
+                                        struct hda_codec *codec,
+                                        struct snd_pcm_substream *substream)
+{
+        struct sigmatel_spec *spec = codec->spec;
+        return snd_hda_multi_out_dig_cleanup(codec, &spec->multiout);
+}
 /*
 * Analog capture callbacks
@@ -2484,7 +2494,8 @@ static struct hda_pcm_stream stac92xx_pcm_digital_playback = {
        .ops = {
                .open = stac92xx_dig_playback_pcm_open,
                .close = stac92xx_dig_playback_pcm_close,
-                .prepare = stac92xx_dig_playback_pcm_prepare
+                .prepare = stac92xx_dig_playback_pcm_prepare,
+                .cleanup = stac92xx_dig_playback_pcm_cleanup
        },
 };
@@ -2539,6 +2550,8 @@ static int stac92xx_build_pcms(struct hda_codec *codec)
        info->name = "STAC92xx Analog";
        info->stream[SNDRV_PCM_STREAM_PLAYBACK] = stac92xx_pcm_analog_playback;
+        info->stream[SNDRV_PCM_STREAM_PLAYBACK].nid =
+                spec->multiout.dac_nids[0];
        info->stream[SNDRV_PCM_STREAM_CAPTURE] = stac92xx_pcm_analog_capture;
        info->stream[SNDRV_PCM_STREAM_CAPTURE].nid = spec->adc_nids[0];
        info->stream[SNDRV_PCM_STREAM_CAPTURE].substreams = spec->num_adcs;
@@ -3503,6 +3516,7 @@ static int stac92xx_parse_auto_config(struct hda_codec *codec, hda_nid_t dig_out
        if (! spec->autocfg.line_outs)
                return 0; /* can't find valid pin config */
+#if 0 /* FIXME: temporarily disabled */
        /* If we have no real line-out pin and multiple hp-outs, HPs should
         * be set up as multi-channel outputs.
         */
@@ -3522,6 +3536,7 @@ static int stac92xx_parse_auto_config(struct hda_codec *codec, hda_nid_t dig_out
                spec->autocfg.line_out_type = AUTO_PIN_HP_OUT;
                spec->autocfg.hp_outs = 0;
        }
+#endif /* FIXME: temporarily disabled */
        if (spec->autocfg.mono_out_pin) {
                int dir = get_wcaps(codec, spec->autocfg.mono_out_pin) &
                        (AC_WCAP_OUT_AMP | AC_WCAP_IN_AMP);
@@ -4976,7 +4991,7 @@ again:
        case STAC_DELL_M4_3:
                spec->num_dmics = 1;
                spec->num_smuxes = 0;
-                spec->num_dmuxes = 0;
+                spec->num_dmuxes = 1;
                break;
        default:
                spec->num_dmics = STAC92HD71BXX_NUM_DMICS;
diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 58d7cda03de5..bab1c700f497 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -2648,9 +2648,9 @@ static int __devinit snd_ice1712_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "ICE1712");
        strcpy(card->shortname, "ICEnsemble ICE1712");
diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c
index bb8d8c766b9d..7ff36d3f0f44 100644
--- a/sound/pci/ice1712/ice1724.c
+++ b/sound/pci/ice1712/ice1724.c
@@ -2456,9 +2456,9 @@ static int __devinit snd_vt1724_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "ICE1724");
        strcpy(card->shortname, "ICEnsemble ICE1724");
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index 19d3391e229f..608655e9275e 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -617,7 +617,7 @@ static int snd_intel8x0_ali_codec_semaphore(struct intel8x0 *chip)
        int time = 100;
        if (chip->buggy_semaphore)
                return 0; /* just ignore ... */
-        while (time-- && (igetdword(chip, ICHREG(ALI_CAS)) & ALI_CAS_SEM_BUSY))
+        while (--time && (igetdword(chip, ICHREG(ALI_CAS)) & ALI_CAS_SEM_BUSY))
                udelay(1);
        if (! time && ! chip->in_ac97_init)
                snd_printk(KERN_WARNING "ali_codec_semaphore timeout\n");
@@ -3058,9 +3058,9 @@ static int __devinit snd_intel8x0_probe(struct pci_dev *pci,
        int err;
        struct shortname_table *name;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if (spdif_aclink < 0)
                spdif_aclink = check_default_spdif_aclink(pci);
diff --git a/sound/pci/intel8x0m.c b/sound/pci/intel8x0m.c
index 93449e464566..33a843c19316 100644
--- a/sound/pci/intel8x0m.c
+++ b/sound/pci/intel8x0m.c
@@ -1269,9 +1269,9 @@ static int __devinit snd_intel8x0m_probe(struct pci_dev *pci,
        int err;
        struct shortname_table *name;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "ICH-MODEM");
        strcpy(card->shortname, "Intel ICH");
diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c
index 5f8006b42750..8b79969034be 100644
--- a/sound/pci/korg1212/korg1212.c
+++ b/sound/pci/korg1212/korg1212.c
@@ -2443,9 +2443,9 @@ snd_korg1212_probe(struct pci_dev *pci,
                dev++;
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_korg1212_create(card, pci, &korg1212)) < 0) {
                snd_card_free(card);
diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
index 59bbaf8f3e5b..70141548f251 100644
--- a/sound/pci/maestro3.c
+++ b/sound/pci/maestro3.c
@@ -2691,9 +2691,9 @@ snd_m3_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        switch (pci->device) {
        case PCI_DEVICE_ID_ESS_ALLEGRO:
diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
index f23a73577c22..c1eb84a14c42 100644
--- a/sound/pci/mixart/mixart.c
+++ b/sound/pci/mixart/mixart.c
@@ -607,6 +607,7 @@ static int snd_mixart_hw_params(struct snd_pcm_substream *subs,
        /* set the format to the board */
        err = mixart_set_format(stream, format);
        if(err < 0) {
+                mutex_unlock(&mgr->setup_mutex);
                return err;
        }
@@ -1365,12 +1366,12 @@ static int __devinit snd_mixart_probe(struct pci_dev *pci,
                else
                        idx = index[dev] + i;
                snprintf(tmpid, sizeof(tmpid), "%s-%d", id[dev] ? id[dev] : "MIXART", i);
-                card = snd_card_new(idx, tmpid, THIS_MODULE, 0);
+                err = snd_card_create(idx, tmpid, THIS_MODULE, 0, &card);
-                if (! card) {
+                if (err < 0) {
                        snd_printk(KERN_ERR "cannot allocate the card %d\n", i);
                        snd_mixart_free(mgr);
-                        return -ENOMEM;
+                        return err;
                }
                strcpy(card->driver, CARD_NAME);
diff --git a/sound/pci/mixart/mixart_hwdep.c b/sound/pci/mixart/mixart_hwdep.c
index dda562081d7e..4cf4cd8c939c 100644
--- a/sound/pci/mixart/mixart_hwdep.c
+++ b/sound/pci/mixart/mixart_hwdep.c
@@ -587,16 +587,6 @@ MODULE_FIRMWARE("mixart/miXart8AES.xlx");
 /* miXart hwdep interface id string */
 #define SND_MIXART_HWDEP_ID       "miXart Loader"
-static int mixart_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-static int mixart_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
 static int mixart_hwdep_dsp_status(struct snd_hwdep *hw,
                                   struct snd_hwdep_dsp_status *info)
 {
@@ -649,8 +639,6 @@ int snd_mixart_setup_firmware(struct mixart_mgr *mgr)
        hw->iface = SNDRV_HWDEP_IFACE_MIXART;
        hw->private_data = mgr;
-        hw->ops.open = mixart_hwdep_open;
-        hw->ops.release = mixart_hwdep_release;
        hw->ops.dsp_status = mixart_hwdep_dsp_status;
        hw->ops.dsp_load = mixart_hwdep_dsp_load;
        hw->exclusive = 1;
diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index 50c9f8a05082..522a040855d4 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -1668,9 +1668,9 @@ static int __devinit snd_nm256_probe(struct pci_dev *pci,
                }
        }
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        switch (pci->device) {
        case PCI_DEVICE_ID_NEOMAGIC_NM256AV_AUDIO:
diff --git a/sound/pci/oxygen/oxygen_lib.c b/sound/pci/oxygen/oxygen_lib.c
index 84f481d41efa..9c81e0b05113 100644
--- a/sound/pci/oxygen/oxygen_lib.c
+++ b/sound/pci/oxygen/oxygen_lib.c
@@ -459,10 +459,10 @@ int oxygen_pci_probe(struct pci_dev *pci, int index, char *id,
        struct oxygen *chip;
        int err;
-        card = snd_card_new(index, id, model->owner,
+        err = snd_card_create(index, id, model->owner,
-                            sizeof *chip + model->model_data_size);
+                              sizeof(*chip) + model->model_data_size, &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        chip = card->private_data;
        chip->card = card;
diff --git a/sound/pci/oxygen/virtuoso.c b/sound/pci/oxygen/virtuoso.c
index 18c7c91786bc..6c870c12a177 100644
--- a/sound/pci/oxygen/virtuoso.c
+++ b/sound/pci/oxygen/virtuoso.c
@@ -26,7 +26,7 @@
 * SPI 0 -> 1st PCM1796 (front)
 * SPI 1 -> 2nd PCM1796 (surround)
 * SPI 2 -> 3rd PCM1796 (center/LFE)
- * SPI 4 -> 4th PCM1796 (back) and EEPROM self-destruct (do not use!)
+ * SPI 4 -> 4th PCM1796 (back)
 *
 * GPIO 2 -> M0 of CS5381
 * GPIO 3 -> M1 of CS5381
@@ -207,12 +207,6 @@ static void xonar_gpio_changed(struct oxygen *chip);
 static inline void pcm1796_write_spi(struct oxygen *chip, unsigned int codec,
                                     u8 reg, u8 value)
 {
-        /*
-         * We don't want to do writes on SPI 4 because the EEPROM, which shares
-         * the same pin, might get confused and broken.  We'd better take care
-         * that the driver works with the default register values ...
-         */
-#if 0
        /* maps ALSA channel pair number to SPI output */
        static const u8 codec_map[4] = {
                0, 1, 2, 4
@@ -223,7 +217,6 @@ static inline void pcm1796_write_spi(struct oxygen *chip, unsigned int codec,
                         (codec_map[codec] << OXYGEN_SPI_CODEC_SHIFT) |
                         OXYGEN_SPI_CEN_LATCH_CLOCK_HI,
                         (reg << 8) | value);
-#endif
 }
 static inline void pcm1796_write_i2c(struct oxygen *chip, unsigned int codec,
@@ -757,9 +750,6 @@ static const DECLARE_TLV_DB_SCALE(cs4362a_db_scale, -12700, 100, 0);
 static int xonar_d2_control_filter(struct snd_kcontrol_new *template)
 {
-        if (!strncmp(template->name, "Master Playback ", 16))
-                /* disable volume/mute because they would require SPI writes */
-                return 1;
        if (!strncmp(template->name, "CD Capture ", 11))
                /* CD in is actually connected to the video in pin */
                template->private_value ^= AC97_CD ^ AC97_VIDEO;
@@ -850,8 +840,9 @@ static const struct oxygen_model model_xonar_d2 = {
        .dac_volume_min = 0x0f,
        .dac_volume_max = 0xff,
        .misc_flags = OXYGEN_MISC_MIDI,
-        .function_flags = OXYGEN_FUNCTION_SPI,
+        .function_flags = OXYGEN_FUNCTION_SPI |
-        .dac_i2s_format = OXYGEN_I2S_FORMAT_I2S,
+                          OXYGEN_FUNCTION_ENABLE_SPI_4_5,
+        .dac_i2s_format = OXYGEN_I2S_FORMAT_LJUST,
        .adc_i2s_format = OXYGEN_I2S_FORMAT_LJUST,
 };
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index 27cf2c28d113..7f95459c8b1f 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -1510,12 +1510,12 @@ static int __devinit pcxhr_probe(struct pci_dev *pci,
                snprintf(tmpid, sizeof(tmpid), "%s-%d",
                         id[dev] ? id[dev] : card_name, i);
-                card = snd_card_new(idx, tmpid, THIS_MODULE, 0);
+                err = snd_card_create(idx, tmpid, THIS_MODULE, 0, &card);
-                if (! card) {
+                if (err < 0) {
                        snd_printk(KERN_ERR "cannot allocate the card %d\n", i);
                        pcxhr_free(mgr);
-                        return -ENOMEM;
+                        return err;
                }
                strcpy(card->driver, DRIVER_NAME);
diff --git a/sound/pci/pcxhr/pcxhr.h b/sound/pci/pcxhr/pcxhr.h
index 84131a916c92..69d87dee6995 100644
--- a/sound/pci/pcxhr/pcxhr.h
+++ b/sound/pci/pcxhr/pcxhr.h
@@ -97,12 +97,12 @@ struct pcxhr_mgr {
        int capture_chips;
        int fw_file_set;
        int firmware_num;
-        int is_hr_stereo:1;
+        unsigned int is_hr_stereo:1;
-        int board_has_aes1:1;   /* if 1 board has AES1 plug and SRC */
+        unsigned int board_has_aes1:1;  /* if 1 board has AES1 plug and SRC */
-        int board_has_analog:1; /* if 0 the board is digital only */
+        unsigned int board_has_analog:1; /* if 0 the board is digital only */
-        int board_has_mic:1;    /* if 1 the board has microphone input */
+        unsigned int board_has_mic:1; /* if 1 the board has microphone input */
-        int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
+        unsigned int board_aes_in_192k:1;/* if 1 the aes input plugs do support 192kHz */
-        int mono_capture:1;     /* if 1 the board does mono capture */
+        unsigned int mono_capture:1; /* if 1 the board does mono capture */
        struct snd_dma_buffer hostport;
diff --git a/sound/pci/pcxhr/pcxhr_hwdep.c b/sound/pci/pcxhr/pcxhr_hwdep.c
index 592743a298b0..17cb1233a903 100644
--- a/sound/pci/pcxhr/pcxhr_hwdep.c
+++ b/sound/pci/pcxhr/pcxhr_hwdep.c
@@ -471,16 +471,6 @@ static int pcxhr_hwdep_dsp_load(struct snd_hwdep *hw,
        return 0;
 }
-static int pcxhr_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-static int pcxhr_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
 int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
 {
        int err;
@@ -495,8 +485,6 @@ int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
        hw->iface = SNDRV_HWDEP_IFACE_PCXHR;
        hw->private_data = mgr;
-        hw->ops.open = pcxhr_hwdep_open;
-        hw->ops.release = pcxhr_hwdep_release;
        hw->ops.dsp_status = pcxhr_hwdep_dsp_status;
        hw->ops.dsp_load = pcxhr_hwdep_dsp_load;
        hw->exclusive = 1;
diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index 3caacfb9d8e0..6f1034417a02 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -2102,9 +2102,9 @@ snd_card_riptide_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_riptide_create(card, pci, &chip)) < 0) {
                snd_card_free(card);
                return err;
diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index e7ef3a1a25a8..d7b966e7c4cf 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -1941,9 +1941,10 @@ snd_rme32_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
                return -ENOENT;
        }
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct rme32))) == NULL)
+                              sizeof(struct rme32), &card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        card->private_free = snd_rme32_card_free;
        rme32 = (struct rme32 *) card->private_data;
        rme32->card = card;
diff --git a/sound/pci/rme96.c b/sound/pci/rme96.c
index 3fdd488d0975..55fb1c131f58 100644
--- a/sound/pci/rme96.c
+++ b/sound/pci/rme96.c
@@ -2348,9 +2348,10 @@ snd_rme96_probe(struct pci_dev *pci,
                dev++;
                return -ENOENT;
        }
-        if ((card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                                 sizeof(struct rme96))) == NULL)
+                              sizeof(struct rme96), &card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        card->private_free = snd_rme96_card_free;
        rme96 = (struct rme96 *)card->private_data;     
        rme96->card = card;
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index 44d0c15e2b71..bacfdd12619b 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -4413,13 +4413,6 @@ static int snd_hdsp_capture_release(struct snd_pcm_substream *substream)
        return 0;
 }
-static int snd_hdsp_hwdep_dummy_op(struct snd_hwdep *hw, struct file *file)
-{
-        /* we have nothing to initialize but the call is required */
-        return 0;
-}
 /* helper functions for copying meter values */
 static inline int copy_u32_le(void __user *dest, void __iomem *src)
 {
@@ -4738,9 +4731,7 @@ static int snd_hdsp_create_hwdep(struct snd_card *card, struct hdsp *hdsp)
        hw->private_data = hdsp;
        strcpy(hw->name, "HDSP hwdep interface");
-        hw->ops.open = snd_hdsp_hwdep_dummy_op;
        hw->ops.ioctl = snd_hdsp_hwdep_ioctl;
-        hw->ops.release = snd_hdsp_hwdep_dummy_op;
                
        return 0;
 }
@@ -5158,8 +5149,10 @@ static int __devinit snd_hdsp_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        if (!(card = snd_card_new(index[dev], id[dev], THIS_MODULE, sizeof(struct hdsp))))
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                return -ENOMEM;
+                              sizeof(struct hdsp), &card);
+        if (err < 0)
+                return err;
        hdsp = (struct hdsp *) card->private_data;
        card->private_free = snd_hdsp_card_free;
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c
index 71231cf1b2b0..bac2dc0c5d85 100644
--- a/sound/pci/rme9652/hdspm.c
+++ b/sound/pci/rme9652/hdspm.c
@@ -4100,13 +4100,6 @@ static int snd_hdspm_capture_release(struct snd_pcm_substream *substream)
        return 0;
 }
-static int snd_hdspm_hwdep_dummy_op(struct snd_hwdep * hw, struct file *file)
-{
-        /* we have nothing to initialize but the call is required */
-        return 0;
-}
 static int snd_hdspm_hwdep_ioctl(struct snd_hwdep * hw, struct file *file,
                                 unsigned int cmd, unsigned long arg)
 {
@@ -4213,9 +4206,7 @@ static int __devinit snd_hdspm_create_hwdep(struct snd_card *card,
        hw->private_data = hdspm;
        strcpy(hw->name, "HDSPM hwdep interface");
-        hw->ops.open = snd_hdspm_hwdep_dummy_op;
        hw->ops.ioctl = snd_hdspm_hwdep_ioctl;
-        hw->ops.release = snd_hdspm_hwdep_dummy_op;
        return 0;
 }
@@ -4503,10 +4494,10 @@ static int __devinit snd_hdspm_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev],
+        err = snd_card_create(index[dev], id[dev],
-                            THIS_MODULE, sizeof(struct hdspm));
+                              THIS_MODULE, sizeof(struct hdspm), &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        hdspm = card->private_data;
        card->private_free = snd_hdspm_card_free;
diff --git a/sound/pci/rme9652/rme9652.c b/sound/pci/rme9652/rme9652.c
index 2570907134d7..bc539abb2105 100644
--- a/sound/pci/rme9652/rme9652.c
+++ b/sound/pci/rme9652/rme9652.c
@@ -2594,11 +2594,11 @@ static int __devinit snd_rme9652_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_rme9652));
+                              sizeof(struct snd_rme9652), &card);
-        if (!card)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        rme9652 = (struct snd_rme9652 *) card->private_data;
        card->private_free = snd_rme9652_card_free;
diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c
index df2007e3be7c..baf6d8e3dabc 100644
--- a/sound/pci/sis7019.c
+++ b/sound/pci/sis7019.c
@@ -1387,9 +1387,8 @@ static int __devinit snd_sis7019_probe(struct pci_dev *pci,
        if (!enable)
                goto error_out;
-        rc = -ENOMEM;
+        rc = snd_card_create(index, id, THIS_MODULE, sizeof(*sis), &card);
-        card = snd_card_new(index, id, THIS_MODULE, sizeof(*sis));
+        if (rc < 0)
-        if (!card)
                goto error_out;
        strcpy(card->driver, "SiS7019");
diff --git a/sound/pci/sonicvibes.c b/sound/pci/sonicvibes.c
index e922b1887b1d..d989215f3556 100644
--- a/sound/pci/sonicvibes.c
+++ b/sound/pci/sonicvibes.c
@@ -1458,9 +1458,9 @@ static int __devinit snd_sonic_probe(struct pci_dev *pci,
                return -ENOENT;
        }
 
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        for (idx = 0; idx < 5; idx++) {
                if (pci_resource_start(pci, idx) == 0 ||
                    !(pci_resource_flags(pci, idx) & IORESOURCE_IO)) {
diff --git a/sound/pci/trident/trident.c b/sound/pci/trident/trident.c
index d94b16ffb385..21cef97d478d 100644
--- a/sound/pci/trident/trident.c
+++ b/sound/pci/trident/trident.c
@@ -89,9 +89,9 @@ static int __devinit snd_trident_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_trident_create(card, pci,
                                      pcm_channels[dev],
diff --git a/sound/pci/via82xx.c b/sound/pci/via82xx.c
index a027896a220f..809b233dd4a3 100644
--- a/sound/pci/via82xx.c
+++ b/sound/pci/via82xx.c
@@ -2436,9 +2436,9 @@ static int __devinit snd_via82xx_probe(struct pci_dev *pci,
        unsigned int i;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        card_type = pci_id->driver_data;
        switch (card_type) {
diff --git a/sound/pci/via82xx_modem.c b/sound/pci/via82xx_modem.c
index c0d9cc9dad44..0d54e3503c1e 100644
--- a/sound/pci/via82xx_modem.c
+++ b/sound/pci/via82xx_modem.c
@@ -1170,9 +1170,9 @@ static int __devinit snd_via82xx_probe(struct pci_dev *pci,
        unsigned int i;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        card_type = pci_id->driver_data;
        switch (card_type) {
diff --git a/sound/pci/vx222/vx222.c b/sound/pci/vx222/vx222.c
index acc352f4a441..fc9136c3e0d7 100644
--- a/sound/pci/vx222/vx222.c
+++ b/sound/pci/vx222/vx222.c
@@ -204,9 +204,9 @@ static int __devinit snd_vx222_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        switch ((int)pci_id->driver_data) {
        case VX_PCI_VX222_OLD:
diff --git a/sound/pci/ymfpci/ymfpci.c b/sound/pci/ymfpci/ymfpci.c
index 2631a554845e..4af66661f9b0 100644
--- a/sound/pci/ymfpci/ymfpci.c
+++ b/sound/pci/ymfpci/ymfpci.c
@@ -187,9 +187,9 @@ static int __devinit snd_card_ymfpci_probe(struct pci_dev *pci,
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, 0);
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        switch (pci_id->device) {
        case 0x0004: str = "YMF724";  model = "DS-1"; break;
diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c
index 819aaaac432f..7dea74b71cf1 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf.c
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c
@@ -91,7 +91,7 @@ static int snd_pdacf_dev_free(struct snd_device *device)
 */
 static int snd_pdacf_probe(struct pcmcia_device *link)
 {
-        int i;
+        int i, err;
        struct snd_pdacf *pdacf;
        struct snd_card *card;
        static struct snd_device_ops ops = {
@@ -112,20 +112,23 @@ static int snd_pdacf_probe(struct pcmcia_device *link)
                return -ENODEV; /* disabled explicitly */
        /* ok, create a card instance */
-        card = snd_card_new(index[i], id[i], THIS_MODULE, 0);
+        err = snd_card_create(index[i], id[i], THIS_MODULE, 0, &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printk(KERN_ERR "pdacf: cannot create a card instance\n");
-                return -ENOMEM;
+                return err;
        }
        pdacf = snd_pdacf_create(card);
-        if (! pdacf)
+        if (!pdacf) {
-                return -EIO;
+                snd_card_free(card);
+                return -ENOMEM;
+        }
-        if (snd_device_new(card, SNDRV_DEV_LOWLEVEL, pdacf, &ops) < 0) {
+        err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, pdacf, &ops);
+        if (err < 0) {
                kfree(pdacf);
                snd_card_free(card);
-                return -ENODEV;
+                return err;
        }
        snd_card_set_dev(card, &handle_to_dev(link));
diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
index 706602a40600..7445cc8a47d3 100644
--- a/sound/pcmcia/vx/vxpocket.c
+++ b/sound/pcmcia/vx/vxpocket.c
@@ -130,23 +130,26 @@ static struct snd_vx_hardware vxp440_hw = {
 /*
 * create vxpocket instance
 */
-static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl,
+static int snd_vxpocket_new(struct snd_card *card, int ibl,
-                                             struct pcmcia_device *link)
+                            struct pcmcia_device *link,
+                            struct snd_vxpocket **chip_ret)
 {
        struct vx_core *chip;
        struct snd_vxpocket *vxp;
        static struct snd_device_ops ops = {
                .dev_free =     snd_vxpocket_dev_free,
        };
+        int err;
        chip = snd_vx_create(card, &vxpocket_hw, &snd_vxpocket_ops,
                             sizeof(struct snd_vxpocket) - sizeof(struct vx_core));
-        if (! chip)
+        if (!chip)
-                return NULL;
+                return -ENOMEM;
-        if (snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops) < 0) {
+        err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, chip, &ops);
+        if (err < 0) {
                kfree(chip);
-                return NULL;
+                return err;
        }
        chip->ibl.size = ibl;
@@ -169,7 +172,8 @@ static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl,
        link->conf.ConfigIndex = 1;
        link->conf.Present = PRESENT_OPTION;
-        return vxp;
+        *chip_ret = vxp;
+        return 0;
 }
@@ -292,7 +296,7 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
 {
        struct snd_card *card;
        struct snd_vxpocket *vxp;
-        int i;
+        int i, err;
        /* find an empty slot from the card list */
        for (i = 0; i < SNDRV_CARDS; i++) {
@@ -307,16 +311,16 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
                return -ENODEV; /* disabled explicitly */
        /* ok, create a card instance */
-        card = snd_card_new(index[i], id[i], THIS_MODULE, 0);
+        err = snd_card_create(index[i], id[i], THIS_MODULE, 0, &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printk(KERN_ERR "vxpocket: cannot create a card instance\n");
-                return -ENOMEM;
+                return err;
        }
-        vxp = snd_vxpocket_new(card, ibl[i], p_dev);
+        err = snd_vxpocket_new(card, ibl[i], p_dev, &vxp);
-        if (! vxp) {
+        if (err < 0) {
                snd_card_free(card);
-                return -ENODEV;
+                return err;
        }
        card->private_data = vxp;
diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c
index c936225771ba..2e18ed0ea899 100644
--- a/sound/ppc/powermac.c
+++ b/sound/ppc/powermac.c
@@ -58,9 +58,9 @@ static int __init snd_pmac_probe(struct platform_device *devptr)
        char *name_ext;
        int err;
-        card = snd_card_new(index, id, THIS_MODULE, 0);
+        err = snd_card_create(index, id, THIS_MODULE, 0, &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        if ((err = snd_pmac_new(card, &chip)) < 0)
                goto __error;
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index ff321110ec02..f361c26506aa 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -969,11 +969,9 @@ static int __init snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
        }
        /* create card instance */
-        the_card.card = snd_card_new(index, id, THIS_MODULE, 0);
+        ret = snd_card_create(index, id, THIS_MODULE, 0, &the_card.card);
-        if (!the_card.card) {
+        if (ret < 0)
-                ret = -ENXIO;
                goto clean_irq;
-        }
        strcpy(the_card.card->driver, "PS3");
        strcpy(the_card.card->shortname, "PS3");
diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 7c920f3e7fe3..f551233c5a08 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -609,11 +609,11 @@ static int __devinit snd_aica_probe(struct platform_device *devptr)
        dreamcastcard = kmalloc(sizeof(struct snd_card_aica), GFP_KERNEL);
        if (unlikely(!dreamcastcard))
                return -ENOMEM;
-        dreamcastcard->card =
+        err = snd_card_create(index, SND_AICA_DRIVER, THIS_MODULE, 0,
-            snd_card_new(index, SND_AICA_DRIVER, THIS_MODULE, 0);
+                              &dreamcastcard->card);
-        if (unlikely(!dreamcastcard->card)) {
+        if (unlikely(err < 0)) {
                kfree(dreamcastcard);
-                return -ENODEV;
+                return err;
        }
        strcpy(dreamcastcard->card->driver, "snd_aica");
        strcpy(dreamcastcard->card->shortname, SND_AICA_DRIVER);
diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
index c5d67900d666..ff0054b76502 100644
--- a/sound/soc/atmel/atmel_ssc_dai.c
+++ b/sound/soc/atmel/atmel_ssc_dai.c
@@ -10,7 +10,7 @@
 * Based on at91-ssc.c by
 * Frank Mandarino <fmandarino@endrelia.com>
 * Based on pxa2xx Platform drivers by
- * Liam Girdwood <liam.girdwood@wolfsonmicro.com>
+ * Liam Girdwood <lrg@slimlogic.co.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/sound/soc/atmel/atmel_ssc_dai.h b/sound/soc/atmel/atmel_ssc_dai.h
index a828746e8a2f..391135f9c6c1 100644
--- a/sound/soc/atmel/atmel_ssc_dai.h
+++ b/sound/soc/atmel/atmel_ssc_dai.h
@@ -10,7 +10,7 @@
 * Based on at91-ssc.c by
 * Frank Mandarino <fmandarino@endrelia.com>
 * Based on pxa2xx Platform drivers by
- * Liam Girdwood <liam.girdwood@wolfsonmicro.com>
+ * Liam Girdwood <lrg@slimlogic.co.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index b47a749c5ea2..aea0cb72d80a 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -165,10 +165,13 @@ static int snd_soc_dapm_put_volsw_aic3x(struct snd_kcontrol *kcontrol,
                                        struct snd_ctl_elem_value *ucontrol)
 {
        struct snd_soc_dapm_widget *widget = snd_kcontrol_chip(kcontrol);
-        int reg = kcontrol->private_value & 0xff;
+        struct soc_mixer_control *mc =
-        int shift = (kcontrol->private_value >> 8) & 0x0f;
+                (struct soc_mixer_control *)kcontrol->private_value;
-        int mask = (kcontrol->private_value >> 16) & 0xff;
+        unsigned int reg = mc->reg;
-        int invert = (kcontrol->private_value >> 24) & 0x01;
+        unsigned int shift = mc->shift;
+        int max = mc->max;
+        unsigned int mask = (1 << fls(max)) - 1;
+        unsigned int invert = mc->invert;
        unsigned short val, val_mask;
        int ret;
        struct snd_soc_dapm_path *path;
diff --git a/sound/soc/codecs/wm8350.c b/sound/soc/codecs/wm8350.c
index e3989d406f54..35d99750c383 100644
--- a/sound/soc/codecs/wm8350.c
+++ b/sound/soc/codecs/wm8350.c
@@ -3,7 +3,7 @@
 *
 * Copyright (C) 2007, 2008 Wolfson Microelectronics PLC.
 *
- * Author: Liam Girdwood <lg@opensource.wolfsonmicro.com>
+ * Author: Liam Girdwood <lrg@slimlogic.co.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index 6c21b50c9375..77620ab98756 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -1451,7 +1451,14 @@ static const struct snd_soc_dai wm8753_all_dai[] = {
 },
 };
-struct snd_soc_dai wm8753_dai[2];
+struct snd_soc_dai wm8753_dai[] = {
+        {
+                .name = "WM8753 DAI 0",
+        },
+        {
+                .name = "WM8753 DAI 1",
+        },
+};
 EXPORT_SYMBOL_GPL(wm8753_dai);
 static void wm8753_set_dai_mode(struct snd_soc_codec *codec, unsigned int mode)
diff --git a/sound/soc/codecs/wm8990.c b/sound/soc/codecs/wm8990.c
index 5b5afc144478..a5731faa150c 100644
--- a/sound/soc/codecs/wm8990.c
+++ b/sound/soc/codecs/wm8990.c
@@ -2,8 +2,7 @@
 * wm8990.c  --  WM8990 ALSA Soc Audio driver
 *
 * Copyright 2008 Wolfson Microelectronics PLC.
- * Author: Liam Girdwood
+ * Author: Liam Girdwood <lrg@slimlogic.co.uk>
- *         lg@opensource.wolfsonmicro.com or linux@wolfsonmicro.com
 *
 *  This program is free software; you can redistribute  it and/or modify it
 *  under  the terms of  the GNU General  Public License as published by the
@@ -177,7 +176,9 @@ static int wm899x_outpga_put_volsw_vu(struct snd_kcontrol *kcontrol,
        struct snd_ctl_elem_value *ucontrol)
 {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-        int reg = kcontrol->private_value & 0xff;
+        struct soc_mixer_control *mc =
+                (struct soc_mixer_control *)kcontrol->private_value;
+        int reg = mc->reg;
        int ret;
        u16 val;
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index ec5e18a78758..05dd5abcddf4 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -302,6 +302,10 @@ static int omap_mcbsp_dai_set_dai_fmt(struct snd_soc_dai *cpu_dai,
        regs->spcr1     |= RINTM(3);
        regs->rcr2      |= RFIG;
        regs->xcr2      |= XFIG;
+        if (cpu_is_omap2430() || cpu_is_omap34xx()) {
+                regs->xccr = DXENDLY(1) | XDMAEN;
+                regs->rccr = RFULL_CYCLE | RDMAEN;
+        }
        switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
        case SND_SOC_DAIFMT_I2S:
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index b0362dfd5b71..dd3bb2933762 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -175,9 +175,10 @@ static int omap_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
 {
        struct snd_pcm_runtime *runtime = substream->runtime;
        struct omap_runtime_data *prtd = runtime->private_data;
+        unsigned long flags;
        int ret = 0;
-        spin_lock_irq(&prtd->lock);
+        spin_lock_irqsave(&prtd->lock, flags);
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
        case SNDRV_PCM_TRIGGER_RESUME:
@@ -195,7 +196,7 @@ static int omap_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
        default:
                ret = -EINVAL;
        }
-        spin_unlock_irq(&prtd->lock);
+        spin_unlock_irqrestore(&prtd->lock, flags);
        return ret;
 }
diff --git a/sound/soc/omap/sdp3430.c b/sound/soc/omap/sdp3430.c
index ad97836818b1..e226fa75669c 100644
--- a/sound/soc/omap/sdp3430.c
+++ b/sound/soc/omap/sdp3430.c
@@ -91,7 +91,7 @@ static struct snd_soc_dai_link sdp3430_dai = {
 };
 /* Audio machine driver */
-static struct snd_soc_machine snd_soc_machine_sdp3430 = {
+static struct snd_soc_card snd_soc_sdp3430 = {
        .name = "SDP3430",
        .platform = &omap_soc_platform,
        .dai_link = &sdp3430_dai,
@@ -100,7 +100,7 @@ static struct snd_soc_machine snd_soc_machine_sdp3430 = {
 /* Audio subsystem */
 static struct snd_soc_device sdp3430_snd_devdata = {
-        .machine = &snd_soc_machine_sdp3430,
+        .card = &snd_soc_sdp3430,
        .codec_dev = &soc_codec_dev_twl4030,
 };
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 55fdb4abb179..637f0d1ea98e 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1311,17 +1311,17 @@ int snd_soc_new_pcms(struct snd_soc_device *socdev, int idx, const char *xid)
 {
        struct snd_soc_codec *codec = socdev->codec;
        struct snd_soc_card *card = socdev->card;
-        int ret = 0, i;
+        int ret, i;
        mutex_lock(&codec->mutex);
        /* register a sound card */
-        codec->card = snd_card_new(idx, xid, codec->owner, 0);
+        ret = snd_card_create(idx, xid, codec->owner, 0, &codec->card);
-        if (!codec->card) {
+        if (ret < 0) {
                printk(KERN_ERR "asoc: can't create sound card for codec %s\n",
                        codec->name);
                mutex_unlock(&codec->mutex);
-                return -ENODEV;
+                return ret;
        }
        codec->card->dev = socdev->dev;
@@ -1385,7 +1385,10 @@ int snd_soc_init_card(struct snd_soc_device *socdev)
        mutex_lock(&codec->mutex);
 #ifdef CONFIG_SND_SOC_AC97_BUS
-        if (ac97) {
+        /* Only instantiate AC97 if not already done by the adaptor
+         * for the generic AC97 subsystem.
+         */
+        if (ac97 && strcmp(codec->name, "AC97") != 0) {
                ret = soc_ac97_dev_register(codec);
                if (ret < 0) {
                        printk(KERN_ERR "asoc: AC97 device register failed\n");
diff --git a/sound/sparc/amd7930.c b/sound/sparc/amd7930.c
index 7cbc725934e5..574af56ba8a6 100644
--- a/sound/sparc/amd7930.c
+++ b/sound/sparc/amd7930.c
@@ -1019,9 +1019,10 @@ static int __devinit amd7930_sbus_probe(struct of_device *op, const struct of_de
                return -ENOENT;
        }
-        card = snd_card_new(index[dev_num], id[dev_num], THIS_MODULE, 0);
+        err = snd_card_create(index[dev_num], id[dev_num], THIS_MODULE, 0,
-        if (card == NULL)
+                              &card);
-                return -ENOMEM;
+        if (err < 0)
+                return err;
        strcpy(card->driver, "AMD7930");
        strcpy(card->shortname, "Sun AMD7930");
diff --git a/sound/sparc/cs4231.c b/sound/sparc/cs4231.c
index 41c387587474..7d93fa705ccf 100644
--- a/sound/sparc/cs4231.c
+++ b/sound/sparc/cs4231.c
@@ -1563,6 +1563,7 @@ static int __init cs4231_attach_begin(struct snd_card **rcard)
 {
        struct snd_card *card;
        struct snd_cs4231 *chip;
+        int err;
        *rcard = NULL;
@@ -1574,10 +1575,10 @@ static int __init cs4231_attach_begin(struct snd_card **rcard)
                return -ENOENT;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_cs4231));
+                              sizeof(struct snd_cs4231), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "CS4231");
        strcpy(card->shortname, "Sun CS4231");
diff --git a/sound/sparc/dbri.c b/sound/sparc/dbri.c
index 23ed6f04a718..af95ff1e126c 100644
--- a/sound/sparc/dbri.c
+++ b/sound/sparc/dbri.c
@@ -2612,10 +2612,10 @@ static int __devinit dbri_probe(struct of_device *op, const struct of_device_id
                return -ENODEV;
        }
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct snd_dbri));
+                              sizeof(struct snd_dbri), &card);
-        if (card == NULL)
+        if (err < 0)
-                return -ENOMEM;
+                return err;
        strcpy(card->driver, "DBRI");
        strcpy(card->shortname, "Sun DBRI");
diff --git a/sound/spi/at73c213.c b/sound/spi/at73c213.c
index 09802e8a6fb8..4c7b051f9d17 100644
--- a/sound/spi/at73c213.c
+++ b/sound/spi/at73c213.c
@@ -965,12 +965,11 @@ static int __devinit snd_at73c213_probe(struct spi_device *spi)
                return PTR_ERR(board->dac_clk);
        }
-        retval = -ENOMEM;
        /* Allocate "card" using some unused identifiers. */
        snprintf(id, sizeof id, "at73c213_%d", board->ssc_id);
-        card = snd_card_new(-1, id, THIS_MODULE, sizeof(struct snd_at73c213));
+        retval = snd_card_create(-1, id, THIS_MODULE,
-        if (!card)
+                                 sizeof(struct snd_at73c213), &card);
+        if (retval < 0)
                goto out;
        chip = card->private_data;
diff --git a/sound/synth/emux/emux_hwdep.c b/sound/synth/emux/emux_hwdep.c
index 0a5391436add..ff0b2a8fd25b 100644
--- a/sound/synth/emux/emux_hwdep.c
+++ b/sound/synth/emux/emux_hwdep.c
@@ -24,25 +24,6 @@
 #include <asm/uaccess.h>
 #include "emux_voice.h"
-/*
- * open the hwdep device
- */
-static int
-snd_emux_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-/*
- * close the device
- */
-static int
-snd_emux_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
 #define TMP_CLIENT_ID   0x1001
@@ -146,8 +127,6 @@ snd_emux_init_hwdep(struct snd_emux *emu)
        emu->hwdep = hw;
        strcpy(hw->name, SNDRV_EMUX_HWDEP_NAME);
        hw->iface = SNDRV_HWDEP_IFACE_EMUX_WAVETABLE;
-        hw->ops.open = snd_emux_hwdep_open;
-        hw->ops.release = snd_emux_hwdep_release;
        hw->ops.ioctl = snd_emux_hwdep_ioctl;
        hw->exclusive = 1;
        hw->private_data = emu;
diff --git a/sound/usb/caiaq/caiaq-device.c b/sound/usb/caiaq/caiaq-device.c
index 41c36b055f6b..09aed2363cc9 100644
--- a/sound/usb/caiaq/caiaq-device.c
+++ b/sound/usb/caiaq/caiaq-device.c
@@ -336,9 +336,10 @@ static void __devinit setup_card(struct snd_usb_caiaqdev *dev)
                log("Unable to set up control system (ret=%d)\n", ret);
 }
-static struct snd_card* create_card(struct usb_device* usb_dev)
+static int create_card(struct usb_device* usb_dev, struct snd_card **cardp)
 {
        int devnum;
+        int err;
        struct snd_card *card;
        struct snd_usb_caiaqdev *dev;
@@ -347,12 +348,12 @@ static struct snd_card* create_card(struct usb_device* usb_dev)
                        break;
        if (devnum >= SNDRV_CARDS)
-                return NULL;
+                return -ENODEV;
-        card = snd_card_new(index[devnum], id[devnum], THIS_MODULE, 
+        err = snd_card_create(index[devnum], id[devnum], THIS_MODULE, 
-                                        sizeof(struct snd_usb_caiaqdev));
+                              sizeof(struct snd_usb_caiaqdev), &card);
-        if (!card)
+        if (err < 0)
-                return NULL;
+                return err;
        dev = caiaqdev(card);
        dev->chip.dev = usb_dev;
@@ -362,7 +363,8 @@ static struct snd_card* create_card(struct usb_device* usb_dev)
        spin_lock_init(&dev->spinlock);
        snd_card_set_dev(card, &usb_dev->dev);
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int __devinit init_card(struct snd_usb_caiaqdev *dev)
@@ -441,10 +443,10 @@ static int __devinit snd_probe(struct usb_interface *intf,
        struct snd_card *card;
        struct usb_device *device = interface_to_usbdev(intf);
        
-        card = create_card(device);
+        ret = create_card(device, &card);
        
-        if (!card)
+        if (ret < 0)
-                return -ENOMEM;
+                return ret;
                        
        usb_set_intfdata(intf, card);
        ret = init_card(caiaqdev(card));
diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c
index c709b9563226..8f3cdb37a0ec 100644
--- a/sound/usb/usbaudio.c
+++ b/sound/usb/usbaudio.c
@@ -2524,7 +2524,6 @@ static int parse_audio_format_rates(struct snd_usb_audio *chip, struct audioform
                 * build the rate table and bitmap flags
                 */
                int r, idx;
-                unsigned int nonzero_rates = 0;
                fp->rate_table = kmalloc(sizeof(int) * nr_rates, GFP_KERNEL);
                if (fp->rate_table == NULL) {
@@ -2532,24 +2531,27 @@ static int parse_audio_format_rates(struct snd_usb_audio *chip, struct audioform
                        return -1;
                }
-                fp->nr_rates = nr_rates;
+                fp->nr_rates = 0;
-                fp->rate_min = fp->rate_max = combine_triple(&fmt[8]);
+                fp->rate_min = fp->rate_max = 0;
                for (r = 0, idx = offset + 1; r < nr_rates; r++, idx += 3) {
                        unsigned int rate = combine_triple(&fmt[idx]);
+                        if (!rate)
+                                continue;
                        /* C-Media CM6501 mislabels its 96 kHz altsetting */
                        if (rate == 48000 && nr_rates == 1 &&
-                            chip->usb_id == USB_ID(0x0d8c, 0x0201) &&
+                            (chip->usb_id == USB_ID(0x0d8c, 0x0201) ||
+                             chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
                            fp->altsetting == 5 && fp->maxpacksize == 392)
                                rate = 96000;
-                        fp->rate_table[r] = rate;
+                        fp->rate_table[fp->nr_rates] = rate;
-                        nonzero_rates |= rate;
+                        if (!fp->rate_min || rate < fp->rate_min)
-                        if (rate < fp->rate_min)
                                fp->rate_min = rate;
-                        else if (rate > fp->rate_max)
+                        if (!fp->rate_max || rate > fp->rate_max)
                                fp->rate_max = rate;
                        fp->rates |= snd_pcm_rate_to_rate_bit(rate);
+                        fp->nr_rates++;
                }
-                if (!nonzero_rates) {
+                if (!fp->nr_rates) {
                        hwc_debug("All rates were zero. Skipping format!\n");
                        return -1;
                }
@@ -2966,6 +2968,7 @@ static int create_fixed_stream_quirk(struct snd_usb_audio *chip,
                return -EINVAL;
        }
        alts = &iface->altsetting[fp->altset_idx];
+        fp->maxpacksize = le16_to_cpu(get_endpoint(alts, 0)->wMaxPacketSize);
        usb_set_interface(chip->dev, fp->iface, 0);
        init_usb_pitch(chip->dev, fp->iface, alts, fp);
        init_usb_sample_rate(chip->dev, fp->iface, alts, fp, fp->rate_max);
@@ -3463,10 +3466,10 @@ static int snd_usb_audio_create(struct usb_device *dev, int idx,
                return -ENXIO;
        }
-        card = snd_card_new(index[idx], id[idx], THIS_MODULE, 0);
+        err = snd_card_create(index[idx], id[idx], THIS_MODULE, 0, &card);
-        if (card == NULL) {
+        if (err < 0) {
                snd_printk(KERN_ERR "cannot create card instance %d\n", idx);
-                return -ENOMEM;
+                return err;
        }
        chip = kzalloc(sizeof(*chip), GFP_KERNEL);
diff --git a/sound/usb/usbmidi.c b/sound/usb/usbmidi.c
index 320641ab5be7..26bad373fe65 100644
--- a/sound/usb/usbmidi.c
+++ b/sound/usb/usbmidi.c
@@ -1625,6 +1625,7 @@ static int snd_usbmidi_create_endpoints_midiman(struct snd_usb_midi* umidi,
        }
        ep_info.out_ep = get_endpoint(hostif, 2)->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
+        ep_info.out_interval = 0;
        ep_info.out_cables = endpoint->out_cables & 0x5555;
        err = snd_usbmidi_out_endpoint_create(umidi, &ep_info, &umidi->endpoints[0]);
        if (err < 0)
diff --git a/sound/usb/usbmixer.c b/sound/usb/usbmixer.c
index 00397c8a765b..2bde79216fa5 100644
--- a/sound/usb/usbmixer.c
+++ b/sound/usb/usbmixer.c
@@ -78,7 +78,6 @@ struct usb_mixer_interface {
        /* Sound Blaster remote control stuff */
        const struct rc_config *rc_cfg;
-        unsigned long rc_hwdep_open;
        u32 rc_code;
        wait_queue_head_t rc_waitq;
        struct urb *rc_urb;
@@ -1797,24 +1796,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb)
        wake_up(&mixer->rc_waitq);
 }
-static int snd_usb_sbrc_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        struct usb_mixer_interface *mixer = hw->private_data;
-        if (test_and_set_bit(0, &mixer->rc_hwdep_open))
-                return -EBUSY;
-        return 0;
-}
-static int snd_usb_sbrc_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        struct usb_mixer_interface *mixer = hw->private_data;
-        clear_bit(0, &mixer->rc_hwdep_open);
-        smp_mb__after_clear_bit();
-        return 0;
-}
 static long snd_usb_sbrc_hwdep_read(struct snd_hwdep *hw, char __user *buf,
                                     long count, loff_t *offset)
 {
@@ -1867,9 +1848,8 @@ static int snd_usb_soundblaster_remote_init(struct usb_mixer_interface *mixer)
        hwdep->iface = SNDRV_HWDEP_IFACE_SB_RC;
        hwdep->private_data = mixer;
        hwdep->ops.read = snd_usb_sbrc_hwdep_read;
-        hwdep->ops.open = snd_usb_sbrc_hwdep_open;
-        hwdep->ops.release = snd_usb_sbrc_hwdep_release;
        hwdep->ops.poll = snd_usb_sbrc_hwdep_poll;
+        hwdep->exclusive = 1;
        mixer->rc_urb = usb_alloc_urb(0, GFP_KERNEL);
        if (!mixer->rc_urb)
diff --git a/sound/usb/usx2y/us122l.c b/sound/usb/usx2y/us122l.c
index 73e59f4403a4..98276aafefe6 100644
--- a/sound/usb/usx2y/us122l.c
+++ b/sound/usb/usx2y/us122l.c
@@ -478,19 +478,21 @@ static bool us122l_create_card(struct snd_card *card)
        return true;
 }
-static struct snd_card *usx2y_create_card(struct usb_device *device)
+static int usx2y_create_card(struct usb_device *device, struct snd_card **cardp)
 {
        int             dev;
        struct snd_card *card;
+        int err;
        for (dev = 0; dev < SNDRV_CARDS; ++dev)
                if (enable[dev] && !snd_us122l_card_used[dev])
                        break;
        if (dev >= SNDRV_CARDS)
-                return NULL;
+                return -ENODEV;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE,
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-                            sizeof(struct us122l));
+                              sizeof(struct us122l), &card);
-        if (!card)
+        if (err < 0)
-                return NULL;
+                return err;
        snd_us122l_card_used[US122L(card)->chip.index = dev] = 1;
        US122L(card)->chip.dev = device;
@@ -509,46 +511,57 @@ static struct snd_card *usx2y_create_card(struct usb_device *device)
                US122L(card)->chip.dev->devnum
                );
        snd_card_set_dev(card, &device->dev);
-        return card;
+        *cardp = card;
+        return 0;
 }
-static void *us122l_usb_probe(struct usb_interface *intf,
+static int us122l_usb_probe(struct usb_interface *intf,
-                              const struct usb_device_id *device_id)
+                            const struct usb_device_id *device_id,
+                            struct snd_card **cardp)
 {
        struct usb_device *device = interface_to_usbdev(intf);
-        struct snd_card *card = usx2y_create_card(device);
+        struct snd_card *card;
+        int err;
-        if (!card)
+        err = usx2y_create_card(device, &card);
-                return NULL;
+        if (err < 0)
+                return err;
-        if (!us122l_create_card(card) ||
+        if (!us122l_create_card(card)) {
-            snd_card_register(card) < 0) {
                snd_card_free(card);
-                return NULL;
+                return -EINVAL;
+        }
+        err = snd_card_register(card);
+        if (err < 0) {
+                snd_card_free(card);
+                return err;
        }
        usb_get_dev(device);
-        return card;
+        *cardp = card;
+        return 0;
 }
 static int snd_us122l_probe(struct usb_interface *intf,
                            const struct usb_device_id *id)
 {
        struct snd_card *card;
+        int err;
        snd_printdd(KERN_DEBUG"%p:%i\n",
                    intf, intf->cur_altsetting->desc.bInterfaceNumber);
        if (intf->cur_altsetting->desc.bInterfaceNumber != 1)
                return 0;
-        card = us122l_usb_probe(usb_get_intf(intf), id);
+        err = us122l_usb_probe(usb_get_intf(intf), id, &card);
+        if (err < 0) {
-        if (card) {
+                usb_put_intf(intf);
-                usb_set_intfdata(intf, card);
+                return err;
-                return 0;
        }
-        usb_put_intf(intf);
+        usb_set_intfdata(intf, card);
-        return -EIO;
+        return 0;
 }
 static void snd_us122l_disconnect(struct usb_interface *intf)
diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c
index fc650c800afc..4af8740db717 100644
--- a/sound/usb/usx2y/usX2Yhwdep.c
+++ b/sound/usb/usx2y/usX2Yhwdep.c
@@ -103,16 +103,6 @@ static unsigned int snd_us428ctls_poll(struct snd_hwdep *hw, struct file *file,
 }
-static int snd_usX2Y_hwdep_open(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
-static int snd_usX2Y_hwdep_release(struct snd_hwdep *hw, struct file *file)
-{
-        return 0;
-}
 static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw,
                                      struct snd_hwdep_dsp_status *info)
 {
@@ -264,8 +254,6 @@ int usX2Y_hwdep_new(struct snd_card *card, struct usb_device* device)
        hw->iface = SNDRV_HWDEP_IFACE_USX2Y;
        hw->private_data = usX2Y(card);
-        hw->ops.open = snd_usX2Y_hwdep_open;
-        hw->ops.release = snd_usX2Y_hwdep_release;
        hw->ops.dsp_status = snd_usX2Y_hwdep_dsp_status;
        hw->ops.dsp_load = snd_usX2Y_hwdep_dsp_load;
        hw->ops.mmap = snd_us428ctls_mmap;
diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c
index c545a02dee48..5ce0da23ee96 100644
--- a/sound/usb/usx2y/usbusx2y.c
+++ b/sound/usb/usx2y/usbusx2y.c
@@ -333,18 +333,21 @@ static struct usb_device_id snd_usX2Y_usb_id_table[] = {
        { /* terminator */ }
 };
-static struct snd_card *usX2Y_create_card(struct usb_device *device)
+static int usX2Y_create_card(struct usb_device *device, struct snd_card **cardp)
 {
        int             dev;
        struct snd_card *       card;
+        int err;
        for (dev = 0; dev < SNDRV_CARDS; ++dev)
                if (enable[dev] && !snd_usX2Y_card_used[dev])
                        break;
        if (dev >= SNDRV_CARDS)
-                return NULL;
+                return -ENODEV;
-        card = snd_card_new(index[dev], id[dev], THIS_MODULE, sizeof(struct usX2Ydev));
+        err = snd_card_create(index[dev], id[dev], THIS_MODULE,
-        if (!card)
+                              sizeof(struct usX2Ydev), &card);
-                return NULL;
+        if (err < 0)
+                return err;
        snd_usX2Y_card_used[usX2Y(card)->chip.index = dev] = 1;
        card->private_free = snd_usX2Y_card_private_free;
        usX2Y(card)->chip.dev = device;
@@ -362,26 +365,36 @@ static struct snd_card *usX2Y_create_card(struct usb_device *device)
                usX2Y(card)->chip.dev->bus->busnum, usX2Y(card)->chip.dev->devnum
                );
        snd_card_set_dev(card, &device->dev);
-        return card;
+        *cardp = card;
+        return 0;
 }
-static void *usX2Y_usb_probe(struct usb_device *device, struct usb_interface *intf, const struct usb_device_id *device_id)
+static int usX2Y_usb_probe(struct usb_device *device,
+                           struct usb_interface *intf,
+                           const struct usb_device_id *device_id,
+                           struct snd_card **cardp)
 {
        int             err;
        struct snd_card *       card;
+        *cardp = NULL;
        if (le16_to_cpu(device->descriptor.idVendor) != 0x1604 ||
            (le16_to_cpu(device->descriptor.idProduct) != USB_ID_US122 &&
             le16_to_cpu(device->descriptor.idProduct) != USB_ID_US224 &&
-             le16_to_cpu(device->descriptor.idProduct) != USB_ID_US428) ||
+             le16_to_cpu(device->descriptor.idProduct) != USB_ID_US428))
-            !(card = usX2Y_create_card(device)))
+                return -EINVAL;
-                return NULL;
+        err = usX2Y_create_card(device, &card);
+        if (err < 0)
+                return err;
        if ((err = usX2Y_hwdep_new(card, device)) < 0  ||
            (err = snd_card_register(card)) < 0) {
                snd_card_free(card);
-                return NULL;
+                return err;
        }
-        return card;
+        *cardp = card;
+        return 0;
 }
 /*
@@ -389,13 +402,14 @@ static void *usX2Y_usb_probe(struct usb_device *device, struct usb_interface *in
 */
 static int snd_usX2Y_probe(struct usb_interface *intf, const struct usb_device_id *id)
 {
-        void *chip;
+        struct snd_card *card;
-        chip = usX2Y_usb_probe(interface_to_usbdev(intf), intf, id);
+        int err;
-        if (chip) {
-                usb_set_intfdata(intf, chip);
+        err = usX2Y_usb_probe(interface_to_usbdev(intf), intf, id, &card);
-                return 0;
+        if (err < 0)
-        } else
+                return err;
-                return -EIO;
+        dev_set_drvdata(&intf->dev, card);
+        return 0;
 }
 static void snd_usX2Y_disconnect(struct usb_interface *intf)