4 files changed, 58 insertions, 126 deletions

diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c
index 77caf43a3109..adfdce7499d1 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf.c
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c
@@ -57,18 +57,12 @@ static struct snd_card *card_list[SNDRV_CARDS];
 /*
  * prototypes
  */
-static void pdacf_config(dev_link_t *link);
+static int pdacf_config(struct pcmcia_device *link);
 static void snd_pdacf_detach(struct pcmcia_device *p_dev);
 
-static void pdacf_release(dev_link_t *link)
+static void pdacf_release(struct pcmcia_device *link)
 {
-        if (link->state & DEV_CONFIG) {
-                /* release cs resources */
-                pcmcia_release_configuration(link->handle);
-                pcmcia_release_io(link->handle, &link->io);
-                pcmcia_release_irq(link->handle, &link->irq);
-                link->state &= ~DEV_CONFIG;
-        }
+        pcmcia_disable_device(link);
 }
 
 /*
@@ -76,7 +70,7 @@ static void pdacf_release(dev_link_t *link)
  */
 static int snd_pdacf_free(struct snd_pdacf *pdacf)
 {
-        dev_link_t *link = &pdacf->link;
+        struct pcmcia_device *link = pdacf->p_dev;
 
         pdacf_release(link);
 
@@ -96,10 +90,9 @@ static int snd_pdacf_dev_free(struct snd_device *device)
 /*
  * snd_pdacf_attach - attach callback for cs
  */
-static int snd_pdacf_attach(struct pcmcia_device *p_dev)
+static int snd_pdacf_probe(struct pcmcia_device *link)
 {
         int i;
-        dev_link_t *link;               /* Info for cardmgr */
         struct snd_pdacf *pdacf;
         struct snd_card *card;
         static struct snd_device_ops ops = {
@@ -139,7 +132,7 @@ static int snd_pdacf_attach(struct pcmcia_device *p_dev)
         pdacf->index = i;
         card_list[i] = card;
 
-        link = &pdacf->link;
+        pdacf->p_dev = link;
         link->priv = pdacf;
 
         link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
@@ -156,13 +149,7 @@ static int snd_pdacf_attach(struct pcmcia_device *p_dev)
         link->conf.ConfigIndex = 1;
         link->conf.Present = PRESENT_OPTION;
 
-        /* Chain drivers */
-        link->next = NULL;
-
-        link->handle = p_dev;
-        pdacf_config(link);
-
-        return 0;
+        return pdacf_config(link);
 }
 
 
@@ -209,9 +196,8 @@ static int snd_pdacf_assign_resources(struct snd_pdacf *pdacf, int port, int irq
 /*
  * snd_pdacf_detach - detach callback for cs
  */
-static void snd_pdacf_detach(struct pcmcia_device *p_dev)
+static void snd_pdacf_detach(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(p_dev);
         struct snd_pdacf *chip = link->priv;
 
         snd_printdd(KERN_DEBUG "pdacf_detach called\n");
@@ -230,13 +216,11 @@ static void snd_pdacf_detach(struct pcmcia_device *p_dev)
 #define CS_CHECK(fn, ret) \
 do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)
 
-static void pdacf_config(dev_link_t *link)
+static int pdacf_config(struct pcmcia_device *link)
 {
-        client_handle_t handle = link->handle;
         struct snd_pdacf *pdacf = link->priv;
         tuple_t tuple;
         cisparse_t *parse = NULL;
-        config_info_t conf;
         u_short buf[32];
         int last_fn, last_ret;
 
@@ -244,7 +228,7 @@ static void pdacf_config(dev_link_t *link)
         parse = kmalloc(sizeof(*parse), GFP_KERNEL);
         if (! parse) {
                 snd_printk(KERN_ERR "pdacf_config: cannot allocate\n");
-                return;
+                return -ENOMEM;
         }
         tuple.DesiredTuple = CISTPL_CFTABLE_ENTRY;
         tuple.Attributes = 0;
@@ -252,71 +236,51 @@ static void pdacf_config(dev_link_t *link)
         tuple.TupleDataMax = sizeof(buf);
         tuple.TupleOffset = 0;
         tuple.DesiredTuple = CISTPL_CONFIG;
-        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(handle, &tuple));
-        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(handle, &tuple));
-        CS_CHECK(ParseTuple, pcmcia_parse_tuple(handle, &tuple, parse));
+        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(link, &tuple));
+        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(link, &tuple));
+        CS_CHECK(ParseTuple, pcmcia_parse_tuple(link, &tuple, parse));
         link->conf.ConfigBase = parse->config.base;
         link->conf.ConfigIndex = 0x5;
         kfree(parse);
 
-        CS_CHECK(GetConfigurationInfo, pcmcia_get_configuration_info(handle, &conf));
-        link->conf.Vcc = conf.Vcc;
-
-        /* Configure card */
-        link->state |= DEV_CONFIG;
-
-        CS_CHECK(RequestIO, pcmcia_request_io(handle, &link->io));
-        CS_CHECK(RequestIRQ, pcmcia_request_irq(link->handle, &link->irq));
-        CS_CHECK(RequestConfiguration, pcmcia_request_configuration(link->handle, &link->conf));
+        CS_CHECK(RequestIO, pcmcia_request_io(link, &link->io));
+        CS_CHECK(RequestIRQ, pcmcia_request_irq(link, &link->irq));
+        CS_CHECK(RequestConfiguration, pcmcia_request_configuration(link, &link->conf));
 
         if (snd_pdacf_assign_resources(pdacf, link->io.BasePort1, link->irq.AssignedIRQ) < 0)
                 goto failed;
 
-        link->dev = &pdacf->node;
-        link->state &= ~DEV_CONFIG_PENDING;
-        return;
+        link->dev_node = &pdacf->node;
+        return 0;
 
 cs_failed:
-        cs_error(link->handle, last_fn, last_ret);
+        cs_error(link, last_fn, last_ret);
 failed:
-        pcmcia_release_configuration(link->handle);
-        pcmcia_release_io(link->handle, &link->io);
-        pcmcia_release_irq(link->handle, &link->irq);
+        pcmcia_disable_device(link);
+        return -ENODEV;
 }
 
 #ifdef CONFIG_PM
 
-static int pdacf_suspend(struct pcmcia_device *dev)
+static int pdacf_suspend(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(dev);
         struct snd_pdacf *chip = link->priv;
 
         snd_printdd(KERN_DEBUG "SUSPEND\n");
-        link->state |= DEV_SUSPEND;
         if (chip) {
                 snd_printdd(KERN_DEBUG "snd_pdacf_suspend calling\n");
                 snd_pdacf_suspend(chip, PMSG_SUSPEND);
         }
 
-        snd_printdd(KERN_DEBUG "RESET_PHYSICAL\n");
-        if (link->state & DEV_CONFIG)
-                pcmcia_release_configuration(link->handle);
-
         return 0;
 }
 
-static int pdacf_resume(struct pcmcia_device *dev)
+static int pdacf_resume(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(dev);
         struct snd_pdacf *chip = link->priv;
 
         snd_printdd(KERN_DEBUG "RESUME\n");
-        link->state &= ~DEV_SUSPEND;
-
-        snd_printdd(KERN_DEBUG "CARD_RESET\n");
-        if (DEV_OK(link)) {
-                snd_printdd(KERN_DEBUG "requestconfig...\n");
-                pcmcia_request_configuration(link->handle, &link->conf);
+        if (pcmcia_dev_present(link)) {
                 if (chip) {
                         snd_printdd(KERN_DEBUG "calling snd_pdacf_resume\n");
                         snd_pdacf_resume(chip);
@@ -343,7 +307,7 @@ static struct pcmcia_driver pdacf_cs_driver = {
         .drv            = {
                 .name   = "snd-pdaudiocf",
         },
-        .probe          = snd_pdacf_attach,
+        .probe          = snd_pdacf_probe,
         .remove         = snd_pdacf_detach,
         .id_table       = snd_pdacf_ids,
 #ifdef CONFIG_PM
diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.h b/sound/pcmcia/pdaudiocf/pdaudiocf.h
index 2744f189a613..9a14a4f64bd3 100644
--- a/sound/pcmcia/pdaudiocf/pdaudiocf.h
+++ b/sound/pcmcia/pdaudiocf/pdaudiocf.h
@@ -116,7 +116,7 @@ struct snd_pdacf {
         void *pcm_area;
         
         /* pcmcia stuff */
-        dev_link_t link;
+        struct pcmcia_device    *p_dev;
         dev_node_t node;
 };
 
diff --git a/sound/pcmcia/vx/vxpocket.c b/sound/pcmcia/vx/vxpocket.c
index 66900d20a42f..7e0cda2b6ef9 100644
--- a/sound/pcmcia/vx/vxpocket.c
+++ b/sound/pcmcia/vx/vxpocket.c
@@ -59,15 +59,9 @@ static unsigned int card_alloc;
 
 /*
  */
-static void vxpocket_release(dev_link_t *link)
+static void vxpocket_release(struct pcmcia_device *link)
 {
-        if (link->state & DEV_CONFIG) {
-                /* release cs resources */
-                pcmcia_release_configuration(link->handle);
-                pcmcia_release_io(link->handle, &link->io);
-                pcmcia_release_irq(link->handle, &link->irq);
-                link->state &= ~DEV_CONFIG;
-        }
+        pcmcia_disable_device(link);
 }
 
 /*
@@ -132,9 +126,9 @@ static struct snd_vx_hardware vxp440_hw = {
 /*
  * create vxpocket instance
  */
-static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl)
+static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl,
+                                             struct pcmcia_device *link)
 {
-        dev_link_t *link;               /* Info for cardmgr */
         struct vx_core *chip;
         struct snd_vxpocket *vxp;
         static struct snd_device_ops ops = {
@@ -154,7 +148,7 @@ static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl)
 
         vxp = (struct snd_vxpocket *)chip;
 
-        link = &vxp->link;
+        vxp->p_dev = link;
         link->priv = chip;
 
         link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
@@ -167,7 +161,6 @@ static struct snd_vxpocket *snd_vxpocket_new(struct snd_card *card, int ibl)
         link->irq.Instance = chip;
 
         link->conf.Attributes = CONF_ENABLE_IRQ;
-        link->conf.Vcc = 50;
         link->conf.IntType = INT_MEMORY_AND_IO;
         link->conf.ConfigIndex = 1;
         link->conf.Present = PRESENT_OPTION;
@@ -215,9 +208,8 @@ static int snd_vxpocket_assign_resources(struct vx_core *chip, int port, int irq
 #define CS_CHECK(fn, ret) \
 do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)
 
-static void vxpocket_config(dev_link_t *link)
+static int vxpocket_config(struct pcmcia_device *link)
 {
-        client_handle_t handle = link->handle;
         struct vx_core *chip = link->priv;
         struct snd_vxpocket *vxp = (struct snd_vxpocket *)chip;
         tuple_t tuple;
@@ -229,24 +221,24 @@ static void vxpocket_config(dev_link_t *link)
         parse = kmalloc(sizeof(*parse), GFP_KERNEL);
         if (! parse) {
                 snd_printk(KERN_ERR "vx: cannot allocate\n");
-                return;
+                return -ENOMEM;
         }
         tuple.Attributes = 0;
         tuple.TupleData = (cisdata_t *)buf;
         tuple.TupleDataMax = sizeof(buf);
         tuple.TupleOffset = 0;
         tuple.DesiredTuple = CISTPL_CONFIG;
-        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(handle, &tuple));
-        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(handle, &tuple));
-        CS_CHECK(ParseTuple, pcmcia_parse_tuple(handle, &tuple, parse));
+        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(link, &tuple));
+        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(link, &tuple));
+        CS_CHECK(ParseTuple, pcmcia_parse_tuple(link, &tuple, parse));
         link->conf.ConfigBase = parse->config.base;
         link->conf.Present = parse->config.rmask[0];
 
         /* redefine hardware record according to the VERSION1 string */
         tuple.DesiredTuple = CISTPL_VERS_1;
-        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(handle, &tuple));
-        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(handle, &tuple));
-        CS_CHECK(ParseTuple, pcmcia_parse_tuple(handle, &tuple, parse));
+        CS_CHECK(GetFirstTuple, pcmcia_get_first_tuple(link, &tuple));
+        CS_CHECK(GetTupleData, pcmcia_get_tuple_data(link, &tuple));
+        CS_CHECK(ParseTuple, pcmcia_parse_tuple(link, &tuple, parse));
         if (! strcmp(parse->version_1.str + parse->version_1.ofs[1], "VX-POCKET")) {
                 snd_printdd("VX-pocket is detected\n");
         } else {
@@ -257,67 +249,50 @@ static void vxpocket_config(dev_link_t *link)
                 strcpy(chip->card->driver, vxp440_hw.name);
         }
 
-        /* Configure card */
-        link->state |= DEV_CONFIG;
-
-        CS_CHECK(RequestIO, pcmcia_request_io(handle, &link->io));
-        CS_CHECK(RequestIRQ, pcmcia_request_irq(link->handle, &link->irq));
-        CS_CHECK(RequestConfiguration, pcmcia_request_configuration(link->handle, &link->conf));
+        CS_CHECK(RequestIO, pcmcia_request_io(link, &link->io));
+        CS_CHECK(RequestIRQ, pcmcia_request_irq(link, &link->irq));
+        CS_CHECK(RequestConfiguration, pcmcia_request_configuration(link, &link->conf));
 
-        chip->dev = &handle_to_dev(link->handle);
+        chip->dev = &handle_to_dev(link);
         snd_card_set_dev(chip->card, chip->dev);
 
         if (snd_vxpocket_assign_resources(chip, link->io.BasePort1, link->irq.AssignedIRQ) < 0)
                 goto failed;
 
-        link->dev = &vxp->node;
-        link->state &= ~DEV_CONFIG_PENDING;
+        link->dev_node = &vxp->node;
         kfree(parse);
-        return;
+        return 9;
 
 cs_failed:
-        cs_error(link->handle, last_fn, last_ret);
+        cs_error(link, last_fn, last_ret);
 failed:
-        pcmcia_release_configuration(link->handle);
-        pcmcia_release_io(link->handle, &link->io);
-        pcmcia_release_irq(link->handle, &link->irq);
-        link->state &= ~DEV_CONFIG;
+        pcmcia_disable_device(link);
         kfree(parse);
+        return -ENODEV;
 }
 
 #ifdef CONFIG_PM
 
-static int vxp_suspend(struct pcmcia_device *dev)
+static int vxp_suspend(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(dev);
         struct vx_core *chip = link->priv;
 
         snd_printdd(KERN_DEBUG "SUSPEND\n");
-        link->state |= DEV_SUSPEND;
         if (chip) {
                 snd_printdd(KERN_DEBUG "snd_vx_suspend calling\n");
                 snd_vx_suspend(chip, PMSG_SUSPEND);
         }
-        snd_printdd(KERN_DEBUG "RESET_PHYSICAL\n");
-        if (link->state & DEV_CONFIG)
-                pcmcia_release_configuration(link->handle);
 
         return 0;
 }
 
-static int vxp_resume(struct pcmcia_device *dev)
+static int vxp_resume(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(dev);
         struct vx_core *chip = link->priv;
 
         snd_printdd(KERN_DEBUG "RESUME\n");
-        link->state &= ~DEV_SUSPEND;
-
-        snd_printdd(KERN_DEBUG "CARD_RESET\n");
-        if (DEV_OK(link)) {
+        if (pcmcia_dev_present(link)) {
                 //struct snd_vxpocket *vxp = (struct snd_vxpocket *)chip;
-                snd_printdd(KERN_DEBUG "requestconfig...\n");
-                pcmcia_request_configuration(link->handle, &link->conf);
                 if (chip) {
                         snd_printdd(KERN_DEBUG "calling snd_vx_resume\n");
                         snd_vx_resume(chip);
@@ -333,7 +308,7 @@ static int vxp_resume(struct pcmcia_device *dev)
 
 /*
  */
-static int vxpocket_attach(struct pcmcia_device *p_dev)
+static int vxpocket_probe(struct pcmcia_device *p_dev)
 {
         struct snd_card *card;
         struct snd_vxpocket *vxp;
@@ -358,7 +333,7 @@ static int vxpocket_attach(struct pcmcia_device *p_dev)
                 return -ENOMEM;
         }
 
-        vxp = snd_vxpocket_new(card, ibl[i]);
+        vxp = snd_vxpocket_new(card, ibl[i], p_dev);
         if (! vxp) {
                 snd_card_free(card);
                 return -ENODEV;
@@ -368,20 +343,13 @@ static int vxpocket_attach(struct pcmcia_device *p_dev)
         vxp->index = i;
         card_alloc |= 1 << i;
 
-        /* Chain drivers */
-        vxp->link.next = NULL;
-
-        vxp->link.handle = p_dev;
-        vxp->link.state |= DEV_PRESENT | DEV_CONFIG_PENDING;
-        p_dev->instance = &vxp->link;
-        vxpocket_config(&vxp->link);
+        vxp->p_dev = p_dev;
 
-        return 0;
+        return vxpocket_config(p_dev);
 }
 
-static void vxpocket_detach(struct pcmcia_device *p_dev)
+static void vxpocket_detach(struct pcmcia_device *link)
 {
-        dev_link_t *link = dev_to_instance(p_dev);
         struct snd_vxpocket *vxp;
         struct vx_core *chip;
 
@@ -413,7 +381,7 @@ static struct pcmcia_driver vxp_cs_driver = {
         .drv            = {
                 .name   = "snd-vxpocket",
         },
-        .probe          = vxpocket_attach,
+        .probe          = vxpocket_probe,
         .remove         = vxpocket_detach,
         .id_table       = vxp_ids,
 #ifdef CONFIG_PM
diff --git a/sound/pcmcia/vx/vxpocket.h b/sound/pcmcia/vx/vxpocket.h
index 67efae3f6c8d..27ea002294c0 100644
--- a/sound/pcmcia/vx/vxpocket.h
+++ b/sound/pcmcia/vx/vxpocket.h
@@ -42,7 +42,7 @@ struct snd_vxpocket {
         int index;      /* card index */
 
         /* pcmcia stuff */
-        dev_link_t link;
+        struct pcmcia_device    *p_dev;
         dev_node_t node;
 };