1 files changed, 42 insertions, 4 deletions

diff --git a/sound/usb/usbmidi.c b/sound/usb/usbmidi.c
index 99295f9b7691..6330788c1c2b 100644
--- a/sound/usb/usbmidi.c
+++ b/sound/usb/usbmidi.c
@@ -407,6 +407,20 @@ static void snd_usbmidi_maudio_broken_running_status_input(
 }
 
 /*
+ * CME protocol: like the standard protocol, but SysEx commands are sent as a
+ * single USB packet preceded by a 0x0F byte.
+ */
+static void snd_usbmidi_cme_input(struct snd_usb_midi_in_endpoint *ep,
+                                  uint8_t *buffer, int buffer_length)
+{
+        if (buffer_length < 2 || (buffer[0] & 0x0f) != 0x0f)
+                snd_usbmidi_standard_input(ep, buffer, buffer_length);
+        else
+                snd_usbmidi_input_data(ep, buffer[0] >> 4,
+                                       &buffer[1], buffer_length - 1);
+}
+
+/*
  * Adds one USB MIDI packet to the output buffer.
  */
 static void snd_usbmidi_output_standard_packet(struct urb* urb, uint8_t p0,
@@ -572,6 +586,12 @@ static struct usb_protocol_ops snd_usbmidi_maudio_broken_running_status_ops = {
         .output_packet = snd_usbmidi_output_standard_packet,
 };
 
+static struct usb_protocol_ops snd_usbmidi_cme_ops = {
+        .input = snd_usbmidi_cme_input,
+        .output = snd_usbmidi_standard_output,
+        .output_packet = snd_usbmidi_output_standard_packet,
+};
+
 /*
  * Novation USB MIDI protocol: number of data bytes is in the first byte
  * (when receiving) (+1!) or in the second byte (when sending); data begins
@@ -963,8 +983,10 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
                 snd_usbmidi_out_endpoint_delete(ep);
                 return -ENOMEM;
         }
-        /* we never use interrupt output pipes */
-        pipe = usb_sndbulkpipe(umidi->chip->dev, ep_info->out_ep);
+        if (ep_info->out_interval)
+                pipe = usb_sndintpipe(umidi->chip->dev, ep_info->out_ep);
+        else
+                pipe = usb_sndbulkpipe(umidi->chip->dev, ep_info->out_ep);
         if (umidi->chip->usb_id == USB_ID(0x0a92, 0x1020)) /* ESI M4U */
                 /* FIXME: we need more URBs to get reasonable bandwidth here: */
                 ep->max_transfer = 4;
@@ -976,8 +998,14 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
                 snd_usbmidi_out_endpoint_delete(ep);
                 return -ENOMEM;
         }
-        usb_fill_bulk_urb(ep->urb, umidi->chip->dev, pipe, buffer,
-                          ep->max_transfer, snd_usbmidi_out_urb_complete, ep);
+        if (ep_info->out_interval)
+                usb_fill_int_urb(ep->urb, umidi->chip->dev, pipe, buffer,
+                                 ep->max_transfer, snd_usbmidi_out_urb_complete,
+                                 ep, ep_info->out_interval);
+        else
+                usb_fill_bulk_urb(ep->urb, umidi->chip->dev,
+                                  pipe, buffer, ep->max_transfer,
+                                  snd_usbmidi_out_urb_complete, ep);
         ep->urb->transfer_flags = URB_NO_TRANSFER_DMA_MAP;
 
         spin_lock_init(&ep->buffer_lock);
@@ -1323,6 +1351,13 @@ static int snd_usbmidi_get_ms_info(struct snd_usb_midi* umidi,
                         endpoints[epidx].out_ep = ep->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
                         if ((ep->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_INT)
                                 endpoints[epidx].out_interval = ep->bInterval;
+                        else if (snd_usb_get_speed(umidi->chip->dev) == USB_SPEED_LOW)
+                                /*
+                                 * Low speed bulk transfers don't exist, so
+                                 * force interrupt transfers for devices like
+                                 * ESI MIDI Mate that try to use them anyway.
+                                 */
+                                endpoints[epidx].out_interval = 1;
                         endpoints[epidx].out_cables = (1 << ms_ep->bNumEmbMIDIJack) - 1;
                         snd_printdd(KERN_INFO "EP %02X: %d jack(s)\n",
                                     ep->bEndpointAddress, ms_ep->bNumEmbMIDIJack);
@@ -1336,6 +1371,8 @@ static int snd_usbmidi_get_ms_info(struct snd_usb_midi* umidi,
                         endpoints[epidx].in_ep = ep->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK;
                         if ((ep->bmAttributes & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_INT)
                                 endpoints[epidx].in_interval = ep->bInterval;
+                        else if (snd_usb_get_speed(umidi->chip->dev) == USB_SPEED_LOW)
+                                endpoints[epidx].in_interval = 1;
                         endpoints[epidx].in_cables = (1 << ms_ep->bNumEmbMIDIJack) - 1;
                         snd_printdd(KERN_INFO "EP %02X: %d jack(s)\n",
                                     ep->bEndpointAddress, ms_ep->bNumEmbMIDIJack);
@@ -1690,6 +1727,7 @@ int snd_usb_create_midi_interface(struct snd_usb_audio* chip,
                 err = snd_usbmidi_detect_endpoints(umidi, &endpoints[0], 1);
                 break;
         case QUIRK_MIDI_CME:
+                umidi->usb_protocol_ops = &snd_usbmidi_cme_ops;
                 err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints);
                 break;
         default: