1 files changed, 4 insertions, 7 deletions

diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c
index ab47fea997a3..4380dcc064a5 100644
--- a/sound/soc/soc-jack.c
+++ b/sound/soc/soc-jack.c
@@ -116,7 +116,7 @@ EXPORT_SYMBOL_GPL(snd_soc_jack_report);
  *
  * @jack:  ASoC jack
  * @count: Number of zones
- * @zone:  Array of zones
+ * @zones:  Array of zones
  *
  * After this function has been called the zones specified in the
  * array will be associated with the jack.
@@ -309,7 +309,7 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
                         /* GPIO descriptor */
                         gpios[i].desc = gpiod_get_index(gpios[i].gpiod_dev,
                                                         gpios[i].name,
-                                                        gpios[i].idx);
+                                                        gpios[i].idx, GPIOD_IN);
                         if (IS_ERR(gpios[i].desc)) {
                                 ret = PTR_ERR(gpios[i].desc);
                                 dev_err(gpios[i].gpiod_dev,
@@ -327,17 +327,14 @@ int snd_soc_jack_add_gpios(struct snd_soc_jack *jack, int count,
                                 goto undo;
                         }
 
-                        ret = gpio_request(gpios[i].gpio, gpios[i].name);
+                        ret = gpio_request_one(gpios[i].gpio, GPIOF_IN,
+                                               gpios[i].name);
                         if (ret)
                                 goto undo;
 
                         gpios[i].desc = gpio_to_desc(gpios[i].gpio);
                 }
 
-                ret = gpiod_direction_input(gpios[i].desc);
-                if (ret)
-                        goto err;
-
                 INIT_DELAYED_WORK(&gpios[i].work, gpio_work);
                 gpios[i].jack = jack;