5 files changed, 31 insertions, 56 deletions

diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c
index 4f59bbaba48f..96bb92dd174c 100644
--- a/sound/soc/fsl/fsl_dma.c
+++ b/sound/soc/fsl/fsl_dma.c
@@ -311,23 +311,23 @@ static int fsl_dma_new(struct snd_soc_pcm_runtime *rtd)
          * should allocate a DMA buffer only for the streams that are valid.
          */
 
-        if (pcm->streams[0].substream) {
+        if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
                 ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, card->dev,
                         fsl_dma_hardware.buffer_bytes_max,
-                        &pcm->streams[0].substream->dma_buffer);
+                        &pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->dma_buffer);
                 if (ret) {
                         dev_err(card->dev, "can't alloc playback dma buffer\n");
                         return ret;
                 }
         }
 
-        if (pcm->streams[1].substream) {
+        if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
                 ret = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, card->dev,
                         fsl_dma_hardware.buffer_bytes_max,
-                        &pcm->streams[1].substream->dma_buffer);
+                        &pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream->dma_buffer);
                 if (ret) {
                         dev_err(card->dev, "can't alloc capture dma buffer\n");
-                        snd_dma_free_pages(&pcm->streams[0].substream->dma_buffer);
+                        snd_dma_free_pages(&pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->dma_buffer);
                         return ret;
                 }
         }
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 3e066966d878..2eb407fa3b48 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -716,12 +716,12 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev)
         }
 
         /* Trigger the machine driver's probe function.  The platform driver
-         * name of the machine driver is taken from the /model property of the
+         * name of the machine driver is taken from /compatible property of the
          * device tree.  We also pass the address of the CPU DAI driver
          * structure.
          */
-        sprop = of_get_property(of_find_node_by_path("/"), "model", NULL);
-        /* Sometimes the model name has a "fsl," prefix, so we strip that. */
+        sprop = of_get_property(of_find_node_by_path("/"), "compatible", NULL);
+        /* Sometimes the compatible name has a "fsl," prefix, so we strip it. */
         p = strrchr(sprop, ',');
         if (p)
                 sprop = p + 1;
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c
index e7803d34c425..9a3f7c5ab687 100644
--- a/sound/soc/fsl/mpc5200_dma.c
+++ b/sound/soc/fsl/mpc5200_dma.c
@@ -8,6 +8,7 @@
 
 #include <linux/module.h>
 #include <linux/of_device.h>
+#include <linux/dma-mapping.h>
 #include <linux/slab.h>
 #include <linux/of_platform.h>
 
@@ -298,7 +299,7 @@ static struct snd_pcm_ops psc_dma_ops = {
         .hw_params      = psc_dma_hw_params,
 };
 
-static u64 psc_dma_dmamask = 0xffffffff;
+static u64 psc_dma_dmamask = DMA_BIT_MASK(32);
 static int psc_dma_new(struct snd_soc_pcm_runtime *rtd)
 {
         struct snd_card *card = rtd->card->snd_card;
@@ -314,18 +315,18 @@ static int psc_dma_new(struct snd_soc_pcm_runtime *rtd)
         if (!card->dev->dma_mask)
                 card->dev->dma_mask = &psc_dma_dmamask;
         if (!card->dev->coherent_dma_mask)
-                card->dev->coherent_dma_mask = 0xffffffff;
+                card->dev->coherent_dma_mask = DMA_BIT_MASK(32);
 
-        if (pcm->streams[0].substream) {
+        if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream) {
                 rc = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, pcm->card->dev,
-                                size, &pcm->streams[0].substream->dma_buffer);
+                                size, &pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->dma_buffer);
                 if (rc)
                         goto playback_alloc_err;
         }
 
-        if (pcm->streams[1].substream) {
+        if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
                 rc = snd_dma_alloc_pages(SNDRV_DMA_TYPE_DEV, pcm->card->dev,
-                                size, &pcm->streams[1].substream->dma_buffer);
+                                size, &pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream->dma_buffer);
                 if (rc)
                         goto capture_alloc_err;
         }
@@ -336,8 +337,8 @@ static int psc_dma_new(struct snd_soc_pcm_runtime *rtd)
         return 0;
 
  capture_alloc_err:
-        if (pcm->streams[0].substream)
-                snd_dma_free_pages(&pcm->streams[0].substream->dma_buffer);
+        if (pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream)
+                snd_dma_free_pages(&pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream->dma_buffer);
 
  playback_alloc_err:
         dev_err(card->dev, "Cannot allocate buffer(s)\n");
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index 0ea4a5a96e06..afbabf427f27 100644
--- a/sound/soc/fsl/mpc8610_hpcd.c
+++ b/sound/soc/fsl/mpc8610_hpcd.c
@@ -245,7 +245,7 @@ static int get_parent_cell_index(struct device_node *np)
  * 'struct device'  It's ugly and hackish, but it works.
  *
  * The dev_name for such devices include the bus number and I2C address. For
- * example, "cs4270-codec.0-004f".
+ * example, "cs4270.0-004f".
  */
 static int codec_node_dev_name(struct device_node *np, char *buf, size_t len)
 {
@@ -267,13 +267,13 @@ static int codec_node_dev_name(struct device_node *np, char *buf, size_t len)
         if (!i2c)
                 return -ENODEV;
 
-        snprintf(buf, len, "%s-codec.%u-%04x", temp, i2c->adapter->nr, addr);
+        snprintf(buf, len, "%s.%u-%04x", temp, i2c->adapter->nr, addr);
 
         return 0;
 }
 
 static int get_dma_channel(struct device_node *ssi_np,
-                           const char *compatible,
+                           const char *name,
                            struct snd_soc_dai_link *dai,
                            unsigned int *dma_channel_id,
                            unsigned int *dma_id)
@@ -283,7 +283,7 @@ static int get_dma_channel(struct device_node *ssi_np,
         const u32 *iprop;
         int ret;
 
-        dma_channel_np = get_node_by_phandle_name(ssi_np, compatible,
+        dma_channel_np = get_node_by_phandle_name(ssi_np, name,
                                                   "fsl,ssi-dma-channel");
         if (!dma_channel_np)
                 return -EINVAL;
@@ -336,12 +336,8 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
         const char *sprop;
         const u32 *iprop;
 
-        /* We are only interested in SSIs with a codec phandle in them,
-         * so let's make sure this SSI has one. The MPC8610 HPCD only
-         * knows about the CS4270 codec, so reject anything else.
-         */
-        codec_np = get_node_by_phandle_name(np, "codec-handle",
-                                            "cirrus,cs4270");
+        /* Find the codec node for this SSI. */
+        codec_np = of_parse_phandle(np, "codec-handle", 0);
         if (!codec_np) {
                 dev_err(dev, "invalid codec node\n");
                 return -EINVAL;
@@ -550,7 +546,7 @@ static struct platform_driver mpc8610_hpcd_driver = {
         .probe = mpc8610_hpcd_probe,
         .remove = __devexit_p(mpc8610_hpcd_remove),
         .driver = {
-                /* The name must match the 'model' property in the device tree,
+                /* The name must match 'compatible' property in the device tree,
                  * in lowercase letters.
                  */
                 .name = "snd-soc-mpc8610hpcd",
diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c
index a5d4e80a9cf4..b88987083475 100644
--- a/sound/soc/fsl/p1022_ds.c
+++ b/sound/soc/fsl/p1022_ds.c
@@ -276,7 +276,7 @@ static int codec_node_dev_name(struct device_node *np, char *buf, size_t len)
 }
 
 static int get_dma_channel(struct device_node *ssi_np,
-                           const char *compatible,
+                           const char *name,
                            struct snd_soc_dai_link *dai,
                            unsigned int *dma_channel_id,
                            unsigned int *dma_id)
@@ -286,7 +286,7 @@ static int get_dma_channel(struct device_node *ssi_np,
         const u32 *iprop;
         int ret;
 
-        dma_channel_np = get_node_by_phandle_name(ssi_np, compatible,
+        dma_channel_np = get_node_by_phandle_name(ssi_np, name,
                                                   "fsl,ssi-dma-channel");
         if (!dma_channel_np)
                 return -EINVAL;
@@ -543,6 +543,11 @@ static struct platform_driver p1022_ds_driver = {
         .probe = p1022_ds_probe,
         .remove = __devexit_p(p1022_ds_remove),
         .driver = {
+                /*
+                 * The name must match 'compatible' property in the device tree,
+                 * in lowercase letters.
+                 */
+                .name = "snd-soc-p1022ds",
                 .owner = THIS_MODULE,
         },
 };
@@ -556,33 +561,6 @@ static int __init p1022_ds_init(void)
 {
         struct device_node *guts_np;
         struct resource res;
-        const char *sprop;
-
-        /*
-         * Check if we're actually running on a P1022DS.  Older device trees
-         * have a model of "fsl,P1022" and newer ones use "fsl,P1022DS", so we
-         * need to support both.  The SSI driver uses that property to link to
-         * the machine driver, so have to match it.
-         */
-        sprop = of_get_property(of_find_node_by_path("/"), "model", NULL);
-        if (!sprop) {
-                pr_err("snd-soc-p1022ds: missing /model node");
-                return -ENODEV;
-        }
-
-        pr_debug("snd-soc-p1022ds: board model name is %s\n", sprop);
-
-        /*
-         * The name of this board, taken from the device tree.  Normally, this is a*
-         * fixed string, but some P1022DS device trees have a /model property of
-         * "fsl,P1022", and others have "fsl,P1022DS".
-         */
-        if (strcasecmp(sprop, "fsl,p1022ds") == 0)
-                p1022_ds_driver.driver.name = "snd-soc-p1022ds";
-        else if (strcasecmp(sprop, "fsl,p1022") == 0)
-                p1022_ds_driver.driver.name = "snd-soc-p1022";
-        else
-                return -ENODEV;
 
         /* Get the physical address of the global utilities registers */
         guts_np = of_find_compatible_node(NULL, NULL, "fsl,p1022-guts");