1 files changed, 57 insertions, 154 deletions

diff --git a/sound/soc/codecs/uda1380.c b/sound/soc/codecs/uda1380.c
index 2f925a27dcde..1a51c816e542 100644
--- a/sound/soc/codecs/uda1380.c
+++ b/sound/soc/codecs/uda1380.c
@@ -33,11 +33,9 @@
 
 #include "uda1380.h"
 
-static struct snd_soc_codec *uda1380_codec;
-
 /* codec private data */
 struct uda1380_priv {
-        struct snd_soc_codec codec;
+        struct snd_soc_codec *codec;
         u16 reg_cache[UDA1380_CACHEREGNUM];
         unsigned int dac_clk;
         struct work_struct work;
@@ -135,6 +133,8 @@ static int uda1380_write(struct snd_soc_codec *codec, unsigned int reg,
 
 static void uda1380_flush_work(struct work_struct *work)
 {
+        struct uda1380_priv *uda1380 = container_of(work, struct uda1380_priv, work);
+        struct snd_soc_codec *uda1380_codec = uda1380->codec;
         int bit, reg;
 
         for_each_set_bit(bit, &uda1380_cache_dirty, UDA1380_CACHEREGNUM - 0x10) {
@@ -145,6 +145,7 @@ static void uda1380_flush_work(struct work_struct *work)
                                 uda1380_read_reg_cache(uda1380_codec, reg));
                 clear_bit(bit, &uda1380_cache_dirty);
         }
+
 }
 
 /* declarations of ALSA reg_elem_REAL controls */
@@ -474,8 +475,7 @@ static int uda1380_trigger(struct snd_pcm_substream *substream, int cmd,
                 struct snd_soc_dai *dai)
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
-        struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_codec *codec = rtd->codec;
         struct uda1380_priv *uda1380 = snd_soc_codec_get_drvdata(codec);
         int mixer = uda1380_read_reg_cache(codec, UDA1380_MIXER);
 
@@ -501,8 +501,7 @@ static int uda1380_pcm_hw_params(struct snd_pcm_substream *substream,
                                  struct snd_soc_dai *dai)
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
-        struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_codec *codec = rtd->codec;
         u16 clk = uda1380_read_reg_cache(codec, UDA1380_CLK);
 
         /* set WSPLL power and divider if running from this clock */
@@ -540,8 +539,7 @@ static void uda1380_pcm_shutdown(struct snd_pcm_substream *substream,
                                  struct snd_soc_dai *dai)
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
-        struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_codec *codec = rtd->codec;
         u16 clk = uda1380_read_reg_cache(codec, UDA1380_CLK);
 
         /* shut down WSPLL power if running from this clock */
@@ -604,9 +602,9 @@ static struct snd_soc_dai_ops uda1380_dai_ops_capture = {
         .set_fmt        = uda1380_set_dai_fmt_capture,
 };
 
-struct snd_soc_dai uda1380_dai[] = {
+static struct snd_soc_dai_driver uda1380_dai[] = {
 {
-        .name = "UDA1380",
+        .name = "uda1380-hifi",
         .playback = {
                 .stream_name = "Playback",
                 .channels_min = 1,
@@ -622,7 +620,7 @@ struct snd_soc_dai uda1380_dai[] = {
         .ops = &uda1380_dai_ops,
 },
 { /* playback only - dual interface */
-        .name = "UDA1380",
+        .name = "uda1380-hifi-playback",
         .playback = {
                 .stream_name = "Playback",
                 .channels_min = 1,
@@ -633,7 +631,7 @@ struct snd_soc_dai uda1380_dai[] = {
         .ops = &uda1380_dai_ops_playback,
 },
 { /* capture only - dual interface*/
-        .name = "UDA1380",
+        .name = "uda1380-hifi-capture",
         .capture = {
                 .stream_name = "Capture",
                 .channels_min = 1,
@@ -644,21 +642,15 @@ struct snd_soc_dai uda1380_dai[] = {
         .ops = &uda1380_dai_ops_capture,
 },
 };
-EXPORT_SYMBOL_GPL(uda1380_dai);
 
-static int uda1380_suspend(struct platform_device *pdev, pm_message_t state)
+static int uda1380_suspend(struct snd_soc_codec *codec, pm_message_t state)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
-
         uda1380_set_bias_level(codec, SND_SOC_BIAS_OFF);
         return 0;
 }
 
-static int uda1380_resume(struct platform_device *pdev)
+static int uda1380_resume(struct snd_soc_codec *codec)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
         int i;
         u8 data[2];
         u16 *cache = codec->reg_cache;
@@ -673,91 +665,20 @@ static int uda1380_resume(struct platform_device *pdev)
         return 0;
 }
 
-static int uda1380_probe(struct platform_device *pdev)
-{
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec;
-        struct uda1380_platform_data *pdata;
-        int ret = 0;
-
-        if (uda1380_codec == NULL) {
-                dev_err(&pdev->dev, "Codec device not registered\n");
-                return -ENODEV;
-        }
-
-        socdev->card->codec = uda1380_codec;
-        codec = uda1380_codec;
-        pdata = codec->dev->platform_data;
-
-        /* register pcms */
-        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
-        if (ret < 0) {
-                dev_err(codec->dev, "failed to create pcms: %d\n", ret);
-                goto pcm_err;
-        }
-
-        /* power on device */
-        uda1380_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-        /* set clock input */
-        switch (pdata->dac_clk) {
-        case UDA1380_DAC_CLK_SYSCLK:
-                uda1380_write(codec, UDA1380_CLK, 0);
-                break;
-        case UDA1380_DAC_CLK_WSPLL:
-                uda1380_write(codec, UDA1380_CLK, R00_DAC_CLK);
-                break;
-        }
-
-        snd_soc_add_controls(codec, uda1380_snd_controls,
-                                ARRAY_SIZE(uda1380_snd_controls));
-        uda1380_add_widgets(codec);
-
-        return ret;
-
-pcm_err:
-        return ret;
-}
-
-/* power down chip */
-static int uda1380_remove(struct platform_device *pdev)
-{
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
-
-        if (codec->control_data)
-                uda1380_set_bias_level(codec, SND_SOC_BIAS_OFF);
-
-        snd_soc_free_pcms(socdev);
-        snd_soc_dapm_free(socdev);
-
-        return 0;
-}
-
-struct snd_soc_codec_device soc_codec_dev_uda1380 = {
-        .probe =        uda1380_probe,
-        .remove =       uda1380_remove,
-        .suspend =      uda1380_suspend,
-        .resume =       uda1380_resume,
-};
-EXPORT_SYMBOL_GPL(soc_codec_dev_uda1380);
-
-static int uda1380_register(struct uda1380_priv *uda1380)
+static int uda1380_probe(struct snd_soc_codec *codec)
 {
-        int ret, i;
-        struct snd_soc_codec *codec = &uda1380->codec;
-        struct uda1380_platform_data *pdata = codec->dev->platform_data;
+        struct uda1380_platform_data *pdata =codec->dev->platform_data;
+        struct uda1380_priv *uda1380 = snd_soc_codec_get_drvdata(codec);
+        int ret;
 
-        if (uda1380_codec) {
-                dev_err(codec->dev, "Another UDA1380 is registered\n");
-                return -EINVAL;
-        }
+        codec->hw_write = (hw_write_t)i2c_master_send;
 
         if (!pdata || !pdata->gpio_power || !pdata->gpio_reset)
                 return -EINVAL;
 
         ret = gpio_request(pdata->gpio_power, "uda1380 power");
         if (ret)
-                goto err_out;
+                return ret;
         ret = gpio_request(pdata->gpio_reset, "uda1380 reset");
         if (ret)
                 goto err_gpio;
@@ -769,25 +690,6 @@ static int uda1380_register(struct uda1380_priv *uda1380)
         udelay(5);
         gpio_set_value(pdata->gpio_reset, 0);
 
-        mutex_init(&codec->mutex);
-        INIT_LIST_HEAD(&codec->dapm_widgets);
-        INIT_LIST_HEAD(&codec->dapm_paths);
-
-        snd_soc_codec_set_drvdata(codec, uda1380);
-        codec->name = "UDA1380";
-        codec->owner = THIS_MODULE;
-        codec->read = uda1380_read_reg_cache;
-        codec->write = uda1380_write;
-        codec->bias_level = SND_SOC_BIAS_OFF;
-        codec->set_bias_level = uda1380_set_bias_level;
-        codec->dai = uda1380_dai;
-        codec->num_dai = ARRAY_SIZE(uda1380_dai);
-        codec->reg_cache_size = ARRAY_SIZE(uda1380_reg);
-        codec->reg_cache = &uda1380->reg_cache;
-        codec->reg_cache_step = 1;
-
-        memcpy(codec->reg_cache, uda1380_reg, sizeof(uda1380_reg));
-
         ret = uda1380_reset(codec);
         if (ret < 0) {
                 dev_err(codec->dev, "Failed to issue reset\n");
@@ -796,83 +698,84 @@ static int uda1380_register(struct uda1380_priv *uda1380)
 
         INIT_WORK(&uda1380->work, uda1380_flush_work);
 
-        for (i = 0; i < ARRAY_SIZE(uda1380_dai); i++)
-                uda1380_dai[i].dev = codec->dev;
-
-        uda1380_codec = codec;
-
-        ret = snd_soc_register_codec(codec);
-        if (ret != 0) {
-                dev_err(codec->dev, "Failed to register codec: %d\n", ret);
-                goto err_reset;
+        /* power on device */
+        uda1380_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+        /* set clock input */
+        switch (pdata->dac_clk) {
+        case UDA1380_DAC_CLK_SYSCLK:
+                uda1380_write(codec, UDA1380_CLK, 0);
+                break;
+        case UDA1380_DAC_CLK_WSPLL:
+                uda1380_write(codec, UDA1380_CLK, R00_DAC_CLK);
+                break;
         }
 
-        ret = snd_soc_register_dais(uda1380_dai, ARRAY_SIZE(uda1380_dai));
-        if (ret != 0) {
-                dev_err(codec->dev, "Failed to register DAIs: %d\n", ret);
-                goto err_dai;
-        }
+        snd_soc_add_controls(codec, uda1380_snd_controls,
+                                ARRAY_SIZE(uda1380_snd_controls));
+        uda1380_add_widgets(codec);
 
         return 0;
 
-err_dai:
-        snd_soc_unregister_codec(codec);
 err_reset:
         gpio_set_value(pdata->gpio_power, 0);
         gpio_free(pdata->gpio_reset);
 err_gpio:
         gpio_free(pdata->gpio_power);
-err_out:
         return ret;
 }
 
-static void uda1380_unregister(struct uda1380_priv *uda1380)
+/* power down chip */
+static int uda1380_remove(struct snd_soc_codec *codec)
 {
-        struct snd_soc_codec *codec = &uda1380->codec;
-        struct uda1380_platform_data *pdata = codec->dev->platform_data;
+        struct uda1380_platform_data *pdata =codec->dev->platform_data;
 
-        snd_soc_unregister_dais(uda1380_dai, ARRAY_SIZE(uda1380_dai));
-        snd_soc_unregister_codec(&uda1380->codec);
+        uda1380_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
         gpio_set_value(pdata->gpio_power, 0);
         gpio_free(pdata->gpio_reset);
         gpio_free(pdata->gpio_power);
 
-        kfree(uda1380);
-        uda1380_codec = NULL;
+        return 0;
 }
 
+static struct snd_soc_codec_driver soc_codec_dev_uda1380 = {
+        .probe =        uda1380_probe,
+        .remove =       uda1380_remove,
+        .suspend =      uda1380_suspend,
+        .resume =       uda1380_resume,
+        .read = uda1380_read_reg_cache,
+        .write = uda1380_write,
+        .set_bias_level = uda1380_set_bias_level,
+        .reg_cache_size = ARRAY_SIZE(uda1380_reg),
+        .reg_word_size = sizeof(u16),
+        .reg_cache_default = uda1380_reg,
+        .reg_cache_step = 1,
+};
+
 #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
 static __devinit int uda1380_i2c_probe(struct i2c_client *i2c,
                                       const struct i2c_device_id *id)
 {
         struct uda1380_priv *uda1380;
-        struct snd_soc_codec *codec;
         int ret;
 
         uda1380 = kzalloc(sizeof(struct uda1380_priv), GFP_KERNEL);
         if (uda1380 == NULL)
                 return -ENOMEM;
 
-        codec = &uda1380->codec;
-        codec->hw_write = (hw_write_t)i2c_master_send;
-
         i2c_set_clientdata(i2c, uda1380);
-        codec->control_data = i2c;
-
-        codec->dev = &i2c->dev;
 
-        ret = uda1380_register(uda1380);
-        if (ret != 0)
+        ret =  snd_soc_register_codec(&i2c->dev,
+                        &soc_codec_dev_uda1380, uda1380_dai, ARRAY_SIZE(uda1380_dai));
+        if (ret < 0)
                 kfree(uda1380);
-
         return ret;
 }
 
 static int __devexit uda1380_i2c_remove(struct i2c_client *i2c)
 {
-        struct uda1380_priv *uda1380 = i2c_get_clientdata(i2c);
-        uda1380_unregister(uda1380);
+        snd_soc_unregister_codec(&i2c->dev);
+        kfree(i2c_get_clientdata(i2c));
         return 0;
 }
 
@@ -884,7 +787,7 @@ MODULE_DEVICE_TABLE(i2c, uda1380_i2c_id);
 
 static struct i2c_driver uda1380_i2c_driver = {
         .driver = {
-                .name =  "UDA1380 I2C Codec",
+                .name =  "uda1380-codec",
                 .owner = THIS_MODULE,
         },
         .probe =    uda1380_i2c_probe,