1 files changed, 383 insertions, 141 deletions

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index ea370a4f86d5..97738e2ece04 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -42,7 +42,7 @@
  */
 static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = {
         0x00, /* this register not used         */
-        0x93, /* REG_CODEC_MODE         (0x1)   */
+        0x91, /* REG_CODEC_MODE         (0x1)   */
         0xc3, /* REG_OPTION             (0x2)   */
         0x00, /* REG_UNKNOWN            (0x3)   */
         0x00, /* REG_MICBIAS_CTL        (0x4)   */
@@ -117,6 +117,13 @@ static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = {
         0x00, /* REG_MISC_SET_2         (0x49)  */
 };
 
+/* codec private data */
+struct twl4030_priv {
+        unsigned int bypass_state;
+        unsigned int codec_powered;
+        unsigned int codec_muted;
+};
+
 /*
  * read twl4030 register cache
  */
@@ -125,6 +132,9 @@ static inline unsigned int twl4030_read_reg_cache(struct snd_soc_codec *codec,
 {
         u8 *cache = codec->reg_cache;
 
+        if (reg >= TWL4030_CACHEREGNUM)
+                return -EIO;
+
         return cache[reg];
 }
 
@@ -151,26 +161,22 @@ static int twl4030_write(struct snd_soc_codec *codec,
         return twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE, value, reg);
 }
 
-static void twl4030_clear_codecpdz(struct snd_soc_codec *codec)
+static void twl4030_codec_enable(struct snd_soc_codec *codec, int enable)
 {
+        struct twl4030_priv *twl4030 = codec->private_data;
         u8 mode;
 
-        mode = twl4030_read_reg_cache(codec, TWL4030_REG_CODEC_MODE);
-        twl4030_write(codec, TWL4030_REG_CODEC_MODE,
-                mode & ~TWL4030_CODECPDZ);
-
-        /* REVISIT: this delay is present in TI sample drivers */
-        /* but there seems to be no TRM requirement for it     */
-        udelay(10);
-}
-
-static void twl4030_set_codecpdz(struct snd_soc_codec *codec)
-{
-        u8 mode;
+        if (enable == twl4030->codec_powered)
+                return;
 
         mode = twl4030_read_reg_cache(codec, TWL4030_REG_CODEC_MODE);
-        twl4030_write(codec, TWL4030_REG_CODEC_MODE,
-                mode | TWL4030_CODECPDZ);
+        if (enable)
+                mode |= TWL4030_CODECPDZ;
+        else
+                mode &= ~TWL4030_CODECPDZ;
+
+        twl4030_write(codec, TWL4030_REG_CODEC_MODE, mode);
+        twl4030->codec_powered = enable;
 
         /* REVISIT: this delay is present in TI sample drivers */
         /* but there seems to be no TRM requirement for it     */
@@ -182,7 +188,7 @@ static void twl4030_init_chip(struct snd_soc_codec *codec)
         int i;
 
         /* clear CODECPDZ prior to setting register defaults */
-        twl4030_clear_codecpdz(codec);
+        twl4030_codec_enable(codec, 0);
 
         /* set all audio section registers to reasonable defaults */
         for (i = TWL4030_REG_OPTION; i <= TWL4030_REG_MISC_SET_2; i++)
@@ -190,6 +196,122 @@ static void twl4030_init_chip(struct snd_soc_codec *codec)
 
 }
 
+static void twl4030_codec_mute(struct snd_soc_codec *codec, int mute)
+{
+        struct twl4030_priv *twl4030 = codec->private_data;
+        u8 reg_val;
+
+        if (mute == twl4030->codec_muted)
+                return;
+
+        if (mute) {
+                /* Bypass the reg_cache and mute the volumes
+                 * Headset mute is done in it's own event handler
+                 * Things to mute:  Earpiece, PreDrivL/R, CarkitL/R
+                 */
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_EAR_CTL);
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        reg_val & (~TWL4030_EAR_GAIN),
+                                        TWL4030_REG_EAR_CTL);
+
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_PREDL_CTL);
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        reg_val & (~TWL4030_PREDL_GAIN),
+                                        TWL4030_REG_PREDL_CTL);
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_PREDR_CTL);
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        reg_val & (~TWL4030_PREDR_GAIN),
+                                        TWL4030_REG_PREDL_CTL);
+
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_PRECKL_CTL);
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        reg_val & (~TWL4030_PRECKL_GAIN),
+                                        TWL4030_REG_PRECKL_CTL);
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_PRECKR_CTL);
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        reg_val & (~TWL4030_PRECKL_GAIN),
+                                        TWL4030_REG_PRECKR_CTL);
+
+                /* Disable PLL */
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
+                reg_val &= ~TWL4030_APLL_EN;
+                twl4030_write(codec, TWL4030_REG_APLL_CTL, reg_val);
+        } else {
+                /* Restore the volumes
+                 * Headset mute is done in it's own event handler
+                 * Things to restore:  Earpiece, PreDrivL/R, CarkitL/R
+                 */
+                twl4030_write(codec, TWL4030_REG_EAR_CTL,
+                        twl4030_read_reg_cache(codec, TWL4030_REG_EAR_CTL));
+
+                twl4030_write(codec, TWL4030_REG_PREDL_CTL,
+                        twl4030_read_reg_cache(codec, TWL4030_REG_PREDL_CTL));
+                twl4030_write(codec, TWL4030_REG_PREDR_CTL,
+                        twl4030_read_reg_cache(codec, TWL4030_REG_PREDR_CTL));
+
+                twl4030_write(codec, TWL4030_REG_PRECKL_CTL,
+                        twl4030_read_reg_cache(codec, TWL4030_REG_PRECKL_CTL));
+                twl4030_write(codec, TWL4030_REG_PRECKR_CTL,
+                        twl4030_read_reg_cache(codec, TWL4030_REG_PRECKR_CTL));
+
+                /* Enable PLL */
+                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
+                reg_val |= TWL4030_APLL_EN;
+                twl4030_write(codec, TWL4030_REG_APLL_CTL, reg_val);
+        }
+
+        twl4030->codec_muted = mute;
+}
+
+static void twl4030_power_up(struct snd_soc_codec *codec)
+{
+        struct twl4030_priv *twl4030 = codec->private_data;
+        u8 anamicl, regmisc1, byte;
+        int i = 0;
+
+        if (twl4030->codec_powered)
+                return;
+
+        /* set CODECPDZ to turn on codec */
+        twl4030_codec_enable(codec, 1);
+
+        /* initiate offset cancellation */
+        anamicl = twl4030_read_reg_cache(codec, TWL4030_REG_ANAMICL);
+        twl4030_write(codec, TWL4030_REG_ANAMICL,
+                anamicl | TWL4030_CNCL_OFFSET_START);
+
+        /* wait for offset cancellation to complete */
+        do {
+                /* this takes a little while, so don't slam i2c */
+                udelay(2000);
+                twl4030_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE, &byte,
+                                    TWL4030_REG_ANAMICL);
+        } while ((i++ < 100) &&
+                 ((byte & TWL4030_CNCL_OFFSET_START) ==
+                  TWL4030_CNCL_OFFSET_START));
+
+        /* Make sure that the reg_cache has the same value as the HW */
+        twl4030_write_reg_cache(codec, TWL4030_REG_ANAMICL, byte);
+
+        /* anti-pop when changing analog gain */
+        regmisc1 = twl4030_read_reg_cache(codec, TWL4030_REG_MISC_SET_1);
+        twl4030_write(codec, TWL4030_REG_MISC_SET_1,
+                regmisc1 | TWL4030_SMOOTH_ANAVOL_EN);
+
+        /* toggle CODECPDZ as per TRM */
+        twl4030_codec_enable(codec, 0);
+        twl4030_codec_enable(codec, 1);
+}
+
+/*
+ * Unconditional power down
+ */
+static void twl4030_power_down(struct snd_soc_codec *codec)
+{
+        /* power down */
+        twl4030_codec_enable(codec, 0);
+}
+
 /* Earpiece */
 static const char *twl4030_earpiece_texts[] =
                 {"Off", "DACL1", "DACL2", "DACR1"};
@@ -366,6 +488,41 @@ static const struct soc_enum twl4030_micpathtx2_enum =
 static const struct snd_kcontrol_new twl4030_dapm_micpathtx2_control =
 SOC_DAPM_ENUM("Route", twl4030_micpathtx2_enum);
 
+/* Analog bypass for AudioR1 */
+static const struct snd_kcontrol_new twl4030_dapm_abypassr1_control =
+        SOC_DAPM_SINGLE("Switch", TWL4030_REG_ARXR1_APGA_CTL, 2, 1, 0);
+
+/* Analog bypass for AudioL1 */
+static const struct snd_kcontrol_new twl4030_dapm_abypassl1_control =
+        SOC_DAPM_SINGLE("Switch", TWL4030_REG_ARXL1_APGA_CTL, 2, 1, 0);
+
+/* Analog bypass for AudioR2 */
+static const struct snd_kcontrol_new twl4030_dapm_abypassr2_control =
+        SOC_DAPM_SINGLE("Switch", TWL4030_REG_ARXR2_APGA_CTL, 2, 1, 0);
+
+/* Analog bypass for AudioL2 */
+static const struct snd_kcontrol_new twl4030_dapm_abypassl2_control =
+        SOC_DAPM_SINGLE("Switch", TWL4030_REG_ARXL2_APGA_CTL, 2, 1, 0);
+
+/* Digital bypass gain, 0 mutes the bypass */
+static const unsigned int twl4030_dapm_dbypass_tlv[] = {
+        TLV_DB_RANGE_HEAD(2),
+        0, 3, TLV_DB_SCALE_ITEM(-2400, 0, 1),
+        4, 7, TLV_DB_SCALE_ITEM(-1800, 600, 0),
+};
+
+/* Digital bypass left (TX1L -> RX2L) */
+static const struct snd_kcontrol_new twl4030_dapm_dbypassl_control =
+        SOC_DAPM_SINGLE_TLV("Volume",
+                        TWL4030_REG_ATX2ARXPGA, 3, 7, 0,
+                        twl4030_dapm_dbypass_tlv);
+
+/* Digital bypass right (TX1R -> RX2R) */
+static const struct snd_kcontrol_new twl4030_dapm_dbypassr_control =
+        SOC_DAPM_SINGLE_TLV("Volume",
+                        TWL4030_REG_ATX2ARXPGA, 0, 7, 0,
+                        twl4030_dapm_dbypass_tlv);
+
 static int micpath_event(struct snd_soc_dapm_widget *w,
         struct snd_kcontrol *kcontrol, int event)
 {
@@ -420,6 +577,79 @@ static int handsfree_event(struct snd_soc_dapm_widget *w,
         return 0;
 }
 
+static int headsetl_event(struct snd_soc_dapm_widget *w,
+                struct snd_kcontrol *kcontrol, int event)
+{
+        unsigned char hs_gain, hs_pop;
+
+        /* Save the current volume */
+        hs_gain = twl4030_read_reg_cache(w->codec, TWL4030_REG_HS_GAIN_SET);
+        hs_pop = twl4030_read_reg_cache(w->codec, TWL4030_REG_HS_POPN_SET);
+
+        switch (event) {
+        case SND_SOC_DAPM_POST_PMU:
+                /* Do the anti-pop/bias ramp enable according to the TRM */
+                hs_pop |= TWL4030_VMID_EN;
+                twl4030_write(w->codec, TWL4030_REG_HS_POPN_SET, hs_pop);
+                /* Is this needed? Can we just use whatever gain here? */
+                twl4030_write(w->codec, TWL4030_REG_HS_GAIN_SET,
+                                (hs_gain & (~0x0f)) | 0x0a);
+                hs_pop |= TWL4030_RAMP_EN;
+                twl4030_write(w->codec, TWL4030_REG_HS_POPN_SET, hs_pop);
+
+                /* Restore the original volume */
+                twl4030_write(w->codec, TWL4030_REG_HS_GAIN_SET, hs_gain);
+                break;
+        case SND_SOC_DAPM_POST_PMD:
+                /* Do the anti-pop/bias ramp disable according to the TRM */
+                hs_pop &= ~TWL4030_RAMP_EN;
+                twl4030_write(w->codec, TWL4030_REG_HS_POPN_SET, hs_pop);
+                /* Bypass the reg_cache to mute the headset */
+                twl4030_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                        hs_gain & (~0x0f),
+                                        TWL4030_REG_HS_GAIN_SET);
+                hs_pop &= ~TWL4030_VMID_EN;
+                twl4030_write(w->codec, TWL4030_REG_HS_POPN_SET, hs_pop);
+                break;
+        }
+        return 0;
+}
+
+static int bypass_event(struct snd_soc_dapm_widget *w,
+                struct snd_kcontrol *kcontrol, int event)
+{
+        struct soc_mixer_control *m =
+                (struct soc_mixer_control *)w->kcontrols->private_value;
+        struct twl4030_priv *twl4030 = w->codec->private_data;
+        unsigned char reg;
+
+        reg = twl4030_read_reg_cache(w->codec, m->reg);
+
+        if (m->reg <= TWL4030_REG_ARXR2_APGA_CTL) {
+                /* Analog bypass */
+                if (reg & (1 << m->shift))
+                        twl4030->bypass_state |=
+                                (1 << (m->reg - TWL4030_REG_ARXL1_APGA_CTL));
+                else
+                        twl4030->bypass_state &=
+                                ~(1 << (m->reg - TWL4030_REG_ARXL1_APGA_CTL));
+        } else {
+                /* Digital bypass */
+                if (reg & (0x7 << m->shift))
+                        twl4030->bypass_state |= (1 << (m->shift ? 5 : 4));
+                else
+                        twl4030->bypass_state &= ~(1 << (m->shift ? 5 : 4));
+        }
+
+        if (w->codec->bias_level == SND_SOC_BIAS_STANDBY) {
+                if (twl4030->bypass_state)
+                        twl4030_codec_mute(w->codec, 0);
+                else
+                        twl4030_codec_mute(w->codec, 1);
+        }
+        return 0;
+}
+
 /*
  * Some of the gain controls in TWL (mostly those which are associated with
  * the outputs) are implemented in an interesting way:
@@ -614,6 +844,17 @@ static DECLARE_TLV_DB_SCALE(digital_capture_tlv, 0, 100, 0);
  */
 static DECLARE_TLV_DB_SCALE(input_gain_tlv, 0, 600, 0);
 
+static const char *twl4030_rampdelay_texts[] = {
+        "27/20/14 ms", "55/40/27 ms", "109/81/55 ms", "218/161/109 ms",
+        "437/323/218 ms", "874/645/437 ms", "1748/1291/874 ms",
+        "3495/2581/1748 ms"
+};
+
+static const struct soc_enum twl4030_rampdelay_enum =
+        SOC_ENUM_SINGLE(TWL4030_REG_HS_POPN_SET, 2,
+                        ARRAY_SIZE(twl4030_rampdelay_texts),
+                        twl4030_rampdelay_texts);
+
 static const struct snd_kcontrol_new twl4030_snd_controls[] = {
         /* Common playback gain controls */
         SOC_DOUBLE_R_TLV("DAC1 Digital Fine Playback Volume",
@@ -668,23 +909,9 @@ static const struct snd_kcontrol_new twl4030_snd_controls[] = {
 
         SOC_DOUBLE_TLV("Analog Capture Volume", TWL4030_REG_ANAMIC_GAIN,
                 0, 3, 5, 0, input_gain_tlv),
-};
-
-/* add non dapm controls */
-static int twl4030_add_controls(struct snd_soc_codec *codec)
-{
-        int err, i;
-
-        for (i = 0; i < ARRAY_SIZE(twl4030_snd_controls); i++) {
-                err = snd_ctl_add(codec->card,
-                                  snd_soc_cnew(&twl4030_snd_controls[i],
-                                                codec, NULL));
-                if (err < 0)
-                        return err;
-        }
 
-        return 0;
-}
+        SOC_ENUM("HS ramp delay", twl4030_rampdelay_enum),
+};
 
 static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
         /* Left channel inputs */
@@ -714,13 +941,13 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
 
         /* DACs */
         SND_SOC_DAPM_DAC("DAC Right1", "Right Front Playback",
-                        TWL4030_REG_AVDAC_CTL, 0, 0),
+                        SND_SOC_NOPM, 0, 0),
         SND_SOC_DAPM_DAC("DAC Left1", "Left Front Playback",
-                        TWL4030_REG_AVDAC_CTL, 1, 0),
+                        SND_SOC_NOPM, 0, 0),
         SND_SOC_DAPM_DAC("DAC Right2", "Right Rear Playback",
-                        TWL4030_REG_AVDAC_CTL, 2, 0),
+                        SND_SOC_NOPM, 0, 0),
         SND_SOC_DAPM_DAC("DAC Left2", "Left Rear Playback",
-                        TWL4030_REG_AVDAC_CTL, 3, 0),
+                        SND_SOC_NOPM, 0, 0),
 
         /* Analog PGAs */
         SND_SOC_DAPM_PGA("ARXR1_APGA", TWL4030_REG_ARXR1_APGA_CTL,
@@ -732,6 +959,37 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
         SND_SOC_DAPM_PGA("ARXL2_APGA", TWL4030_REG_ARXL2_APGA_CTL,
                         0, 0, NULL, 0),
 
+        /* Analog bypasses */
+        SND_SOC_DAPM_SWITCH_E("Right1 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassr1_control, bypass_event,
+                        SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH_E("Left1 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassl1_control,
+                        bypass_event, SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH_E("Right2 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassr2_control,
+                        bypass_event, SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH_E("Left2 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassl2_control,
+                        bypass_event, SND_SOC_DAPM_POST_REG),
+
+        /* Digital bypasses */
+        SND_SOC_DAPM_SWITCH_E("Left Digital Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_dbypassl_control, bypass_event,
+                        SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH_E("Right Digital Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_dbypassr_control, bypass_event,
+                        SND_SOC_DAPM_POST_REG),
+
+        SND_SOC_DAPM_MIXER("Analog R1 Playback Mixer", TWL4030_REG_AVDAC_CTL,
+                        0, 0, NULL, 0),
+        SND_SOC_DAPM_MIXER("Analog L1 Playback Mixer", TWL4030_REG_AVDAC_CTL,
+                        1, 0, NULL, 0),
+        SND_SOC_DAPM_MIXER("Analog R2 Playback Mixer", TWL4030_REG_AVDAC_CTL,
+                        2, 0, NULL, 0),
+        SND_SOC_DAPM_MIXER("Analog L2 Playback Mixer", TWL4030_REG_AVDAC_CTL,
+                        3, 0, NULL, 0),
+
         /* Output MUX controls */
         /* Earpiece */
         SND_SOC_DAPM_VALUE_MUX("Earpiece Mux", SND_SOC_NOPM, 0, 0,
@@ -742,8 +1000,9 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
         SND_SOC_DAPM_VALUE_MUX("PredriveR Mux", SND_SOC_NOPM, 0, 0,
                 &twl4030_dapm_predriver_control),
         /* HeadsetL/R */
-        SND_SOC_DAPM_MUX("HeadsetL Mux", SND_SOC_NOPM, 0, 0,
-                &twl4030_dapm_hsol_control),
+        SND_SOC_DAPM_MUX_E("HeadsetL Mux", SND_SOC_NOPM, 0, 0,
+                &twl4030_dapm_hsol_control, headsetl_event,
+                SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD),
         SND_SOC_DAPM_MUX("HeadsetR Mux", SND_SOC_NOPM, 0, 0,
                 &twl4030_dapm_hsor_control),
         /* CarkitL/R */
@@ -782,16 +1041,16 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
                 SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD|
                 SND_SOC_DAPM_POST_REG),
 
-        /* Analog input muxes with power switch for the physical ADCL/R */
+        /* Analog input muxes with switch for the capture amplifiers */
         SND_SOC_DAPM_VALUE_MUX("Analog Left Capture Route",
-                TWL4030_REG_AVADC_CTL, 3, 0, &twl4030_dapm_analoglmic_control),
+                TWL4030_REG_ANAMICL, 4, 0, &twl4030_dapm_analoglmic_control),
         SND_SOC_DAPM_VALUE_MUX("Analog Right Capture Route",
-                TWL4030_REG_AVADC_CTL, 1, 0, &twl4030_dapm_analogrmic_control),
+                TWL4030_REG_ANAMICR, 4, 0, &twl4030_dapm_analogrmic_control),
 
-        SND_SOC_DAPM_PGA("Analog Left Amplifier",
-                TWL4030_REG_ANAMICL, 4, 0, NULL, 0),
-        SND_SOC_DAPM_PGA("Analog Right Amplifier",
-                TWL4030_REG_ANAMICR, 4, 0, NULL, 0),
+        SND_SOC_DAPM_PGA("ADC Physical Left",
+                TWL4030_REG_AVADC_CTL, 3, 0, NULL, 0),
+        SND_SOC_DAPM_PGA("ADC Physical Right",
+                TWL4030_REG_AVADC_CTL, 1, 0, NULL, 0),
 
         SND_SOC_DAPM_PGA("Digimic0 Enable",
                 TWL4030_REG_ADCMICSEL, 1, 0, NULL, 0),
@@ -801,13 +1060,19 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
         SND_SOC_DAPM_MICBIAS("Mic Bias 1", TWL4030_REG_MICBIAS_CTL, 0, 0),
         SND_SOC_DAPM_MICBIAS("Mic Bias 2", TWL4030_REG_MICBIAS_CTL, 1, 0),
         SND_SOC_DAPM_MICBIAS("Headset Mic Bias", TWL4030_REG_MICBIAS_CTL, 2, 0),
+
 };
 
 static const struct snd_soc_dapm_route intercon[] = {
-        {"ARXL1_APGA", NULL, "DAC Left1"},
-        {"ARXR1_APGA", NULL, "DAC Right1"},
-        {"ARXL2_APGA", NULL, "DAC Left2"},
-        {"ARXR2_APGA", NULL, "DAC Right2"},
+        {"Analog L1 Playback Mixer", NULL, "DAC Left1"},
+        {"Analog R1 Playback Mixer", NULL, "DAC Right1"},
+        {"Analog L2 Playback Mixer", NULL, "DAC Left2"},
+        {"Analog R2 Playback Mixer", NULL, "DAC Right2"},
+
+        {"ARXL1_APGA", NULL, "Analog L1 Playback Mixer"},
+        {"ARXR1_APGA", NULL, "Analog R1 Playback Mixer"},
+        {"ARXL2_APGA", NULL, "Analog L2 Playback Mixer"},
+        {"ARXR2_APGA", NULL, "Analog R2 Playback Mixer"},
 
         /* Internal playback routings */
         /* Earpiece */
@@ -865,23 +1130,23 @@ static const struct snd_soc_dapm_route intercon[] = {
         {"Analog Right Capture Route", "Sub mic", "SUBMIC"},
         {"Analog Right Capture Route", "AUXR", "AUXR"},
 
-        {"Analog Left Amplifier", NULL, "Analog Left Capture Route"},
-        {"Analog Right Amplifier", NULL, "Analog Right Capture Route"},
+        {"ADC Physical Left", NULL, "Analog Left Capture Route"},
+        {"ADC Physical Right", NULL, "Analog Right Capture Route"},
 
         {"Digimic0 Enable", NULL, "DIGIMIC0"},
         {"Digimic1 Enable", NULL, "DIGIMIC1"},
 
         /* TX1 Left capture path */
-        {"TX1 Capture Route", "Analog", "Analog Left Amplifier"},
+        {"TX1 Capture Route", "Analog", "ADC Physical Left"},
         {"TX1 Capture Route", "Digimic0", "Digimic0 Enable"},
         /* TX1 Right capture path */
-        {"TX1 Capture Route", "Analog", "Analog Right Amplifier"},
+        {"TX1 Capture Route", "Analog", "ADC Physical Right"},
         {"TX1 Capture Route", "Digimic0", "Digimic0 Enable"},
         /* TX2 Left capture path */
-        {"TX2 Capture Route", "Analog", "Analog Left Amplifier"},
+        {"TX2 Capture Route", "Analog", "ADC Physical Left"},
         {"TX2 Capture Route", "Digimic1", "Digimic1 Enable"},
         /* TX2 Right capture path */
-        {"TX2 Capture Route", "Analog", "Analog Right Amplifier"},
+        {"TX2 Capture Route", "Analog", "ADC Physical Right"},
         {"TX2 Capture Route", "Digimic1", "Digimic1 Enable"},
 
         {"ADC Virtual Left1", NULL, "TX1 Capture Route"},
@@ -889,6 +1154,24 @@ static const struct snd_soc_dapm_route intercon[] = {
         {"ADC Virtual Left2", NULL, "TX2 Capture Route"},
         {"ADC Virtual Right2", NULL, "TX2 Capture Route"},
 
+        /* Analog bypass routes */
+        {"Right1 Analog Loopback", "Switch", "Analog Right Capture Route"},
+        {"Left1 Analog Loopback", "Switch", "Analog Left Capture Route"},
+        {"Right2 Analog Loopback", "Switch", "Analog Right Capture Route"},
+        {"Left2 Analog Loopback", "Switch", "Analog Left Capture Route"},
+
+        {"Analog R1 Playback Mixer", NULL, "Right1 Analog Loopback"},
+        {"Analog L1 Playback Mixer", NULL, "Left1 Analog Loopback"},
+        {"Analog R2 Playback Mixer", NULL, "Right2 Analog Loopback"},
+        {"Analog L2 Playback Mixer", NULL, "Left2 Analog Loopback"},
+
+        /* Digital bypass routes */
+        {"Right Digital Loopback", "Volume", "TX1 Capture Route"},
+        {"Left Digital Loopback", "Volume", "TX1 Capture Route"},
+
+        {"Analog R2 Playback Mixer", NULL, "Right Digital Loopback"},
+        {"Analog L2 Playback Mixer", NULL, "Left Digital Loopback"},
+
 };
 
 static int twl4030_add_widgets(struct snd_soc_codec *codec)
@@ -902,82 +1185,28 @@ static int twl4030_add_widgets(struct snd_soc_codec *codec)
         return 0;
 }
 
-static void twl4030_power_up(struct snd_soc_codec *codec)
-{
-        u8 anamicl, regmisc1, byte, popn;
-        int i = 0;
-
-        /* set CODECPDZ to turn on codec */
-        twl4030_set_codecpdz(codec);
-
-        /* initiate offset cancellation */
-        anamicl = twl4030_read_reg_cache(codec, TWL4030_REG_ANAMICL);
-        twl4030_write(codec, TWL4030_REG_ANAMICL,
-                anamicl | TWL4030_CNCL_OFFSET_START);
-
-
-        /* wait for offset cancellation to complete */
-        do {
-                /* this takes a little while, so don't slam i2c */
-                udelay(2000);
-                twl4030_i2c_read_u8(TWL4030_MODULE_AUDIO_VOICE, &byte,
-                                    TWL4030_REG_ANAMICL);
-        } while ((i++ < 100) &&
-                 ((byte & TWL4030_CNCL_OFFSET_START) ==
-                  TWL4030_CNCL_OFFSET_START));
-
-        /* anti-pop when changing analog gain */
-        regmisc1 = twl4030_read_reg_cache(codec, TWL4030_REG_MISC_SET_1);
-        twl4030_write(codec, TWL4030_REG_MISC_SET_1,
-                regmisc1 | TWL4030_SMOOTH_ANAVOL_EN);
-
-        /* toggle CODECPDZ as per TRM */
-        twl4030_clear_codecpdz(codec);
-        twl4030_set_codecpdz(codec);
-
-        /* program anti-pop with bias ramp delay */
-        popn = twl4030_read_reg_cache(codec, TWL4030_REG_HS_POPN_SET);
-        popn &= TWL4030_RAMP_DELAY;
-        popn |= TWL4030_RAMP_DELAY_645MS;
-        twl4030_write(codec, TWL4030_REG_HS_POPN_SET, popn);
-        popn |= TWL4030_VMID_EN;
-        twl4030_write(codec, TWL4030_REG_HS_POPN_SET, popn);
-
-        /* enable anti-pop ramp */
-        popn |= TWL4030_RAMP_EN;
-        twl4030_write(codec, TWL4030_REG_HS_POPN_SET, popn);
-}
-
-static void twl4030_power_down(struct snd_soc_codec *codec)
-{
-        u8 popn;
-
-        /* disable anti-pop ramp */
-        popn = twl4030_read_reg_cache(codec, TWL4030_REG_HS_POPN_SET);
-        popn &= ~TWL4030_RAMP_EN;
-        twl4030_write(codec, TWL4030_REG_HS_POPN_SET, popn);
-
-        /* disable bias out */
-        popn &= ~TWL4030_VMID_EN;
-        twl4030_write(codec, TWL4030_REG_HS_POPN_SET, popn);
-
-        /* power down */
-        twl4030_clear_codecpdz(codec);
-}
-
 static int twl4030_set_bias_level(struct snd_soc_codec *codec,
                                   enum snd_soc_bias_level level)
 {
+        struct twl4030_priv *twl4030 = codec->private_data;
+
         switch (level) {
         case SND_SOC_BIAS_ON:
-                twl4030_power_up(codec);
+                twl4030_codec_mute(codec, 0);
                 break;
         case SND_SOC_BIAS_PREPARE:
-                /* TODO: develop a twl4030_prepare function */
+                twl4030_power_up(codec);
+                if (twl4030->bypass_state)
+                        twl4030_codec_mute(codec, 0);
+                else
+                        twl4030_codec_mute(codec, 1);
                 break;
         case SND_SOC_BIAS_STANDBY:
-                /* TODO: develop a twl4030_standby function */
-                twl4030_power_down(codec);
+                twl4030_power_up(codec);
+                if (twl4030->bypass_state)
+                        twl4030_codec_mute(codec, 0);
+                else
+                        twl4030_codec_mute(codec, 1);
                 break;
         case SND_SOC_BIAS_OFF:
                 twl4030_power_down(codec);
@@ -994,10 +1223,9 @@ static int twl4030_hw_params(struct snd_pcm_substream *substream,
 {
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
         struct snd_soc_device *socdev = rtd->socdev;
-        struct snd_soc_codec *codec = socdev->codec;
+        struct snd_soc_codec *codec = socdev->card->codec;
         u8 mode, old_mode, format, old_format;
 
-
         /* bit rate */
         old_mode = twl4030_read_reg_cache(codec,
                         TWL4030_REG_CODEC_MODE) & ~TWL4030_CODECPDZ;
@@ -1039,8 +1267,9 @@ static int twl4030_hw_params(struct snd_pcm_substream *substream,
 
         if (mode != old_mode) {
                 /* change rate and set CODECPDZ */
+                twl4030_codec_enable(codec, 0);
                 twl4030_write(codec, TWL4030_REG_CODEC_MODE, mode);
-                twl4030_set_codecpdz(codec);
+                twl4030_codec_enable(codec, 1);
         }
 
         /* sample size */
@@ -1063,13 +1292,13 @@ static int twl4030_hw_params(struct snd_pcm_substream *substream,
         if (format != old_format) {
 
                 /* clear CODECPDZ before changing format (codec requirement) */
-                twl4030_clear_codecpdz(codec);
+                twl4030_codec_enable(codec, 0);
 
                 /* change format */
                 twl4030_write(codec, TWL4030_REG_AUDIO_IF, format);
 
                 /* set CODECPDZ afterwards */
-                twl4030_set_codecpdz(codec);
+                twl4030_codec_enable(codec, 1);
         }
         return 0;
 }
@@ -1139,13 +1368,13 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai,
         if (format != old_format) {
 
                 /* clear CODECPDZ before changing format (codec requirement) */
-                twl4030_clear_codecpdz(codec);
+                twl4030_codec_enable(codec, 0);
 
                 /* change format */
                 twl4030_write(codec, TWL4030_REG_AUDIO_IF, format);
 
                 /* set CODECPDZ afterwards */
-                twl4030_set_codecpdz(codec);
+                twl4030_codec_enable(codec, 1);
         }
 
         return 0;
@@ -1154,6 +1383,12 @@ static int twl4030_set_dai_fmt(struct snd_soc_dai *codec_dai,
 #define TWL4030_RATES    (SNDRV_PCM_RATE_8000_48000)
 #define TWL4030_FORMATS  (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FORMAT_S24_LE)
 
+static struct snd_soc_dai_ops twl4030_dai_ops = {
+        .hw_params      = twl4030_hw_params,
+        .set_sysclk     = twl4030_set_dai_sysclk,
+        .set_fmt        = twl4030_set_dai_fmt,
+};
+
 struct snd_soc_dai twl4030_dai = {
         .name = "twl4030",
         .playback = {
@@ -1168,18 +1403,14 @@ struct snd_soc_dai twl4030_dai = {
                 .channels_max = 2,
                 .rates = TWL4030_RATES,
                 .formats = TWL4030_FORMATS,},
-        .ops = {
-                .hw_params = twl4030_hw_params,
-                .set_sysclk = twl4030_set_dai_sysclk,
-                .set_fmt = twl4030_set_dai_fmt,
-        }
+        .ops = &twl4030_dai_ops,
 };
 EXPORT_SYMBOL_GPL(twl4030_dai);
 
 static int twl4030_suspend(struct platform_device *pdev, pm_message_t state)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->codec;
+        struct snd_soc_codec *codec = socdev->card->codec;
 
         twl4030_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
@@ -1189,7 +1420,7 @@ static int twl4030_suspend(struct platform_device *pdev, pm_message_t state)
 static int twl4030_resume(struct platform_device *pdev)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->codec;
+        struct snd_soc_codec *codec = socdev->card->codec;
 
         twl4030_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
         twl4030_set_bias_level(codec, codec->suspend_bias_level);
@@ -1203,7 +1434,7 @@ static int twl4030_resume(struct platform_device *pdev)
 
 static int twl4030_init(struct snd_soc_device *socdev)
 {
-        struct snd_soc_codec *codec = socdev->codec;
+        struct snd_soc_codec *codec = socdev->card->codec;
         int ret = 0;
 
         printk(KERN_INFO "TWL4030 Audio Codec init \n");
@@ -1233,7 +1464,8 @@ static int twl4030_init(struct snd_soc_device *socdev)
         /* power on device */
         twl4030_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
 
-        twl4030_add_controls(codec);
+        snd_soc_add_controls(codec, twl4030_snd_controls,
+                                ARRAY_SIZE(twl4030_snd_controls));
         twl4030_add_widgets(codec);
 
         ret = snd_soc_init_card(socdev);
@@ -1258,12 +1490,20 @@ static int twl4030_probe(struct platform_device *pdev)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
         struct snd_soc_codec *codec;
+        struct twl4030_priv *twl4030;
 
         codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
         if (codec == NULL)
                 return -ENOMEM;
 
-        socdev->codec = codec;
+        twl4030 = kzalloc(sizeof(struct twl4030_priv), GFP_KERNEL);
+        if (twl4030 == NULL) {
+                kfree(codec);
+                return -ENOMEM;
+        }
+
+        codec->private_data = twl4030;
+        socdev->card->codec = codec;
         mutex_init(&codec->mutex);
         INIT_LIST_HEAD(&codec->dapm_widgets);
         INIT_LIST_HEAD(&codec->dapm_paths);
@@ -1277,11 +1517,13 @@ static int twl4030_probe(struct platform_device *pdev)
 static int twl4030_remove(struct platform_device *pdev)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->codec;
+        struct snd_soc_codec *codec = socdev->card->codec;
 
         printk(KERN_INFO "TWL4030 Audio Codec remove\n");
+        twl4030_set_bias_level(codec, SND_SOC_BIAS_OFF);
         snd_soc_free_pcms(socdev);
         snd_soc_dapm_free(socdev);
+        kfree(codec->private_data);
         kfree(codec);
 
         return 0;