1 files changed, 222 insertions, 230 deletions

diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 4df7c6c61c76..5f1681f6ca76 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -120,9 +120,10 @@ static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = {
 
 /* codec private data */
 struct twl4030_priv {
-        unsigned int bypass_state;
+        struct snd_soc_codec codec;
+
         unsigned int codec_powered;
-        unsigned int codec_muted;
+        unsigned int apll_enabled;
 
         struct snd_pcm_substream *master_substream;
         struct snd_pcm_substream *slave_substream;
@@ -183,19 +184,20 @@ static int twl4030_write(struct snd_soc_codec *codec,
 static void twl4030_codec_enable(struct snd_soc_codec *codec, int enable)
 {
         struct twl4030_priv *twl4030 = codec->private_data;
-        u8 mode;
+        int mode;
 
         if (enable == twl4030->codec_powered)
                 return;
 
-        mode = twl4030_read_reg_cache(codec, TWL4030_REG_CODEC_MODE);
         if (enable)
-                mode |= TWL4030_CODECPDZ;
+                mode = twl4030_codec_enable_resource(TWL4030_CODEC_RES_POWER);
         else
-                mode &= ~TWL4030_CODECPDZ;
+                mode = twl4030_codec_disable_resource(TWL4030_CODEC_RES_POWER);
 
-        twl4030_write(codec, TWL4030_REG_CODEC_MODE, mode);
-        twl4030->codec_powered = enable;
+        if (mode >= 0) {
+                twl4030_write_reg_cache(codec, TWL4030_REG_CODEC_MODE, mode);
+                twl4030->codec_powered = enable;
+        }
 
         /* REVISIT: this delay is present in TI sample drivers */
         /* but there seems to be no TRM requirement for it     */
@@ -212,31 +214,30 @@ static void twl4030_init_chip(struct snd_soc_codec *codec)
 
         /* set all audio section registers to reasonable defaults */
         for (i = TWL4030_REG_OPTION; i <= TWL4030_REG_MISC_SET_2; i++)
-                twl4030_write(codec, i, cache[i]);
+                if (i != TWL4030_REG_APLL_CTL)
+                        twl4030_write(codec, i, cache[i]);
 
 }
 
-static void twl4030_codec_mute(struct snd_soc_codec *codec, int mute)
+static void twl4030_apll_enable(struct snd_soc_codec *codec, int enable)
 {
         struct twl4030_priv *twl4030 = codec->private_data;
-        u8 reg_val;
+        int status;
 
-        if (mute == twl4030->codec_muted)
+        if (enable == twl4030->apll_enabled)
                 return;
 
-        if (mute) {
-                /* Disable PLL */
-                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
-                reg_val &= ~TWL4030_APLL_EN;
-                twl4030_write(codec, TWL4030_REG_APLL_CTL, reg_val);
-        } else {
+        if (enable)
                 /* Enable PLL */
-                reg_val = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
-                reg_val |= TWL4030_APLL_EN;
-                twl4030_write(codec, TWL4030_REG_APLL_CTL, reg_val);
-        }
+                status = twl4030_codec_enable_resource(TWL4030_CODEC_RES_APLL);
+        else
+                /* Disable PLL */
+                status = twl4030_codec_disable_resource(TWL4030_CODEC_RES_APLL);
+
+        if (status >= 0)
+                twl4030_write_reg_cache(codec, TWL4030_REG_APLL_CTL, status);
 
-        twl4030->codec_muted = mute;
+        twl4030->apll_enabled = enable;
 }
 
 static void twl4030_power_up(struct snd_soc_codec *codec)
@@ -613,6 +614,27 @@ static int handsfreerpga_event(struct snd_soc_dapm_widget *w,
         return 0;
 }
 
+static int vibramux_event(struct snd_soc_dapm_widget *w,
+                struct snd_kcontrol *kcontrol, int event)
+{
+        twl4030_write(w->codec, TWL4030_REG_VIBRA_SET, 0xff);
+        return 0;
+}
+
+static int apll_event(struct snd_soc_dapm_widget *w,
+                struct snd_kcontrol *kcontrol, int event)
+{
+        switch (event) {
+        case SND_SOC_DAPM_PRE_PMU:
+                twl4030_apll_enable(w->codec, 1);
+                break;
+        case SND_SOC_DAPM_POST_PMD:
+                twl4030_apll_enable(w->codec, 0);
+                break;
+        }
+        return 0;
+}
+
 static void headset_ramp(struct snd_soc_codec *codec, int ramp)
 {
         struct snd_soc_device *socdev = codec->socdev;
@@ -724,67 +746,6 @@ static int headsetrpga_event(struct snd_soc_dapm_widget *w,
         return 0;
 }
 
-static int bypass_event(struct snd_soc_dapm_widget *w,
-                struct snd_kcontrol *kcontrol, int event)
-{
-        struct soc_mixer_control *m =
-                (struct soc_mixer_control *)w->kcontrols->private_value;
-        struct twl4030_priv *twl4030 = w->codec->private_data;
-        unsigned char reg, misc;
-
-        reg = twl4030_read_reg_cache(w->codec, m->reg);
-
-        /*
-         * bypass_state[0:3] - analog HiFi bypass
-         * bypass_state[4]   - analog voice bypass
-         * bypass_state[5]   - digital voice bypass
-         * bypass_state[6:7] - digital HiFi bypass
-         */
-        if (m->reg == TWL4030_REG_VSTPGA) {
-                /* Voice digital bypass */
-                if (reg)
-                        twl4030->bypass_state |= (1 << 5);
-                else
-                        twl4030->bypass_state &= ~(1 << 5);
-        } else if (m->reg <= TWL4030_REG_ARXR2_APGA_CTL) {
-                /* Analog bypass */
-                if (reg & (1 << m->shift))
-                        twl4030->bypass_state |=
-                                (1 << (m->reg - TWL4030_REG_ARXL1_APGA_CTL));
-                else
-                        twl4030->bypass_state &=
-                                ~(1 << (m->reg - TWL4030_REG_ARXL1_APGA_CTL));
-        } else if (m->reg == TWL4030_REG_VDL_APGA_CTL) {
-                /* Analog voice bypass */
-                if (reg & (1 << m->shift))
-                        twl4030->bypass_state |= (1 << 4);
-                else
-                        twl4030->bypass_state &= ~(1 << 4);
-        } else {
-                /* Digital bypass */
-                if (reg & (0x7 << m->shift))
-                        twl4030->bypass_state |= (1 << (m->shift ? 7 : 6));
-                else
-                        twl4030->bypass_state &= ~(1 << (m->shift ? 7 : 6));
-        }
-
-        /* Enable master analog loopback mode if any analog switch is enabled*/
-        misc = twl4030_read_reg_cache(w->codec, TWL4030_REG_MISC_SET_1);
-        if (twl4030->bypass_state & 0x1F)
-                misc |= TWL4030_FMLOOP_EN;
-        else
-                misc &= ~TWL4030_FMLOOP_EN;
-        twl4030_write(w->codec, TWL4030_REG_MISC_SET_1, misc);
-
-        if (w->codec->bias_level == SND_SOC_BIAS_STANDBY) {
-                if (twl4030->bypass_state)
-                        twl4030_codec_mute(w->codec, 0);
-                else
-                        twl4030_codec_mute(w->codec, 1);
-        }
-        return 0;
-}
-
 /*
  * Some of the gain controls in TWL (mostly those which are associated with
  * the outputs) are implemented in an interesting way:
@@ -1192,32 +1153,28 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
                         SND_SOC_NOPM, 0, 0),
 
         /* Analog bypasses */
-        SND_SOC_DAPM_SWITCH_E("Right1 Analog Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_abypassr1_control, bypass_event,
-                        SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Left1 Analog Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_abypassl1_control,
-                        bypass_event, SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Right2 Analog Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_abypassr2_control,
-                        bypass_event, SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Left2 Analog Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_abypassl2_control,
-                        bypass_event, SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Voice Analog Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_abypassv_control,
-                        bypass_event, SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH("Right1 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassr1_control),
+        SND_SOC_DAPM_SWITCH("Left1 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassl1_control),
+        SND_SOC_DAPM_SWITCH("Right2 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassr2_control),
+        SND_SOC_DAPM_SWITCH("Left2 Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassl2_control),
+        SND_SOC_DAPM_SWITCH("Voice Analog Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_abypassv_control),
+
+        /* Master analog loopback switch */
+        SND_SOC_DAPM_SUPPLY("FM Loop Enable", TWL4030_REG_MISC_SET_1, 5, 0,
+                            NULL, 0),
 
         /* Digital bypasses */
-        SND_SOC_DAPM_SWITCH_E("Left Digital Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_dbypassl_control, bypass_event,
-                        SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Right Digital Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_dbypassr_control, bypass_event,
-                        SND_SOC_DAPM_POST_REG),
-        SND_SOC_DAPM_SWITCH_E("Voice Digital Loopback", SND_SOC_NOPM, 0, 0,
-                        &twl4030_dapm_dbypassv_control, bypass_event,
-                        SND_SOC_DAPM_POST_REG),
+        SND_SOC_DAPM_SWITCH("Left Digital Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_dbypassl_control),
+        SND_SOC_DAPM_SWITCH("Right Digital Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_dbypassr_control),
+        SND_SOC_DAPM_SWITCH("Voice Digital Loopback", SND_SOC_NOPM, 0, 0,
+                        &twl4030_dapm_dbypassv_control),
 
         /* Digital mixers, power control for the physical DACs */
         SND_SOC_DAPM_MIXER("Digital R1 Playback Mixer",
@@ -1243,6 +1200,9 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
         SND_SOC_DAPM_MIXER("Analog Voice Playback Mixer",
                         TWL4030_REG_VDL_APGA_CTL, 0, 0, NULL, 0),
 
+        SND_SOC_DAPM_SUPPLY("APLL Enable", SND_SOC_NOPM, 0, 0, apll_event,
+                            SND_SOC_DAPM_PRE_PMU|SND_SOC_DAPM_POST_PMD),
+
         /* Output MIXER controls */
         /* Earpiece */
         SND_SOC_DAPM_MIXER("Earpiece Mixer", SND_SOC_NOPM, 0, 0,
@@ -1308,8 +1268,9 @@ static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
                         0, 0, NULL, 0, handsfreerpga_event,
                         SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD),
         /* Vibra */
-        SND_SOC_DAPM_MUX("Vibra Mux", TWL4030_REG_VIBRA_CTL, 0, 0,
-                &twl4030_dapm_vibra_control),
+        SND_SOC_DAPM_MUX_E("Vibra Mux", TWL4030_REG_VIBRA_CTL, 0, 0,
+                           &twl4030_dapm_vibra_control, vibramux_event,
+                           SND_SOC_DAPM_PRE_PMU),
         SND_SOC_DAPM_MUX("Vibra Route", SND_SOC_NOPM, 0, 0,
                 &twl4030_dapm_vibrapath_control),
 
@@ -1369,6 +1330,13 @@ static const struct snd_soc_dapm_route intercon[] = {
         {"Digital R2 Playback Mixer", NULL, "DAC Right2"},
         {"Digital Voice Playback Mixer", NULL, "DAC Voice"},
 
+        /* Supply for the digital part (APLL) */
+        {"Digital R1 Playback Mixer", NULL, "APLL Enable"},
+        {"Digital L1 Playback Mixer", NULL, "APLL Enable"},
+        {"Digital R2 Playback Mixer", NULL, "APLL Enable"},
+        {"Digital L2 Playback Mixer", NULL, "APLL Enable"},
+        {"Digital Voice Playback Mixer", NULL, "APLL Enable"},
+
         {"Analog L1 Playback Mixer", NULL, "Digital L1 Playback Mixer"},
         {"Analog R1 Playback Mixer", NULL, "Digital R1 Playback Mixer"},
         {"Analog L2 Playback Mixer", NULL, "Digital L2 Playback Mixer"},
@@ -1482,6 +1450,11 @@ static const struct snd_soc_dapm_route intercon[] = {
         {"ADC Virtual Left2", NULL, "TX2 Capture Route"},
         {"ADC Virtual Right2", NULL, "TX2 Capture Route"},
 
+        {"ADC Virtual Left1", NULL, "APLL Enable"},
+        {"ADC Virtual Right1", NULL, "APLL Enable"},
+        {"ADC Virtual Left2", NULL, "APLL Enable"},
+        {"ADC Virtual Right2", NULL, "APLL Enable"},
+
         /* Analog bypass routes */
         {"Right1 Analog Loopback", "Switch", "Analog Right"},
         {"Left1 Analog Loopback", "Switch", "Analog Left"},
@@ -1489,6 +1462,13 @@ static const struct snd_soc_dapm_route intercon[] = {
         {"Left2 Analog Loopback", "Switch", "Analog Left"},
         {"Voice Analog Loopback", "Switch", "Analog Left"},
 
+        /* Supply for the Analog loopbacks */
+        {"Right1 Analog Loopback", NULL, "FM Loop Enable"},
+        {"Left1 Analog Loopback", NULL, "FM Loop Enable"},
+        {"Right2 Analog Loopback", NULL, "FM Loop Enable"},
+        {"Left2 Analog Loopback", NULL, "FM Loop Enable"},
+        {"Voice Analog Loopback", NULL, "FM Loop Enable"},
+
         {"Analog R1 Playback Mixer", NULL, "Right1 Analog Loopback"},
         {"Analog L1 Playback Mixer", NULL, "Left1 Analog Loopback"},
         {"Analog R2 Playback Mixer", NULL, "Right2 Analog Loopback"},
@@ -1513,32 +1493,20 @@ static int twl4030_add_widgets(struct snd_soc_codec *codec)
 
         snd_soc_dapm_add_routes(codec, intercon, ARRAY_SIZE(intercon));
 
-        snd_soc_dapm_new_widgets(codec);
         return 0;
 }
 
 static int twl4030_set_bias_level(struct snd_soc_codec *codec,
                                   enum snd_soc_bias_level level)
 {
-        struct twl4030_priv *twl4030 = codec->private_data;
-
         switch (level) {
         case SND_SOC_BIAS_ON:
-                twl4030_codec_mute(codec, 0);
                 break;
         case SND_SOC_BIAS_PREPARE:
-                twl4030_power_up(codec);
-                if (twl4030->bypass_state)
-                        twl4030_codec_mute(codec, 0);
-                else
-                        twl4030_codec_mute(codec, 1);
                 break;
         case SND_SOC_BIAS_STANDBY:
-                twl4030_power_up(codec);
-                if (twl4030->bypass_state)
-                        twl4030_codec_mute(codec, 0);
-                else
-                        twl4030_codec_mute(codec, 1);
+                if (codec->bias_level == SND_SOC_BIAS_OFF)
+                        twl4030_power_up(codec);
                 break;
         case SND_SOC_BIAS_OFF:
                 twl4030_power_down(codec);
@@ -1785,29 +1753,23 @@ static int twl4030_set_dai_sysclk(struct snd_soc_dai *codec_dai,
 {
         struct snd_soc_codec *codec = codec_dai->codec;
         struct twl4030_priv *twl4030 = codec->private_data;
-        u8 infreq;
 
         switch (freq) {
         case 19200000:
-                infreq = TWL4030_APLL_INFREQ_19200KHZ;
-                twl4030->sysclk = 19200;
-                break;
         case 26000000:
-                infreq = TWL4030_APLL_INFREQ_26000KHZ;
-                twl4030->sysclk = 26000;
-                break;
         case 38400000:
-                infreq = TWL4030_APLL_INFREQ_38400KHZ;
-                twl4030->sysclk = 38400;
                 break;
         default:
-                printk(KERN_ERR "TWL4030 set sysclk: unknown rate %d\n",
-                        freq);
+                dev_err(codec->dev, "Unsupported APLL mclk: %u\n", freq);
                 return -EINVAL;
         }
 
-        infreq |= TWL4030_APLL_EN;
-        twl4030_write(codec, TWL4030_REG_APLL_CTL, infreq);
+        if ((freq / 1000) != twl4030->sysclk) {
+                dev_err(codec->dev,
+                        "Mismatch in APLL mclk: %u (configured: %u)\n",
+                        freq, twl4030->sysclk * 1000);
+                return -EINVAL;
+        }
 
         return 0;
 }
@@ -1905,18 +1867,16 @@ static int twl4030_voice_startup(struct snd_pcm_substream *substream,
         struct snd_soc_pcm_runtime *rtd = substream->private_data;
         struct snd_soc_device *socdev = rtd->socdev;
         struct snd_soc_codec *codec = socdev->card->codec;
-        u8 infreq;
+        struct twl4030_priv *twl4030 = codec->private_data;
         u8 mode;
 
         /* If the system master clock is not 26MHz, the voice PCM interface is
          * not avilable.
          */
-        infreq = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL)
-                & TWL4030_APLL_INFREQ;
-
-        if (infreq != TWL4030_APLL_INFREQ_26000KHZ) {
-                printk(KERN_ERR "TWL4030 voice startup: "
-                        "MCLK is not 26MHz, call set_sysclk() on init\n");
+        if (twl4030->sysclk != 26000) {
+                dev_err(codec->dev, "The board is configured for %u Hz, while"
+                        "the Voice interface needs 26MHz APLL mclk\n",
+                        twl4030->sysclk * 1000);
                 return -EINVAL;
         }
 
@@ -1989,21 +1949,19 @@ static int twl4030_voice_set_dai_sysclk(struct snd_soc_dai *codec_dai,
                 int clk_id, unsigned int freq, int dir)
 {
         struct snd_soc_codec *codec = codec_dai->codec;
-        u8 infreq;
+        struct twl4030_priv *twl4030 = codec->private_data;
 
-        switch (freq) {
-        case 26000000:
-                infreq = TWL4030_APLL_INFREQ_26000KHZ;
-                break;
-        default:
-                printk(KERN_ERR "TWL4030 voice set sysclk: unknown rate %d\n",
-                        freq);
+        if (freq != 26000000) {
+                dev_err(codec->dev, "Unsupported APLL mclk: %u, the Voice"
+                        "interface needs 26MHz APLL mclk\n", freq);
+                return -EINVAL;
+        }
+        if ((freq / 1000) != twl4030->sysclk) {
+                dev_err(codec->dev,
+                        "Mismatch in APLL mclk: %u (configured: %u)\n",
+                        freq, twl4030->sysclk * 1000);
                 return -EINVAL;
         }
-
-        infreq |= TWL4030_APLL_EN;
-        twl4030_write(codec, TWL4030_REG_APLL_CTL, infreq);
-
         return 0;
 }
 
@@ -2121,7 +2079,7 @@ struct snd_soc_dai twl4030_dai[] = {
 };
 EXPORT_SYMBOL_GPL(twl4030_dai);
 
-static int twl4030_suspend(struct platform_device *pdev, pm_message_t state)
+static int twl4030_soc_suspend(struct platform_device *pdev, pm_message_t state)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
         struct snd_soc_codec *codec = socdev->card->codec;
@@ -2131,7 +2089,7 @@ static int twl4030_suspend(struct platform_device *pdev, pm_message_t state)
         return 0;
 }
 
-static int twl4030_resume(struct platform_device *pdev)
+static int twl4030_soc_resume(struct platform_device *pdev)
 {
         struct snd_soc_device *socdev = platform_get_drvdata(pdev);
         struct snd_soc_codec *codec = socdev->card->codec;
@@ -2141,147 +2099,181 @@ static int twl4030_resume(struct platform_device *pdev)
         return 0;
 }
 
-/*
- * initialize the driver
- * register the mixer and dsp interfaces with the kernel
- */
+static struct snd_soc_codec *twl4030_codec;
 
-static int twl4030_init(struct snd_soc_device *socdev)
+static int twl4030_soc_probe(struct platform_device *pdev)
 {
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
         struct twl4030_setup_data *setup = socdev->codec_data;
-        struct twl4030_priv *twl4030 = codec->private_data;
-        int ret = 0;
+        struct snd_soc_codec *codec;
+        struct twl4030_priv *twl4030;
+        int ret;
 
-        printk(KERN_INFO "TWL4030 Audio Codec init \n");
+        BUG_ON(!twl4030_codec);
 
-        codec->name = "twl4030";
-        codec->owner = THIS_MODULE;
-        codec->read = twl4030_read_reg_cache;
-        codec->write = twl4030_write;
-        codec->set_bias_level = twl4030_set_bias_level;
-        codec->dai = twl4030_dai;
-        codec->num_dai = ARRAY_SIZE(twl4030_dai),
-        codec->reg_cache_size = sizeof(twl4030_reg);
-        codec->reg_cache = kmemdup(twl4030_reg, sizeof(twl4030_reg),
-                                        GFP_KERNEL);
-        if (codec->reg_cache == NULL)
-                return -ENOMEM;
+        codec = twl4030_codec;
+        twl4030 = codec->private_data;
+        socdev->card->codec = codec;
 
         /* Configuration for headset ramp delay from setup data */
         if (setup) {
                 unsigned char hs_pop;
 
-                if (setup->sysclk)
-                        twl4030->sysclk = setup->sysclk;
-                else
-                        twl4030->sysclk = 26000;
+                if (setup->sysclk != twl4030->sysclk)
+                        dev_warn(&pdev->dev,
+                                 "Mismatch in APLL mclk: %u (configured: %u)\n",
+                                 setup->sysclk, twl4030->sysclk);
 
                 hs_pop = twl4030_read_reg_cache(codec, TWL4030_REG_HS_POPN_SET);
                 hs_pop &= ~TWL4030_RAMP_DELAY;
                 hs_pop |= (setup->ramp_delay_value << 2);
                 twl4030_write_reg_cache(codec, TWL4030_REG_HS_POPN_SET, hs_pop);
-        } else {
-                twl4030->sysclk = 26000;
         }
 
         /* register pcms */
         ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
         if (ret < 0) {
-                printk(KERN_ERR "twl4030: failed to create pcms\n");
-                goto pcm_err;
+                dev_err(&pdev->dev, "failed to create pcms\n");
+                return ret;
         }
 
-        twl4030_init_chip(codec);
-
-        /* power on device */
-        twl4030_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
         snd_soc_add_controls(codec, twl4030_snd_controls,
                                 ARRAY_SIZE(twl4030_snd_controls));
         twl4030_add_widgets(codec);
 
-        ret = snd_soc_init_card(socdev);
-        if (ret < 0) {
-                printk(KERN_ERR "twl4030: failed to register card\n");
-                goto card_err;
-        }
+        return 0;
+}
 
-        return ret;
+static int twl4030_soc_remove(struct platform_device *pdev)
+{
+        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+        struct snd_soc_codec *codec = socdev->card->codec;
 
-card_err:
+        twl4030_set_bias_level(codec, SND_SOC_BIAS_OFF);
         snd_soc_free_pcms(socdev);
         snd_soc_dapm_free(socdev);
-pcm_err:
-        kfree(codec->reg_cache);
-        return ret;
-}
+        kfree(codec->private_data);
+        kfree(codec);
 
-static struct snd_soc_device *twl4030_socdev;
+        return 0;
+}
 
-static int twl4030_probe(struct platform_device *pdev)
+static int __devinit twl4030_codec_probe(struct platform_device *pdev)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+        struct twl4030_codec_audio_data *pdata = pdev->dev.platform_data;
         struct snd_soc_codec *codec;
         struct twl4030_priv *twl4030;
+        int ret;
 
-        codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-        if (codec == NULL)
-                return -ENOMEM;
+        if (!pdata) {
+                dev_err(&pdev->dev, "platform_data is missing\n");
+                return -EINVAL;
+        }
 
         twl4030 = kzalloc(sizeof(struct twl4030_priv), GFP_KERNEL);
         if (twl4030 == NULL) {
-                kfree(codec);
+                dev_err(&pdev->dev, "Can not allocate memroy\n");
                 return -ENOMEM;
         }
 
+        codec = &twl4030->codec;
         codec->private_data = twl4030;
-        socdev->card->codec = codec;
+        codec->dev = &pdev->dev;
+        twl4030_dai[0].dev = &pdev->dev;
+        twl4030_dai[1].dev = &pdev->dev;
+
         mutex_init(&codec->mutex);
         INIT_LIST_HEAD(&codec->dapm_widgets);
         INIT_LIST_HEAD(&codec->dapm_paths);
 
-        twl4030_socdev = socdev;
-        twl4030_init(socdev);
+        codec->name = "twl4030";
+        codec->owner = THIS_MODULE;
+        codec->read = twl4030_read_reg_cache;
+        codec->write = twl4030_write;
+        codec->set_bias_level = twl4030_set_bias_level;
+        codec->dai = twl4030_dai;
+        codec->num_dai = ARRAY_SIZE(twl4030_dai),
+        codec->reg_cache_size = sizeof(twl4030_reg);
+        codec->reg_cache = kmemdup(twl4030_reg, sizeof(twl4030_reg),
+                                        GFP_KERNEL);
+        if (codec->reg_cache == NULL) {
+                ret = -ENOMEM;
+                goto error_cache;
+        }
+
+        platform_set_drvdata(pdev, twl4030);
+        twl4030_codec = codec;
+
+        /* Set the defaults, and power up the codec */
+        twl4030->sysclk = twl4030_codec_get_mclk() / 1000;
+        twl4030_init_chip(codec);
+        codec->bias_level = SND_SOC_BIAS_OFF;
+        twl4030_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+
+        ret = snd_soc_register_codec(codec);
+        if (ret != 0) {
+                dev_err(codec->dev, "Failed to register codec: %d\n", ret);
+                goto error_codec;
+        }
+
+        ret = snd_soc_register_dais(&twl4030_dai[0], ARRAY_SIZE(twl4030_dai));
+        if (ret != 0) {
+                dev_err(codec->dev, "Failed to register DAIs: %d\n", ret);
+                snd_soc_unregister_codec(codec);
+                goto error_codec;
+        }
 
         return 0;
+
+error_codec:
+        twl4030_power_down(codec);
+        kfree(codec->reg_cache);
+error_cache:
+        kfree(twl4030);
+        return ret;
 }
 
-static int twl4030_remove(struct platform_device *pdev)
+static int __devexit twl4030_codec_remove(struct platform_device *pdev)
 {
-        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-        struct snd_soc_codec *codec = socdev->card->codec;
+        struct twl4030_priv *twl4030 = platform_get_drvdata(pdev);
 
-        printk(KERN_INFO "TWL4030 Audio Codec remove\n");
-        twl4030_set_bias_level(codec, SND_SOC_BIAS_OFF);
-        snd_soc_free_pcms(socdev);
-        snd_soc_dapm_free(socdev);
-        kfree(codec->private_data);
-        kfree(codec);
+        kfree(twl4030);
 
+        twl4030_codec = NULL;
         return 0;
 }
 
-struct snd_soc_codec_device soc_codec_dev_twl4030 = {
-        .probe = twl4030_probe,
-        .remove = twl4030_remove,
-        .suspend = twl4030_suspend,
-        .resume = twl4030_resume,
+MODULE_ALIAS("platform:twl4030_codec_audio");
+
+static struct platform_driver twl4030_codec_driver = {
+        .probe          = twl4030_codec_probe,
+        .remove         = __devexit_p(twl4030_codec_remove),
+        .driver         = {
+                .name   = "twl4030_codec_audio",
+                .owner  = THIS_MODULE,
+        },
 };
-EXPORT_SYMBOL_GPL(soc_codec_dev_twl4030);
 
 static int __init twl4030_modinit(void)
 {
-        return snd_soc_register_dais(&twl4030_dai[0], ARRAY_SIZE(twl4030_dai));
+        return platform_driver_register(&twl4030_codec_driver);
 }
 module_init(twl4030_modinit);
 
 static void __exit twl4030_exit(void)
 {
-        snd_soc_unregister_dais(&twl4030_dai[0], ARRAY_SIZE(twl4030_dai));
+        platform_driver_unregister(&twl4030_codec_driver);
 }
 module_exit(twl4030_exit);
 
+struct snd_soc_codec_device soc_codec_dev_twl4030 = {
+        .probe = twl4030_soc_probe,
+        .remove = twl4030_soc_remove,
+        .suspend = twl4030_soc_suspend,
+        .resume = twl4030_soc_resume,
+};
+EXPORT_SYMBOL_GPL(soc_codec_dev_twl4030);
+
 MODULE_DESCRIPTION("ASoC TWL4030 codec driver");
 MODULE_AUTHOR("Steve Sakoman");
 MODULE_LICENSE("GPL");