1 files changed, 33 insertions, 15 deletions

diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 75af2d6e0e78..3c51d6a57523 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -15,23 +15,15 @@
  * option) any later version.
  */
 
-#include <linux/module.h>
-#include <linux/moduleparam.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
 #include <linux/delay.h>
-#include <linux/pm.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
-#include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
-#include <sound/soc.h>
 #include <sound/soc-dapm.h>
-#include <sound/tlv.h>
 #include <sound/initval.h>
-#include <asm/div64.h>
+#include <sound/tlv.h>
 
 #include "da7210.h"
 
@@ -145,6 +137,29 @@
 
 #define DA7210_VERSION "0.0.1"
 
+/*
+ * Playback Volume
+ *
+ * max          : 0x3F (+15.0 dB)
+ *                 (1.5 dB step)
+ * min          : 0x11 (-54.0 dB)
+ * mute         : 0x10
+ * reserved     : 0x00 - 0x0F
+ *
+ * ** FIXME **
+ *
+ * Reserved area are considered as "mute".
+ * -> min = -79.5 dB
+ */
+static const DECLARE_TLV_DB_SCALE(hp_out_tlv, -7950, 150, 1);
+
+static const struct snd_kcontrol_new da7210_snd_controls[] = {
+
+        SOC_DOUBLE_R_TLV("HeadPhone Playback Volume",
+                         DA7210_HP_L_VOL, DA7210_HP_R_VOL,
+                         0, 0x3F, 0, hp_out_tlv),
+};
+
 /* Codec private data */
 struct da7210_priv {
         struct snd_soc_codec codec;
@@ -227,10 +242,6 @@ static int da7210_startup(struct snd_pcm_substream *substream,
         struct snd_soc_codec *codec = dai->codec;
 
         if (is_play) {
-                /* PlayBack Volume 40 */
-                snd_soc_update_bits(codec, DA7210_HP_L_VOL, 0x3F, 40);
-                snd_soc_update_bits(codec, DA7210_HP_R_VOL, 0x3F, 40);
-
                 /* Enable Out */
                 snd_soc_update_bits(codec, DA7210_OUTMIX_L, 0x1F, 0x10);
                 snd_soc_update_bits(codec, DA7210_OUTMIX_R, 0x1F, 0x10);
@@ -488,7 +499,7 @@ static int da7210_init(struct da7210_priv *da7210)
         ret = snd_soc_register_dai(&da7210_dai);
         if (ret) {
                 dev_err(codec->dev, "Failed to register DAI: %d\n", ret);
-                goto init_err;
+                goto codec_err;
         }
 
         /* FIXME
@@ -574,6 +585,8 @@ static int da7210_init(struct da7210_priv *da7210)
 
         return ret;
 
+codec_err:
+        snd_soc_unregister_codec(codec);
 init_err:
         kfree(codec->reg_cache);
         codec->reg_cache = NULL;
@@ -601,8 +614,10 @@ static int __devinit da7210_i2c_probe(struct i2c_client *i2c,
         codec->control_data = i2c;
 
         ret = da7210_init(da7210);
-        if (ret < 0)
+        if (ret < 0) {
                 pr_err("Failed to initialise da7210 audio codec\n");
+                kfree(da7210);
+        }
 
         return ret;
 }
@@ -656,6 +671,9 @@ static int da7210_probe(struct platform_device *pdev)
         if (ret < 0)
                 goto pcm_err;
 
+        snd_soc_add_controls(da7210_codec, da7210_snd_controls,
+                             ARRAY_SIZE(da7210_snd_controls));
+
         dev_info(&pdev->dev, "DA7210 Audio Codec %s\n", DA7210_VERSION);
 
 pcm_err: