1 files changed, 428 insertions, 69 deletions

diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index e7d34711412c..389f23253831 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -10,6 +10,7 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/delay.h>
 #include <linux/gcd.h>
 #include <linux/module.h>
 #include <linux/pm_runtime.h>
@@ -65,6 +66,163 @@
 #define arizona_aif_dbg(_dai, fmt, ...) \
         dev_dbg(_dai->dev, "AIF%d: " fmt, _dai->id, ##__VA_ARGS__)
 
+static int arizona_spk_ev(struct snd_soc_dapm_widget *w,
+                          struct snd_kcontrol *kcontrol,
+                          int event)
+{
+        struct snd_soc_codec *codec = w->codec;
+        struct arizona *arizona = dev_get_drvdata(codec->dev->parent);
+        struct arizona_priv *priv = snd_soc_codec_get_drvdata(codec);
+        bool manual_ena = false;
+        int val;
+
+        switch (arizona->type) {
+        case WM5102:
+                switch (arizona->rev) {
+                case 0:
+                        break;
+                default:
+                        manual_ena = true;
+                        break;
+                }
+        default:
+                break;
+        }
+
+        switch (event) {
+        case SND_SOC_DAPM_PRE_PMU:
+                if (!priv->spk_ena && manual_ena) {
+                        snd_soc_write(codec, 0x4f5, 0x25a);
+                        priv->spk_ena_pending = true;
+                }
+                break;
+        case SND_SOC_DAPM_POST_PMU:
+                val = snd_soc_read(codec, ARIZONA_INTERRUPT_RAW_STATUS_3);
+                if (val & ARIZONA_SPK_SHUTDOWN_STS) {
+                        dev_crit(arizona->dev,
+                                 "Speaker not enabled due to temperature\n");
+                        return -EBUSY;
+                }
+
+                snd_soc_update_bits(codec, ARIZONA_OUTPUT_ENABLES_1,
+                                    1 << w->shift, 1 << w->shift);
+
+                if (priv->spk_ena_pending) {
+                        msleep(75);
+                        snd_soc_write(codec, 0x4f5, 0xda);
+                        priv->spk_ena_pending = false;
+                        priv->spk_ena++;
+                }
+                break;
+        case SND_SOC_DAPM_PRE_PMD:
+                if (manual_ena) {
+                        priv->spk_ena--;
+                        if (!priv->spk_ena)
+                                snd_soc_write(codec, 0x4f5, 0x25a);
+                }
+
+                snd_soc_update_bits(codec, ARIZONA_OUTPUT_ENABLES_1,
+                                    1 << w->shift, 0);
+                break;
+        case SND_SOC_DAPM_POST_PMD:
+                if (manual_ena) {
+                        if (!priv->spk_ena)
+                                snd_soc_write(codec, 0x4f5, 0x0da);
+                }
+                break;
+        }
+
+        return 0;
+}
+
+static irqreturn_t arizona_thermal_warn(int irq, void *data)
+{
+        struct arizona *arizona = data;
+        unsigned int val;
+        int ret;
+
+        ret = regmap_read(arizona->regmap, ARIZONA_INTERRUPT_RAW_STATUS_3,
+                          &val);
+        if (ret != 0) {
+                dev_err(arizona->dev, "Failed to read thermal status: %d\n",
+                        ret);
+        } else if (val & ARIZONA_SPK_SHUTDOWN_WARN_STS) {
+                dev_crit(arizona->dev, "Thermal warning\n");
+        }
+
+        return IRQ_HANDLED;
+}
+
+static irqreturn_t arizona_thermal_shutdown(int irq, void *data)
+{
+        struct arizona *arizona = data;
+        unsigned int val;
+        int ret;
+
+        ret = regmap_read(arizona->regmap, ARIZONA_INTERRUPT_RAW_STATUS_3,
+                          &val);
+        if (ret != 0) {
+                dev_err(arizona->dev, "Failed to read thermal status: %d\n",
+                        ret);
+        } else if (val & ARIZONA_SPK_SHUTDOWN_STS) {
+                dev_crit(arizona->dev, "Thermal shutdown\n");
+                ret = regmap_update_bits(arizona->regmap,
+                                         ARIZONA_OUTPUT_ENABLES_1,
+                                         ARIZONA_OUT4L_ENA |
+                                         ARIZONA_OUT4R_ENA, 0);
+                if (ret != 0)
+                        dev_crit(arizona->dev,
+                                 "Failed to disable speaker outputs: %d\n",
+                                 ret);
+        }
+
+        return IRQ_HANDLED;
+}
+
+static const struct snd_soc_dapm_widget arizona_spkl =
+        SND_SOC_DAPM_PGA_E("OUT4L", SND_SOC_NOPM,
+                           ARIZONA_OUT4L_ENA_SHIFT, 0, NULL, 0, arizona_spk_ev,
+                           SND_SOC_DAPM_PRE_PMD | SND_SOC_DAPM_POST_PMU);
+
+static const struct snd_soc_dapm_widget arizona_spkr =
+        SND_SOC_DAPM_PGA_E("OUT4R", SND_SOC_NOPM,
+                           ARIZONA_OUT4R_ENA_SHIFT, 0, NULL, 0, arizona_spk_ev,
+                           SND_SOC_DAPM_PRE_PMD | SND_SOC_DAPM_POST_PMU);
+
+int arizona_init_spk(struct snd_soc_codec *codec)
+{
+        struct arizona_priv *priv = snd_soc_codec_get_drvdata(codec);
+        struct arizona *arizona = priv->arizona;
+        int ret;
+
+        ret = snd_soc_dapm_new_controls(&codec->dapm, &arizona_spkl, 1);
+        if (ret != 0)
+                return ret;
+
+        ret = snd_soc_dapm_new_controls(&codec->dapm, &arizona_spkr, 1);
+        if (ret != 0)
+                return ret;
+
+        ret = arizona_request_irq(arizona, ARIZONA_IRQ_SPK_SHUTDOWN_WARN,
+                                  "Thermal warning", arizona_thermal_warn,
+                                  arizona);
+        if (ret != 0)
+                dev_err(arizona->dev,
+                        "Failed to get thermal warning IRQ: %d\n",
+                        ret);
+
+        ret = arizona_request_irq(arizona, ARIZONA_IRQ_SPK_SHUTDOWN,
+                                  "Thermal shutdown", arizona_thermal_shutdown,
+                                  arizona);
+        if (ret != 0)
+                dev_err(arizona->dev,
+                        "Failed to get thermal shutdown IRQ: %d\n",
+                        ret);
+
+        return 0;
+}
+EXPORT_SYMBOL_GPL(arizona_init_spk);
+
 const char *arizona_mixer_texts[ARIZONA_NUM_MIXER_INPUTS] = {
         "None",
         "Tone Generator 1",
@@ -274,6 +432,33 @@ EXPORT_SYMBOL_GPL(arizona_mixer_values);
 const DECLARE_TLV_DB_SCALE(arizona_mixer_tlv, -3200, 100, 0);
 EXPORT_SYMBOL_GPL(arizona_mixer_tlv);
 
+const char *arizona_rate_text[ARIZONA_RATE_ENUM_SIZE] = {
+        "SYNCCLK rate", "8kHz", "16kHz", "ASYNCCLK rate",
+};
+EXPORT_SYMBOL_GPL(arizona_rate_text);
+
+const int arizona_rate_val[ARIZONA_RATE_ENUM_SIZE] = {
+        0, 1, 2, 8,
+};
+EXPORT_SYMBOL_GPL(arizona_rate_val);
+
+
+const struct soc_enum arizona_isrc_fsl[] = {
+        SOC_VALUE_ENUM_SINGLE(ARIZONA_ISRC_1_CTRL_2,
+                              ARIZONA_ISRC1_FSL_SHIFT, 0xf,
+                              ARIZONA_RATE_ENUM_SIZE,
+                              arizona_rate_text, arizona_rate_val),
+        SOC_VALUE_ENUM_SINGLE(ARIZONA_ISRC_2_CTRL_2,
+                              ARIZONA_ISRC2_FSL_SHIFT, 0xf,
+                              ARIZONA_RATE_ENUM_SIZE,
+                              arizona_rate_text, arizona_rate_val),
+        SOC_VALUE_ENUM_SINGLE(ARIZONA_ISRC_3_CTRL_2,
+                              ARIZONA_ISRC3_FSL_SHIFT, 0xf,
+                              ARIZONA_RATE_ENUM_SIZE,
+                              arizona_rate_text, arizona_rate_val),
+};
+EXPORT_SYMBOL_GPL(arizona_isrc_fsl);
+
 static const char *arizona_vol_ramp_text[] = {
         "0ms/6dB", "0.5ms/6dB", "1ms/6dB", "2ms/6dB", "4ms/6dB", "8ms/6dB",
         "15ms/6dB", "30ms/6dB",
@@ -332,9 +517,27 @@ const struct soc_enum arizona_ng_hold =
                         4, arizona_ng_hold_text);
 EXPORT_SYMBOL_GPL(arizona_ng_hold);
 
+static void arizona_in_set_vu(struct snd_soc_codec *codec, int ena)
+{
+        struct arizona_priv *priv = snd_soc_codec_get_drvdata(codec);
+        unsigned int val;
+        int i;
+
+        if (ena)
+                val = ARIZONA_IN_VU;
+        else
+                val = 0;
+
+        for (i = 0; i < priv->num_inputs; i++)
+                snd_soc_update_bits(codec,
+                                    ARIZONA_ADC_DIGITAL_VOLUME_1L + (i * 4),
+                                    ARIZONA_IN_VU, val);
+}
+
 int arizona_in_ev(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol,
                   int event)
 {
+        struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
         unsigned int reg;
 
         if (w->shift % 2)
@@ -343,13 +546,29 @@ int arizona_in_ev(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol,
                 reg = ARIZONA_ADC_DIGITAL_VOLUME_1R + ((w->shift / 2) * 8);
 
         switch (event) {
+        case SND_SOC_DAPM_PRE_PMU:
+                priv->in_pending++;
+                break;
         case SND_SOC_DAPM_POST_PMU:
                 snd_soc_update_bits(w->codec, reg, ARIZONA_IN1L_MUTE, 0);
+
+                /* If this is the last input pending then allow VU */
+                priv->in_pending--;
+                if (priv->in_pending == 0) {
+                        msleep(1);
+                        arizona_in_set_vu(w->codec, 1);
+                }
                 break;
         case SND_SOC_DAPM_PRE_PMD:
-                snd_soc_update_bits(w->codec, reg, ARIZONA_IN1L_MUTE,
-                                    ARIZONA_IN1L_MUTE);
+                snd_soc_update_bits(w->codec, reg,
+                                    ARIZONA_IN1L_MUTE | ARIZONA_IN_VU,
+                                    ARIZONA_IN1L_MUTE | ARIZONA_IN_VU);
                 break;
+        case SND_SOC_DAPM_POST_PMD:
+                /* Disable volume updates if no inputs are enabled */
+                reg = snd_soc_read(w->codec, ARIZONA_INPUT_ENABLES);
+                if (reg == 0)
+                        arizona_in_set_vu(w->codec, 0);
         }
 
         return 0;
@@ -360,6 +579,24 @@ int arizona_out_ev(struct snd_soc_dapm_widget *w,
                    struct snd_kcontrol *kcontrol,
                    int event)
 {
+        switch (event) {
+        case SND_SOC_DAPM_POST_PMU:
+                switch (w->shift) {
+                case ARIZONA_OUT1L_ENA_SHIFT:
+                case ARIZONA_OUT1R_ENA_SHIFT:
+                case ARIZONA_OUT2L_ENA_SHIFT:
+                case ARIZONA_OUT2R_ENA_SHIFT:
+                case ARIZONA_OUT3L_ENA_SHIFT:
+                case ARIZONA_OUT3R_ENA_SHIFT:
+                        msleep(17);
+                        break;
+
+                default:
+                        break;
+                }
+                break;
+        }
+
         return 0;
 }
 EXPORT_SYMBOL_GPL(arizona_out_ev);
@@ -502,27 +739,27 @@ int arizona_set_sysclk(struct snd_soc_codec *codec, int clk_id,
                 break;
         case 11289600:
         case 12288000:
-                val |= 1 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_12MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 22579200:
         case 24576000:
-                val |= 2 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_24MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 45158400:
         case 49152000:
-                val |= 3 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_49MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 67737600:
         case 73728000:
-                val |= 4 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_73MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 90316800:
         case 98304000:
-                val |= 5 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_98MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 135475200:
         case 147456000:
-                val |= 6 << ARIZONA_SYSCLK_FREQ_SHIFT;
+                val |= ARIZONA_CLK_147MHZ << ARIZONA_SYSCLK_FREQ_SHIFT;
                 break;
         case 0:
                 dev_dbg(arizona->dev, "%s cleared\n", name);
@@ -816,7 +1053,7 @@ static int arizona_hw_params(struct snd_pcm_substream *substream,
         struct arizona *arizona = priv->arizona;
         int base = dai->driver->base;
         const int *rates;
-        int i, ret;
+        int i, ret, val;
         int chan_limit = arizona->pdata.max_channels_clocked[dai->id - 1];
         int bclk, lrclk, wl, frame, bclk_target;
 
@@ -832,6 +1069,13 @@ static int arizona_hw_params(struct snd_pcm_substream *substream,
                 bclk_target *= chan_limit;
         }
 
+        /* Force stereo for I2S mode */
+        val = snd_soc_read(codec, base + ARIZONA_AIF_FORMAT);
+        if (params_channels(params) == 1 && (val & ARIZONA_AIF1_FMT_MASK)) {
+                arizona_aif_dbg(dai, "Forcing stereo mode\n");
+                bclk_target *= 2;
+        }
+
         for (i = 0; i < ARRAY_SIZE(arizona_44k1_bclk_rates); i++) {
                 if (rates[i] >= bclk_target &&
                     rates[i] % params_rate(params) == 0) {
@@ -988,6 +1232,16 @@ static struct {
         { 1000000, 13500000, 0,  1 },
 };
 
+static struct {
+        unsigned int min;
+        unsigned int max;
+        u16 gain;
+} fll_gains[] = {
+        {       0,   256000, 0 },
+        {  256000,  1000000, 2 },
+        { 1000000, 13500000, 4 },
+};
+
 struct arizona_fll_cfg {
         int n;
         int theta;
@@ -995,6 +1249,7 @@ struct arizona_fll_cfg {
         int refdiv;
         int outdiv;
         int fratio;
+        int gain;
 };
 
 static int arizona_calc_fll(struct arizona_fll *fll,
@@ -1054,6 +1309,18 @@ static int arizona_calc_fll(struct arizona_fll *fll,
                 return -EINVAL;
         }
 
+        for (i = 0; i < ARRAY_SIZE(fll_gains); i++) {
+                if (fll_gains[i].min <= Fref && Fref <= fll_gains[i].max) {
+                        cfg->gain = fll_gains[i].gain;
+                        break;
+                }
+        }
+        if (i == ARRAY_SIZE(fll_gains)) {
+                arizona_fll_err(fll, "Unable to find gain for Fref=%uHz\n",
+                                Fref);
+                return -EINVAL;
+        }
+
         cfg->n = target / (ratio * Fref);
 
         if (target % (ratio * Fref)) {
@@ -1081,13 +1348,15 @@ static int arizona_calc_fll(struct arizona_fll *fll,
                         cfg->n, cfg->theta, cfg->lambda);
         arizona_fll_dbg(fll, "FRATIO=%x(%d) OUTDIV=%x REFCLK_DIV=%x\n",
                         cfg->fratio, cfg->fratio, cfg->outdiv, cfg->refdiv);
+        arizona_fll_dbg(fll, "GAIN=%d\n", cfg->gain);
 
         return 0;
 
 }
 
 static void arizona_apply_fll(struct arizona *arizona, unsigned int base,
-                              struct arizona_fll_cfg *cfg, int source)
+                              struct arizona_fll_cfg *cfg, int source,
+                              bool sync)
 {
         regmap_update_bits(arizona->regmap, base + 3,
                            ARIZONA_FLL1_THETA_MASK, cfg->theta);
@@ -1102,87 +1371,84 @@ static void arizona_apply_fll(struct arizona *arizona, unsigned int base,
                            cfg->refdiv << ARIZONA_FLL1_CLK_REF_DIV_SHIFT |
                            source << ARIZONA_FLL1_CLK_REF_SRC_SHIFT);
 
+        if (sync)
+                regmap_update_bits(arizona->regmap, base + 0x7,
+                                   ARIZONA_FLL1_GAIN_MASK,
+                                   cfg->gain << ARIZONA_FLL1_GAIN_SHIFT);
+        else
+                regmap_update_bits(arizona->regmap, base + 0x9,
+                                   ARIZONA_FLL1_GAIN_MASK,
+                                   cfg->gain << ARIZONA_FLL1_GAIN_SHIFT);
+
         regmap_update_bits(arizona->regmap, base + 2,
                            ARIZONA_FLL1_CTRL_UPD | ARIZONA_FLL1_N_MASK,
                            ARIZONA_FLL1_CTRL_UPD | cfg->n);
 }
 
-int arizona_set_fll(struct arizona_fll *fll, int source,
-                    unsigned int Fref, unsigned int Fout)
+static bool arizona_is_enabled_fll(struct arizona_fll *fll)
 {
         struct arizona *arizona = fll->arizona;
-        struct arizona_fll_cfg cfg, sync;
-        unsigned int reg, val;
-        int syncsrc;
-        bool ena;
+        unsigned int reg;
         int ret;
 
-        if (fll->fref == Fref && fll->fout == Fout)
-                return 0;
-
         ret = regmap_read(arizona->regmap, fll->base + 1, &reg);
         if (ret != 0) {
                 arizona_fll_err(fll, "Failed to read current state: %d\n",
                                 ret);
                 return ret;
         }
-        ena = reg & ARIZONA_FLL1_ENA;
 
-        if (Fout) {
-                /* Do we have a 32kHz reference? */
-                regmap_read(arizona->regmap, ARIZONA_CLOCK_32K_1, &val);
-                switch (val & ARIZONA_CLK_32K_SRC_MASK) {
-                case ARIZONA_CLK_SRC_MCLK1:
-                case ARIZONA_CLK_SRC_MCLK2:
-                        syncsrc = val & ARIZONA_CLK_32K_SRC_MASK;
-                        break;
-                default:
-                        syncsrc = -1;
-                }
+        return reg & ARIZONA_FLL1_ENA;
+}
 
-                if (source == syncsrc)
-                        syncsrc = -1;
+static void arizona_enable_fll(struct arizona_fll *fll,
+                              struct arizona_fll_cfg *ref,
+                              struct arizona_fll_cfg *sync)
+{
+        struct arizona *arizona = fll->arizona;
+        int ret;
 
-                if (syncsrc >= 0) {
-                        ret = arizona_calc_fll(fll, &sync, Fref, Fout);
-                        if (ret != 0)
-                                return ret;
+        /*
+         * If we have both REFCLK and SYNCCLK then enable both,
+         * otherwise apply the SYNCCLK settings to REFCLK.
+         */
+        if (fll->ref_src >= 0 && fll->ref_src != fll->sync_src) {
+                regmap_update_bits(arizona->regmap, fll->base + 5,
+                                   ARIZONA_FLL1_OUTDIV_MASK,
+                                   ref->outdiv << ARIZONA_FLL1_OUTDIV_SHIFT);
+
+                arizona_apply_fll(arizona, fll->base, ref, fll->ref_src,
+                                  false);
+                if (fll->sync_src >= 0)
+                        arizona_apply_fll(arizona, fll->base + 0x10, sync,
+                                          fll->sync_src, true);
+        } else if (fll->sync_src >= 0) {
+                regmap_update_bits(arizona->regmap, fll->base + 5,
+                                   ARIZONA_FLL1_OUTDIV_MASK,
+                                   sync->outdiv << ARIZONA_FLL1_OUTDIV_SHIFT);
+
+                arizona_apply_fll(arizona, fll->base, sync,
+                                  fll->sync_src, false);
 
-                        ret = arizona_calc_fll(fll, &cfg, 32768, Fout);
-                        if (ret != 0)
-                                return ret;
-                } else {
-                        ret = arizona_calc_fll(fll, &cfg, Fref, Fout);
-                        if (ret != 0)
-                                return ret;
-                }
-        } else {
-                regmap_update_bits(arizona->regmap, fll->base + 1,
-                                   ARIZONA_FLL1_ENA, 0);
                 regmap_update_bits(arizona->regmap, fll->base + 0x11,
                                    ARIZONA_FLL1_SYNC_ENA, 0);
-
-                if (ena)
-                        pm_runtime_put_autosuspend(arizona->dev);
-
-                fll->fref = Fref;
-                fll->fout = Fout;
-
-                return 0;
-        }
-
-        regmap_update_bits(arizona->regmap, fll->base + 5,
-                           ARIZONA_FLL1_OUTDIV_MASK,
-                           cfg.outdiv << ARIZONA_FLL1_OUTDIV_SHIFT);
-
-        if (syncsrc >= 0) {
-                arizona_apply_fll(arizona, fll->base, &cfg, syncsrc);
-                arizona_apply_fll(arizona, fll->base + 0x10, &sync, source);
         } else {
-                arizona_apply_fll(arizona, fll->base, &cfg, source);
+                arizona_fll_err(fll, "No clocks provided\n");
+                return;
         }
 
-        if (!ena)
+        /*
+         * Increase the bandwidth if we're not using a low frequency
+         * sync source.
+         */
+        if (fll->sync_src >= 0 && fll->sync_freq > 100000)
+                regmap_update_bits(arizona->regmap, fll->base + 0x17,
+                                   ARIZONA_FLL1_SYNC_BW, 0);
+        else
+                regmap_update_bits(arizona->regmap, fll->base + 0x17,
+                                   ARIZONA_FLL1_SYNC_BW, ARIZONA_FLL1_SYNC_BW);
+
+        if (!arizona_is_enabled_fll(fll))
                 pm_runtime_get(arizona->dev);
 
         /* Clear any pending completions */
@@ -1190,7 +1456,8 @@ int arizona_set_fll(struct arizona_fll *fll, int source,
 
         regmap_update_bits(arizona->regmap, fll->base + 1,
                            ARIZONA_FLL1_ENA, ARIZONA_FLL1_ENA);
-        if (syncsrc >= 0)
+        if (fll->ref_src >= 0 && fll->sync_src >= 0 &&
+            fll->ref_src != fll->sync_src)
                 regmap_update_bits(arizona->regmap, fll->base + 0x11,
                                    ARIZONA_FLL1_SYNC_ENA,
                                    ARIZONA_FLL1_SYNC_ENA);
@@ -1199,10 +1466,88 @@ int arizona_set_fll(struct arizona_fll *fll, int source,
                                           msecs_to_jiffies(250));
         if (ret == 0)
                 arizona_fll_warn(fll, "Timed out waiting for lock\n");
+}
+
+static void arizona_disable_fll(struct arizona_fll *fll)
+{
+        struct arizona *arizona = fll->arizona;
+        bool change;
+
+        regmap_update_bits_check(arizona->regmap, fll->base + 1,
+                                 ARIZONA_FLL1_ENA, 0, &change);
+        regmap_update_bits(arizona->regmap, fll->base + 0x11,
+                           ARIZONA_FLL1_SYNC_ENA, 0);
+
+        if (change)
+                pm_runtime_put_autosuspend(arizona->dev);
+}
+
+int arizona_set_fll_refclk(struct arizona_fll *fll, int source,
+                           unsigned int Fref, unsigned int Fout)
+{
+        struct arizona_fll_cfg ref, sync;
+        int ret;
 
-        fll->fref = Fref;
+        if (fll->ref_src == source && fll->ref_freq == Fref)
+                return 0;
+
+        if (fll->fout && Fref > 0) {
+                ret = arizona_calc_fll(fll, &ref, Fref, fll->fout);
+                if (ret != 0)
+                        return ret;
+
+                if (fll->sync_src >= 0) {
+                        ret = arizona_calc_fll(fll, &sync, fll->sync_freq,
+                                               fll->fout);
+                        if (ret != 0)
+                                return ret;
+                }
+        }
+
+        fll->ref_src = source;
+        fll->ref_freq = Fref;
+
+        if (fll->fout && Fref > 0) {
+                arizona_enable_fll(fll, &ref, &sync);
+        }
+
+        return 0;
+}
+EXPORT_SYMBOL_GPL(arizona_set_fll_refclk);
+
+int arizona_set_fll(struct arizona_fll *fll, int source,
+                    unsigned int Fref, unsigned int Fout)
+{
+        struct arizona_fll_cfg ref, sync;
+        int ret;
+
+        if (fll->sync_src == source &&
+            fll->sync_freq == Fref && fll->fout == Fout)
+                return 0;
+
+        if (Fout) {
+                if (fll->ref_src >= 0) {
+                        ret = arizona_calc_fll(fll, &ref, fll->ref_freq,
+                                               Fout);
+                        if (ret != 0)
+                                return ret;
+                }
+
+                ret = arizona_calc_fll(fll, &sync, Fref, Fout);
+                if (ret != 0)
+                        return ret;
+        }
+
+        fll->sync_src = source;
+        fll->sync_freq = Fref;
         fll->fout = Fout;
 
+        if (Fout) {
+                arizona_enable_fll(fll, &ref, &sync);
+        } else {
+                arizona_disable_fll(fll);
+        }
+
         return 0;
 }
 EXPORT_SYMBOL_GPL(arizona_set_fll);
@@ -1211,12 +1556,26 @@ int arizona_init_fll(struct arizona *arizona, int id, int base, int lock_irq,
                      int ok_irq, struct arizona_fll *fll)
 {
         int ret;
+        unsigned int val;
 
         init_completion(&fll->ok);
 
         fll->id = id;
         fll->base = base;
         fll->arizona = arizona;
+        fll->sync_src = ARIZONA_FLL_SRC_NONE;
+
+        /* Configure default refclk to 32kHz if we have one */
+        regmap_read(arizona->regmap, ARIZONA_CLOCK_32K_1, &val);
+        switch (val & ARIZONA_CLK_32K_SRC_MASK) {
+        case ARIZONA_CLK_SRC_MCLK1:
+        case ARIZONA_CLK_SRC_MCLK2:
+                fll->ref_src = val & ARIZONA_CLK_32K_SRC_MASK;
+                break;
+        default:
+                fll->ref_src = ARIZONA_FLL_SRC_NONE;
+        }
+        fll->ref_freq = 32768;
 
         snprintf(fll->lock_name, sizeof(fll->lock_name), "FLL%d lock", id);
         snprintf(fll->clock_ok_name, sizeof(fll->clock_ok_name),