1 files changed, 6 insertions, 3 deletions

diff --git a/sound/sh/aica.c b/sound/sh/aica.c
index 88dc840152ce..d49417bf78c6 100644
--- a/sound/sh/aica.c
+++ b/sound/sh/aica.c
@@ -35,7 +35,6 @@
 #include <linux/timer.h>
 #include <linux/delay.h>
 #include <linux/workqueue.h>
-#include <sound/driver.h>
 #include <sound/core.h>
 #include <sound/control.h>
 #include <sound/pcm.h>
@@ -237,6 +236,7 @@ static int aica_dma_transfer(int channels, int buffer_size,
         struct snd_card_aica *dreamcastcard;
         struct snd_pcm_runtime *runtime;
         unsigned long flags;
+        err = 0;
         dreamcastcard = substream->pcm->private_data;
         period_offset = dreamcastcard->clicks;
         period_offset %= (AICA_PERIOD_NUMBER / channels);
@@ -522,11 +522,14 @@ static int aica_pcmvolume_put(struct snd_kcontrol *kcontrol,
                               struct snd_ctl_elem_value *ucontrol)
 {
         struct snd_card_aica *dreamcastcard;
+        unsigned int vol;
         dreamcastcard = kcontrol->private_data;
         if (unlikely(!dreamcastcard->channel))
                 return -ETXTBSY;
-        if (unlikely(dreamcastcard->channel->vol ==
-                     ucontrol->value.integer.value[0]))
+        vol = ucontrol->value.integer.value[0];
+        if (vol > 0xff)
+                return -EINVAL;
+        if (unlikely(dreamcastcard->channel->vol == vol))
                 return 0;
         dreamcastcard->channel->vol = ucontrol->value.integer.value[0];
         dreamcastcard->master_volume = ucontrol->value.integer.value[0];