9 files changed, 139 insertions, 68 deletions

diff --git a/sound/ppc/Kconfig b/sound/ppc/Kconfig
index 777de2b17178..bd2338ab2ced 100644
--- a/sound/ppc/Kconfig
+++ b/sound/ppc/Kconfig
@@ -13,6 +13,7 @@ config SND_POWERMAC
         tristate "PowerMac (AWACS, DACA, Burgundy, Tumbler, Keywest)"
         depends on I2C && INPUT && PPC_PMAC
         select SND_PCM
+        select SND_VMASTER
         help
           Say Y here to include support for the integrated sound device.
 
diff --git a/sound/ppc/awacs.c b/sound/ppc/awacs.c
index 7bd33e6552ab..80df9b1f651e 100644
--- a/sound/ppc/awacs.c
+++ b/sound/ppc/awacs.c
@@ -608,9 +608,12 @@ static struct snd_kcontrol_new snd_pmac_screamer_mixers_beige[] __initdata = {
         AWACS_SWITCH("CD Capture Switch", 0, SHIFT_MUX_LINE, 0),
 };
 
-static struct snd_kcontrol_new snd_pmac_screamer_mixers_imac[] __initdata = {
+static struct snd_kcontrol_new snd_pmac_screamer_mixers_lo[] __initdata = {
         AWACS_VOLUME("Line out Playback Volume", 2, 6, 1),
-        AWACS_VOLUME("Master Playback Volume", 5, 6, 1),
+};
+
+static struct snd_kcontrol_new snd_pmac_screamer_mixers_imac[] __initdata = {
+        AWACS_VOLUME("Play-through Playback Volume", 5, 6, 1),
         AWACS_SWITCH("CD Capture Switch", 0, SHIFT_MUX_CD, 0),
 };
 
@@ -627,6 +630,10 @@ static struct snd_kcontrol_new snd_pmac_awacs_mixers_pmac7500[] __initdata = {
         AWACS_SWITCH("Line Capture Switch", 0, SHIFT_MUX_MIC, 0),
 };
 
+static struct snd_kcontrol_new snd_pmac_awacs_mixers_pmac5500[] __initdata = {
+        AWACS_VOLUME("Headphone Playback Volume", 2, 6, 1),
+};
+
 static struct snd_kcontrol_new snd_pmac_awacs_mixers_pmac[] __initdata = {
         AWACS_VOLUME("Master Playback Volume", 2, 6, 1),
         AWACS_SWITCH("CD Capture Switch", 0, SHIFT_MUX_CD, 0),
@@ -645,12 +652,19 @@ static struct snd_kcontrol_new snd_pmac_screamer_mixers2[] __initdata = {
         AWACS_SWITCH("Mic Capture Switch", 0, SHIFT_MUX_LINE, 0),
 };
 
+static struct snd_kcontrol_new snd_pmac_awacs_mixers2_pmac5500[] __initdata = {
+        AWACS_SWITCH("CD Capture Switch", 0, SHIFT_MUX_CD, 0),
+};
+
 static struct snd_kcontrol_new snd_pmac_awacs_master_sw __initdata =
 AWACS_SWITCH("Master Playback Switch", 1, SHIFT_HDMUTE, 1);
 
 static struct snd_kcontrol_new snd_pmac_awacs_master_sw_imac __initdata =
 AWACS_SWITCH("Line out Playback Switch", 1, SHIFT_HDMUTE, 1);
 
+static struct snd_kcontrol_new snd_pmac_awacs_master_sw_pmac5500 __initdata =
+AWACS_SWITCH("Headphone Playback Switch", 1, SHIFT_HDMUTE, 1);
+
 static struct snd_kcontrol_new snd_pmac_awacs_mic_boost[] __initdata = {
         AWACS_SWITCH("Mic Boost Capture Switch", 0, SHIFT_GAINLINE, 0),
 };
@@ -766,12 +780,16 @@ static void snd_pmac_awacs_resume(struct snd_pmac *chip)
 }
 #endif /* CONFIG_PM */
 
-#define IS_PM7500 (machine_is_compatible("AAPL,7500"))
+#define IS_PM7500 (machine_is_compatible("AAPL,7500") \
+                || machine_is_compatible("AAPL,8500") \
+                || machine_is_compatible("AAPL,9500"))
+#define IS_PM5500 (machine_is_compatible("AAPL,e411"))
 #define IS_BEIGE (machine_is_compatible("AAPL,Gossamer"))
 #define IS_IMAC1 (machine_is_compatible("PowerMac2,1"))
 #define IS_IMAC2 (machine_is_compatible("PowerMac2,2") \
                 || machine_is_compatible("PowerMac4,1"))
 #define IS_G4AGP (machine_is_compatible("PowerMac3,1"))
+#define IS_LOMBARD (machine_is_compatible("PowerBook1,1"))
 
 static int imac1, imac2;
 
@@ -858,10 +876,14 @@ int __init
 snd_pmac_awacs_init(struct snd_pmac *chip)
 {
         int pm7500 = IS_PM7500;
+        int pm5500 = IS_PM5500;
         int beige = IS_BEIGE;
         int g4agp = IS_G4AGP;
+        int lombard = IS_LOMBARD;
         int imac;
         int err, vol;
+        struct snd_kcontrol *vmaster_sw, *vmaster_vol;
+        struct snd_kcontrol *master_vol, *speaker_vol;
 
         imac1 = IS_IMAC1;
         imac2 = IS_IMAC2;
@@ -915,7 +937,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
                 /* set headphone-jack detection bit */
                 switch (chip->model) {
                 case PMAC_AWACS:
-                        chip->hp_stat_mask = pm7500 ? MASK_HDPCONN
+                        chip->hp_stat_mask = pm7500 || pm5500 ? MASK_HDPCONN
                                 : MASK_LOCONN;
                         break;
                 case PMAC_SCREAMER:
@@ -954,7 +976,7 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
                 return err;
         if (beige || g4agp)
                 ;
-        else if (chip->model == PMAC_SCREAMER)
+        else if (chip->model == PMAC_SCREAMER || pm5500)
                 err = build_mixers(chip, ARRAY_SIZE(snd_pmac_screamer_mixers2),
                                    snd_pmac_screamer_mixers2);
         else if (!pm7500)
@@ -962,19 +984,35 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
                                    snd_pmac_awacs_mixers2);
         if (err < 0)
                 return err;
+        if (pm5500) {
+                err = build_mixers(chip,
+                                   ARRAY_SIZE(snd_pmac_awacs_mixers2_pmac5500),
+                                   snd_pmac_awacs_mixers2_pmac5500);
+                if (err < 0)
+                        return err;
+        }
         if (pm7500)
                 err = build_mixers(chip,
                                    ARRAY_SIZE(snd_pmac_awacs_mixers_pmac7500),
                                    snd_pmac_awacs_mixers_pmac7500);
+        else if (pm5500)
+                err = snd_ctl_add(chip->card,
+                    (master_vol = snd_ctl_new1(snd_pmac_awacs_mixers_pmac5500,
+                                                chip)));
         else if (beige)
                 err = build_mixers(chip,
                                    ARRAY_SIZE(snd_pmac_screamer_mixers_beige),
                                    snd_pmac_screamer_mixers_beige);
-        else if (imac)
+        else if (imac || lombard) {
+                err = snd_ctl_add(chip->card,
+                    (master_vol = snd_ctl_new1(snd_pmac_screamer_mixers_lo,
+                                                chip)));
+                if (err < 0)
+                        return err;
                 err = build_mixers(chip,
                                    ARRAY_SIZE(snd_pmac_screamer_mixers_imac),
                                    snd_pmac_screamer_mixers_imac);
-        else if (g4agp)
+        } else if (g4agp)
                 err = build_mixers(chip,
                                    ARRAY_SIZE(snd_pmac_screamer_mixers_g4agp),
                                    snd_pmac_screamer_mixers_g4agp);
@@ -984,8 +1022,10 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
                                    snd_pmac_awacs_mixers_pmac);
         if (err < 0)
                 return err;
-        chip->master_sw_ctl = snd_ctl_new1((pm7500 || imac || g4agp)
+        chip->master_sw_ctl = snd_ctl_new1((pm7500 || imac || g4agp || lombard)
                         ? &snd_pmac_awacs_master_sw_imac
+                        : pm5500
+                        ? &snd_pmac_awacs_master_sw_pmac5500
                         : &snd_pmac_awacs_master_sw, chip);
         err = snd_ctl_add(chip->card, chip->master_sw_ctl);
         if (err < 0)
@@ -1017,8 +1057,9 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
 #endif /* PMAC_AMP_AVAIL */
         {
                 /* route A = headphone, route C = speaker */
-                err = build_mixers(chip, ARRAY_SIZE(snd_pmac_awacs_speaker_vol),
-                                        snd_pmac_awacs_speaker_vol);
+                err = snd_ctl_add(chip->card,
+                    (speaker_vol = snd_ctl_new1(snd_pmac_awacs_speaker_vol,
+                                                chip)));
                 if (err < 0)
                         return err;
                 chip->speaker_sw_ctl = snd_ctl_new1(imac1
@@ -1031,6 +1072,33 @@ snd_pmac_awacs_init(struct snd_pmac *chip)
                         return err;
         }
 
+        if (pm5500 || imac || lombard) {
+                vmaster_sw = snd_ctl_make_virtual_master(
+                        "Master Playback Switch", (unsigned int *) NULL);
+                err = snd_ctl_add_slave_uncached(vmaster_sw,
+                                                 chip->master_sw_ctl);
+                if (err < 0)
+                        return err;
+                err = snd_ctl_add_slave_uncached(vmaster_sw,
+                                                  chip->speaker_sw_ctl);
+                if (err < 0)
+                        return err;
+                err = snd_ctl_add(chip->card, vmaster_sw);
+                if (err < 0)
+                        return err;
+                vmaster_vol = snd_ctl_make_virtual_master(
+                        "Master Playback Volume", (unsigned int *) NULL);
+                err = snd_ctl_add_slave(vmaster_vol, master_vol);
+                if (err < 0)
+                        return err;
+                err = snd_ctl_add_slave(vmaster_vol, speaker_vol);
+                if (err < 0)
+                        return err;
+                err = snd_ctl_add(chip->card, vmaster_vol);
+                if (err < 0)
+                        return err;
+        }
+
         if (beige || g4agp)
                 err = build_mixers(chip,
                                 ARRAY_SIZE(snd_pmac_screamer_mic_boost_beige),
diff --git a/sound/ppc/burgundy.c b/sound/ppc/burgundy.c
index f860d39af36b..45a76297c38d 100644
--- a/sound/ppc/burgundy.c
+++ b/sound/ppc/burgundy.c
@@ -35,7 +35,7 @@ snd_pmac_burgundy_busy_wait(struct snd_pmac *chip)
         int timeout = 50;
         while ((in_le32(&chip->awacs->codec_ctrl) & MASK_NEWECMD) && timeout--)
                 udelay(1);
-        if (! timeout)
+        if (timeout < 0)
                 printk(KERN_DEBUG "burgundy_busy_wait: timeout\n");
 }
 
diff --git a/sound/ppc/daca.c b/sound/ppc/daca.c
index 8a5b29031933..f8d478c2da62 100644
--- a/sound/ppc/daca.c
+++ b/sound/ppc/daca.c
@@ -82,7 +82,7 @@ static int daca_set_volume(struct pmac_daca *mix)
         data[1] |= mix->deemphasis ? 0x40 : 0;
         if (i2c_smbus_write_block_data(mix->i2c.client, DACA_REG_AVOL,
                                        2, data) < 0) {
-                snd_printk("failed to set volume \n");
+                snd_printk(KERN_ERR "failed to set volume \n");
                 return -EINVAL;
         }
         return 0;
diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c
index 6ff99ed77516..a5afb2682e7f 100644
--- a/sound/ppc/keywest.c
+++ b/sound/ppc/keywest.c
@@ -33,26 +33,25 @@
 static struct pmac_keywest *keywest_ctx;
 
 
-static int keywest_attach_adapter(struct i2c_adapter *adapter);
-static int keywest_detach_client(struct i2c_client *client);
-
-struct i2c_driver keywest_driver = {  
-        .driver = {
-                .name = "PMac Keywest Audio",
-        },
-        .attach_adapter = &keywest_attach_adapter,
-        .detach_client = &keywest_detach_client,
-};
-
-
 #ifndef i2c_device_name
 #define i2c_device_name(x)      ((x)->name)
 #endif
 
+static int keywest_probe(struct i2c_client *client,
+                         const struct i2c_device_id *id)
+{
+        i2c_set_clientdata(client, keywest_ctx);
+        return 0;
+}
+
+/*
+ * This is kind of a hack, best would be to turn powermac to fixed i2c
+ * bus numbers and declare the sound device as part of platform
+ * initialization
+ */
 static int keywest_attach_adapter(struct i2c_adapter *adapter)
 {
-        int err;
-        struct i2c_client *new_client;
+        struct i2c_board_info info;
 
         if (! keywest_ctx)
                 return -EINVAL;
@@ -60,46 +59,47 @@ static int keywest_attach_adapter(struct i2c_adapter *adapter)
         if (strncmp(i2c_device_name(adapter), "mac-io", 6))
                 return 0; /* ignored */
 
-        new_client = kzalloc(sizeof(struct i2c_client), GFP_KERNEL);
-        if (! new_client)
-                return -ENOMEM;
-
-        new_client->addr = keywest_ctx->addr;
-        i2c_set_clientdata(new_client, keywest_ctx);
-        new_client->adapter = adapter;
-        new_client->driver = &keywest_driver;
-        new_client->flags = 0;
-
-        strcpy(i2c_device_name(new_client), keywest_ctx->name);
-        keywest_ctx->client = new_client;
+        memset(&info, 0, sizeof(struct i2c_board_info));
+        strlcpy(info.type, "keywest", I2C_NAME_SIZE);
+        info.addr = keywest_ctx->addr;
+        keywest_ctx->client = i2c_new_device(adapter, &info);
         
-        /* Tell the i2c layer a new client has arrived */
-        if (i2c_attach_client(new_client)) {
-                snd_printk(KERN_ERR "tumbler: cannot attach i2c client\n");
-                err = -ENODEV;
-                goto __err;
-        }
-
+        /*
+         * Let i2c-core delete that device on driver removal.
+         * This is safe because i2c-core holds the core_lock mutex for us.
+         */
+        list_add_tail(&keywest_ctx->client->detected,
+                      &keywest_ctx->client->driver->clients);
         return 0;
-
- __err:
-        kfree(new_client);
-        keywest_ctx->client = NULL;
-        return err;
 }
 
-static int keywest_detach_client(struct i2c_client *client)
+static int keywest_remove(struct i2c_client *client)
 {
+        i2c_set_clientdata(client, NULL);
         if (! keywest_ctx)
                 return 0;
         if (client == keywest_ctx->client)
                 keywest_ctx->client = NULL;
 
-        i2c_detach_client(client);
-        kfree(client);
         return 0;
 }
 
+
+static const struct i2c_device_id keywest_i2c_id[] = {
+        { "keywest", 0 },
+        { }
+};
+
+struct i2c_driver keywest_driver = {
+        .driver = {
+                .name = "PMac Keywest Audio",
+        },
+        .attach_adapter = keywest_attach_adapter,
+        .probe = keywest_probe,
+        .remove = keywest_remove,
+        .id_table = keywest_i2c_id,
+};
+
 /* exported */
 void snd_pmac_keywest_cleanup(struct pmac_keywest *i2c)
 {
diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
index af76ee862d27..9b4e9c316695 100644
--- a/sound/ppc/pmac.c
+++ b/sound/ppc/pmac.c
@@ -299,7 +299,7 @@ static int snd_pmac_pcm_trigger(struct snd_pmac *chip, struct pmac_stream *rec,
         case SNDRV_PCM_TRIGGER_SUSPEND:
                 spin_lock(&chip->reg_lock);
                 rec->running = 0;
-                /*printk("stopped!!\n");*/
+                /*printk(KERN_DEBUG "stopped!!\n");*/
                 snd_pmac_dma_stop(rec);
                 for (i = 0, cp = rec->cmd.cmds; i < rec->nperiods; i++, cp++)
                         out_le16(&cp->command, DBDMA_STOP);
@@ -334,7 +334,7 @@ static snd_pcm_uframes_t snd_pmac_pcm_pointer(struct snd_pmac *chip,
         }
 #endif
         count += rec->cur_period * rec->period_size;
-        /*printk("pointer=%d\n", count);*/
+        /*printk(KERN_DEBUG "pointer=%d\n", count);*/
         return bytes_to_frames(subs->runtime, count);
 }
 
@@ -486,7 +486,7 @@ static void snd_pmac_pcm_update(struct snd_pmac *chip, struct pmac_stream *rec)
                         if (! (stat & ACTIVE))
                                 break;
 
-                        /*printk("update frag %d\n", rec->cur_period);*/
+                        /*printk(KERN_DEBUG "update frag %d\n", rec->cur_period);*/
                         st_le16(&cp->xfer_status, 0);
                         st_le16(&cp->req_count, rec->period_size);
                         /*st_le16(&cp->res_count, 0);*/
@@ -806,7 +806,7 @@ snd_pmac_ctrl_intr(int irq, void *devid)
         struct snd_pmac *chip = devid;
         int ctrl = in_le32(&chip->awacs->control);
 
-        /*printk("pmac: control interrupt.. 0x%x\n", ctrl);*/
+        /*printk(KERN_DEBUG "pmac: control interrupt.. 0x%x\n", ctrl);*/
         if (ctrl & MASK_PORTCHG) {
                 /* do something when headphone is plugged/unplugged? */
                 if (chip->update_automute)
@@ -1033,7 +1033,8 @@ static int __init snd_pmac_detect(struct snd_pmac *chip)
         }
         if (of_device_is_compatible(sound, "tumbler")) {
                 chip->model = PMAC_TUMBLER;
-                chip->can_capture = machine_is_compatible("PowerMac4,2");
+                chip->can_capture = machine_is_compatible("PowerMac4,2")
+                                || machine_is_compatible("PowerBook4,1");
                 chip->can_duplex = 0;
                 // chip->can_byte_swap = 0; /* FIXME: check this */
                 chip->num_freqs = ARRAY_SIZE(tumbler_freqs);
diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c
index 2e18ed0ea899..a2b69b8cff43 100644
--- a/sound/ppc/powermac.c
+++ b/sound/ppc/powermac.c
@@ -51,7 +51,7 @@ static struct platform_device *device;
 /*
  */
 
-static int __init snd_pmac_probe(struct platform_device *devptr)
+static int __devinit snd_pmac_probe(struct platform_device *devptr)
 {
         struct snd_card *card;
         struct snd_pmac *chip;
@@ -110,7 +110,7 @@ static int __init snd_pmac_probe(struct platform_device *devptr)
                         goto __error;
                 break;
         default:
-                snd_printk("unsupported hardware %d\n", chip->model);
+                snd_printk(KERN_ERR "unsupported hardware %d\n", chip->model);
                 err = -EINVAL;
                 goto __error;
         }
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index ef2c3f417175..f361c26506aa 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -477,7 +477,7 @@ static int snd_ps3_pcm_prepare(struct snd_pcm_substream *substream)
                 card->dma_start_bus_addr[SND_PS3_CH_R] =
                         runtime->dma_addr + (runtime->dma_bytes / 2);
 
-                pr_debug("%s: vaddr=%p bus=%#lx\n", __func__,
+                pr_debug("%s: vaddr=%p bus=%#llx\n", __func__,
                          card->dma_start_vaddr[SND_PS3_CH_L],
                          card->dma_start_bus_addr[SND_PS3_CH_L]);
 
@@ -1028,7 +1028,7 @@ static int __init snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
                 pr_info("%s: nullbuffer alloc failed\n", __func__);
                 goto clean_preallocate;
         }
-        pr_debug("%s: null vaddr=%p dma=%#lx\n", __func__,
+        pr_debug("%s: null vaddr=%p dma=%#llx\n", __func__,
                  the_card.null_buffer_start_vaddr,
                  the_card.null_buffer_start_dma_addr);
         /* set default sample rate/word width */
diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c
index 3eb223385416..40222fcc0878 100644
--- a/sound/ppc/tumbler.c
+++ b/sound/ppc/tumbler.c
@@ -41,7 +41,7 @@
 #undef DEBUG
 
 #ifdef DEBUG
-#define DBG(fmt...) printk(fmt)
+#define DBG(fmt...) printk(KERN_DEBUG fmt)
 #else
 #define DBG(fmt...)
 #endif
@@ -240,7 +240,7 @@ static int tumbler_set_master_volume(struct pmac_tumbler *mix)
   
         if (i2c_smbus_write_i2c_block_data(mix->i2c.client, TAS_REG_VOL, 6,
                                            block) < 0) {
-                snd_printk("failed to set volume \n");
+                snd_printk(KERN_ERR "failed to set volume \n");
                 return -EINVAL;
         }
         return 0;
@@ -350,7 +350,7 @@ static int tumbler_set_drc(struct pmac_tumbler *mix)
 
         if (i2c_smbus_write_i2c_block_data(mix->i2c.client, TAS_REG_DRC,
                                            2, val) < 0) {
-                snd_printk("failed to set DRC\n");
+                snd_printk(KERN_ERR "failed to set DRC\n");
                 return -EINVAL;
         }
         return 0;
@@ -386,7 +386,7 @@ static int snapper_set_drc(struct pmac_tumbler *mix)
 
         if (i2c_smbus_write_i2c_block_data(mix->i2c.client, TAS_REG_DRC,
                                            6, val) < 0) {
-                snd_printk("failed to set DRC\n");
+                snd_printk(KERN_ERR "failed to set DRC\n");
                 return -EINVAL;
         }
         return 0;
@@ -506,7 +506,8 @@ static int tumbler_set_mono_volume(struct pmac_tumbler *mix,
                 block[i] = (vol >> ((info->bytes - i - 1) * 8)) & 0xff;
         if (i2c_smbus_write_i2c_block_data(mix->i2c.client, info->reg,
                                            info->bytes, block) < 0) {
-                snd_printk("failed to set mono volume %d\n", info->index);
+                snd_printk(KERN_ERR "failed to set mono volume %d\n",
+                           info->index);
                 return -EINVAL;
         }
         return 0;
@@ -643,7 +644,7 @@ static int snapper_set_mix_vol1(struct pmac_tumbler *mix, int idx, int ch, int r
         }
         if (i2c_smbus_write_i2c_block_data(mix->i2c.client, reg,
                                            9, block) < 0) {
-                snd_printk("failed to set mono volume %d\n", reg);
+                snd_printk(KERN_ERR "failed to set mono volume %d\n", reg);
                 return -EINVAL;
         }
         return 0;