1 files changed, 12 insertions, 6 deletions

diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index ad4462677615..f64fb7d988cb 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -97,6 +97,7 @@
 #include <linux/gameport.h>
 #include <linux/device.h>
 #include <linux/firmware.h>
+#include <linux/kernel.h>
 #include <asm/io.h>
 #include <sound/core.h>
 #include <sound/info.h>
@@ -667,13 +668,12 @@ static u32 atoh(const unsigned char *in, unsigned int len)
         unsigned char c;
 
         while (len) {
+                int value;
+
                 c = in[len - 1];
-                if ((c >= '0') && (c <= '9'))
-                        sum += mult * (c - '0');
-                else if ((c >= 'A') && (c <= 'F'))
-                        sum += mult * (c - ('A' - 10));
-                else if ((c >= 'a') && (c <= 'f'))
-                        sum += mult * (c - ('a' - 10));
+                value = hex_to_bin(c);
+                if (value >= 0)
+                        sum += mult * value;
                 mult *= 16;
                 --len;
         }
@@ -1615,7 +1615,10 @@ static int snd_riptide_playback_open(struct snd_pcm_substream *substream)
 
         chip->playback_substream[sub_num] = substream;
         runtime->hw = snd_riptide_playback;
+
         data = kzalloc(sizeof(struct pcmhw), GFP_KERNEL);
+        if (data == NULL)
+                return -ENOMEM;
         data->paths = lbus_play_paths[sub_num];
         data->id = play_ids[sub_num];
         data->source = play_sources[sub_num];
@@ -1635,7 +1638,10 @@ static int snd_riptide_capture_open(struct snd_pcm_substream *substream)
 
         chip->capture_substream = substream;
         runtime->hw = snd_riptide_capture;
+
         data = kzalloc(sizeof(struct pcmhw), GFP_KERNEL);
+        if (data == NULL)
+                return -ENOMEM;
         data->paths = lbus_rec_path;
         data->id = PADC;
         data->source = ACLNK2PADC;