1 files changed, 81 insertions, 11 deletions

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 31df7747990d..f29b97b5de8f 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -31,10 +31,15 @@
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
+#include <linux/moduleparam.h>
 #include <sound/core.h>
 #include "hda_codec.h"
 #include "hda_local.h"
 
+static bool static_hdmi_pcm;
+module_param(static_hdmi_pcm, bool, 0644);
+MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info");
+
 /*
  * The HDMI/DisplayPort configuration can be highly dynamic. A graphics device
  * could support two independent pipes, each of them can be connected to one or
@@ -827,7 +832,7 @@ static int hdmi_pcm_open(struct hda_pcm_stream *hinfo,
                 *codec_pars = *hinfo;
 
         eld = &spec->sink_eld[idx];
-        if (eld->sad_count > 0) {
+        if (!static_hdmi_pcm && eld->eld_valid && eld->sad_count > 0) {
                 hdmi_eld_update_pcm_info(eld, hinfo, codec_pars);
                 if (hinfo->channels_min > hinfo->channels_max ||
                     !hinfo->rates || !hinfo->formats)
@@ -904,23 +909,28 @@ static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid)
         spec->pin[spec->num_pins] = pin_nid;
         spec->num_pins++;
 
-        /*
-         * It is assumed that converter nodes come first in the node list and
-         * hence have been registered and usable now.
-         */
         return hdmi_read_pin_conn(codec, pin_nid);
 }
 
 static int hdmi_add_cvt(struct hda_codec *codec, hda_nid_t nid)
 {
+        int i, found_pin = 0;
         struct hdmi_spec *spec = codec->spec;
 
-        if (spec->num_cvts >= MAX_HDMI_CVTS) {
-                snd_printk(KERN_WARNING
-                           "HDMI: no space for converter %d\n", nid);
-                return -E2BIG;
+        for (i = 0; i < spec->num_pins; i++)
+                if (nid == spec->pin_cvt[i]) {
+                        found_pin = 1;
+                        break;
+                }
+
+        if (!found_pin) {
+                snd_printdd("HDMI: Skipping node %d (no connection)\n", nid);
+                return -EINVAL;
         }
 
+        if (snd_BUG_ON(spec->num_cvts >= MAX_HDMI_CVTS))
+                return -E2BIG;
+
         spec->cvt[spec->num_cvts] = nid;
         spec->num_cvts++;
 
@@ -931,6 +941,8 @@ static int hdmi_parse_codec(struct hda_codec *codec)
 {
         hda_nid_t nid;
         int i, nodes;
+        int num_tmp_cvts = 0;
+        hda_nid_t tmp_cvt[MAX_HDMI_CVTS];
 
         nodes = snd_hda_get_sub_nodes(codec, codec->afg, &nid);
         if (!nid || nodes < 0) {
@@ -941,6 +953,7 @@ static int hdmi_parse_codec(struct hda_codec *codec)
         for (i = 0; i < nodes; i++, nid++) {
                 unsigned int caps;
                 unsigned int type;
+                unsigned int config;
 
                 caps = snd_hda_param_read(codec, nid, AC_PAR_AUDIO_WIDGET_CAP);
                 type = get_wcaps_type(caps);
@@ -950,17 +963,32 @@ static int hdmi_parse_codec(struct hda_codec *codec)
 
                 switch (type) {
                 case AC_WID_AUD_OUT:
-                        hdmi_add_cvt(codec, nid);
+                        if (num_tmp_cvts >= MAX_HDMI_CVTS) {
+                                snd_printk(KERN_WARNING
+                                           "HDMI: no space for converter %d\n", nid);
+                                continue;
+                        }
+                        tmp_cvt[num_tmp_cvts] = nid;
+                        num_tmp_cvts++;
                         break;
                 case AC_WID_PIN:
                         caps = snd_hda_param_read(codec, nid, AC_PAR_PIN_CAP);
                         if (!(caps & (AC_PINCAP_HDMI | AC_PINCAP_DP)))
                                 continue;
+
+                        config = snd_hda_codec_read(codec, nid, 0,
+                                             AC_VERB_GET_CONFIG_DEFAULT, 0);
+                        if (get_defcfg_connect(config) == AC_JACK_PORT_NONE)
+                                continue;
+
                         hdmi_add_pin(codec, nid);
                         break;
                 }
         }
 
+        for (i = 0; i < num_tmp_cvts; i++)
+                hdmi_add_cvt(codec, tmp_cvt[i]);
+
         /*
          * G45/IbexPeak don't support EPSS: the unsolicited pin hot plug event
          * can be lost and presence sense verb will become inaccurate if the
@@ -1165,11 +1193,53 @@ static int nvhdmi_7x_init(struct hda_codec *codec)
         return 0;
 }
 
+static unsigned int channels_2_6_8[] = {
+        2, 6, 8
+};
+
+static unsigned int channels_2_8[] = {
+        2, 8
+};
+
+static struct snd_pcm_hw_constraint_list hw_constraints_2_6_8_channels = {
+        .count = ARRAY_SIZE(channels_2_6_8),
+        .list = channels_2_6_8,
+        .mask = 0,
+};
+
+static struct snd_pcm_hw_constraint_list hw_constraints_2_8_channels = {
+        .count = ARRAY_SIZE(channels_2_8),
+        .list = channels_2_8,
+        .mask = 0,
+};
+
 static int simple_playback_pcm_open(struct hda_pcm_stream *hinfo,
                                     struct hda_codec *codec,
                                     struct snd_pcm_substream *substream)
 {
         struct hdmi_spec *spec = codec->spec;
+        struct snd_pcm_hw_constraint_list *hw_constraints_channels = NULL;
+
+        switch (codec->preset->id) {
+        case 0x10de0002:
+        case 0x10de0003:
+        case 0x10de0005:
+        case 0x10de0006:
+                hw_constraints_channels = &hw_constraints_2_8_channels;
+                break;
+        case 0x10de0007:
+                hw_constraints_channels = &hw_constraints_2_6_8_channels;
+                break;
+        default:
+                break;
+        }
+
+        if (hw_constraints_channels != NULL) {
+                snd_pcm_hw_constraint_list(substream->runtime, 0,
+                                SNDRV_PCM_HW_PARAM_CHANNELS,
+                                hw_constraints_channels);
+        }
+
         return snd_hda_multi_out_dig_open(codec, &spec->multiout);
 }
 
@@ -1532,7 +1602,7 @@ static struct hda_codec_preset snd_hda_preset_hdmi[] = {
 { .id = 0x1002793c, .name = "RS600 HDMI",       .patch = patch_atihdmi },
 { .id = 0x10027919, .name = "RS600 HDMI",       .patch = patch_atihdmi },
 { .id = 0x1002791a, .name = "RS690/780 HDMI",   .patch = patch_atihdmi },
-{ .id = 0x1002aa01, .name = "R6xx HDMI",        .patch = patch_atihdmi },
+{ .id = 0x1002aa01, .name = "R6xx HDMI",        .patch = patch_generic_hdmi },
 { .id = 0x10951390, .name = "SiI1390 HDMI",     .patch = patch_generic_hdmi },
 { .id = 0x10951392, .name = "SiI1392 HDMI",     .patch = patch_generic_hdmi },
 { .id = 0x17e80047, .name = "Chrontel HDMI",    .patch = patch_generic_hdmi },