5 files changed, 31 insertions, 78 deletions

diff --git a/sound/pci/cs5535audio/Makefile b/sound/pci/cs5535audio/Makefile
index ad947b4c04cc..bb3d57e6a3cb 100644
--- a/sound/pci/cs5535audio/Makefile
+++ b/sound/pci/cs5535audio/Makefile
@@ -2,11 +2,8 @@
 # Makefile for cs5535audio
 #
 
-snd-cs5535audio-objs := cs5535audio.o cs5535audio_pcm.o
-
-ifeq ($(CONFIG_PM),y)
-snd-cs5535audio-objs += cs5535audio_pm.o
-endif
+snd-cs5535audio-y := cs5535audio.o cs5535audio_pcm.o
+snd-cs5535audio-$(CONFIG_PM) += cs5535audio_pm.o
 
 # Toplevel Module Dependency
 obj-$(CONFIG_SND_CS5535AUDIO) += snd-cs5535audio.o
diff --git a/sound/pci/cs5535audio/cs5535audio.c b/sound/pci/cs5535audio/cs5535audio.c
index b8e75ef9c1e6..2b35889787be 100644
--- a/sound/pci/cs5535audio/cs5535audio.c
+++ b/sound/pci/cs5535audio/cs5535audio.c
@@ -206,7 +206,6 @@ static void process_bm1_irq(struct cs5535audio *cs5535au)
 static irqreturn_t snd_cs5535audio_interrupt(int irq, void *dev_id)
 {
         u16 acc_irq_stat;
-        u8 bm_stat;
         unsigned char count;
         struct cs5535audio *cs5535au = dev_id;
 
@@ -217,7 +216,7 @@ static irqreturn_t snd_cs5535audio_interrupt(int irq, void *dev_id)
 
         if (!acc_irq_stat)
                 return IRQ_NONE;
-        for (count = 0; count < 10; count++) {
+        for (count = 0; count < 4; count++) {
                 if (acc_irq_stat & (1 << count)) {
                         switch (count) {
                         case IRQ_STS:
@@ -232,26 +231,9 @@ static irqreturn_t snd_cs5535audio_interrupt(int irq, void *dev_id)
                         case BM1_IRQ_STS:
                                 process_bm1_irq(cs5535au);
                                 break;
-                        case BM2_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM2_STATUS);
-                                break;
-                        case BM3_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM3_STATUS);
-                                break;
-                        case BM4_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM4_STATUS);
-                                break;
-                        case BM5_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM5_STATUS);
-                                break;
-                        case BM6_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM6_STATUS);
-                                break;
-                        case BM7_IRQ_STS:
-                                bm_stat = cs_readb(cs5535au, ACC_BM7_STATUS);
-                                break;
                         default:
-                                snd_printk(KERN_ERR "Unexpected irq src\n");
+                                snd_printk(KERN_ERR "Unexpected irq src: "
+                                                "0x%x\n", acc_irq_stat);
                                 break;
                         }
                 }
diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h
index 4fd1f31a6cf9..66bae7664193 100644
--- a/sound/pci/cs5535audio/cs5535audio.h
+++ b/sound/pci/cs5535audio/cs5535audio.h
@@ -16,57 +16,28 @@
 #define ACC_IRQ_STATUS                  0x12
 #define ACC_BM0_CMD                     0x20
 #define ACC_BM1_CMD                     0x28
-#define ACC_BM2_CMD                     0x30
-#define ACC_BM3_CMD                     0x38
-#define ACC_BM4_CMD                     0x40
-#define ACC_BM5_CMD                     0x48
-#define ACC_BM6_CMD                     0x50
-#define ACC_BM7_CMD                     0x58
 #define ACC_BM0_PRD                     0x24
 #define ACC_BM1_PRD                     0x2C
-#define ACC_BM2_PRD                     0x34
-#define ACC_BM3_PRD                     0x3C
-#define ACC_BM4_PRD                     0x44
-#define ACC_BM5_PRD                     0x4C
-#define ACC_BM6_PRD                     0x54
-#define ACC_BM7_PRD                     0x5C
 #define ACC_BM0_STATUS                  0x21
 #define ACC_BM1_STATUS                  0x29
-#define ACC_BM2_STATUS                  0x31
-#define ACC_BM3_STATUS                  0x39
-#define ACC_BM4_STATUS                  0x41
-#define ACC_BM5_STATUS                  0x49
-#define ACC_BM6_STATUS                  0x51
-#define ACC_BM7_STATUS                  0x59
 #define ACC_BM0_PNTR                    0x60
 #define ACC_BM1_PNTR                    0x64
-#define ACC_BM2_PNTR                    0x68
-#define ACC_BM3_PNTR                    0x6C
-#define ACC_BM4_PNTR                    0x70
-#define ACC_BM5_PNTR                    0x74
-#define ACC_BM6_PNTR                    0x78
-#define ACC_BM7_PNTR                    0x7C
+
 /* acc_codec bar0 reg bits */
 /* ACC_IRQ_STATUS */
 #define IRQ_STS                         0
 #define WU_IRQ_STS                      1
 #define BM0_IRQ_STS                     2
 #define BM1_IRQ_STS                     3
-#define BM2_IRQ_STS                     4
-#define BM3_IRQ_STS                     5
-#define BM4_IRQ_STS                     6
-#define BM5_IRQ_STS                     7
-#define BM6_IRQ_STS                     8
-#define BM7_IRQ_STS                     9
 /* ACC_BMX_STATUS */
 #define EOP                             (1<<0)
 #define BM_EOP_ERR                      (1<<1)
 /* ACC_BMX_CTL */
-#define BM_CTL_EN                       0x00000001
-#define BM_CTL_PAUSE                    0x00000011
-#define BM_CTL_DIS                      0x00000000
-#define BM_CTL_BYTE_ORD_LE              0x00000000
-#define BM_CTL_BYTE_ORD_BE              0x00000100
+#define BM_CTL_EN                       0x01
+#define BM_CTL_PAUSE                    0x03
+#define BM_CTL_DIS                      0x00
+#define BM_CTL_BYTE_ORD_LE              0x00
+#define BM_CTL_BYTE_ORD_BE              0x04
 /* cs5535 specific ac97 codec register defines */
 #define CMD_MASK                        0xFF00FFFF
 #define CMD_NEW                         0x00010000
@@ -106,7 +77,6 @@ struct cs5535audio_dma {
         struct snd_pcm_substream *substream;
         unsigned int buf_addr, buf_bytes;
         unsigned int period_bytes, periods;
-        int suspended;
         u32 saved_prd;
 };
 
diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
index 5450a9e8f133..21df0634af32 100644
--- a/sound/pci/cs5535audio/cs5535audio_pcm.c
+++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
@@ -43,7 +43,6 @@ static struct snd_pcm_hardware snd_cs5535audio_playback =
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
                                 SNDRV_PCM_INFO_MMAP_VALID |
                                 SNDRV_PCM_INFO_PAUSE |
-                                SNDRV_PCM_INFO_SYNC_START |
                                 SNDRV_PCM_INFO_RESUME
                                 ),
         .formats =              (
@@ -71,8 +70,7 @@ static struct snd_pcm_hardware snd_cs5535audio_capture =
                                 SNDRV_PCM_INFO_MMAP |
                                 SNDRV_PCM_INFO_INTERLEAVED |
                                 SNDRV_PCM_INFO_BLOCK_TRANSFER |
-                                SNDRV_PCM_INFO_MMAP_VALID |
-                                SNDRV_PCM_INFO_SYNC_START
+                                SNDRV_PCM_INFO_MMAP_VALID
                                 ),
         .formats =              (
                                 SNDRV_PCM_FMTBIT_S16_LE
@@ -102,7 +100,6 @@ static int snd_cs5535audio_playback_open(struct snd_pcm_substream *substream)
         runtime->hw = snd_cs5535audio_playback;
         cs5535au->playback_substream = substream;
         runtime->private_data = &(cs5535au->dmas[CS5535AUDIO_DMA_PLAYBACK]);
-        snd_pcm_set_sync(substream);
         if ((err = snd_pcm_hw_constraint_integer(runtime,
                                 SNDRV_PCM_HW_PARAM_PERIODS)) < 0)
                 return err;
@@ -164,6 +161,7 @@ static int cs5535audio_build_dma_packets(struct cs5535audio *cs5535au,
         jmpprd_addr = cpu_to_le32(lastdesc->addr +
                                   (sizeof(struct cs5535audio_dma_desc)*periods));
 
+        dma->substream = substream;
         dma->period_bytes = period_bytes;
         dma->periods = periods;
         spin_lock_irq(&cs5535au->reg_lock);
@@ -241,6 +239,7 @@ static void cs5535audio_clear_dma_packets(struct cs5535audio *cs5535au,
 {
         snd_dma_free_pages(&dma->desc_buf);
         dma->desc_buf.area = NULL;
+        dma->substream = NULL;
 }
 
 static int snd_cs5535audio_hw_params(struct snd_pcm_substream *substream,
@@ -298,14 +297,12 @@ static int snd_cs5535audio_trigger(struct snd_pcm_substream *substream, int cmd)
                 break;
         case SNDRV_PCM_TRIGGER_RESUME:
                 dma->ops->enable_dma(cs5535au);
-                dma->suspended = 0;
                 break;
         case SNDRV_PCM_TRIGGER_STOP:
                 dma->ops->disable_dma(cs5535au);
                 break;
         case SNDRV_PCM_TRIGGER_SUSPEND:
                 dma->ops->disable_dma(cs5535au);
-                dma->suspended = 1;
                 break;
         default:
                 snd_printk(KERN_ERR "unhandled trigger\n");
@@ -348,7 +345,6 @@ static int snd_cs5535audio_capture_open(struct snd_pcm_substream *substream)
         runtime->hw = snd_cs5535audio_capture;
         cs5535au->capture_substream = substream;
         runtime->private_data = &(cs5535au->dmas[CS5535AUDIO_DMA_CAPTURE]);
-        snd_pcm_set_sync(substream);
         if ((err = snd_pcm_hw_constraint_integer(runtime,
                                          SNDRV_PCM_HW_PARAM_PERIODS)) < 0)
                 return err;
diff --git a/sound/pci/cs5535audio/cs5535audio_pm.c b/sound/pci/cs5535audio/cs5535audio_pm.c
index 3e4d198a4502..838708f6d45e 100644
--- a/sound/pci/cs5535audio/cs5535audio_pm.c
+++ b/sound/pci/cs5535audio/cs5535audio_pm.c
@@ -64,18 +64,21 @@ int snd_cs5535audio_suspend(struct pci_dev *pci, pm_message_t state)
         int i;
 
         snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+        snd_pcm_suspend_all(cs5535au->pcm);
+        snd_ac97_suspend(cs5535au->ac97);
         for (i = 0; i < NUM_CS5535AUDIO_DMAS; i++) {
                 struct cs5535audio_dma *dma = &cs5535au->dmas[i];
-                if (dma && dma->substream && !dma->suspended) 
+                if (dma && dma->substream)
                         dma->saved_prd = dma->ops->read_prd(cs5535au);
         }
-        snd_pcm_suspend_all(cs5535au->pcm);
-        snd_ac97_suspend(cs5535au->ac97);
         /* save important regs, then disable aclink in hw */
         snd_cs5535audio_stop_hardware(cs5535au);
 
+        if (pci_save_state(pci)) {
+                printk(KERN_ERR "cs5535audio: pci_save_state failed!\n");
+                return -EIO;
+        }
         pci_disable_device(pci);
-        pci_save_state(pci);
         pci_set_power_state(pci, pci_choose_state(pci, state));
         return 0;
 }
@@ -89,7 +92,12 @@ int snd_cs5535audio_resume(struct pci_dev *pci)
         int i;
 
         pci_set_power_state(pci, PCI_D0);
-        pci_restore_state(pci);
+        if (pci_restore_state(pci) < 0) {
+                printk(KERN_ERR "cs5535audio: pci_restore_state failed, "
+                       "disabling device\n");
+                snd_card_disconnect(card);
+                return -EIO;
+        }
         if (pci_enable_device(pci) < 0) {
                 printk(KERN_ERR "cs5535audio: pci_enable_device failed, "
                        "disabling device\n");
@@ -112,17 +120,17 @@ int snd_cs5535audio_resume(struct pci_dev *pci)
         if (!timeout)
                 snd_printk(KERN_ERR "Failure getting AC Link ready\n");
 
-        /* we depend on ac97 to perform the codec power up */
-        snd_ac97_resume(cs5535au->ac97);
         /* set up rate regs, dma. actual initiation is done in trig */
         for (i = 0; i < NUM_CS5535AUDIO_DMAS; i++) {
                 struct cs5535audio_dma *dma = &cs5535au->dmas[i];
-                if (dma && dma->substream && dma->suspended) {
+                if (dma && dma->substream) {
                         dma->substream->ops->prepare(dma->substream);
                         dma->ops->setup_prd(cs5535au, dma->saved_prd);
                 }
         }
-                
+
+        /* we depend on ac97 to perform the codec power up */
+        snd_ac97_resume(cs5535au->ac97);
         snd_power_change_state(card, SNDRV_CTL_POWER_D0);
 
         return 0;