5 files changed, 50 insertions, 54 deletions

diff --git a/sound/oss/cmpci.c b/sound/oss/cmpci.c
index 1fbd5137f6d7..de60a059ff5f 100644
--- a/sound/oss/cmpci.c
+++ b/sound/oss/cmpci.c
@@ -1713,7 +1713,7 @@ static int mixer_ioctl(struct cm_state *s, unsigned int cmd, unsigned long arg)
         case SOUND_MIXER_RECSRC: /* Arg contains a bit for each recording source */
                 if (get_user(val, p))
                         return -EFAULT;
-                i = generic_hweight32(val);
+                i = hweight32(val);
                 for (j = i = 0; i < SOUND_MIXER_NRDEVICES; i++) {
                         if (!(val & (1 << i)))
                                 continue;
diff --git a/sound/oss/cs4232.c b/sound/oss/cs4232.c
index 7c59e2d4003a..c7f86f09c28d 100644
--- a/sound/oss/cs4232.c
+++ b/sound/oss/cs4232.c
@@ -360,6 +360,8 @@ static int __initdata synthio	= -1;
 static int __initdata synthirq  = -1;
 static int __initdata isapnp    = 1;
 
+static unsigned int cs4232_devices;
+
 MODULE_DESCRIPTION("CS4232 based soundcard driver"); 
 MODULE_AUTHOR("Hannu Savolainen, Paul Barton-Davis"); 
 MODULE_LICENSE("GPL");
@@ -421,6 +423,7 @@ static int cs4232_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev
                 return -ENODEV;
         }
         pnp_set_drvdata(dev,isapnpcfg);
+        cs4232_devices++;
         return 0;
 }
 
@@ -455,10 +458,11 @@ static int __init init_cs4232(void)
 #endif
         cfg.irq = -1;
 
-        if (isapnp &&
-            (pnp_register_driver(&cs4232_driver) > 0)
-        )
-                return 0;
+        if (isapnp) {
+                pnp_register_driver(&cs4232_driver);
+                if (cs4232_devices)
+                        return 0;
+        }
 
         if(io==-1||irq==-1||dma==-1)
         {
@@ -503,7 +507,8 @@ static int __init setup_cs4232(char *str)
         int ints[7];
 
         /* If we have isapnp cards, no need for options */
-        if (pnp_register_driver(&cs4232_driver) > 0)
+        pnp_register_driver(&cs4232_driver);
+        if (cs4232_devices)
                 return 1;
         
         str = get_options(str, ARRAY_SIZE(ints), ints);
diff --git a/sound/oss/sb_card.c b/sound/oss/sb_card.c
index 680b82e15298..d38e88abc8fa 100644
--- a/sound/oss/sb_card.c
+++ b/sound/oss/sb_card.c
@@ -52,6 +52,7 @@ static int __initdata sm_games 	= 0; /* Logitech soundman games? */
 static struct sb_card_config *legacy = NULL;
 
 #ifdef CONFIG_PNP
+static int pnp_registered;
 static int __initdata pnp       = 1;
 /*
 static int __initdata uart401   = 0;
@@ -133,7 +134,7 @@ static void sb_unload(struct sb_card_config *scc)
 }
 
 /* Register legacy card with OSS subsystem */
-static int sb_init_legacy(void)
+static int __init sb_init_legacy(void)
 {
         struct sb_module_options sbmo = {0};
 
@@ -234,6 +235,8 @@ static void sb_dev2cfg(struct pnp_dev *dev, struct sb_card_config *scc)
         }
 }
 
+static unsigned int sb_pnp_devices;
+
 /* Probe callback function for the PnP API */
 static int sb_pnp_probe(struct pnp_card_link *card, const struct pnp_card_device_id *card_id)
 {
@@ -264,6 +267,7 @@ static int sb_pnp_probe(struct pnp_card_link *card, const struct pnp_card_device
                scc->conf.dma, scc->conf.dma2);
 
         pnp_set_card_drvdata(card, scc);
+        sb_pnp_devices++;
 
         return sb_register_oss(scc, &sbmo);
 }
@@ -289,6 +293,14 @@ static struct pnp_card_driver sb_pnp_driver = {
 MODULE_DEVICE_TABLE(pnp_card, sb_pnp_card_table);
 #endif /* CONFIG_PNP */
 
+static void __init_or_module sb_unregister_all(void)
+{
+#ifdef CONFIG_PNP
+        if (pnp_registered)
+                pnp_unregister_card_driver(&sb_pnp_driver);
+#endif
+}
+
 static int __init sb_init(void)
 {
         int lres = 0;
@@ -307,17 +319,18 @@ static int __init sb_init(void)
 
 #ifdef CONFIG_PNP
         if(pnp) {
-                pres = pnp_register_card_driver(&sb_pnp_driver);
+                int err = pnp_register_card_driver(&sb_pnp_driver);
+                if (!err)
+                        pnp_registered = 1;
+                pres = sb_pnp_devices;
         }
 #endif
         printk(KERN_INFO "sb: Init: Done\n");
 
         /* If either PnP or Legacy registered a card then return
          * success */
-        if (pres <= 0 && lres <= 0) {
-#ifdef CONFIG_PNP
-                pnp_unregister_card_driver(&sb_pnp_driver);
-#endif
+        if (pres == 0 && lres <= 0) {
+                sb_unregister_all();
                 return -ENODEV;
         }
         return 0;
@@ -333,9 +346,7 @@ static void __exit sb_exit(void)
                 sb_unload(legacy);
         }
 
-#ifdef CONFIG_PNP
-        pnp_unregister_card_driver(&sb_pnp_driver);
-#endif
+        sb_unregister_all();
 
         if (smw_free) {
                 vfree(smw_free);
diff --git a/sound/oss/sonicvibes.c b/sound/oss/sonicvibes.c
index 69a4b8778b51..4471757b7985 100644
--- a/sound/oss/sonicvibes.c
+++ b/sound/oss/sonicvibes.c
@@ -407,24 +407,6 @@ static inline unsigned ld2(unsigned int x)
         return r;
 }
 
-/*
- * hweightN: returns the hamming weight (i.e. the number
- * of bits set) of a N-bit word
- */
-
-#ifdef hweight32
-#undef hweight32
-#endif
-
-static inline unsigned int hweight32(unsigned int w)
-{
-        unsigned int res = (w & 0x55555555) + ((w >> 1) & 0x55555555);
-        res = (res & 0x33333333) + ((res >> 2) & 0x33333333);
-        res = (res & 0x0F0F0F0F) + ((res >> 4) & 0x0F0F0F0F);
-        res = (res & 0x00FF00FF) + ((res >> 8) & 0x00FF00FF);
-        return (res & 0x0000FFFF) + ((res >> 16) & 0x0000FFFF);
-}
-
 /* --------------------------------------------------------------------- */
 
 /*
diff --git a/sound/oss/vwsnd.c b/sound/oss/vwsnd.c
index b372e88e857f..5f140c7586b3 100644
--- a/sound/oss/vwsnd.c
+++ b/sound/oss/vwsnd.c
@@ -248,27 +248,6 @@ typedef struct lithium {
 } lithium_t;
 
 /*
- * li_create initializes the lithium_t structure and sets up vm mappings
- * to access the registers.
- * Returns 0 on success, -errno on failure.
- */
-
-static int __init li_create(lithium_t *lith, unsigned long baseaddr)
-{
-        static void li_destroy(lithium_t *);
-
-        spin_lock_init(&lith->lock);
-        lith->page0 = ioremap_nocache(baseaddr + LI_PAGE0_OFFSET, PAGE_SIZE);
-        lith->page1 = ioremap_nocache(baseaddr + LI_PAGE1_OFFSET, PAGE_SIZE);
-        lith->page2 = ioremap_nocache(baseaddr + LI_PAGE2_OFFSET, PAGE_SIZE);
-        if (!lith->page0 || !lith->page1 || !lith->page2) {
-                li_destroy(lith);
-                return -ENOMEM;
-        }
-        return 0;
-}
-
-/*
  * li_destroy destroys the lithium_t structure and vm mappings.
  */
 
@@ -289,6 +268,25 @@ static void li_destroy(lithium_t *lith)
 }
 
 /*
+ * li_create initializes the lithium_t structure and sets up vm mappings
+ * to access the registers.
+ * Returns 0 on success, -errno on failure.
+ */
+
+static int __init li_create(lithium_t *lith, unsigned long baseaddr)
+{
+        spin_lock_init(&lith->lock);
+        lith->page0 = ioremap_nocache(baseaddr + LI_PAGE0_OFFSET, PAGE_SIZE);
+        lith->page1 = ioremap_nocache(baseaddr + LI_PAGE1_OFFSET, PAGE_SIZE);
+        lith->page2 = ioremap_nocache(baseaddr + LI_PAGE2_OFFSET, PAGE_SIZE);
+        if (!lith->page0 || !lith->page1 || !lith->page2) {
+                li_destroy(lith);
+                return -ENOMEM;
+        }
+        return 0;
+}
+
+/*
  * basic register accessors - read/write long/byte
  */