4 files changed, 26 insertions, 18 deletions

diff --git a/sound/oss/coproc.h b/sound/oss/coproc.h
index 7306346e9ac4..7bec21bbdd88 100644
--- a/sound/oss/coproc.h
+++ b/sound/oss/coproc.h
@@ -4,7 +4,7 @@
  */
 
 /*
- * Coprocessor access types 
+ * Coprocessor access types
  */
 #define COPR_CUSTOM             0x0001  /* Custom applications */
 #define COPR_MIDI               0x0002  /* MIDI (MPU-401) emulation */
diff --git a/sound/oss/kahlua.c b/sound/oss/kahlua.c
index 89466b056be7..24d152ccf80d 100644
--- a/sound/oss/kahlua.c
+++ b/sound/oss/kahlua.c
@@ -198,7 +198,7 @@ MODULE_LICENSE("GPL");
  *      5530 only. The 5510/5520 decode is different.
  */
 
-static struct pci_device_id id_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(id_tbl) = {
         { PCI_VDEVICE(CYRIX, PCI_DEVICE_ID_CYRIX_5530_AUDIO), 0 },
         { }
 };
diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index c62530943888..fde7c12fe5da 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -328,11 +328,11 @@ static int sound_mixer_ioctl(int mixdev, unsigned int cmd, void __user *arg)
         return mixer_devs[mixdev]->ioctl(mixdev, cmd, arg);
 }
 
-static int sound_ioctl(struct inode *inode, struct file *file,
-                       unsigned int cmd, unsigned long arg)
+static long sound_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
         int len = 0, dtype;
-        int dev = iminor(inode);
+        int dev = iminor(file->f_dentry->d_inode);
+        long ret = -EINVAL;
         void __user *p = (void __user *)arg;
 
         if (_SIOC_DIR(cmd) != _SIOC_NONE && _SIOC_DIR(cmd) != 0) {
@@ -353,6 +353,7 @@ static int sound_ioctl(struct inode *inode, struct file *file,
         if (cmd == OSS_GETVERSION)
                 return __put_user(SOUND_VERSION, (int __user *)p);
         
+        lock_kernel();
         if (_IOC_TYPE(cmd) == 'M' && num_mixers > 0 &&   /* Mixer ioctl */
             (dev & 0x0f) != SND_DEV_CTL) {              
                 dtype = dev & 0x0f;
@@ -360,24 +361,31 @@ static int sound_ioctl(struct inode *inode, struct file *file,
                 case SND_DEV_DSP:
                 case SND_DEV_DSP16:
                 case SND_DEV_AUDIO:
-                        return sound_mixer_ioctl(audio_devs[dev >> 4]->mixer_dev,
+                        ret = sound_mixer_ioctl(audio_devs[dev >> 4]->mixer_dev,
                                                  cmd, p);
-                        
+                        break;                  
                 default:
-                        return sound_mixer_ioctl(dev >> 4, cmd, p);
+                        ret = sound_mixer_ioctl(dev >> 4, cmd, p);
+                        break;
                 }
+                unlock_kernel();
+                return ret;
         }
+
         switch (dev & 0x0f) {
         case SND_DEV_CTL:
                 if (cmd == SOUND_MIXER_GETLEVELS)
-                        return get_mixer_levels(p);
-                if (cmd == SOUND_MIXER_SETLEVELS)
-                        return set_mixer_levels(p);
-                return sound_mixer_ioctl(dev >> 4, cmd, p);
+                        ret = get_mixer_levels(p);
+                else if (cmd == SOUND_MIXER_SETLEVELS)
+                        ret = set_mixer_levels(p);
+                else
+                        ret = sound_mixer_ioctl(dev >> 4, cmd, p);
+                break;
 
         case SND_DEV_SEQ:
         case SND_DEV_SEQ2:
-                return sequencer_ioctl(dev, file, cmd, p);
+                ret = sequencer_ioctl(dev, file, cmd, p);
+                break;
 
         case SND_DEV_DSP:
         case SND_DEV_DSP16:
@@ -390,7 +398,8 @@ static int sound_ioctl(struct inode *inode, struct file *file,
                 break;
 
         }
-        return -EINVAL;
+        unlock_kernel();
+        return ret;
 }
 
 static unsigned int sound_poll(struct file *file, poll_table * wait)
@@ -490,7 +499,7 @@ const struct file_operations oss_sound_fops = {
         .read           = sound_read,
         .write          = sound_write,
         .poll           = sound_poll,
-        .ioctl          = sound_ioctl,
+        .unlocked_ioctl = sound_ioctl,
         .mmap           = sound_mmap,
         .open           = sound_open,
         .release        = sound_release,
diff --git a/sound/oss/v_midi.h b/sound/oss/v_midi.h
index 1b86cb45c607..08e2185ee816 100644
--- a/sound/oss/v_midi.h
+++ b/sound/oss/v_midi.h
@@ -2,9 +2,9 @@ typedef struct vmidi_devc {
            int dev;
 
         /* State variables */
-           int opened;
+           int opened;
            spinlock_t lock;
-        
+
         /* MIDI fields */
            int my_mididev;
            int pair_mididev;
@@ -12,4 +12,3 @@ typedef struct vmidi_devc {
            int intr_active;
            void (*midi_input_intr) (int dev, unsigned char data);
         } vmidi_devc;
-