10 files changed, 50 insertions, 47 deletions

diff --git a/sound/oss/cs4232.c b/sound/oss/cs4232.c
index 7c59e2d4003a..c7f86f09c28d 100644
--- a/sound/oss/cs4232.c
+++ b/sound/oss/cs4232.c
@@ -360,6 +360,8 @@ static int __initdata synthio	= -1;
 static int __initdata synthirq  = -1;
 static int __initdata isapnp    = 1;
 
+static unsigned int cs4232_devices;
+
 MODULE_DESCRIPTION("CS4232 based soundcard driver"); 
 MODULE_AUTHOR("Hannu Savolainen, Paul Barton-Davis"); 
 MODULE_LICENSE("GPL");
@@ -421,6 +423,7 @@ static int cs4232_pnp_probe(struct pnp_dev *dev, const struct pnp_device_id *dev
                 return -ENODEV;
         }
         pnp_set_drvdata(dev,isapnpcfg);
+        cs4232_devices++;
         return 0;
 }
 
@@ -455,10 +458,11 @@ static int __init init_cs4232(void)
 #endif
         cfg.irq = -1;
 
-        if (isapnp &&
-            (pnp_register_driver(&cs4232_driver) > 0)
-        )
-                return 0;
+        if (isapnp) {
+                pnp_register_driver(&cs4232_driver);
+                if (cs4232_devices)
+                        return 0;
+        }
 
         if(io==-1||irq==-1||dma==-1)
         {
@@ -503,7 +507,8 @@ static int __init setup_cs4232(char *str)
         int ints[7];
 
         /* If we have isapnp cards, no need for options */
-        if (pnp_register_driver(&cs4232_driver) > 0)
+        pnp_register_driver(&cs4232_driver);
+        if (cs4232_devices)
                 return 1;
         
         str = get_options(str, ARRAY_SIZE(ints), ints);
diff --git a/sound/oss/dmasound/dmasound_awacs.c b/sound/oss/dmasound/dmasound_awacs.c
index a8636adef2e6..c8e210326893 100644
--- a/sound/oss/dmasound/dmasound_awacs.c
+++ b/sound/oss/dmasound/dmasound_awacs.c
@@ -2798,7 +2798,7 @@ __init setup_beep(void)
                         DBDMA_ALIGN(beep_dbdma_cmd_space);
         /* set up emergency dbdma cmd */
         emergency_dbdma_cmd = beep_dbdma_cmd+1 ;
-        beep_buf = (short *) kmalloc(BEEP_BUFLEN * 4, GFP_KERNEL);
+        beep_buf = kmalloc(BEEP_BUFLEN * 4, GFP_KERNEL);
         if (beep_buf == NULL) {
                 printk(KERN_ERR "dmasound_pmac: no memory for beep buffer\n");
                 kfree(beep_dbdma_cmd_space) ;
diff --git a/sound/oss/emu10k1/midi.c b/sound/oss/emu10k1/midi.c
index 959a96794dba..25ae8e4a488d 100644
--- a/sound/oss/emu10k1/midi.c
+++ b/sound/oss/emu10k1/midi.c
@@ -65,7 +65,8 @@ static int midiin_add_buffer(struct emu10k1_mididevice *midi_dev, struct midi_hd
 
         init_midi_hdr(midihdr);
 
-        if ((midihdr->data = (u8 *) kmalloc(MIDIIN_BUFLEN, GFP_KERNEL)) == NULL) {
+        midihdr->data = kmalloc(MIDIIN_BUFLEN, GFP_KERNEL);
+        if (!midihdr->data) {
                 ERROR();
                 kfree(midihdr);
                 return -1;
@@ -334,7 +335,8 @@ static ssize_t emu10k1_midi_write(struct file *file, const char __user *buffer,
         midihdr->bytesrecorded = 0;
         midihdr->flags = 0;
 
-        if ((midihdr->data = (u8 *) kmalloc(count, GFP_KERNEL)) == NULL) {
+        midihdr->data = kmalloc(count, GFP_KERNEL);
+        if (!midihdr->data) {
                 ERROR();
                 kfree(midihdr);
                 return -EINVAL;
@@ -545,7 +547,8 @@ int emu10k1_seq_midi_out(int dev, unsigned char midi_byte)
         midihdr->bytesrecorded = 0;
         midihdr->flags = 0;
 
-        if ((midihdr->data = (u8 *) kmalloc(1, GFP_KERNEL)) == NULL) {
+        midihdr->data = kmalloc(1, GFP_KERNEL);
+        if (!midihdr->data) {
                 ERROR();
                 kfree(midihdr);
                 return -EINVAL;
diff --git a/sound/oss/esssolo1.c b/sound/oss/esssolo1.c
index 78d3e29ce968..6861563d7525 100644
--- a/sound/oss/esssolo1.c
+++ b/sound/oss/esssolo1.c
@@ -2348,7 +2348,7 @@ static int __devinit solo1_probe(struct pci_dev *pcidev, const struct pci_device
         /* Recording requires 24-bit DMA, so attempt to set dma mask
          * to 24 bits first, then 32 bits (playback only) if that fails.
          */
-        if (pci_set_dma_mask(pcidev, 0x00ffffff) &&
+        if (pci_set_dma_mask(pcidev, DMA_24BIT_MASK) &&
             pci_set_dma_mask(pcidev, DMA_32BIT_MASK)) {
                 printk(KERN_WARNING "solo1: architecture does not support 24bit or 32bit PCI busmaster DMA\n");
                 return -ENODEV;
diff --git a/sound/oss/maestro3.c b/sound/oss/maestro3.c
index 66044aff2586..4a5e4237a110 100644
--- a/sound/oss/maestro3.c
+++ b/sound/oss/maestro3.c
@@ -2582,15 +2582,9 @@ static int alloc_dsp_suspendmem(struct m3_card *card)
 
     return 0;
 }
-static void free_dsp_suspendmem(struct m3_card *card)
-{
-   if(card->suspend_mem)
-       vfree(card->suspend_mem);
-}
 
 #else
 #define alloc_dsp_suspendmem(args...) 0
-#define free_dsp_suspendmem(args...) 
 #endif
 
 /*
@@ -2717,7 +2711,7 @@ out:
     if(ret) {
         if(card->iobase)
             release_region(pci_resource_start(pci_dev, 0), pci_resource_len(pci_dev, 0));
-        free_dsp_suspendmem(card);
+        vfree(card->suspend_mem);
         if(card->ac97) {
             unregister_sound_mixer(card->ac97->dev_mixer);
             kfree(card->ac97);
@@ -2760,7 +2754,7 @@ static void m3_remove(struct pci_dev *pci_dev)
         }
 
         release_region(card->iobase, 256);
-        free_dsp_suspendmem(card);
+        vfree(card->suspend_mem);
         kfree(card);
     }
     devs = NULL;
diff --git a/sound/oss/msnd.c b/sound/oss/msnd.c
index a7ad2b0a2ac0..5dbfc0f9c3c7 100644
--- a/sound/oss/msnd.c
+++ b/sound/oss/msnd.c
@@ -95,10 +95,8 @@ void msnd_fifo_init(msnd_fifo *f)
 
 void msnd_fifo_free(msnd_fifo *f)
 {
-        if (f->data) {
-                vfree(f->data);
-                f->data = NULL;
-        }
+        vfree(f->data);
+        f->data = NULL;
 }
 
 int msnd_fifo_alloc(msnd_fifo *f, size_t n)
diff --git a/sound/oss/sb_card.c b/sound/oss/sb_card.c
index 680b82e15298..4708cbdc3149 100644
--- a/sound/oss/sb_card.c
+++ b/sound/oss/sb_card.c
@@ -52,6 +52,7 @@ static int __initdata sm_games 	= 0; /* Logitech soundman games? */
 static struct sb_card_config *legacy = NULL;
 
 #ifdef CONFIG_PNP
+static int pnp_registered;
 static int __initdata pnp       = 1;
 /*
 static int __initdata uart401   = 0;
@@ -133,7 +134,7 @@ static void sb_unload(struct sb_card_config *scc)
 }
 
 /* Register legacy card with OSS subsystem */
-static int sb_init_legacy(void)
+static int __init sb_init_legacy(void)
 {
         struct sb_module_options sbmo = {0};
 
@@ -234,6 +235,8 @@ static void sb_dev2cfg(struct pnp_dev *dev, struct sb_card_config *scc)
         }
 }
 
+static unsigned int sb_pnp_devices;
+
 /* Probe callback function for the PnP API */
 static int sb_pnp_probe(struct pnp_card_link *card, const struct pnp_card_device_id *card_id)
 {
@@ -264,6 +267,7 @@ static int sb_pnp_probe(struct pnp_card_link *card, const struct pnp_card_device
                scc->conf.dma, scc->conf.dma2);
 
         pnp_set_card_drvdata(card, scc);
+        sb_pnp_devices++;
 
         return sb_register_oss(scc, &sbmo);
 }
@@ -289,6 +293,14 @@ static struct pnp_card_driver sb_pnp_driver = {
 MODULE_DEVICE_TABLE(pnp_card, sb_pnp_card_table);
 #endif /* CONFIG_PNP */
 
+static void __init_or_module sb_unregister_all(void)
+{
+#ifdef CONFIG_PNP
+        if (pnp_registered)
+                pnp_unregister_card_driver(&sb_pnp_driver);
+#endif
+}
+
 static int __init sb_init(void)
 {
         int lres = 0;
@@ -307,17 +319,18 @@ static int __init sb_init(void)
 
 #ifdef CONFIG_PNP
         if(pnp) {
-                pres = pnp_register_card_driver(&sb_pnp_driver);
+                int err = pnp_register_card_driver(&sb_pnp_driver);
+                if (!err)
+                        pnp_registered = 1;
+                pres = sb_pnp_devices;
         }
 #endif
         printk(KERN_INFO "sb: Init: Done\n");
 
         /* If either PnP or Legacy registered a card then return
          * success */
-        if (pres <= 0 && lres <= 0) {
-#ifdef CONFIG_PNP
-                pnp_unregister_card_driver(&sb_pnp_driver);
-#endif
+        if (pres == 0 && lres <= 0) {
+                sb_unregister_all();
                 return -ENODEV;
         }
         return 0;
@@ -333,14 +346,10 @@ static void __exit sb_exit(void)
                 sb_unload(legacy);
         }
 
-#ifdef CONFIG_PNP
-        pnp_unregister_card_driver(&sb_pnp_driver);
-#endif
+        sb_unregister_all();
 
-        if (smw_free) {
-                vfree(smw_free);
-                smw_free = NULL;
-        }
+        vfree(smw_free);
+        smw_free = NULL;
 }
 
 module_init(sb_init);
diff --git a/sound/oss/sequencer.c b/sound/oss/sequencer.c
index 347cd79c2502..6815c30e0bc1 100644
--- a/sound/oss/sequencer.c
+++ b/sound/oss/sequencer.c
@@ -1671,14 +1671,7 @@ void sequencer_init(void)
 
 void sequencer_unload(void)
 {
-        if(queue)
-        {
-                vfree(queue);
-                queue=NULL;
-        }
-        if(iqueue)
-        {
-                vfree(iqueue);
-                iqueue=NULL;
-        }
+        vfree(queue);
+        vfree(iqueue);
+        queue = iqueue = NULL;
 }
diff --git a/sound/oss/sh_dac_audio.c b/sound/oss/sh_dac_audio.c
index 8a9917c919c2..3f7427cd195a 100644
--- a/sound/oss/sh_dac_audio.c
+++ b/sound/oss/sh_dac_audio.c
@@ -289,7 +289,7 @@ static int __init dac_audio_init(void)
 
         in_use = 0;
 
-        data_buffer = (char *)kmalloc(BUFFER_SIZE, GFP_KERNEL);
+        data_buffer = kmalloc(BUFFER_SIZE, GFP_KERNEL);
         if (data_buffer == NULL)
                 return -ENOMEM;
 
diff --git a/sound/oss/sonicvibes.c b/sound/oss/sonicvibes.c
index 4471757b7985..42bd276cfc39 100644
--- a/sound/oss/sonicvibes.c
+++ b/sound/oss/sonicvibes.c
@@ -116,6 +116,7 @@
 #include <linux/spinlock.h>
 #include <linux/smp_lock.h>
 #include <linux/gameport.h>
+#include <linux/dma-mapping.h>
 #include <linux/mutex.h>
 
 
@@ -2535,7 +2536,7 @@ static int __devinit sv_probe(struct pci_dev *pcidev, const struct pci_device_id
                 return -ENODEV;
         if (pcidev->irq == 0)
                 return -ENODEV;
-        if (pci_set_dma_mask(pcidev, 0x00ffffff)) {
+        if (pci_set_dma_mask(pcidev, DMA_24BIT_MASK)) {
                 printk(KERN_WARNING "sonicvibes: architecture does not support 24bit PCI busmaster DMA\n");
                 return -ENODEV;
         }