2 files changed, 76 insertions, 15 deletions

diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index d7ccf28bd66a..f8fbe22515c9 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -135,10 +135,9 @@ struct snd_opti9xx {
         unsigned long mc_base_size;
 #ifdef OPTi93X
         unsigned long mc_indir_index;
-        unsigned long mc_indir_size;
         struct resource *res_mc_indir;
-        struct snd_wss *codec;
 #endif  /* OPTi93X */
+        struct snd_wss *codec;
         unsigned long pwd_reg;
 
         spinlock_t lock;
@@ -245,10 +244,8 @@ static int __devinit snd_opti9xx_init(struct snd_opti9xx *chip,
         case OPTi9XX_HW_82C931:
         case OPTi9XX_HW_82C933:
                 chip->mc_base = (hardware == OPTi9XX_HW_82C930) ? 0xf8f : 0xf8d;
-                if (!chip->mc_indir_index) {
+                if (!chip->mc_indir_index)
                         chip->mc_indir_index = 0xe0e;
-                        chip->mc_indir_size = 2;
-                }
                 chip->password = 0xe4;
                 chip->pwd_reg = 0;
                 break;
@@ -351,7 +348,7 @@ static void snd_opti9xx_write(struct snd_opti9xx *chip, unsigned char reg,
                 (snd_opti9xx_read(chip, reg) & ~(mask)) | ((value) & (mask)))
 
 
-static int __devinit snd_opti9xx_configure(struct snd_opti9xx *chip,
+static int snd_opti9xx_configure(struct snd_opti9xx *chip,
                                            long port,
                                            int irq, int dma1, int dma2,
                                            long mpu_port, int mpu_irq)
@@ -403,7 +400,9 @@ static int __devinit snd_opti9xx_configure(struct snd_opti9xx *chip,
 
 #else   /* OPTi93X */
         case OPTi9XX_HW_82C931:
-        case OPTi9XX_HW_82C933:
+                /* disable 3D sound (set GPIO1 as output, low) */
+                snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(20), 0x04, 0x0c);
+        case OPTi9XX_HW_82C933: /* FALL THROUGH */
                 /*
                  * The BTC 1817DW has QS1000 wavetable which is connected
                  * to the serial digital input of the OPTI931.
@@ -696,8 +695,7 @@ static int __devinit snd_opti9xx_read_check(struct snd_opti9xx *chip)
                 if (value == snd_opti9xx_read(chip, OPTi9XX_MC_REG(1)))
                         return 0;
 #else   /* OPTi93X */
-        chip->res_mc_indir = request_region(chip->mc_indir_index,
-                                            chip->mc_indir_size,
+        chip->res_mc_indir = request_region(chip->mc_indir_index, 2,
                                             "OPTi93x MC");
         if (chip->res_mc_indir == NULL)
                 return -EBUSY;
@@ -770,8 +768,9 @@ static int __devinit snd_card_opti9xx_pnp(struct snd_opti9xx *chip,
 #ifdef OPTi93X
         port = pnp_port_start(pdev, 0) - 4;
         fm_port = pnp_port_start(pdev, 1) + 8;
-        chip->mc_indir_index = pnp_port_start(pdev, 3) + 2;
-        chip->mc_indir_size = pnp_port_len(pdev, 3) - 2;
+        /* adjust mc_indir_index - some cards report it at 0xe?d,
+           other at 0xe?c but it really is always at 0xe?e */
+        chip->mc_indir_index = (pnp_port_start(pdev, 3) & ~0xf) | 0xe;
 #else
         devmc = pnp_request_card_device(card, pid->devs[2].id, NULL);
         if (devmc == NULL)
@@ -871,9 +870,7 @@ static int __devinit snd_opti9xx_probe(struct snd_card *card)
                                &codec);
         if (error < 0)
                 return error;
-#ifdef OPTi93X
         chip->codec = codec;
-#endif
         error = snd_wss_pcm(codec, 0, &pcm);
         if (error < 0)
                 return error;
@@ -1054,11 +1051,55 @@ static int __devexit snd_opti9xx_isa_remove(struct device *devptr,
         return 0;
 }
 
+#ifdef CONFIG_PM
+static int snd_opti9xx_suspend(struct snd_card *card)
+{
+        struct snd_opti9xx *chip = card->private_data;
+
+        snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
+        chip->codec->suspend(chip->codec);
+        return 0;
+}
+
+static int snd_opti9xx_resume(struct snd_card *card)
+{
+        struct snd_opti9xx *chip = card->private_data;
+        int error, xdma2;
+#if defined(CS4231) || defined(OPTi93X)
+        xdma2 = dma2;
+#else
+        xdma2 = -1;
+#endif
+
+        error = snd_opti9xx_configure(chip, port, irq, dma1, xdma2,
+                                      mpu_port, mpu_irq);
+        if (error)
+                return error;
+        chip->codec->resume(chip->codec);
+        snd_power_change_state(card, SNDRV_CTL_POWER_D0);
+        return 0;
+}
+
+static int snd_opti9xx_isa_suspend(struct device *dev, unsigned int n,
+                                   pm_message_t state)
+{
+        return snd_opti9xx_suspend(dev_get_drvdata(dev));
+}
+
+static int snd_opti9xx_isa_resume(struct device *dev, unsigned int n)
+{
+        return snd_opti9xx_resume(dev_get_drvdata(dev));
+}
+#endif
+
 static struct isa_driver snd_opti9xx_driver = {
         .match          = snd_opti9xx_isa_match,
         .probe          = snd_opti9xx_isa_probe,
         .remove         = __devexit_p(snd_opti9xx_isa_remove),
-        /* FIXME: suspend/resume */
+#ifdef CONFIG_PM
+        .suspend        = snd_opti9xx_isa_suspend,
+        .resume         = snd_opti9xx_isa_resume,
+#endif
         .driver         = {
                 .name   = DEV_NAME
         },
@@ -1124,12 +1165,29 @@ static void __devexit snd_opti9xx_pnp_remove(struct pnp_card_link * pcard)
         snd_opti9xx_pnp_is_probed = 0;
 }
 
+#ifdef CONFIG_PM
+static int snd_opti9xx_pnp_suspend(struct pnp_card_link *pcard,
+                                   pm_message_t state)
+{
+        return snd_opti9xx_suspend(pnp_get_card_drvdata(pcard));
+}
+
+static int snd_opti9xx_pnp_resume(struct pnp_card_link *pcard)
+{
+        return snd_opti9xx_resume(pnp_get_card_drvdata(pcard));
+}
+#endif
+
 static struct pnp_card_driver opti9xx_pnpc_driver = {
         .flags          = PNP_DRIVER_RES_DISABLE,
         .name           = "opti9xx",
         .id_table       = snd_opti9xx_pnpids,
         .probe          = snd_opti9xx_pnp_probe,
         .remove         = __devexit_p(snd_opti9xx_pnp_remove),
+#ifdef CONFIG_PM
+        .suspend        = snd_opti9xx_pnp_suspend,
+        .resume         = snd_opti9xx_pnp_resume,
+#endif
 };
 #endif
 
diff --git a/sound/isa/wss/wss_lib.c b/sound/isa/wss/wss_lib.c
index 49c8a0c2442c..360b08b03e1d 100644
--- a/sound/isa/wss/wss_lib.c
+++ b/sound/isa/wss/wss_lib.c
@@ -1456,7 +1456,6 @@ static struct snd_pcm_hardware snd_wss_playback =
 {
         .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED |
                                  SNDRV_PCM_INFO_MMAP_VALID |
-                                 SNDRV_PCM_INFO_RESUME |
                                  SNDRV_PCM_INFO_SYNC_START),
         .formats =              (SNDRV_PCM_FMTBIT_MU_LAW | SNDRV_PCM_FMTBIT_A_LAW | SNDRV_PCM_FMTBIT_IMA_ADPCM |
                                  SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE),
@@ -1657,6 +1656,10 @@ static void snd_wss_resume(struct snd_wss *chip)
                         break;
                 }
         }
+        /* Yamaha needs this to resume properly */
+        if (chip->hardware == WSS_HW_OPL3SA2)
+                snd_wss_out(chip, CS4231_PLAYBK_FORMAT,
+                            chip->image[CS4231_PLAYBK_FORMAT]);
         spin_unlock_irqrestore(&chip->reg_lock, flags);
 #if 1
         snd_wss_mce_down(chip);