13 files changed, 82 insertions, 47 deletions

diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
index 4e4c69e6cb4c..e5e749f3e0ef 100644
--- a/sound/drivers/dummy.c
+++ b/sound/drivers/dummy.c
@@ -47,9 +47,11 @@ MODULE_SUPPORTED_DEVICE("{{ALSA,Dummy soundcard}}");
 static int emu10k1_playback_constraints(struct snd_pcm_runtime *runtime)
 {
         int err;
-        if ((err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS)) < 0)
+        err = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
+        if (err < 0)
                 return err;
-        if ((err = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 256, UINT_MAX)) < 0)
+        err = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 256, UINT_MAX);
+        if (err) < 0)
                 return err;
         return 0;
 }
@@ -354,6 +356,7 @@ static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream)
         if ((dpcm = new_pcm_stream(substream)) == NULL)
                 return -ENOMEM;
         runtime->private_data = dpcm;
+        /* makes the infrastructure responsible for freeing dpcm */
         runtime->private_free = snd_card_dummy_runtime_free;
         runtime->hw = snd_card_dummy_playback;
         if (substream->pcm->device & 1) {
@@ -362,10 +365,9 @@ static int snd_card_dummy_playback_open(struct snd_pcm_substream *substream)
         }
         if (substream->pcm->device & 2)
                 runtime->hw.info &= ~(SNDRV_PCM_INFO_MMAP|SNDRV_PCM_INFO_MMAP_VALID);
-        if ((err = add_playback_constraints(runtime)) < 0) {
-                kfree(dpcm);
+        err = add_playback_constraints(runtime);
+        if (err < 0)
                 return err;
-        }
 
         return 0;
 }
@@ -379,6 +381,7 @@ static int snd_card_dummy_capture_open(struct snd_pcm_substream *substream)
         if ((dpcm = new_pcm_stream(substream)) == NULL)
                 return -ENOMEM;
         runtime->private_data = dpcm;
+        /* makes the infrastructure responsible for freeing dpcm */
         runtime->private_free = snd_card_dummy_runtime_free;
         runtime->hw = snd_card_dummy_capture;
         if (substream->pcm->device == 1) {
@@ -387,10 +390,9 @@ static int snd_card_dummy_capture_open(struct snd_pcm_substream *substream)
         }
         if (substream->pcm->device & 2)
                 runtime->hw.info &= ~(SNDRV_PCM_INFO_MMAP|SNDRV_PCM_INFO_MMAP_VALID);
-        if ((err = add_capture_constraints(runtime)) < 0) {
-                kfree(dpcm);
+        err = add_capture_constraints(runtime);
+        if (err < 0)
                 return err;
-        }
 
         return 0;
 }
@@ -433,8 +435,9 @@ static int __devinit snd_card_dummy_pcm(struct snd_dummy *dummy, int device,
         struct snd_pcm *pcm;
         int err;
 
-        if ((err = snd_pcm_new(dummy->card, "Dummy PCM", device,
-                               substreams, substreams, &pcm)) < 0)
+        err = snd_pcm_new(dummy->card, "Dummy PCM", device,
+                               substreams, substreams, &pcm);
+        if (err < 0)
                 return err;
         dummy->pcm = pcm;
         snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_card_dummy_playback_ops);
@@ -565,12 +568,14 @@ static int __devinit snd_card_dummy_new_mixer(struct snd_dummy *dummy)
         unsigned int idx;
         int err;
 
-        snd_assert(dummy != NULL, return -EINVAL);
+        if (snd_BUG_ON(!dummy))
+                return -EINVAL;
         spin_lock_init(&dummy->mixer_lock);
         strcpy(card->mixername, "Dummy Mixer");
 
         for (idx = 0; idx < ARRAY_SIZE(snd_dummy_controls); idx++) {
-                if ((err = snd_ctl_add(card, snd_ctl_new1(&snd_dummy_controls[idx], dummy))) < 0)
+                err = snd_ctl_add(card, snd_ctl_new1(&snd_dummy_controls[idx], dummy));
+                if (err < 0)
                         return err;
         }
         return 0;
@@ -594,10 +599,12 @@ static int __devinit snd_dummy_probe(struct platform_device *devptr)
                         pcm_substreams[dev] = 1;
                 if (pcm_substreams[dev] > MAX_PCM_SUBSTREAMS)
                         pcm_substreams[dev] = MAX_PCM_SUBSTREAMS;
-                if ((err = snd_card_dummy_pcm(dummy, idx, pcm_substreams[dev])) < 0)
+                err = snd_card_dummy_pcm(dummy, idx, pcm_substreams[dev]);
+                if (err < 0)
                         goto __nodev;
         }
-        if ((err = snd_card_dummy_new_mixer(dummy)) < 0)
+        err = snd_card_dummy_new_mixer(dummy);
+        if (err < 0)
                 goto __nodev;
         strcpy(card->driver, "Dummy");
         strcpy(card->shortname, "Dummy");
@@ -605,7 +612,8 @@ static int __devinit snd_dummy_probe(struct platform_device *devptr)
 
         snd_card_set_dev(card, &devptr->dev);
 
-        if ((err = snd_card_register(card)) == 0) {
+        err = snd_card_register(card);
+        if (err == 0) {
                 platform_set_drvdata(devptr, card);
                 return 0;
         }
@@ -668,7 +676,8 @@ static int __init alsa_card_dummy_init(void)
 {
         int i, cards, err;
 
-        if ((err = platform_driver_register(&snd_dummy_driver)) < 0)
+        err = platform_driver_register(&snd_dummy_driver);
+        if (err < 0)
                 return err;
 
         cards = 0;
diff --git a/sound/drivers/mtpav.c b/sound/drivers/mtpav.c
index b5e1a71bb64b..5b89c0883d60 100644
--- a/sound/drivers/mtpav.c
+++ b/sound/drivers/mtpav.c
@@ -715,6 +715,10 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev)
 
         card->private_free = snd_mtpav_free;
 
+        err = snd_mtpav_get_RAWMIDI(mtp_card);
+        if (err < 0)
+                goto __error;
+
         err = snd_mtpav_get_ISA(mtp_card);
         if (err < 0)
                 goto __error;
@@ -724,10 +728,6 @@ static int __devinit snd_mtpav_probe(struct platform_device *dev)
         snprintf(card->longname, sizeof(card->longname),
                  "MTPAV on parallel port at 0x%lx", port);
 
-        err = snd_mtpav_get_RAWMIDI(mtp_card);
-        if (err < 0)
-                goto __error;
-
         snd_mtpav_portscan(mtp_card);
 
         snd_card_set_dev(card, &dev->dev);
diff --git a/sound/drivers/opl3/opl3_lib.c b/sound/drivers/opl3/opl3_lib.c
index ebe4359047cb..780582340fef 100644
--- a/sound/drivers/opl3/opl3_lib.c
+++ b/sound/drivers/opl3/opl3_lib.c
@@ -139,7 +139,8 @@ static int snd_opl3_detect(struct snd_opl3 * opl3)
                  * If we had an OPL4 chip, opl3->hardware would have been set
                  * by the OPL4 driver; so we can assume OPL3 here.
                  */
-                snd_assert(opl3->r_port != 0, return -ENODEV);
+                if (snd_BUG_ON(!opl3->r_port))
+                        return -ENODEV;
                 opl3->hardware = OPL3_HW_OPL3;
         }
         return 0;
@@ -324,7 +325,8 @@ EXPORT_SYMBOL(snd_opl3_interrupt);
 
 static int snd_opl3_free(struct snd_opl3 *opl3)
 {
-        snd_assert(opl3 != NULL, return -ENXIO);
+        if (snd_BUG_ON(!opl3))
+                return -ENXIO;
         if (opl3->private_free)
                 opl3->private_free(opl3);
         snd_opl3_clear_patches(opl3);
diff --git a/sound/drivers/opl3/opl3_midi.c b/sound/drivers/opl3/opl3_midi.c
index cebcb8b78acb..16feafa2c51e 100644
--- a/sound/drivers/opl3/opl3_midi.c
+++ b/sound/drivers/opl3/opl3_midi.c
@@ -617,7 +617,8 @@ static void snd_opl3_kill_voice(struct snd_opl3 *opl3, int voice)
 
         struct snd_opl3_voice *vp, *vp2;
 
-        snd_assert(voice < MAX_OPL3_VOICES, return);
+        if (snd_BUG_ON(voice >= MAX_OPL3_VOICES))
+                return;
 
         vp = &opl3->voices[voice];
         if (voice < MAX_OPL2_VOICES) {
@@ -737,7 +738,8 @@ static void snd_opl3_update_pitch(struct snd_opl3 *opl3, int voice)
 
         struct snd_opl3_voice *vp;
 
-        snd_assert(voice < MAX_OPL3_VOICES, return);
+        if (snd_BUG_ON(voice >= MAX_OPL3_VOICES))
+                return;
 
         vp = &opl3->voices[voice];
         if (vp->chan == NULL)
diff --git a/sound/drivers/opl3/opl3_oss.c b/sound/drivers/opl3/opl3_oss.c
index 239347f26154..9a2271dc046a 100644
--- a/sound/drivers/opl3/opl3_oss.c
+++ b/sound/drivers/opl3/opl3_oss.c
@@ -162,7 +162,8 @@ static int snd_opl3_open_seq_oss(struct snd_seq_oss_arg *arg, void *closure)
         struct snd_opl3 *opl3 = closure;
         int err;
 
-        snd_assert(arg != NULL, return -ENXIO);
+        if (snd_BUG_ON(!arg))
+                return -ENXIO;
 
         if ((err = snd_opl3_synth_setup(opl3)) < 0)
                 return err;
@@ -184,7 +185,8 @@ static int snd_opl3_close_seq_oss(struct snd_seq_oss_arg *arg)
 {
         struct snd_opl3 *opl3;
 
-        snd_assert(arg != NULL, return -ENXIO);
+        if (snd_BUG_ON(!arg))
+                return -ENXIO;
         opl3 = arg->private_data;
 
         snd_opl3_synth_cleanup(opl3);
@@ -206,7 +208,8 @@ static int snd_opl3_load_patch_seq_oss(struct snd_seq_oss_arg *arg, int format,
         char name[32];
         int err, type;
 
-        snd_assert(arg != NULL, return -ENXIO);
+        if (snd_BUG_ON(!arg))
+                return -ENXIO;
         opl3 = arg->private_data;
 
         if (format == FM_PATCH)
@@ -246,7 +249,8 @@ static int snd_opl3_ioctl_seq_oss(struct snd_seq_oss_arg *arg, unsigned int cmd,
 {
         struct snd_opl3 *opl3;
 
-        snd_assert(arg != NULL, return -ENXIO);
+        if (snd_BUG_ON(!arg))
+                return -ENXIO;
         opl3 = arg->private_data;
         switch (cmd) {
                 case SNDCTL_FM_LOAD_INSTR:
@@ -271,7 +275,8 @@ static int snd_opl3_reset_seq_oss(struct snd_seq_oss_arg *arg)
 {
         struct snd_opl3 *opl3;
 
-        snd_assert(arg != NULL, return -ENXIO);
+        if (snd_BUG_ON(!arg))
+                return -ENXIO;
         opl3 = arg->private_data;
 
         return 0;
diff --git a/sound/drivers/opl3/opl3_synth.c b/sound/drivers/opl3/opl3_synth.c
index fb64c890109b..962bb9c8b9c8 100644
--- a/sound/drivers/opl3/opl3_synth.c
+++ b/sound/drivers/opl3/opl3_synth.c
@@ -92,7 +92,8 @@ int snd_opl3_ioctl(struct snd_hwdep * hw, struct file *file,
         struct snd_opl3 *opl3 = hw->private_data;
         void __user *argp = (void __user *)arg;
 
-        snd_assert(opl3 != NULL, return -EINVAL);
+        if (snd_BUG_ON(!opl3))
+                return -EINVAL;
 
         switch (cmd) {
                 /* get information */
diff --git a/sound/drivers/opl4/opl4_synth.c b/sound/drivers/opl4/opl4_synth.c
index 74f6e53eae0d..49b9e240915c 100644
--- a/sound/drivers/opl4/opl4_synth.c
+++ b/sound/drivers/opl4/opl4_synth.c
@@ -467,7 +467,7 @@ static struct opl4_voice *snd_opl4_get_voice(struct snd_opl4 *opl4)
         if (!list_empty(&opl4->off_voices))
                 return list_entry(opl4->off_voices.next, struct opl4_voice, list);
         /* then get the oldest key-on voice */
-        snd_assert(!list_empty(&opl4->on_voices), );
+        snd_BUG_ON(list_empty(&opl4->on_voices));
         return list_entry(opl4->on_voices.next, struct opl4_voice, list);
 }
 
diff --git a/sound/drivers/vx/vx_cmd.c b/sound/drivers/vx/vx_cmd.c
index 9529e3bf2866..23f4857f02c8 100644
--- a/sound/drivers/vx/vx_cmd.c
+++ b/sound/drivers/vx/vx_cmd.c
@@ -99,7 +99,8 @@ static struct vx_cmd_info vx_dsp_cmds[] = {
  */
 void vx_init_rmh(struct vx_rmh *rmh, unsigned int cmd)
 {
-        snd_assert(cmd < CMD_LAST_INDEX, return);
+        if (snd_BUG_ON(cmd >= CMD_LAST_INDEX))
+                return;
         rmh->LgCmd = vx_dsp_cmds[cmd].length;
         rmh->LgStat = vx_dsp_cmds[cmd].st_length;
         rmh->DspStat = vx_dsp_cmds[cmd].st_type;
diff --git a/sound/drivers/vx/vx_core.c b/sound/drivers/vx/vx_core.c
index 585af2eb1438..473b07f6ae85 100644
--- a/sound/drivers/vx/vx_core.c
+++ b/sound/drivers/vx/vx_core.c
@@ -205,7 +205,8 @@ static int vx_read_status(struct vx_core *chip, struct vx_rmh *rmh)
 
         if (size < 1)
                 return 0;
-        snd_assert(size <= SIZE_MAX_STATUS, return -EINVAL);
+        if (snd_BUG_ON(size > SIZE_MAX_STATUS))
+                return -EINVAL;
 
         for (i = 1; i <= size; i++) {
                 /* trigger an irq MESS_WRITE_NEXT */
@@ -425,13 +426,16 @@ int snd_vx_load_boot_image(struct vx_core *chip, const struct firmware *boot)
         int no_fillup = vx_has_new_dsp(chip);
 
         /* check the length of boot image */
-        snd_assert(boot->size > 0, return -EINVAL);
-        snd_assert(boot->size % 3 == 0, return -EINVAL);
+        if (boot->size <= 0)
+                return -EINVAL;
+        if (boot->size % 3)
+                return -EINVAL;
 #if 0
         {
                 /* more strict check */
                 unsigned int c = ((u32)boot->data[0] << 16) | ((u32)boot->data[1] << 8) | boot->data[2];
-                snd_assert(boot->size == (c + 2) * 3, return -EINVAL);
+                if (boot->size != (c + 2) * 3)
+                        return -EINVAL;
         }
 #endif
 
@@ -554,7 +558,8 @@ EXPORT_SYMBOL(snd_vx_irq_handler);
  */
 static void vx_reset_board(struct vx_core *chip, int cold_reset)
 {
-        snd_assert(chip->ops->reset_board, return);
+        if (snd_BUG_ON(!chip->ops->reset_board))
+                return;
 
         /* current source, later sync'ed with target */
         chip->audio_source = VX_AUDIO_SRC_LINE;
@@ -673,7 +678,8 @@ int snd_vx_dsp_load(struct vx_core *chip, const struct firmware *dsp)
         unsigned int csum = 0;
         const unsigned char *image, *cptr;
 
-        snd_assert(dsp->size % 3 == 0, return -EINVAL);
+        if (dsp->size % 3)
+                return -EINVAL;
 
         vx_toggle_dac_mute(chip, 1);
 
@@ -775,7 +781,8 @@ struct vx_core *snd_vx_create(struct snd_card *card, struct snd_vx_hardware *hw,
 {
         struct vx_core *chip;
 
-        snd_assert(card && hw && ops, return NULL);
+        if (snd_BUG_ON(!card || !hw || !ops))
+                return NULL;
 
         chip = kzalloc(sizeof(*chip) + extra_size, GFP_KERNEL);
         if (! chip) {
diff --git a/sound/drivers/vx/vx_hwdep.c b/sound/drivers/vx/vx_hwdep.c
index efd22e92bced..8d6362e2d4c9 100644
--- a/sound/drivers/vx/vx_hwdep.c
+++ b/sound/drivers/vx/vx_hwdep.c
@@ -141,7 +141,8 @@ static int vx_hwdep_dsp_status(struct snd_hwdep *hw,
         };
         struct vx_core *vx = hw->private_data;
 
-        snd_assert(type_ids[vx->type], return -EINVAL);
+        if (snd_BUG_ON(!type_ids[vx->type]))
+                return -EINVAL;
         strcpy(info->id, type_ids[vx->type]);
         if (vx_is_pcmcia(vx))
                 info->num_dsps = 4;
@@ -168,7 +169,8 @@ static int vx_hwdep_dsp_load(struct snd_hwdep *hw,
         int index, err;
         struct firmware *fw;
 
-        snd_assert(vx->ops->load_dsp, return -ENXIO);
+        if (snd_BUG_ON(!vx->ops->load_dsp))
+                return -ENXIO;
 
         fw = kmalloc(sizeof(*fw), GFP_KERNEL);
         if (! fw) {
diff --git a/sound/drivers/vx/vx_mixer.c b/sound/drivers/vx/vx_mixer.c
index 5a347321f8c0..c71b8d148d7f 100644
--- a/sound/drivers/vx/vx_mixer.c
+++ b/sound/drivers/vx/vx_mixer.c
@@ -34,7 +34,8 @@ static void vx_write_codec_reg(struct vx_core *chip, int codec, unsigned int dat
 {
         unsigned long flags;
 
-        snd_assert(chip->ops->write_codec, return);
+        if (snd_BUG_ON(!chip->ops->write_codec))
+                return;
 
         if (chip->chip_status & VX_STAT_IS_STALE)
                 return;
diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c
index fdbf86571b1f..27de574c08f7 100644
--- a/sound/drivers/vx/vx_pcm.c
+++ b/sound/drivers/vx/vx_pcm.c
@@ -587,7 +587,8 @@ static int vx_pcm_playback_open(struct snd_pcm_substream *subs)
                 return -EBUSY;
 
         audio = subs->pcm->device * 2;
-        snd_assert(audio < chip->audio_outs, return -EINVAL);
+        if (snd_BUG_ON(audio >= chip->audio_outs))
+                return -EINVAL;
         
         /* playback pipe may have been already allocated for monitoring */
         pipe = chip->playback_pipes[audio];
@@ -996,7 +997,8 @@ static int vx_pcm_capture_open(struct snd_pcm_substream *subs)
                 return -EBUSY;
 
         audio = subs->pcm->device * 2;
-        snd_assert(audio < chip->audio_ins, return -EINVAL);
+        if (snd_BUG_ON(audio >= chip->audio_ins))
+                return -EINVAL;
         err = vx_alloc_pipe(chip, 1, audio, 2, &pipe);
         if (err < 0)
                 return err;
@@ -1214,7 +1216,8 @@ void vx_pcm_update_intr(struct vx_core *chip, unsigned int events)
                         }
                         if (capture)
                                 continue;
-                        snd_assert(p >= 0 && (unsigned int)p < chip->audio_outs,);
+                        if (snd_BUG_ON(p < 0 || p >= chip->audio_outs))
+                                continue;
                         pipe = chip->playback_pipes[p];
                         if (pipe && pipe->substream) {
                                 vx_pcm_playback_update(chip, pipe->substream, pipe);
diff --git a/sound/drivers/vx/vx_uer.c b/sound/drivers/vx/vx_uer.c
index fb8932af888d..0e1ba9b47904 100644
--- a/sound/drivers/vx/vx_uer.c
+++ b/sound/drivers/vx/vx_uer.c
@@ -163,13 +163,15 @@ static int vx_calc_clock_from_freq(struct vx_core *chip, int freq)
 {
         int hexfreq;
 
-        snd_assert(freq > 0, return 0);
+        if (snd_BUG_ON(freq <= 0))
+                return 0;
 
         hexfreq = (28224000 * 10) / freq;
         hexfreq = (hexfreq + 5) / 10;
 
         /* max freq = 55125 Hz */
-        snd_assert(hexfreq > 0x00000200, return 0);
+        if (snd_BUG_ON(hexfreq <= 0x00000200))
+                return 0;
 
         if (hexfreq <= 0x03ff)
                 return hexfreq - 0x00000201;