3 files changed, 6 insertions, 13 deletions

diff --git a/security/keys/compat.c b/security/keys/compat.c
index fab4f8dda6c6..c92d42b021aa 100644
--- a/security/keys/compat.c
+++ b/security/keys/compat.c
@@ -38,7 +38,7 @@ long compat_keyctl_instantiate_key_iov(
 
         ret = compat_rw_copy_check_uvector(WRITE, _payload_iov, ioc,
                                            ARRAY_SIZE(iovstack),
-                                           iovstack, &iov, 1);
+                                           iovstack, &iov);
         if (ret < 0)
                 return ret;
         if (ret == 0)
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 2f28126215a2..0f5b3f027299 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -84,7 +84,7 @@ SYSCALL_DEFINE5(add_key, const char __user *, _type,
         vm = false;
         if (_payload) {
                 ret = -ENOMEM;
-                payload = kmalloc(plen, GFP_KERNEL);
+                payload = kmalloc(plen, GFP_KERNEL | __GFP_NOWARN);
                 if (!payload) {
                         if (plen <= PAGE_SIZE)
                                 goto error2;
@@ -1110,7 +1110,7 @@ long keyctl_instantiate_key_iov(key_serial_t id,
                 goto no_payload;
 
         ret = rw_copy_check_uvector(WRITE, _payload_iov, ioc,
-                                    ARRAY_SIZE(iovstack), iovstack, &iov, 1);
+                                    ARRAY_SIZE(iovstack), iovstack, &iov);
         if (ret < 0)
                 return ret;
         if (ret == 0)
diff --git a/security/keys/request_key.c b/security/keys/request_key.c
index cc3790315d2f..000e75017520 100644
--- a/security/keys/request_key.c
+++ b/security/keys/request_key.c
@@ -93,16 +93,9 @@ static void umh_keys_cleanup(struct subprocess_info *info)
 static int call_usermodehelper_keys(char *path, char **argv, char **envp,
                                         struct key *session_keyring, int wait)
 {
-        gfp_t gfp_mask = (wait == UMH_NO_WAIT) ? GFP_ATOMIC : GFP_KERNEL;
-        struct subprocess_info *info =
-                call_usermodehelper_setup(path, argv, envp, gfp_mask);
-
-        if (!info)
-                return -ENOMEM;
-
-        call_usermodehelper_setfns(info, umh_keys_init, umh_keys_cleanup,
-                                        key_get(session_keyring));
-        return call_usermodehelper_exec(info, wait);
+        return call_usermodehelper_fns(path, argv, envp, wait,
+                                       umh_keys_init, umh_keys_cleanup,
+                                       key_get(session_keyring));
 }
 
 /*