1 files changed, 37 insertions, 29 deletions

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index f85597a4d733..f71de5a64d0c 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -1687,15 +1687,39 @@ static inline u32 file_mask_to_av(int mode, int mask)
         return av;
 }
 
+/* Convert a Linux file to an access vector. */
+static inline u32 file_to_av(struct file *file)
+{
+        u32 av = 0;
+
+        if (file->f_mode & FMODE_READ)
+                av |= FILE__READ;
+        if (file->f_mode & FMODE_WRITE) {
+                if (file->f_flags & O_APPEND)
+                        av |= FILE__APPEND;
+                else
+                        av |= FILE__WRITE;
+        }
+        if (!av) {
+                /*
+                 * Special file opened with flags 3 for ioctl-only use.
+                 */
+                av = FILE__IOCTL;
+        }
+
+        return av;
+}
+
 /*
- * Convert a file mask to an access vector and include the correct open
+ * Convert a file to an access vector and include the correct open
  * open permission.
  */
-static inline u32 open_file_mask_to_av(int mode, int mask)
+static inline u32 open_file_to_av(struct file *file)
 {
-        u32 av = file_mask_to_av(mode, mask);
+        u32 av = file_to_av(file);
 
         if (selinux_policycap_openperm) {
+                mode_t mode = file->f_path.dentry->d_inode->i_mode;
                 /*
                  * lnk files and socks do not really have an 'open'
                  */
@@ -1711,34 +1735,11 @@ static inline u32 open_file_mask_to_av(int mode, int mask)
                         av |= DIR__OPEN;
                 else
                         printk(KERN_ERR "SELinux: WARNING: inside %s with "
-                                "unknown mode:%x\n", __func__, mode);
+                                "unknown mode:%o\n", __func__, mode);
         }
         return av;
 }
 
-/* Convert a Linux file to an access vector. */
-static inline u32 file_to_av(struct file *file)
-{
-        u32 av = 0;
-
-        if (file->f_mode & FMODE_READ)
-                av |= FILE__READ;
-        if (file->f_mode & FMODE_WRITE) {
-                if (file->f_flags & O_APPEND)
-                        av |= FILE__APPEND;
-                else
-                        av |= FILE__WRITE;
-        }
-        if (!av) {
-                /*
-                 * Special file opened with flags 3 for ioctl-only use.
-                 */
-                av = FILE__IOCTL;
-        }
-
-        return av;
-}
-
 /* Hook functions begin here. */
 
 static int selinux_ptrace_may_access(struct task_struct *child,
@@ -2269,7 +2270,9 @@ static void selinux_bprm_post_apply_creds(struct linux_binprm *bprm)
         struct rlimit *rlim, *initrlim;
         struct itimerval itimer;
         struct bprm_security_struct *bsec;
+        struct sighand_struct *psig;
         int rc, i;
+        unsigned long flags;
 
         tsec = current->security;
         bsec = bprm->security;
@@ -2330,7 +2333,12 @@ static void selinux_bprm_post_apply_creds(struct linux_binprm *bprm)
 
         /* Wake up the parent if it is waiting so that it can
            recheck wait permission to the new task SID. */
+        read_lock_irq(&tasklist_lock);
+        psig = current->parent->sighand;
+        spin_lock_irqsave(&psig->siglock, flags);
         wake_up_interruptible(&current->parent->signal->wait_chldexit);
+        spin_unlock_irqrestore(&psig->siglock, flags);
+        read_unlock_irq(&tasklist_lock);
 }
 
 /* superblock security operations */
@@ -2650,7 +2658,7 @@ static int selinux_inode_permission(struct inode *inode, int mask)
         }
 
         return inode_has_perm(current, inode,
-                               open_file_mask_to_av(inode->i_mode, mask), NULL);
+                              file_mask_to_av(inode->i_mode, mask), NULL);
 }
 
 static int selinux_inode_setattr(struct dentry *dentry, struct iattr *iattr)
@@ -3166,7 +3174,7 @@ static int selinux_dentry_open(struct file *file)
          * new inode label or new policy.
          * This check is not redundant - do not remove.
          */
-        return inode_has_perm(current, inode, file_to_av(file), NULL);
+        return inode_has_perm(current, inode, open_file_to_av(file), NULL);
 }
 
 /* task security operations */